On Tue, Mar 22, 2016 at 07:45:25AM +0530, Sohom Bhattacharjee wrote:
> On Mon, Mar 21, 2016 at 05:29:24PM -0400, Greg KH wrote:
> > On Mon, Mar 21, 2016 at 10:53:36PM +0530, Sohom Bhattacharjee wrote:
> > > fixed *only* comments that did not follow kernel coding style.
> > > the errors were caught
On Mon, Mar 21, 2016 at 05:29:24PM -0400, Greg KH wrote:
> On Mon, Mar 21, 2016 at 10:53:36PM +0530, Sohom Bhattacharjee wrote:
> > fixed *only* comments that did not follow kernel coding style.
> > the errors were caught by the checkpatch.pl tool
> >
> > Signed-off-by: Sohom Bhattacharjee
>
> D
On Thu, Mar 17, 2016 at 04:55:37PM +, Yousof El-Sayed wrote:
> Signed-off-by: Yousof El-Sayed
I can't take a patch with no changelog entry. And your subject is too
vague as well :(
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http:
On Sat, Mar 12, 2016 at 04:01:03PM +0100, Adonis Settouf wrote:
> This patch fixes the checkpatch.pl warning regarding the exceeding 80
> characters on line 36. This patch add a newline after function statement
> on line 52
You did 2 different things in the same patch, that should be 2 patches.
>
On Mon, Mar 21, 2016 at 09:34:58PM +0100, Ben Marsh wrote:
> Removes a void pointer in prism2mgmt.c
>
> Signed-off-by: Ben Marsh
> ---
> drivers/staging/wlan-ng/prism2mgmt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This was already in my tree from someone else, sorry.
greg k-h
_
On Mon, Mar 21, 2016 at 12:29:01AM +0200, Claudiu Beznea wrote:
> This patch removes "goto " instructions which do only
> a return. In this way, aditional instructions were removed.
But this is now harder to read and understand, why make this change for
no good reason?
thanks,
greg k-h
_
On Tue, Mar 15, 2016 at 09:53:15PM +0200, Claudiu Beznea wrote:
> This patch moves memset() calls from p80211netdev_ethtool()
> after copy_from_user() call in order to avoid unnecessary
> instruction in case copy_from_user() fails.
Does that really matter? If an error happens, then we are on a "s
On Mon, Mar 14, 2016 at 04:53:01AM +0100, Salah Triki wrote:
> The call of read_nic_word_E may fail, therefore its return value must be
> checked and propagated in the case of error.
>
> Signed-off-by: Salah Triki
> ---
> drivers/staging/rtl8192u/r8180_93cx6.c | 24 ++--
> 1
On Tue, Mar 15, 2016 at 04:46:24PM +, laerdevstud...@gmail.com wrote:
> From: Parth Sane
>
> Fixed multiple assignment checkpatch warning by rearranging code.
>
> Signed-off-by: Parth Sane
>
> ---
> drivers/staging/netlogic/platform_net.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 dele
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Monday, March 21, 2016 23:28
> To: Dexuan Cui
> Cc: gre...@linuxfoundation.org; net...@vger.kernel.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
> a...@canonical.com; jasow...@redhat.com; KY Srinivasan
Caro usuário,
Essa é você? Alguém está tentando entrar em sua conta do Reino Unido,
Estamos apenas tentando também certifique-se que é você e não alguém mais
tentando roubar sua conta.
Agora, você deve executar uma verificação rápida para evitar que sua conta
ser suspensa.
Preencha esta perg
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Monday, March 21, 2016 1:19 AM
> To: KY Srinivasan
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> jasow...@redhat.com;
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Monday, March 21, 2016 1:29 AM
> To: KY Srinivasan
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> jasow...@redhat.com
Fixed checkpatch warning after removing FSF address paragraph as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v3:
- Fixed subject
- Fixed commit message
drivers/staging/rtl8712/basic_types.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl87
Fixed checkpatch warning after removing FSF address block as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v3:
- Fixed subject
- Fixed commit message
drivers/staging/rtl8712/ieee80211.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/iee
Fixed Multiple FSF address checkpatch warnings to conform to kernel coding
style.
Parth Sane (5):
staging: rtl8712: Fixed FSF address warning in basic_types.h
staging: rtl8712: Fixed FSF address warning in drv_types.h
staging: rtl8712: Fixed FSF address warning in ethernet.h
staging: rtl8
Fixed checkpatch warning after removing FSF address block as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v3:
- Fixed subject
- Fixed commit message
drivers/staging/rtl8712/hal_init.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/hal_
Fixed checkpatch warning after removing FSF address block as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v3:
- Fixed subject
- Fixed commit message
drivers/staging/rtl8712/drv_types.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/drv
Fixed checkpatch warning after removing FSF address block as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v3:
- Fixed subject
- Fixed commit message
drivers/staging/rtl8712/ethernet.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/ethe
This patch replaces struct semaphore hif_sema_deinit with struct mutex
hif_deinit_lock. It is better to use mutex because mutex gives better
performance than semaphore.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 18 +-
1 file changed, 9 insertions
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Monday, March 21, 2016 12:52 AM
> To: KY Srinivasan
> Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; Haiyang
> Zhang ; Alex Ng (LIS) ;
> Radim Krcmar ; Cathy Avery
> Subject: Re: [PATCH]
From: Colin Ian King
The ENOMEM error return paths are not free'ing allocated memory
resulting in a memory leak of allocated structures. Perform the
required kfree to fix the memory leaks.
Issue discovered with static analysis using CoverityScan
Signed-off-by: Colin Ian King
---
drivers/stagi
On Mon, Mar 21, 2016 at 10:53:36PM +0530, Sohom Bhattacharjee wrote:
> fixed *only* comments that did not follow kernel coding style.
> the errors were caught by the checkpatch.pl tool
>
> Signed-off-by: Sohom Bhattacharjee
Does not apply to the tree at all :(
___
On Mon, Mar 21, 2016 at 08:17:36AM +, Parth Sane wrote:
> Fixed checkpatch warning caused to FSF address block as per guidelines.
>
> Signed-off-by: Parth Sane
> ---
> Changes in v2:
> - Added commit message
Incorrect subject :(
___
devel mai
On Mon, Mar 21, 2016 at 08:17:35AM +, Parth Sane wrote:
> Fixed checkpatch warning caused due to FSF address block as per guidelines.
>
> Signed-off-by: Parth Sane
> ---
> Changes in v2:
> - Added commit message.
Incorrect subject :(
___
deve
On Mon, Mar 21, 2016 at 08:17:34AM +, Parth Sane wrote:
> Fixed checkpatch check caused by FSF address paragraph as per guidelines.
>
> Signed-off-by: Parth Sane
Your subject is not correct :(
___
devel mailing list
de...@linuxdriverproject.org
h
On Sun, Mar 20, 2016 at 03:58:28PM +, Parth Sane wrote:
> Signed-off-by: Parth Sane
I can't take patches with no changelog text :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev
On Sun, Mar 20, 2016 at 03:59:09PM +, Parth Sane wrote:
> *** BLURB HERE ***
You forgot to fill this out :(
>
> Parth Sane (5):
> staging: rtl8712: Fixed FSF address warning in basic_types.h
> staging: rtl8712: Fixed FSF address warning in drv_types.h
> staging: rtl9712: Fixed FSF addr
On Sun, Mar 20, 2016 at 02:10:08AM +, Parth Sane wrote:
> Fixed checkpatch warnings about parenthesis alignment at line #186.
Why is a line number needed? How is this different from your previous
patch for this driver?
Please resend all of your previous patches for this driver, I don't know
w
On Mon, Mar 14, 2016 at 01:29:00PM +0900, Daeseok Youn wrote:
> the tty_alloc_driver() can allocate memory for ttys and termios.
> And also it can release allocated memory easly with using
> put_tty_driver().
>
> Signed-off-by: Daeseok Youn
But you broke the driver in the previous patch, you can
On Mon, Mar 14, 2016 at 01:28:31PM +0900, Daeseok Youn wrote:
> For using tty_alloc_driver, SerialDriver has to be pointer type.
Yes, but you aren't calling tty_alloc_driver, so this patch totally
breaks the working code :(
Please be more careful...
greg k-h
_
On Mon, Mar 14, 2016 at 01:28:01PM +0900, Daeseok Youn wrote:
> Signed-off-by: Daeseok Youn
Your subject: does not make sense, and I can't take a patch without any
changelog entry :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.
Removes a void pointer in prism2mgmt.c
Signed-off-by: Ben Marsh
---
drivers/staging/wlan-ng/prism2mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/prism2mgmt.c
b/drivers/staging/wlan-ng/prism2mgmt.c
index 013a624..d8ed9a0 100644
--- a/drivers/st
On Sun, Mar 13, 2016 at 07:14:38PM +0100, Ben Marsh wrote:
> Patch to nvec.c to remove a useless cast on a void pointer.
>
> Signed-off-by: Ben Marsh
> ---
> drivers/staging/nvec/nvec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Someone sent this before you did :(
_
On Sat, Mar 12, 2016 at 03:40:35AM -0500, YU Bo wrote:
> Fix comments to use trailing */ on separste lines.
>
> Signed-off-by: YU BO
> ---
> drivers/staging/xgifb/vb_init.c|3 ++-
> drivers/staging/xgifb/vb_setmode.c |3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
You sent m
On Sat, Mar 12, 2016 at 01:54:17PM +0530, PrasannaKumar Muralidharan wrote:
> From: PrasannaKumar Muralidharan
>
> Remove unnecessary __cplusplus check in header files as it is not
> required.
Your subject line contains a spelling mistake :(
___
devel
On Mon, Mar 21, 2016 at 03:08:41PM +0530, PrasannaKumar Muralidharan wrote:
> > Are you sure you can just remove these markings? Does the code work the
> > same? What is properly locking these values? Why were they marked this
> > way in the first place?
>
> I could not test the change due to l
On Sun, Mar 20, 2016 at 09:47:29PM +0800, To .LiMit wrote:
> Hi, I saw drivers/staging/rtl8192e/TODO, checked the files within
> drivers/staging/rtl8192e/, and I found their function naming codestyle is
> camelcase, I changed them. But I don't know if I should change all variable
> naming codest
On Mon, Mar 21, 2016 at 06:44:04PM +0800, Ming Li wrote:
> hi, in drivers/staging/skein/, i move macros into appropriate header
> files.
>
>
> Regards,
>
>
> Signed-off-by: Ming Li
Please use scripts/checkpatch.pl to find the errors in your patch before
sending.
Also, don't send html ema
On Monday, March 21, 2016 8:39 AM, Ian Abbott wrote:
> On 18/03/16 19:38, H Hartley Sweeten wrote:
>> This driver has a lot of checkpatch.pl issues:
>> total: 0 errors, 71 warnings, 27 checks, 1222 lines checked
>>
>> There is also a lot of cruft that bloats the driver and makes it harder
>> to fol
fixed *only* comments that did not follow kernel coding style.
the errors were caught by the checkpatch.pl tool
Signed-off-by: Sohom Bhattacharjee
---
drivers/staging/rts5208/rtsx.c | 55 +-
drivers/staging/rts5208/rtsx_chip.h | 53 -
On Mon, Mar 21, 2016 at 01:26:58PM +0100, David Herrmann wrote:
> Hi
>
> On Mon, Mar 21, 2016 at 8:51 AM, Daniel Vetter wrote:
> > Just a bit of wording polish plus mentioning that it can fail and must
> > be restarted.
> >
> > Requested by Sumit.
> >
> > v2: Fix them typos (Hans).
> >
> > Cc: Ch
On 18/03/16 19:38, H Hartley Sweeten wrote:
This driver has a lot of checkpatch.pl issues:
total: 0 errors, 71 warnings, 27 checks, 1222 lines checked
There is also a lot of cruft that bloats the driver and makes it harder
to follow.
This series fixes all the checkpatch.pl issues:
total: 0 erro
Two things wrong with this submission:
1) You need to provide an initial "[PATCH net-next 0/3] ..." header posting
explaining at a high level what this patch series is about and how it is
implemented and why.
2) The net-next tree is closed at this time because we are in the merge window,
On 18/03/16 19:39, H Hartley Sweeten wrote:
Remove the unnecessary NULL pointer check.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers
On 18/03/16 19:39, H Hartley Sweeten wrote:
Remove the unnecessary NULL pointer check.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/c
On 03/21/2016 04:51 AM, Daniel Vetter wrote:
Just a bit of wording polish plus mentioning that it can fail and must
be restarted.
Requested by Sumit.
v2: Fix them typos (Hans).
Cc: Chris Wilson
Cc: Tiago Vignatti
Cc: Stéphane Marchesin
Cc: David Herrmann
Cc: Sumit Semwal
Cc: Daniel Vetter
On 03/18/2016 05:02 PM, Chris Wilson wrote:
Drivers, especially i915.ko, can fail during the initial migration of a
dma-buf for CPU access. However, the error code from the driver was not
being propagated back to ioctl and so userspace was blissfully ignorant
of the failure. Rendering corruption
Hi
On Mon, Mar 21, 2016 at 8:51 AM, Daniel Vetter wrote:
> Just a bit of wording polish plus mentioning that it can fail and must
> be restarted.
>
> Requested by Sumit.
>
> v2: Fix them typos (Hans).
>
> Cc: Chris Wilson
> Cc: Tiago Vignatti
> Cc: Stéphane Marchesin
> Cc: David Herrmann
> Cc
On Mon, Mar 21, 2016 at 08:00:49PM +0900, Tetsuo Handa wrote:
> Greg Kroah-Hartman wrote:
> > On Tue, Mar 08, 2016 at 03:18:59PM +0100, Michal Hocko wrote:
> > > On Tue 08-03-16 20:01:32, Tetsuo Handa wrote:
> > > > Currently, lowmemorykiller (LMK) is using TIF_MEMDIE for two purposes.
> > > > One
Greg Kroah-Hartman wrote:
> On Tue, Mar 08, 2016 at 03:18:59PM +0100, Michal Hocko wrote:
> > On Tue 08-03-16 20:01:32, Tetsuo Handa wrote:
> > > Currently, lowmemorykiller (LMK) is using TIF_MEMDIE for two purposes.
> > > One is to remember processes killed by LMK, and the other is to
> > > accele
> Are you sure you can just remove these markings? Does the code work the
> same? What is properly locking these values? Why were they marked this
> way in the first place?
I could not test the change due to lack of hardware.
Given that the code works without lock and as volatile does not
guar
"K. Y. Srinivasan" writes:
> Implement copy-free read APIs.
>
> Signed-off-by: K. Y. Srinivasan
> ---
> drivers/hv/ring_buffer.c | 55
> ++
> include/linux/hyperv.h |6 +
> 2 files changed, 61 insertions(+), 0 deletions(-)
>
> diff --git
"K. Y. Srinivasan" writes:
> We need to issue a full memory barrier prior making a signalling
> decision.
Any reason this should be mb()? This is pretty strong and will probably
lead to performace regression ... and, btw, we have another mb() in
hv_ringbuffer_read().
Could you please describe t
Fixed checkpatch warning caused to FSF address block as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v2:
- Added commit message
drivers/staging/rtl8712/ieee80211.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/ieee80211.c
b/drivers/staging/r
Fixed checkpatch warning caused due to FSF address block as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v2:
- Added commit message.
drivers/staging/rtl8712/hal_init.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/hal_init.c
b/drivers/stagin
Fixed checkpatch check caused by FSF address paragraph as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v2:
- Added commit message
drivers/staging/rtl8712/ethernet.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/ethernet.h
b/drivers/staging/r
Fixed checkpatch warning caused due to FSF address block.
Linux already has a copy of the GPL, so as per checkpatch this address block is
unnecessary.
Parth Sane (5):
staging: rtl8712: Fixed FSF address warning in basic_types.h
staging: rtl8712: Fixed FSF address warning in drv_types.h
stagi
Fixed checkpatch check caused by FSF address paragraph as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v2:
- Added commit message
drivers/staging/rtl8712/basic_types.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/basic_types.h
b/drivers/stag
Fixed checkpatch check caused by FSF address paragraph as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v2:
- Added commit message
drivers/staging/rtl8712/drv_types.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/drv_types.h
b/drivers/staging
This is for the hv_sock driver, which introduces AF_HYPERV(42).
Signed-off-by: Dexuan Cui
Cc: "K. Y. Srinivasan"
Cc: Haiyang Zhang
---
net/core/sock.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/core/sock.c b/net/core/sock.c
index 7e73c26..51ffc54 100644
--- a
Hyper-V Sockets (hv_sock) supplies a byte-stream based communication
mechanism between the host and the guest. It's somewhat like TCP over
VMBus, but the transportation layer (VMBus) is much simpler than IP.
With Hyper-V Sockets, applications between the host and the guest can talk
to each other d
This is for the recent kcm driver, which introduces AF_KCM(41) in
b7ac4eb(kcm: Kernel Connection Multiplexor module).
Signed-off-by: Dexuan Cui
Cc: Signed-off-by: Tom Herbert
---
net/core/sock.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/net/core/sock.c b/net/c
On Mon, Mar 21, 2016 at 8:40 AM, Hans Verkuil wrote:
>> +For correctness and optimal performance, it is always required to use
>> +SYNC_START and SYNC_END before and after, respectively, when accessing
>> the
>> +mapped address. Userspace cannot on coherent access, even when there are
On 03/21/2016 08:51 AM, Daniel Vetter wrote:
> Just a bit of wording polish plus mentioning that it can fail and must
> be restarted.
>
> Requested by Sumit.
>
> v2: Fix them typos (Hans).
>
> Cc: Chris Wilson
> Cc: Tiago Vignatti
> Cc: Stéphane Marchesin
> Cc: David Herrmann
> Cc: Sumit Sem
KY Srinivasan writes:
>> -Original Message-
>> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
>> Sent: Friday, March 18, 2016 5:33 AM
>> To: de...@linuxdriverproject.org
>> Cc: linux-ker...@vger.kernel.org; KY Srinivasan ;
>> Haiyang Zhang ; Alex Ng (LIS)
>> ; Radim Krcmar ; Cathy
>>
Just a bit of wording polish plus mentioning that it can fail and must
be restarted.
Requested by Sumit.
v2: Fix them typos (Hans).
Cc: Chris Wilson
Cc: Tiago Vignatti
Cc: Stéphane Marchesin
Cc: David Herrmann
Cc: Sumit Semwal
Cc: Daniel Vetter
CC: linux-me...@vger.kernel.org
Cc: dri-de...
Hi Daniel,
Two small comments:
On 03/21/2016 08:30 AM, Daniel Vetter wrote:
> Just a bit of wording polish plus mentioning that it can fail and must
> be restarted.
>
> Requested by Sumit.
>
> Cc: Chris Wilson
> Cc: Tiago Vignatti
> Cc: Stéphane Marchesin
> Cc: David Herrmann
> Cc: Sumit Se
Just a bit of wording polish plus mentioning that it can fail and must
be restarted.
Requested by Sumit.
Cc: Chris Wilson
Cc: Tiago Vignatti
Cc: Stéphane Marchesin
Cc: David Herrmann
Cc: Sumit Semwal
Cc: Daniel Vetter
CC: linux-me...@vger.kernel.org
Cc: dri-de...@lists.freedesktop.org
Cc: l
On 21 March 2016 at 13:00, Daniel Vetter wrote:
> Just a bit of wording polish plus mentioning that it can fail and must
> be restarted.
>
> Requested by Sumit.
>
> Cc: Chris Wilson
> Cc: Tiago Vignatti
> Cc: Stéphane Marchesin
> Cc: David Herrmann
> Cc: Sumit Semwal
> Cc: Daniel Vetter
> CC
Thanks for the patch, Gustavo!
On 18 March 2016 at 19:49, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> sync_file is useful to connect one or more fences to the file. The file is
> used by userspace to track fences.
>
I think it is worthwhile to add relevant bits to the Documentation as
wel
71 matches
Mail list logo