[PATCH] staging: rts5208: alignment to match open paranthesis

Fixes CHECK: Alignment should match open parenthesis Signed-off-by: Manav Batra --- drivers/staging/rts5208/ms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c index 3e75db7..0f0cd4a 100644

[PATCH 23/35] staging: comedi: das1800: cleanup copyright and comedi comment blocks

Tidy up these multi-line comments to fix the checkpatch.pl issues: WARNING: Block comments use * on subsequent lines WARNING: line over 80 characters Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman

[PATCH 30/35] staging: comedi: das1800: remove the function comments

These comments are just added cruft. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c | 4 1 file changed, 4 deletions(-) diff

[PATCH 15/35] staging: comedi: das1800: tidy up das1800_probe()

Refactor das1800_probe() to return an errno instead of the boardinfo pointer. Add the board 'id' to the boardinfo to tidy up this function to clarify the sanity check when the user provided a board name when trying to attach to the driver. Currently when this function probes for a boardinfo

[PATCH 35/35] staging: comedi: das1800: update the MODULE_DESCRIPTION

Change the MODULE_DESCRIPTION to something more usefull than the generic "Comedi low-level driver". Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c

[PATCH 22/35] staging: comedi: das1800: document the spinlock

The comedi_device spinlock is used to protect the indirect addressing selected by the DAS1800_SELECT register. It also prevents races between the interrupt handler and the analog input (*poll). Update the comments to make this clear. Signed-off-by: H Hartley Sweeten

[PATCH 10/35] staging: comedi: das1800: refactor 'ao_ability' boardinfo

The "da" and "hc" type boards have normal analog outputs. The "ao" type boards have move advanced analog outputs with waveform generation capability. Replace the 'ao_ability' member of the boardinfo with some bit-field flags, 'has_ao' and 'has_wform_ao', and only set them appropriately based on

[PATCH 25/35] staging: comedi: das1800: move comment about max conversion speeds

For aesthetics, move this information into the comedi comment block. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c | 7 +++ 1 file changed, 3

[PATCH 00/35] staging: comedi: das1800: tidy up driver

Tidy up this driver and fix all the checkpatch.pl issues. This series applies after the bug fix patches: staging: comedi: das1800: fix analog input sample munging staging: comedi: das1800: fix analog input number of channels staging: comedi: das1800: fix das-1801st-da boardinfo Patch 28/35

[PATCH 12/35] staging: comedi: das1800: refactor 'ao_n_chan' boardinfo

The "st-da" board types have 4 analog output channels. All other board types, with analog outputs, only have 2 channels. Replace the 'ao_n_chan' member of the boardinfo with a bit-field flag, 'has_4_ao_chan' and only set it for the "st-da" boards. Remove the unnecessary initialization for all

[PATCH 19/35] staging: comedi: das1800: refactor program_chanlist()

Refactor this function so it can be used to program the chanlist for the analog input (*do_cmd) and (*insn_read). Rename the function so it has namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg

[PATCH 03/35] staging: comedi: das1800: tidy up analog output subdevice init

For aesthetics, add some whitespace to the subdevice init and rename the (*insn_write) function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c |

[PATCH 06/35] staging: comedi: das1800: remove 'common' boardinfo member

The 64 channel "hc" type boards do not support common mode analog inputs all the other boards do. Remove the unnecessary member from the boardinfo and use the 'has_64_ai_chan' member to determine if the SDF_COMMON flag needs to be set for the subdevice. Signed-off-by: H Hartley Sweeten

[PATCH 20/35] staging: comedi: das1800: use comedi_timeout()

Use the helper function to handle the busywaiting for the analog input conversion to complete. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c | 34

[PATCH 11/35] staging: comedi: das1800: initialize all analog outputs

The current code used to initialize the analog outputs only sets the last channel. The other channels will be reloaded with the last value that was written to them. Move the initialzation into the subdevice init and properly initialize all the channels to 0V. Signed-off-by: H Hartley Sweeten

[PATCH 24/35] staging: comedi: das1800: change type of private data 'fifo_buf'

Fix the checkpatch.pl issue: CHECK: Prefer kernel type 'u16' over 'uint16_t' Change the type to 'unsigned short' as that is more typical in comedi drivers. Use sizeof(*p) instead of sizeof(type) when allocation the buffer. Also fix the checkpatch.pl issue: WARNING: line over 80 characters

[PATCH 32/35] staging: comedi: das1800: fix comments in das1800_ai_handler()

Fix the checkpatch.pl issues: WARNING: line over 80 characters Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c | 12 +--- 1 file changed, 5

[PATCH 04/35] staging: comedi: das1800: tidy up analog input subdevice init

For aesthetics, add some whitespace to the subdevice init and rename the subdevice support functions. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman ---

[PATCH 29/35] staging: comedi: das1800: fix NULL pointer dereference in das1800_ai_setup_dma()

DMA is optional with this driver. If it was not enabled the devpriv->dma pointer will be NULL. It's probably harmless here because the 'desc' pointer will not be used if DMA is disabled. But, fix the possible NULL pointer dereference. Signed-off-by: H Hartley Sweeten

[PATCH 07/35] staging: comedi: das1800: tidy up das1800_ao_insn_write()

The (*insn_write) functions are supposed to write insn->n values to the specified channel. Tidy up this function and make it work like the core expects. Use the comedi_offset_munge() helper to handle the munging of the data to 2's complement format. Signed-off-by: H Hartley Sweeten

[PATCH 34/35] staging: comedi: das1800: fix comments about the 'ao' board range

The waveform analog outputs on the 'ao' boards are not currently supported. Modify the comment about the analog output range on these boards so that the information is saved but fixes the checkpatch.pl issues: WARNING: Block comments use a trailing */ on a separate line Move the comment so it's

[PATCH 08/35] staging: comedi: das1800: refactor 'resolution' boardinfo

The "hr" type boards have 16-bit analog inputs and outputs. All other board types are 12-bit. Replace the 'resolution' member of the boardinfo with a bit-field flag, 'is_16bit', and only set it for the 16-bit boards. Remove the unnecessary initialization for the 12-bit boards. Signed-off-by: H

[PATCH 26/35] staging: comedi: das1800: remove the private data member comments

The comments about the members of the private data are not really necessary and removing them fixes a couple checkpatch.pl issues. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman ---

[PATCH 28/35] staging: comedi: das1800: fix das1800_ai_cancel()

DMA is optional with this driver. If it was not enabled the devpriv->dma pointer will be NULL. Fix the possible NULL pointer dereference when trying to disable the DMA channels. Also, tidy up the comments to fix the checkpatch.pl issues: WARNING: line over 80 characters Signed-off-by: H Hartley

[PATCH 33/35] staging: comedi: das1800: fix lines over 80 characters

These comments are just extra cruft. Remove them to fix the checkpatch.pl issues: WARNING: line over 80 characters Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman ---

[PATCH 18/35] staging: comedi: das1800: absorb control_c_bits()

Absorb this helper function into the analog input (*do_cmd). For aesthetics, convert the switch code into if/else. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman ---

[PATCH 05/35] staging: comedi: das1800: tidy up boardinfo

For aesthetics, add some whitespace to the boardinfo array and remove the unnecessary '= 0' initializations. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman ---

[PATCH 27/35] staging: comedi: das1800: rename burst_convert_arg()

Rename this function so it has namespace associated with the driver. Remove the unnecessary comment about the function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman ---

[PATCH 16/35] staging: comedi: das1800: add analog output readback

Use the core provided readback support to allow reading back the last value written to the analog output channels. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman ---

[PATCH 31/35] staging: comedi: das1800: fix comments in das1800_ai_cmd()

Fix the checkpatch.pl issues: WARNING: Block comments use a trailing */ on a separate line WARNING: line over 80 characters Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman ---

[PATCH 17/35] staging: comedi: das1800: introduce das1800_ai_chanspec_bits()

Introduce a helper function for the common code needed to get the control c register bits for a channel specification. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman ---

[PATCH 02/35] staging: comedi: das1800: tidy up digital input subdevice init

For aesthetics, add some whitespace to the subdevice init and rename the (*insn_bits) function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c | 22

[PATCH 14/35] staging: comedi: das1800: change type of 'ai_speed' boardinfo

This value is compared against the unsigned int cmd->convert_arg to check the minimum value (max speed) for the analog input conversion timing. For aesthetics, change the type to match the cmd->convert_arg type. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott

[PATCH 09/35] staging: comedi: das1800: refactor 'do_n_chan' boardinfo

The "hc" type boards have 8 digtial outputs. All other board types have 4. Replace the 'do_n_chan' member of the boardinfo with a bit-field flag, 'has_8_do_chan', and only set it for the "hc" type boards. Remove the unnecessary initialization for all other board types. Signed-off-by: H Hartley

[PATCH 01/35] staging: comedi: das1800: tidy up digital output subdevice init

For aesthetics, add some whitespace to the subdevice init and rename the (*insn_bits) function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c | 22

[PATCH 21/35] staging: comedi: das1800: absorb control_a_bits()

Absorb this helper function into the analog input (*do_cmd). For aesthetics, convert the switch code into if/else. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman ---

[PATCH 13/35] staging: comedi: das1800: refactor 'range_ai' boardinfo

The boards supported by this driver have analog inputs with gains of 1, 10, 50, and 250 ("01" type) or 1, 2, 4, and 8 ("02" type). Replace the 'range_ai' member of the boardinfo with a bit-field flag, 'das1801_range' and only set it for the "01" type boards. Remove the unnecessary initialization

Re: [PATCH] staging: rts5208: alignment to match open paranthesis

On Wed, Apr 06, 2016 at 02:41:01PM -0700, Manav Batra wrote: > Fixes CHECK: Alignment should match open parenthesis > > Is the subject and patch fine? > Sorry, just getting used to the process, and thanks. Yes, this is better, but please resend without these two lines in here, you don't want

[PATCH 5/7] staging: wilc1000: change handle_set_operation_mode's return type to void

When handle_set_operation_mode is called in hostIFthread that is a kernel thread, it is not checked return type of this function. This patch changes return type to void and removes braces if statement due to have a single statement. Signed-off-by: Chaehyun Lim ---

[PATCH 7/7] staging: wilc1000: rename result in handle_set_operation_mode

This patch renames result to ret that is used to get return value from wilc_send_config_pkt. Some handle_*() functions are used as result, others are used as ret. It will be changed as ret in all handle_*() functions to match variable name. Signed-off-by: Chaehyun Lim ---

[PATCH 2/7] staging: wilc1000: change handle_set_wfi_drv_handler's return type to void

When handle_set_wfi_drv_handler is called in hostIFthread that is a kernel thread, it is not checked return type of this function. This patch changes return type to void and removes braces if statement due to have a single statement. Signed-off-by: Chaehyun Lim ---

[PATCH 3/7] staging: wilc1000: change data type of result in handle_set_wfi_drv_handler

This patch changes data type of result variable from s32 to int. result is used to get return value from wilc_send_config_pkt that has return type of int. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 4/7] staging: wilc1000: rename result in handle_set_wfi_drv_handler

This patch renames result to ret that is used to get return value from wilc_send_config_pkt. Some handle_*() function are used as result, others are used as ret. It will be changed as ret in all handle_*() function to match variable name. Signed-off-by: Chaehyun Lim ---

[PATCH 1/7] staging: wilc1000: change return type of ret variable in handle_get_tx_pwr

This patch changes return type of ret variable from s32 to int. ret has return value from wilc_send_config_pkt that has return type of int. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] staging: android: ion: make locally used functions static

Functions ion_handle_put and ion_handle_get_by_id are only used locally in ion.c, so they should be made static as they used to be before 9590232b ("staging/android/ion : fix a race condition in the ion driver"). Signed-off-by: Markus Böhme ---

Re: android,lowmemorykiller: Don't abuse TIF_MEMDIE.

Dan Carpenter wrote: > Hello Tetsuo Handa, Hello, Dan. > > This is a semi-automatic email about new static checker warnings. > > The patch 77ed2c5745d9: "android,lowmemorykiller: Don't abuse > TIF_MEMDIE." from Mar 8, 2016, leads to the following Smatch > complaint: > >

[PATCH] staging: rts5208: alignment to match open paranthesis

Fixes CHECK: Alignment should match open parenthesis Is the subject and patch fine? Sorry, just getting used to the process, and thanks. Signed-off-by: Manav Batra --- drivers/staging/rts5208/ms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2] staging: iio: ad7606: use iio_device_{claim|release}_direct_mode()

On 04/06/2016 06:11 AM, Alison Schofield wrote: > Replace the code that guarantees the device stays in direct mode with > iio_device_{claim|release}_direct_mode() which does same. > > Signed-off-by: Alison Schofield Looks good, thanks. Acked-by: Lars-Peter Clausen

Re: [PATCH] Fixes some checkpatch.pl warnings

On Wed, Apr 06, 2016 at 04:38:07AM -0700, Manav Batra wrote: > CHECK: Alignment should match open parenthesis > WARNING: line over 80 characters > > Signed-off-by: Manav Batra > --- > drivers/staging/rts5208/ms.c | 66 > ++-- > 1

[PATCH 10/24] staging: lustre: selftest: convert sfw_test_client_ops_t to proper struct

Turn typedef sfw_test_client_ops_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/brw_test.c |3 ++- drivers/staging/lustre/lnet/selftest/framework.c |2 +- drivers/staging/lustre/lnet/selftest/ping_test.c |3 ++-

[PATCH 22/24] staging: lustre: selftest: convert srpc_msg_t to proper struct

Turn typedef struct srpc_msg to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/brw_test.c |8 drivers/staging/lustre/lnet/selftest/conrpc.c| 14 +++--- drivers/staging/lustre/lnet/selftest/conrpc.h|2

[PATCH 17/24] staging: lustre: selftest: convert lstcon_ndlink_t to proper struct

Turn typedef lstcon_ndlink_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/conrpc.c |6 +- drivers/staging/lustre/lnet/selftest/console.c | 64 drivers/staging/lustre/lnet/selftest/console.h |7

[PATCH 21/24] staging: lustre: selftest: convert lstcon_test_t to proper struct

Turn typedef lstcon_test_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/conctl.c |2 +- drivers/staging/lustre/lnet/selftest/conrpc.c |5 ++- drivers/staging/lustre/lnet/selftest/console.c | 26

[PATCH 23/24] staging: lustre: selftest: convert wire protocol to use struct

Change all the wire protocol typedefs to proper structures Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/brw_test.c | 22 ++-- drivers/staging/lustre/lnet/selftest/conrpc.c| 44 +++--- drivers/staging/lustre/lnet/selftest/console.c | 10

[PATCH 20/24] staging: lustre: selftest: convert lstcon_batch_t to proper struct

Turn typedef lstcon_batch_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/conrpc.c |4 +- drivers/staging/lustre/lnet/selftest/console.c | 46 drivers/staging/lustre/lnet/selftest/console.h |7

[PATCH 16/24] staging: lustre: selftest: convert lstcon_node_t to proper struct

Turn typedef lstcon_node_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/conrpc.c | 32 drivers/staging/lustre/lnet/selftest/console.c | 20 +++---

[PATCH 18/24] staging: lustre: selftest: convert lstcon_group_t to proper struct

Turn typedef lstcon_group_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/conrpc.c |6 +- drivers/staging/lustre/lnet/selftest/console.c | 80 drivers/staging/lustre/lnet/selftest/console.h |9

[PATCH 24/24] staging: lustre: selftest: change srpc_state_t to proper enum

Turn typedef srpc_state_t to proper enum Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/rpc.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lnet/selftest/rpc.c

[PATCH 15/24] staging: lustre: selftest: convert lstcon_rpc_trans_t to proper struct

Turn typedef lstcon_rpc_trans_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/conrpc.c | 36 drivers/staging/lustre/lnet/selftest/conrpc.h | 20 ++--

[PATCH 19/24] staging: lustre: selftest: convert lstcon_tsb_hdr_t to proper struct

Turn typedef lstcon_tsb_hdr_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/conrpc.c |5 +++-- drivers/staging/lustre/lnet/selftest/console.c |2 +- drivers/staging/lustre/lnet/selftest/console.h |8 3 files

[PATCH 06/24] staging: lustre: selftest: convert srpc_client_rpc_t to proper struct

Turn typedef srpc_client_rpc_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/brw_test.c |6 ++-- drivers/staging/lustre/lnet/selftest/conrpc.c|8 ++-- drivers/staging/lustre/lnet/selftest/conrpc.h|2 +-

[PATCH 14/24] staging: lustre: selftest: convert lstcon_rpc_t to proper struct

Turn typedef lstcon_rpc_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/conrpc.c | 50 drivers/staging/lustre/lnet/selftest/conrpc.h | 18 drivers/staging/lustre/lnet/selftest/console.c |

[PATCH 12/24] staging: lustre: selftest: convert sfw_test_unit_t to proper struct

Turn typedef sfw_test_unit_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/brw_test.c |8 drivers/staging/lustre/lnet/selftest/framework.c | 20 ++-- drivers/staging/lustre/lnet/selftest/ping_test.c

[PATCH 03/24] staging: lustre: selftest: convert srpc_bulk_t to proper struct

Turn typedef srpc_bulk_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/brw_test.c | 14 +++--- drivers/staging/lustre/lnet/selftest/conrpc.c|4 ++-- drivers/staging/lustre/lnet/selftest/framework.c |2 +-

[PATCH 11/24] staging: lustre: selftest: convert sfw_test_instance_t to proper struct

Turn typedef sfw_test_instance_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/brw_test.c |8 +++--- drivers/staging/lustre/lnet/selftest/framework.c | 26 +++---

[PATCH 04/24] staging: lustre: selftest: convert srpc_buffer_t to proper struct

Turn typedef srpc_buffer_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/rpc.c | 12 ++-- drivers/staging/lustre/lnet/selftest/selftest.h |6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH 13/24] staging: lustre: selftest: convert sfw_test_case_t to proper struct

Turn typedef sfw_test_case_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/framework.c | 16 drivers/staging/lustre/lnet/selftest/selftest.h |4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff

[PATCH 09/24] staging: lustre: selftest: convert sfw_batch_t to proper struct

Turn typedef sfw_batch_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/framework.c | 38 +++--- drivers/staging/lustre/lnet/selftest/selftest.h |6 ++-- 2 files changed, 22 insertions(+), 22 deletions(-)

[PATCH 05/24] staging: lustre: selftest: convert swi_workitem_t to proper struct

Turn typedef swi_workitem_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/framework.c |4 +- drivers/staging/lustre/lnet/selftest/rpc.c |8 +++--- drivers/staging/lustre/lnet/selftest/selftest.h | 26

[PATCH 02/24] staging: lustre: selftest: convert srpc_event_t to proper struct

Turn typedef srpc_event_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/rpc.c | 20 ++-- drivers/staging/lustre/lnet/selftest/selftest.h | 14 +++--- 2 files changed, 17 insertions(+), 17

[PATCH 08/24] staging: lustre: selftest: convert sfw_session_t to proper struct

Turn typedef sfw_session_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/brw_test.c |6 ++-- drivers/staging/lustre/lnet/selftest/framework.c | 40 +++--- drivers/staging/lustre/lnet/selftest/ping_test.c |

[PATCH 00/24] staging: lustre: selftest: remove typedefs

The lnet selftest code is littered with typedefs. Convert these typedefs into their proper data types. James Simmons (24): staging: lustre: selftest: convert srpc_event_type to proper enum staging: lustre: selftest: convert srpc_event_t to proper struct staging: lustre: selftest: convert

[PATCH 07/24] staging: lustre: selftest: convert srpc_service_t to proper struct

Turn typedef srpc_service_t to proper structure Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/brw_test.c |3 +- drivers/staging/lustre/lnet/selftest/console.c |3 +- drivers/staging/lustre/lnet/selftest/framework.c |8 +++---

[PATCH 01/24] staging: lustre: selftest: convert srpc_event_type to proper enum

Turn tyepdef srpc_event_type to proper enum Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/selftest.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lnet/selftest/selftest.h

Re: [lustre-devel] [PATCH] staging/lustre/obdclass: fix build warning

> While building with W=1 we were getting the warning: > > drivers/staging/lustre/lustre/obdclass/cl_object.c:1056:16: > warning: old-style function definition > struct lu_env *cl_env_percpu_get() > ^ > > Signed-off-by: Sudip Mukherjee

Re: [1/9] rtlwifi: Fix Smatch warnings

> Smatch reports the following: > > CHECK drivers/net/wireless/realtek/rtlwifi/pci.c > drivers/net/wireless/realtek/rtlwifi/pci.c:366 rtl_pci_check_buddy_priv() > error: we previously assumed 'tpriv' could be null (see line 368) > drivers/net/wireless/realtek/rtlwifi/pci.c:1216

Re: [1/2] rtlwifi: rtl8723be: Add antenna select module parameter

> A number of new laptops have been delivered with only a single antenna. > In principle, this is OK; however, a problem arises when the on-board > EEPROM is programmed to use the other antenna connection. The option > of opening the computer and moving the connector is not always possible > as

re: android,lowmemorykiller: Don't abuse TIF_MEMDIE.

Hello Tetsuo Handa, This is a semi-automatic email about new static checker warnings. The patch 77ed2c5745d9: "android,lowmemorykiller: Don't abuse TIF_MEMDIE." from Mar 8, 2016, leads to the following Smatch complaint: drivers/staging/android/lowmemorykiller.c:145 lowmem_scan()

[PATCH] staging: comedi: das1800: fix das-1801st-da boardinfo

The "da" type boards all have 4 analog inputs. Fix the boardinfo for the das-1801st-da. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c | 2 +- 1

RE: [PATCH] staging: comedi: das1800: remove unused variable

On Wednesday, April 06, 2016 3:41 AM, Ian Abbott wrote: > On 06/04/16 10:41, Ian Abbott wrote: >> On 06/04/16 02:21, Hartley Sweeten wrote: >>> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: The variable unipolar was never used. Signed-off-by: Sudip Mukherjee

[PATCH] staging: comedi: das1800: fix analog input number of channels

The "hc" type boards have 64 analog input channels with a 64 entry queue. All the others have 16 channels and a 256 entry queue. Currently the boardinfo 'qram_len' is used to initialize the subdevice 'n_chan' and 'len_chanlist'. This works for the 64 channel boards but sets the 'n_chan' wrong for

Re: [PATCH] staging: iio: ad7606: use iio_device_{claim|release}_direct_mode()

On 04/03/2016 11:09 AM, Jonathan Cameron wrote: > On 01/04/16 17:53, Alison Schofield wrote: >> Two instances are moved to the new claim/release API: >> >> In the first instance, the driver was using mlock followed by >> iio_buffer_enabled(). Replace that code with the new API to guarantee >> the

[PATCH] staging: comedi: das1800: fix analog input sample munging

The analog input samples are 2's complement when the inputs are configured for bipolar ranges and offset binary when they are unipolar ranges. For bipolar ranges the samples need to be munged to the offset binary format that comedi uses. The (*insn_read) does the munging correctly but the async

RE: [PATCH] staging: comedi: das1800: remove unused variable

On Wednesday, April 06, 2016 2:41 AM, Ian Abbott wrote: > On 06/04/16 02:21, Hartley Sweeten wrote: >> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: >>> The variable unipolar was never used. >>> >>> Signed-off-by: Sudip Mukherjee >>> --- >>> >>> There

[PATCH] staging: unisys: removed unused 'visor_device.respond_to_device_create'

From: Alexander Curtin The respond_to_device_create flag was used previously when we used to delay responses to create requests until the drivers were finished loading. This behaviour was removed some time ago, yet the field still existed, while never being

Re: [PATCH] staging: rts5208: ensure braces on all arms of if stmt

On Tue, Apr 05, 2016 at 05:29:17PM +0100, Nicholas Sim wrote: > Added braces on if arm of if statement where else arm already needs braces > as suggested for clarity in Documentation/CodingStyle > > Signed-off-by: Nicholas Sim > --- > drivers/staging/rts5208/ms.c | 3

[PATCH] Fixes some checkpatch.pl warnings

CHECK: Alignment should match open parenthesis WARNING: line over 80 characters Signed-off-by: Manav Batra --- drivers/staging/rts5208/ms.c | 66 ++-- 1 file changed, 39 insertions(+), 27 deletions(-) diff --git

Re: [PATCH] staging: comedi: das1800: remove unused variable

On 06/04/16 10:41, Ian Abbott wrote: On 06/04/16 02:21, Hartley Sweeten wrote: On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: The variable unipolar was never used. Signed-off-by: Sudip Mukherjee --- There may be a chance that reading from

Re: [PATCH] staging: comedi: das1800: remove unused variable

On 06/04/16 02:21, Hartley Sweeten wrote: On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: The variable unipolar was never used. Signed-off-by: Sudip Mukherjee --- There may be a chance that reading from DAS1800_CONTROL_C is necessary before reading