Re: [PATCH] ion: scatterlist offset not used for buffer map

2016-04-07 Thread John Einar Reitan
On Thu, Apr 07, 2016 at 12:37:50PM -0700, Laura Abbott wrote: > On 04/07/2016 04:29 AM, John Einar Reitan wrote: > > ion's default user/kernel page mapping code don't honor the offset > > option for scatterlists. It uses sg_page and expect the whole page to be > > mapped, while the offset could dic

[PATCH] staging: wilc1000: move initialization of the config values

2016-04-07 Thread Alison Schofield
Move the initialization of the config values so that an uninit'd mutex is not exposed and to simplify the initialization process. The code was allocating a structure with a lock, initializing and taking the lock, setting some values, and then releasing the lock. If no other thread can get it, the

RE: [PATCH v8 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-04-07 Thread Dexuan Cui
> From: Joe Perches [mailto:j...@perches.com] > Sent: Friday, April 8, 2016 9:15 > On Thu, 2016-04-07 at 18:36 -0700, Dexuan Cui wrote: > > diff --git a/include/net/af_hvsock.h b/include/net/af_hvsock.h > [] > > +#define VMBUS_RINGBUFFER_SIZE_HVSOCK_RECV (5 * PAGE_SIZE) > > +#define VMBUS_RINGBUFFE

Re: [PATCH v8 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-04-07 Thread Joe Perches
On Thu, 2016-04-07 at 18:36 -0700, Dexuan Cui wrote: > Hyper-V Sockets (hv_sock) supplies a byte-stream based communication > mechanism between the host and the guest. It's somewhat like TCP over > VMBus, but the transportation layer (VMBus) is much simpler than IP. [] > diff --git a/include/net/af

[PATCH v8 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-04-07 Thread Dexuan Cui
Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It's somewhat like TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V Sockets, applications between the host and the guest can talk to each other d

[PATCH v8 net-next 0/1] introduce Hyper-V VM Sockets(hv_sock)

2016-04-07 Thread Dexuan Cui
Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It's somewhat like TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V Sockets, applications between the host and the guest can talk to each other d

Re: [PATCH] staging: android: ion: make locally used functions static

2016-04-07 Thread Laura Abbott
On 04/06/2016 02:53 PM, Markus Böhme wrote: Functions ion_handle_put and ion_handle_get_by_id are only used locally in ion.c, so they should be made static as they used to be before 9590232b ("staging/android/ion : fix a race condition in the ion driver"). Signed-off-by: Markus Böhme Reviewed

Re: [PATCH] staging: android: ion: dummy: fix dereference of ERR_PTR

2016-04-07 Thread Laura Abbott
On 04/07/2016 09:32 AM, Sudip Mukherjee wrote: ion_device_create() can fail and if it fails then it returns the error value in ERR_PTR. Reviewed-by: Laura Abbott Signed-off-by: Sudip Mukherjee --- drivers/staging/android/ion/ion_dummy_driver.c | 2 ++ 1 file changed, 2 insertions(+) di

Re: [PATCH] ion: scatterlist offset not used for buffer map

2016-04-07 Thread Laura Abbott
On 04/07/2016 04:29 AM, John Einar Reitan wrote: ion's default user/kernel page mapping code don't honor the offset option for scatterlists. It uses sg_page and expect the whole page to be mapped, while the offset could dictate an offset within a large page. sg_phys correctly accounts for the of

[PATCH] Staging: android: modify memory allocation style in ion_chunk_heap.c

2016-04-07 Thread Ben Marsh
Modify memory allocation style in order to silence a checkpatch.pl warning. Signed-off-by: Ben Marsh --- drivers/staging/android/ion/ion_chunk_heap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_chunk_heap.c b/drivers/staging/android/io

RE: [PATCH 00/35] staging: comedi: das1800: tidy up driver

2016-04-07 Thread Hartley Sweeten
On Thursday, April 07, 2016 4:24 AM, Ian Abbott wrote: > On 07/04/16 00:31, H Hartley Sweeten wrote: >> Tidy up this driver and fix all the checkpatch.pl issues. >> >> This series applies after the bug fix patches: >>staging: comedi: das1800: fix analog input sample munging >>staging: comed

Re: [PATCH] staging: rtl8192u: remove blank lines after braces (opening)

2016-04-07 Thread Joe Perches
On Thu, 2016-04-07 at 21:06 +0300, Andy Shevchenko wrote: > On Thu, Apr 7, 2016 at 9:04 PM, Joe Perches wrote: > > On Thu, 2016-04-07 at 20:59 +0300, Andy Shevchenko wrote: > > > On Tue, Apr 5, 2016 at 7:07 PM, Nicholas Sim wrote: > > > > > > > > Remove unneeded blank lines appearing after openi

Re: [PATCH] staging: rtl8192u: remove blank lines after braces (opening)

2016-04-07 Thread Joe Perches
On Thu, 2016-04-07 at 20:59 +0300, Andy Shevchenko wrote: > On Tue, Apr 5, 2016 at 7:07 PM, Nicholas Sim wrote: > > > > Remove unneeded blank lines appearing after opening braces as suggested > > by checkpatch.pl > > > You have to combine this with the rest so called 'indentation' fixes, > e.g.

Re: [PATCH] staging: rtl8192u: remove blank lines after braces (opening)

2016-04-07 Thread Andy Shevchenko
On Thu, Apr 7, 2016 at 9:04 PM, Joe Perches wrote: > On Thu, 2016-04-07 at 20:59 +0300, Andy Shevchenko wrote: >> On Tue, Apr 5, 2016 at 7:07 PM, Nicholas Sim wrote: >> > >> > Remove unneeded blank lines appearing after opening braces as suggested >> > by checkpatch.pl >> > >> You have to combine

Re: [PATCH] staging: rtl8192u: remove blank lines after braces (opening)

2016-04-07 Thread Andy Shevchenko
On Tue, Apr 5, 2016 at 7:07 PM, Nicholas Sim wrote: > Remove unneeded blank lines appearing after opening braces as suggested > by checkpatch.pl > You have to combine this with the rest so called 'indentation' fixes, e.g. +- empty lines, tabs vs. spaces, etc. P.S. By the way. are they first patc

RE: [PATCH] staging: comedi: das1800: fix analog input number of channels

2016-04-07 Thread Hartley Sweeten
On Thursday, April 07, 2016 9:48 AM, Hartley Sweeten wrote: > On Thursday, April 07, 2016 3:16 AM, Ian Abbott wrote: >> On 06/04/16 19:06, H Hartley Sweeten wrote: >>> The "hc" type boards have 64 analog input channels with a 64 entry queue. >>> All the others have 16 channels and a 256 entry queue

RE: [PATCH] staging: comedi: das1800: fix analog input number of channels

2016-04-07 Thread Hartley Sweeten
On Thursday, April 07, 2016 3:16 AM, Ian Abbott wrote: > On 06/04/16 19:06, H Hartley Sweeten wrote: >> The "hc" type boards have 64 analog input channels with a 64 entry queue. >> All the others have 16 channels and a 256 entry queue. >> >> Currently the boardinfo 'qram_len' is used to initialize

[PATCH] staging: android: ion: dummy: fix dereference of ERR_PTR

2016-04-07 Thread Sudip Mukherjee
ion_device_create() can fail and if it fails then it returns the error value in ERR_PTR. Signed-off-by: Sudip Mukherjee --- drivers/staging/android/ion/ion_dummy_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/ion/ion_dummy_driver.c b/drivers/staging/andro

Re: [RFC PATCH v1 1/9] selftest: sync: basic tests for sw_sync framework

2016-04-07 Thread Emil Velikov
On 4 April 2016 at 05:12, Emilio López wrote: > Hi, > > El 28/03/16 a las 10:48, Emil Velikov escribió: > > These tests are based on the libsync test suite from Android. > This commit lays the ground for future tests, as well as includes > tests for a variety of basic allocation comman

RE: [PATCH v7 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-04-07 Thread Dexuan Cui
> From: Joe Perches [mailto:j...@perches.com] > Sent: Thursday, April 7, 2016 19:30 > To: Dexuan Cui ; gre...@linuxfoundation.org; > da...@davemloft.net; net...@vger.kernel.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com;

[PATCH] ion: scatterlist offset not used for buffer map

2016-04-07 Thread John Einar Reitan
ion's default user/kernel page mapping code don't honor the offset option for scatterlists. It uses sg_page and expect the whole page to be mapped, while the offset could dictate an offset within a large page. sg_phys correctly accounts for the offset, so should be used instead. Signed-off-by: Jo

Re: [PATCH v7 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-04-07 Thread Joe Perches
On Thu, 2016-04-07 at 05:50 -0700, Dexuan Cui wrote: > Hyper-V Sockets (hv_sock) supplies a byte-stream based communication > mechanism between the host and the guest. It's somewhat like TCP over > VMBus, but the transportation layer (VMBus) is much simpler than IP. style trivia: > diff --git a/n

Re: [PATCH 00/35] staging: comedi: das1800: tidy up driver

2016-04-07 Thread Ian Abbott
On 07/04/16 00:31, H Hartley Sweeten wrote: Tidy up this driver and fix all the checkpatch.pl issues. This series applies after the bug fix patches: staging: comedi: das1800: fix analog input sample munging staging: comedi: das1800: fix analog input number of channels staging: comedi: d

[PATCH v7 net-next 0/1] introduce Hyper-V VM Sockets(hv_sock)

2016-04-07 Thread Dexuan Cui
Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It's somewhat like TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V Sockets, applications between the host and the guest can talk to each other d

[PATCH v7 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-04-07 Thread Dexuan Cui
Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It's somewhat like TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V Sockets, applications between the host and the guest can talk to each other d

Re: [PATCH] staging: comedi: das1800: fix das-1801st-da boardinfo

2016-04-07 Thread Ian Abbott
On 07/04/16 11:16, Ian Abbott wrote: On 06/04/16 19:20, H Hartley Sweeten wrote: The "da" type boards all have 4 analog inputs. Fix the boardinfo for the das-1801st-da. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c | 2 +

Re: [PATCH] staging: comedi: das1800: fix analog input number of channels

2016-04-07 Thread Ian Abbott
On 07/04/16 11:15, Ian Abbott wrote: On 06/04/16 19:06, H Hartley Sweeten wrote: The "hc" type boards have 64 analog input channels with a 64 entry queue. All the others have 16 channels and a 256 entry queue. Currently the boardinfo 'qram_len' is used to initialize the subdevice 'n_chan' and '

Re: android,lowmemorykiller: Don't abuse TIF_MEMDIE.

2016-04-07 Thread Tetsuo Handa
Dan Carpenter wrote: > On Thu, Apr 07, 2016 at 06:49:58AM +0900, Tetsuo Handa wrote: > > Dan Carpenter wrote: > > > Hello Tetsuo Handa, > > > > Hello, Dan. > > > > > > > > This is a semi-automatic email about new static checker warnings. > > > > > > The patch 77ed2c5745d9: "android,lowmemorykil

Re: [PATCH] staging: comedi: das1800: fix das-1801st-da boardinfo

2016-04-07 Thread Ian Abbott
On 06/04/16 19:20, H Hartley Sweeten wrote: The "da" type boards all have 4 analog inputs. Fix the boardinfo for the das-1801st-da. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] staging: comedi: das1800: fix analog input number of channels

2016-04-07 Thread Ian Abbott
On 06/04/16 19:06, H Hartley Sweeten wrote: The "hc" type boards have 64 analog input channels with a 64 entry queue. All the others have 16 channels and a 256 entry queue. Currently the boardinfo 'qram_len' is used to initialize the subdevice 'n_chan' and 'len_chanlist'. This works for the 64 c

Re: [PATCH] staging: comedi: das1800: fix analog input sample munging

2016-04-07 Thread Ian Abbott
On 06/04/16 18:45, H Hartley Sweeten wrote: The analog input samples are 2's complement when the inputs are configured for bipolar ranges and offset binary when they are unipolar ranges. For bipolar ranges the samples need to be munged to the offset binary format that comedi uses. The (*insn_rea

Re: android,lowmemorykiller: Don't abuse TIF_MEMDIE.

2016-04-07 Thread Dan Carpenter
On Thu, Apr 07, 2016 at 06:49:58AM +0900, Tetsuo Handa wrote: > Dan Carpenter wrote: > > Hello Tetsuo Handa, > > Hello, Dan. > > > > > This is a semi-automatic email about new static checker warnings. > > > > The patch 77ed2c5745d9: "android,lowmemorykiller: Don't abuse > > TIF_MEMDIE." from M