[PATCH 2/4] staging: skein: cleanup: Fixed operator whitespace

2016-04-29 Thread Manu Kumar
added operator white space and parentheses for readability --- drivers/staging/skein/skein_base.c| 66 +-- drivers/staging/skein/skein_base.h| 28 +++ drivers/staging/skein/skein_block.c | 44 --- drivers/staging/skein/three

[PATCH 1/4] staging: skein: cleanup: fixed new lines

2016-04-29 Thread Manu Kumar
Added lines between functions in skein_block.c and removed unneeded lines in skein_block.c --- drivers/staging/skein/skein_api.c | 1 - drivers/staging/skein/skein_block.c | 4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/skein/skein_api.c b/drivers/stagin

[PATCH] Staging: speakup: i18n: Fixed a CHECK coding style.

2016-04-29 Thread rohitsakala
NULL comparison has been changed to correct coding style. Signed-off-by: Sakala Venkata Krishna Rohit --- drivers/staging/speakup/i18n.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c index 8960079..a031a2d

Re: [PATCH 00/14] staging: fsl-mc: misc updates

2016-04-29 Thread Greg KH
On Mon, Apr 11, 2016 at 11:48:25AM -0500, Stuart Yoder wrote: > From: Stuart Yoder > > This patch series makes further progress towards completing the fsl-mc > TODO list. I don't seem to have gotten patch 14/14, can you resend just that one? thanks, greg k-h ___

[PATCH V5 7/9] staging: rtl8192u: propagate errors in write_nic_byte_E

2016-04-29 Thread Salah Triki
Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_byte_E from void to int. Signed-off-by: Salah Triki --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 9 ++--- 2 files changed, 7 insertions(+), 4 deletions(-)

[PATCH V5 9/9] staging: rtl8192u: propagate errors in write_nic_dword

2016-04-29 Thread Salah Triki
Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_dword from void to int. Signed-off-by: Salah Triki --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 9 ++--- 2 files changed, 7 insertions(+), 4 deletions(-)

[PATCH V5 6/9] staging: rtl8192u: propagate errors in write_nic_byte

2016-04-29 Thread Salah Triki
Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_byte from void to int. Signed-off-by: Salah Triki --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 10 ++ 2 files changed, 7 insertions(+), 5 deletions(-

[PATCH V5 5/9] staging: rtl8192u: check return value of rtl8192_read_eeprom_info

2016-04-29 Thread Salah Triki
The call of rtl8192_read_eeprom_info may fail, therefore its return value must be checked and propagated in the case of error Signed-off-by: Salah Triki --- drivers/staging/rtl8192u/r8192U_core.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8

[PATCH V5 4/9] staging: rtl8192u: propagate errors in rtl8192_read_eeprom_info

2016-04-29 Thread Salah Triki
Propagate error from eprom_read and change the return type of rtl8192_read_eeprom_info from void to int. Signed-off-by: Salah Triki --- drivers/staging/rtl8192u/r8192U_core.c | 37 +- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/drivers/staging/

[PATCH V5 8/9] staging: rtl8192u: propagate errors in write_nic_word

2016-04-29 Thread Salah Triki
Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_word from void to int. Signed-off-by: Salah Triki --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 9 ++--- 2 files changed, 7 insertions(+), 4 deletions(-) d

[PATCH V5 2/9] staging: rtl8192u: propagate errors in eprom_read

2016-04-29 Thread Salah Triki
Propagate error from eprom_r and change the return type of eprom_read from u32 to int. Signed-off-by: Salah Triki --- drivers/staging/rtl8192u/r8180_93cx6.c | 9 +++-- drivers/staging/rtl8192u/r8180_93cx6.h | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/stagin

[PATCH V5 0/9] staging: rtl8192u: Checking return value/propagating errors

2016-04-29 Thread Salah Triki
These patchs check the return value/propagate error of the functions read_nic_word_E, eprom_r, eprom_read, rtl8192_read_eeprom_info, write_nic_* Salah Triki (9): staging: rtl8192u: check return value of read_nic_word_E staging: rtl8192u: propagate errors in eprom_read staging: rtl8192u: chec

[PATCH V5 1/9] staging: rtl8192u: check return value of read_nic_word_E

2016-04-29 Thread Salah Triki
The call of read_nic_word_E may fail, therefore its return value must be checked and propagated in the case of error. Signed-off-by: Salah Triki --- drivers/staging/rtl8192u/r8180_93cx6.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/staging/r

[PATCH V5 3/9] staging: rtl8192u: check return value eprom_read

2016-04-29 Thread Salah Triki
The call of eprom_read may fail, therefore its return value must be checked Signed-off-by: Salah Triki --- drivers/staging/rtl8192u/r8192U_core.c | 145 +++-- 1 file changed, 103 insertions(+), 42 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/dr

Re: [PATCH 2/4] staging: skein: cleanup: fixed blank lines

2016-04-29 Thread Greg KH
On Mon, Apr 04, 2016 at 08:08:06PM -0700, Manu Kumar wrote: > Added a blank line between functions in skein_block.c and removed unneeded > blank lines in skein_api.c and threefish_block.c > > Signed-off-by: Manu Kumar > --- > drivers/staging/skein/skein_api.c | 1 - > drivers/staging/skein/

Re: [PATCH v2 1/4] drivers: staging: fix parameter alignment

2016-04-29 Thread Greg KH
On Mon, Apr 18, 2016 at 10:35:28AM +1000, Tobin C Harding wrote: > drivers/staging/android/ion/ion.c checkpatch produces alignment checks. > > This patch is whitespace only and fixes these checks. > > Signed-off-by: Tobin C Harding > --- > drivers/staging/android/ion/ion.c | 64 > +

Re: [PATCH] staging: rts5208: Avoid multiple assignment in one line

2016-04-29 Thread Greg KH
On Thu, Apr 28, 2016 at 10:42:07PM -0700, Manav Batra wrote: > Signed-off-by: Manav Batra > > Separates out assignment in one line to two lines. signed-off-by goes at the end of the text, not at the top. Please fix all of these and resend. thanks, greg k-h

Re: [PATCH] staging: rts5208: Unnecessary parantheses around chip->sd_card

2016-04-29 Thread Greg KH
On Fri, Apr 29, 2016 at 11:15:27AM +0530, Manav Batra wrote: > Removes unnecessary parantheses around chip->sd_card > Signed-off-by: Manav Batra > --- >  drivers/staging/rts5208/sd.c | 6 +++--- >  1 file changed, 3 insertions(+), 3 deletions(-) HTML patches do not work, sorry :( Also, put a blan

Re: [PATCH] Staging: android: change memory allocation style in ion.c

2016-04-29 Thread Greg KH
On Thu, Apr 14, 2016 at 08:11:35PM +0200, Ben Marsh wrote: > Modify the memory allocation style in ion.c in order to silence a > checkpatch.pl warning. > > Signed-off-by: Ben Marsh > --- > drivers/staging/android/ion/ion.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) You s

Re: [PATCH v2 00/13] De-stage Sync File Framework

2016-04-29 Thread Greg Kroah-Hartman
On Thu, Apr 28, 2016 at 10:46:47AM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Hi, > > This patchset sits on top of Sync ABI Rework v13: > > https://www.spinics.net/lists/dri-devel/msg105667.html > > The first eight clean up and prepare sync_file for de-staging. The last four > p

Re: [PATCH 3/6] intel_sgx: driver for Intel Secure Guard eXtensions

2016-04-29 Thread Jethro Beekman
On 29-04-16 13:04, Jarkko Sakkinen wrote: >>> Why would you want to do that? >> >> ... > > Do you see this as a performance issue or why do you think that this > would hurt that much? I don't think it's a performance issue at all. I'm just giving an example of why you'd want to do this. I'm sure p

Re: [PATCH 0/6] Intel Secure Guard Extensions

2016-04-29 Thread Jarkko Sakkinen
On Tue, Apr 26, 2016 at 09:00:10PM +0200, Pavel Machek wrote: > On Mon 2016-04-25 20:34:07, Jarkko Sakkinen wrote: > > Intel(R) SGX is a set of CPU instructions that can be used by > > applications to set aside private regions of code and data. The code > > outside the enclave is disallowed to acc

[PATCH v2] vme: change LM callback argument to void pointer

2016-04-29 Thread Aaron Sierra
Make the location monitor callback function prototype more useful by changing the argument from an integer to a void pointer. All VME bridge drivers were simply passing the location monitor index (e.g. 0-3) as the argument to these callbacks. It is much more useful to pass back a pointer to data t

RE: Time for a code audit?

2016-04-29 Thread Kershner, David A
> -Original Message- > From: Romer, Benjamin M > Sent: Tuesday, February 16, 2016 10:03 AM > To: Dan Carpenter > Cc: gre...@linuxfoundation.org; driverdev-devel@linuxdriverproject.org; > Sell, Timothy C ; *S-Par-Maintainer > > Subject: Re: Time for a code audit? > ... > > Hi Dan, > >

Re: [PATCH 0/6] Intel Secure Guard Extensions

2016-04-29 Thread Jarkko Sakkinen
On Tue, Apr 26, 2016 at 09:00:10PM +0200, Pavel Machek wrote: > On Mon 2016-04-25 20:34:07, Jarkko Sakkinen wrote: > > Intel(R) SGX is a set of CPU instructions that can be used by > > applications to set aside private regions of code and data. The code > > outside the enclave is disallowed to acc

Re: [PATCH 3/6] intel_sgx: driver for Intel Secure Guard eXtensions

2016-04-29 Thread Jarkko Sakkinen
On Wed, Apr 27, 2016 at 04:32:23PM -0700, Jethro Beekman wrote: > On 27-04-16 05:40, Jarkko Sakkinen wrote: > >> The hardware supports calling EEXTEND on only a part of a page, I think the > >> driver should also support that. > > > > Why would you want to do that? > > You might have segments in a

[PATCH 1/3] Drivers: hv: balloon: don't crash when memory is added in non-sorted order

2016-04-29 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov When we iterate through all HA regions in handle_pg_range() we have an assumption that all these regions are sorted in the list and the 'start_pfn >= has->end_pfn' check is enough to find the proper region. Unfortunately it's not the case with WS2016 where host can hot-add

RE: [PATCH] PCI: hv: report resources release after stopping the bus

2016-04-29 Thread Jake Oshins
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Friday, April 29, 2016 2:39 AM > To: linux-...@vger.kernel.org > Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; KY > Srinivasan ; Haiyang Zhang > ; Bjorn Helgaas ; Jake > Oshins > Subject: [

Re: [PATCH 2/8] staging: rtl8192u: check return value eprom_read

2016-04-29 Thread Dan Carpenter
On Thu, Apr 28, 2016 at 06:53:14PM +0100, Salah Triki wrote: > The call of eprom_read may fail, therefore its return value must be > checked. > > Signed-off-by: Salah Triki > --- > drivers/staging/rtl8192u/r8192U_core.c | 147 > +++-- > 1 file changed, 104 insertions

Re: [PATCH] staging: rtl8712: Removed paragraph about writing to FSF

2016-04-29 Thread Dan Carpenter
On Fri, Apr 29, 2016 at 03:12:09AM -0700, Manav Batra wrote: > Signed-off-by: Manav Batra > > Removed paragraph about writing to FSF since the address may change and > a copy of the GPL is included already. Stop doing this already. Read your emails. regards, dan carpenter

[PATCH] staging: rtl8712: Removed paragraph about writing to FSF

2016-04-29 Thread Manav Batra
Signed-off-by: Manav Batra Removed paragraph about writing to FSF since the address may change and a copy of the GPL is included already. --- drivers/staging/rtl8712/recv_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/recv_linux.c b/drivers

Re: [PATCH] staging: sm750fb: unsigned int instead of unsigned

2016-04-29 Thread Dan Carpenter
On Fri, Apr 29, 2016 at 02:21:43AM -0700, Manav Batra wrote: > Signed-off-by: Manav Batra > > Replaced occurences of unsigned with unsigned int. The Signed-off-by goes at the end. Look at some other patches and copy the format. Please resend everything. regards, dan carpenter ___

[PATCH] PCI: hv: report resources release after stopping the bus

2016-04-29 Thread Vitaly Kuznetsov
Kernel hang is observed when pci-hyperv module is release with device drivers still attached. E.g. when I do 'rmmod pci_hyperv' with BCM5720 device pass-through-ed (tg3 module) I see the following: NMI watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [rmmod:2104] ... Call Trace: [] tg3_read_

[PATCH] staging: sm750fb: unsigned int instead of unsigned

2016-04-29 Thread Manav Batra
Signed-off-by: Manav Batra Replaced occurences of unsigned with unsigned int. --- drivers/staging/sm750fb/sm750.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 6ed004e..0665b5c 100644 --- a/d

[PATCH] staging: sm750fb: Removed multiple blank lines

2016-04-29 Thread Manav Batra
Signed-off-by: Manav Batra Removes multiple blank lines. --- drivers/staging/sm750fb/ddk750_power.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_power.c b/drivers/staging/sm750fb/ddk750_power.c index b3c3791..5d92a09 100644 --- a/drivers/staging/sm750fb/d