> -Original Message-
> From: Neil Horman [mailto:nhor...@redhat.com]
> Sent: Wednesday, June 01, 2016 2:43 PM
> To: Sell, Timothy C
> Cc: Kershner, David A; cor...@lwn.net; t...@linutronix.de;
> mi...@redhat.com; h...@zytor.com; gre...@linuxfoundation.org;
> Arfvidson, Erik; hof...@osadl.or
The semaphore 'wx_sem' in ieee80211_device is a simple mutex,
so it should be written as one. Semaphores are going away in the future.
Signed-off-by: Binoy Jayan
---
This patch depends on the following patch:
rtl8192u: r8192_priv: Replace semaphore wx_sem with mutex
drivers/staging/rtl8192u/iee
The semaphore 'scan_sem' in rtl8192u is a simple mutex, so it should
be written as one. Semaphores are going away in the future.
Signed-off-by: Binoy Jayan
---
This patch depends on the following patch:
rtl8192u: ieee80211_device: Replace semaphore wx_sem with mutex
drivers/staging/rtl8192u/iee
The semaphore 'wx_sem' in r8192_priv is a simple mutex, so
it should be written as one. Semaphores are going away in the future.
Signed-off-by: Binoy Jayan
---
drivers/staging/rtl8192u/r8192U.h | 2 +-
drivers/staging/rtl8192u/r8192U_core.c | 28 ++--
drivers/staging/rtl8192u/r8192
The semaphore 'rf_sem' in rtl8192u is a simple mutex, so it should
be written as one. Semaphores are going away in the future.
Signed-off-by: Binoy Jayan
---
This patch depends on the following patch:
rtl8192u: Replace semaphore scan_sem with mutex
drivers/staging/rtl8192u/r8192U.h | 2 +-
Hi,
These are a set of patches which removes semaphores from:
drivers/staging/rtl8192u
They build correctly (individually and as a whole).
NB: I have not tested this as I do not have the following hardware:
"RealTek RTL8192U Wireless LAN NIC driver"
Thanks,
Binoy
Binoy Jayan (4):
rtl8192u:
The semaphore 'terminate_cmdthread_sema' is used as completion,
so convert it to a struct completion type.
Signed-off-by: Binoy Jayan
---
This patch depends on the following patch:
rtl8712: Replace semaphore cmd_queue_sema with completion
drivers/staging/rtl8712/os_intfs.c| 2 +-
drivers/s
The semaphore 'lock' in 'pwrctrl_priv' is used as a simple mutex, so it
should be written as one. Semaphores are going away in the future.
_enter_pwrlock was using down_interruptible(), so the lock could be broken
by sending a signal. This could be a bug, because nothing checks the return
code here
Hi,
These are a set of patches [v2] which removes semaphores from:
drivers/staging/rtl8712
They build correctly (individually and as a whole).
NB: I have not tested this as I do not have the following hardware:
"RealTek RTL8712U (RTL8192SU) Wireless LAN NIC driver"
Rework on comments w.r.t. PA
The semaphore 'cmd_queue_sema' is used as completion,
so convert it to a struct completion type.
Signed-off-by: Binoy Jayan
---
drivers/staging/rtl8712/os_intfs.c| 2 +-
drivers/staging/rtl8712/rtl8712_cmd.c | 2 +-
drivers/staging/rtl8712/rtl871x_cmd.c | 6 +++---
drivers/stagin
The semaphore 'lock' in 'intf_priv' is used as completion,
so convert it to a struct completion type.
Signed-off-by: Binoy Jayan
---
This patch depends on the following patch:
rtl8712: Replace semaphore terminate_cmdthread_sema with completion
drivers/staging/rtl8712/osdep_intf.h| 2 +-
dr
Correctly handle the settling time cycles value. The else branch is an
impossible condition, > 1022 in the else branch of > 511. Flipping the order.
Based on the Table 13 at the bottom of Page 25 of the Data Sheet:
http://www.analog.com/media/en/technical-documentation/data-sheets/AD5933.pdf
Sign
On Wed, Jun 01, 2016 at 03:09:13PM +, Sell, Timothy C wrote:
> > -Original Message-
> > From: Neil Horman [mailto:nhor...@redhat.com]
> > Sent: Wednesday, June 01, 2016 10:18 AM
> > To: Kershner, David A
> > Cc: cor...@lwn.net; t...@linutronix.de; mi...@redhat.com;
> > h...@zytor.com; g
On 01/06/16 17:22, Lars-Peter Clausen wrote:
> On 06/01/2016 05:55 PM, Luis de Bethencourt wrote:
>> Correctly handle the settling time cycles value. The else branch was an
>> impossible condition (> 1022 in the else branch of > 511) and the handling
>> of the values was dividing by 2 and 4, with a
On 06/01/2016 05:55 PM, Luis de Bethencourt wrote:
> Correctly handle the settling time cycles value. The else branch was an
> impossible condition (> 1022 in the else branch of > 511) and the handling
> of the values was dividing by 2 and 4, with a left shift, instead of
> multiplying.
>
> Based
Correctly handle the settling time cycles value. The else branch was an
impossible condition (> 1022 in the else branch of > 511) and the handling
of the values was dividing by 2 and 4, with a left shift, instead of
multiplying.
Based on the Table 13 at the bottom of Page 25 of the Data Sheet:
htt
> -Original Message-
> From: Neil Horman [mailto:nhor...@redhat.com]
> Sent: Wednesday, June 01, 2016 10:18 AM
> To: Kershner, David A
> Cc: cor...@lwn.net; t...@linutronix.de; mi...@redhat.com;
> h...@zytor.com; gre...@linuxfoundation.org; Arfvidson, Erik; Sell, Timothy
> C; hof...@osadl.o
On Tue, May 31, 2016 at 10:26:36PM -0400, David Kershner wrote:
> From: Tim Sell
>
> Locking in the _interrupt() function is NOT necessary so long as we ensure
> that interrupts have been stopped whenever we need to pause or resume the
> device, which we now do.
>
> While a device is paused, we
On 01/06/16 11:26, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the comedi_bond.c file that fixes up a
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drive
On 01/06/16 11:26, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the das16m1.c file that fixes up a
WARNING: 'Block comments use a trailing */ on a separate line'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/dri
On 01/06/16 11:26, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the jr3_pci.c file that fixes up a
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/j
On 01/06/16 11:26, Ravishankar Karkala Mallikarjunayya wrote:
This patch Replace all occurences of (1<
---
drivers/staging/comedi/drivers/das6402.c | 56
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das6402.c
b
On 01/06/16 11:26, Ravishankar Karkala Mallikarjunayya wrote:
This patch Replace all occurences of (1<
---
drivers/staging/comedi/drivers/das16.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ ME
On Tue, May 31, 2016 at 10:26:29PM -0400, David Kershner wrote:
> From: Erik Arfvidson
>
> This patch changes the vague -1 return values to -EPERM.
> This operation is not supported is a good alternative
> to -1 because the return is basically telling the caller
> that the processor doesn't suppo
On 01/06/16 11:26, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the jr3_pci.c file that fixes up a
WARNING: 'Block comments use a trailing */ on a separate line'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/dri
On 01/06/16 11:26, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the me_daq.c file that fixes up a
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/me
On Tue, May 31, 2016 at 10:26:27PM -0400, David Kershner wrote:
> From: Erik Arfvidson
>
> This patch changes the vague -1 return values to -EFAULT since
> it would be the most appropriate, given that this error
> would only occur in an unexpected bad offset field.
> Resulting in a bad address.
>
On 01/06/16 11:26, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the mpc624.c file that fixes up a
WARNING: 'Statements should start on a tabstop' found by
the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/mpc624.c |
On 01/06/16 11:26, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the ni_65xx.c file that fixes up a
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
found by the checkpatch.pl tool
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/ni
On 01/06/16 11:26, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the pcmuio.c file that fixes up a
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/pc
On Tue, May 31, 2016 at 10:26:28PM -0400, David Kershner wrote:
> From: Erik Arfvidson
>
> This patch changes the vague -1 return value to -EINVAL
>
> Signed-off-by: Erik Arfvidson
> Signed-off-by: David Kershner
> Reviewed-by: Tim Sell
> ---
> drivers/staging/unisys/visorbus/visorchipset.c
On Wednesday, June 1, 2016 2:56:51 PM CEST Binoy Jayan wrote:
> Resending the same patchset by adding the following lists:
> de...@driverdev.osuosl.org
> linux-ker...@vger.kernel.org
>
> Hi,
>
> These are a set of patches towards the removing semaphores.
> They build correctly (individually a
There is a rare race when we remove an entry from the global list
hv_context.percpu_list[cpu] in hv_process_channel_removal() ->
percpu_channel_deq() -> list_del(): at this time, if vmbus_on_event() ->
process_chn_event() -> pcpu_relid2channel() is trying to query the list,
we can get the kernel fa
This is a patch to the jr3_pci.c file that fixes up a
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/jr3_pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-
This patch Replace all occurences of (1<
---
drivers/staging/comedi/drivers/das6402.c | 56
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das6402.c
b/drivers/staging/comedi/drivers/das6402.c
index 1701294..f6319b3 1
This is a patch to the comedi_bond.c file that fixes up a
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/comedi_bond.c | 10 +-
1 file changed, 5 insertions(+)
This is a patch to the das16m1.c file that fixes up a
WARNING: 'Block comments use a trailing */ on a separate line'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/das16m1.c | 168 ---
1 file chan
This patch Replace all occurences of (1<
---
drivers/staging/comedi/drivers/das16.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das16.c
b/drivers/staging/comedi/drivers/das16.c
index fd8e0b7..69133e3 100644
This is a patch to the jr3_pci.c file that fixes up a
WARNING: 'Block comments use a trailing */ on a separate line'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/jr3_pci.c | 32
1 file chan
This is a patch to the me_daq.c file that fixes up a
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/me_daq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
This is a patch to the mpc624.c file that fixes up a
WARNING: 'Statements should start on a tabstop' found by
the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/mpc624.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --g
This is a patch to the ni_65xx.c file that fixes up a
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
found by the checkpatch.pl tool
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/ni_65xx.c | 18 +-
1 file changed, 9 insertions(+),
This is a patch to the pcmuio.c file that fixes up a
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya
---
drivers/staging/comedi/drivers/pcmuio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
> >> [5.472143] BUG: unable to handle kernel paging request at
> >> 00079fff5288
> >> [5.477107] IP: [] vmbus_onoffer+0x311/0x570
> >> [hv_vmbus]
> >> ...
> >> Vitaly
> >
> > I can't reproduce the panic somehow, but I did find a bug in
> vmbus_process_offer():
> >
> > "hv_event_taskle
On 01/06/16 10:19, Ashwin Ravichandran wrote:
Fixed a coding style issue.
Signed-off-by: Ashwin Ravichandran
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +-
drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletion
On 31/05/16 18:07, Joe Perches wrote:
On Tue, 2016-05-31 at 11:29 +0100, Ian Abbott wrote:
On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the s626.c file that fixes up a type issues like
i.e Prefer kernel type 'u8' over 'uint8_t'
Prefer kernel type 'u16'
The semaphore 'scan_sem' in the rtl8192e is a simple mutex, so it should
be written as one. Semaphores are going away in the future.
Signed-off-by: Binoy Jayan
---
This patch depends on the following patch:
rtl8192e: Replace semaphore rf_sem with mutex
drivers/staging/rtl8192e/rtllib.h
Resending the same patchset by adding the following lists:
de...@driverdev.osuosl.org
linux-ker...@vger.kernel.org
Hi,
These are a set of patches towards the removing semaphores.
They build correctly (individually and as a whole).
Is there any way to get this tested as I do not have the follo
The semaphore 'ips_sem' in the rtl8192e is a simple mutex, so it should
be written as one. Semaphores are going away in the future.
Signed-off-by: Binoy Jayan
---
This patch depends on the following patch:
rtl8192e: Replace semaphore scan_sem with mutex
drivers/staging/rtl8192e/rtl8192e/rtl_ca
The semaphore 'wx_sem' in the rtllib_device is a simple mutex,
so it should be written as one. Semaphores are going away in the future.
Signed-off-by: Binoy Jayan
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 4 +--
drivers/staging/rtl8192e/rtllib.h| 5 ++--
drivers/staging/rt
The semaphore 'rf_sem' in the rtl8192e is a simple mutex, so it should
be written as one. Semaphores are going away in the future.
Signed-off-by: Binoy Jayan
---
This patch depends on the following patch:
rtl8192e: r8192_priv: Replace semaphore wx_sem with mutex
drivers/staging/rtl8192e/rtl819
The semaphore 'wx_sem' in the r8192_priv is a simple mutex,
so it should be written as one. Semaphores are going away in the future.
Signed-off-by: Binoy Jayan
---
This patch depends on the following patch:
rtl8192e: rtllib_device: Replace semaphore wx_sem with mutex
drivers/staging/rtl8192e/r
Fixed a coding style issue.
Signed-off-by: Ashwin Ravichandran
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +-
drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/a
Dexuan Cui writes:
>> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
>> Sent: Wednesday, June 1, 2016 0:27
>> To: Dexuan Cui
>> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev-
>> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
>> jasow...@redhat.co
On Wednesday, June 1, 2016 10:52:06 AM CEST Binoy Jayan wrote:
> The semaphore 'lock' in 'pwrctrl_priv' is used as a simple mutex,
> so it should be written as one. Semaphores are going away in the future.
>
> Signed-off-by: Binoy Jayan
> ---
> This patch depends on the following patch:
> rtl87
On Wednesday, June 1, 2016 10:52:03 AM CEST Binoy Jayan wrote:
> The semaphore 'cmd_queue_sema' is used as completion,
> so convert it to a struct completion type.
>
> Signed-off-by: Binoy Jayan
> ---
The conversion looks correct, and I see that you have
driverdev-devel@linuxdriverproject.org wi
56 matches
Mail list logo
