Re: [PATCH 1/1] AX.25: Close socket connection on session completion

2016-06-15 Thread Greg KH
On Wed, Jun 15, 2016 at 12:20:27PM -0700, Basil Gunn wrote: > A socket connection made in ax.25 is not closed when session is > completed. The heartbeat timer is stopped prematurely and this is > where the socket gets closed. Allow heatbeat timer to run to close > socket. Symptom occurs in

Re: [PATCH 2/5] staging/lustre: Replace sun.com GPLv2 URL with gnu.org one

2016-06-15 Thread Greg KH
On Wed, Jun 15, 2016 at 03:04:33PM +0200, Xose Vazquez Perez wrote: > On 06/15/2016 05:15 AM, Oleg Drokin wrote: > > > On Jun 14, 2016, at 11:11 PM, Xose Vazquez Perez wrote: > > >> And "http://www.gnu.org/licenses/; is preferred > > > > Is it? I don't mind it either way, but since we do "GPLv2

Re: [PATCH] android: binder: fix dangling pointer comparison

2016-06-15 Thread Jann Horn
On Thu, Jun 16, 2016 at 12:31 AM, Arve Hjønnevåg wrote: > On Wed, Jun 15, 2016 at 3:09 PM, Jann Horn wrote: >> If /dev/binder is opened and the opener process then e.g. calls execve, >> proc->vma_vm_mm will still point to the location of the now-freed >>

Re: [PATCH] android: binder: fix dangling pointer comparison

2016-06-15 Thread Arve Hjønnevåg
On Wed, Jun 15, 2016 at 3:09 PM, Jann Horn wrote: > If /dev/binder is opened and the opener process then e.g. calls execve, > proc->vma_vm_mm will still point to the location of the now-freed > mm_struct. If the process then calls ioctl(binder_fd, ...), the dangling >

[PATCH 3/3] media: i2c/soc_camera: fix ov6650 sensor getting wrong clock

2016-06-15 Thread Janusz Krzysztofik
After changes to v4l2_clk API introduced in v4.1 by commits a37462b919 '[media] V4L: remove clock name from v4l2_clk API' and 4f528afcfb '[media] V4L: add CCF support to the v4l2_clk API', ov6650 sensor stopped responding because v4l2_clk_get(), still called with depreciated V4L2 clock name

[PATCH 2/3] staging: media: omap1: fix sensor probe not working anymore

2016-06-15 Thread Janusz Krzysztofik
After clock_start() removal from from soc_camera_probe() (commit 9aea470b39 '[media] soc-camera: switch I2C subdevice drivers to use v4l2-clk', introduced in v3.11), it occurred omap1_camera's sensor can't be probed successfully without its clock being turned on in advance. Fix that by surrounding

[PATCH 1/3] staging: media: omap1: fix null pointer dereference in omap1_cam_probe()

2016-06-15 Thread Janusz Krzysztofik
Commit 76e543382bd4 ("staging: media: omap1: Switch to devm_ioremap_resource") moved assignment of struct resource *res = platform_get_resource() several lines down. That resulted in the following error: [3.793237] Unable to handle kernel NULL pointer dereference at virtual address 0004

[PATCH 0/3] media: fixes for Amstrad Delta camera

2016-06-15 Thread Janusz Krzysztofik
Janusz Krzysztofik (3): staging: media: omap1: fix null pointer dereference in omap1_cam_probe() staging: media: omap1: fix sensor probe not working anymore media: i2c/soc_camera: fix ov6650 sensor getting wrong clock drivers/media/i2c/soc_camera/ov6650.c | 2 +-

[PATCH] staging: ks7010: honor 'const' qualifier

2016-06-15 Thread Arnd Bergmann
The recently-added ks7010 driver produces an annoying build warning: drivers/staging/ks7010/ks7010_config.c: In function 'ks_wlan_read_config_file': drivers/staging/ks7010/ks7010_config.c:263:8: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]

[PATCH] staging/rtlwifi: use s8 instead of char

2016-06-15 Thread Arnd Bergmann
Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of incorrect code that results from 'char' being unsigned here, e.g. staging/rtl8192e/rtl8192e/r8192E_phy.c:1072:36: error: comparison is always false due to limited range of data type [-Werror=type-limits]

Re: [PATCH 1/6] staging: i4l: icn: do not use return as a function

2016-06-15 Thread Luis de Bethencourt
On 11/06/16 22:10, Sudip Mukherjee wrote: > return is not a function so no need to use the parenthesis. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/i4l/icn/icn.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > All the

Re: [PATCH] staging:vt6656:card.c:Fix comment block issue

2016-06-15 Thread Luis de Bethencourt
On 11/06/16 21:08, Rithvik Patibandla wrote: > Fix "Block comments use * on subsequent lines" and "Block comments use > */ on trailing lines" warnings thrown by checkpatch.pl > > Signed-off-by: Rithvik Patibandla > --- > drivers/staging/vt6656/card.c | 3 ++- > 1 file

Re: [PATCH 0/8] Lustre: Multiple assignments removal.

2016-06-15 Thread Luis de Bethencourt
On 10/06/16 03:35, Oleg Drokin wrote: > These patches remove multiple assignments in Lustre, that makes > checkpatch (somewhat understandably) unhappy. > > Nathaniel Clark (8): > staging/lustre/osc: Fix Multiple Assignment Warnings > staging/lustre/fid: Fix Multiple Assignments >

[PATCH 1/1] AX.25: Close socket connection on session completion

2016-06-15 Thread Basil Gunn
A socket connection made in ax.25 is not closed when session is completed. The heartbeat timer is stopped prematurely and this is where the socket gets closed. Allow heatbeat timer to run to close socket. Symptom occurs in kernels >= 4.2.0 Signed-off-by: Basil Gunn --- diff

Re: [PATCH 2/5] staging/lustre: Replace sun.com GPLv2 URL with gnu.org one

2016-06-15 Thread Xose Vazquez Perez
On 06/15/2016 05:15 AM, Oleg Drokin wrote: > On Jun 14, 2016, at 11:11 PM, Xose Vazquez Perez wrote: >> And "http://www.gnu.org/licenses/; is preferred > > Is it? I don't mind it either way, but since we do "GPLv2 only", > seemed to make sense to only link to that? Shorter and less prone to