Deconstruct the kthread / message_queue logic, replacing it with
create_singlethread_workqueue() / queue_work() setup, by adding a
'struct work_struct' to 'struct host_if_msg'. The current kthread
hostIFthread() is converted to a work queue helper with the name
'host_if_work'.
Signed-off-by:
Replace the interface 'wilc_mq_send' with 'wilc_enqueue_cmd'
and remove the now unused structures 'message' and 'message_queue'.
Restructure switch statement in the work queue helper function
host_if_work and remove unwanted indentation.
Signed-off-by: Binoy Jayan
---
Hi,
Thank you Arnd for patiently reviewing this patch series multiple times and
apologies to everyone for spamming you inboxes with a patch (v3) that does
not even build. It was due to an uncommited change in my git repo before
generating the patch. It is corrected in v4.
This patchset [v4] is
Move the contents of wilc_msgqueue.c and wilc_msgqueue.h into
host_interface.c, remove 'wilc_msgqueue.c' and 'wilc_msgqueue.h'.
This is done so as to restructure the implementation of the kthread
'hostIFthread' using a work queue.
Signed-off-by: Binoy Jayan
---
Hi All,
On Sat, Jun 18, 2016 at 3:34 AM, wrote:
> From: Wei Yongjun
>
> In case of error, the function kthread_run() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
>
>
Hi All,
On Wed, Jun 22, 2016 at 10:39 PM, Luis de Bethencourt
wrote:
> The common format to check if a function returned an error pointer is to
> use PTR_ERR(). Instead of ERR_PTR() which is used to return said errors.
>
> Also, if there was an error returning -EINVAL
Hi Gustavo,
On 20 June 2016 at 16:53, Gustavo Padovan wrote:
> - - port libsync tests to kselftest
I believe the tests haven't landed yet right, so this should stay right ?
-Emil
___
devel mailing list
From: Ioana Radulescu
The layer abstracting the building of commands and extracting
responses is currently based on macros that shift and mask the command
fields and requires exposing offset/size values as macro parameters
and makes the code harder to read.
For
Move the definition of fsl_mc_device_id to its proper location in
mod_devicetable.h, and add fsl-mc bus support to devicetable-offsets.c
and file2alias.c to enable device table matching. With this patch udev
based module loading of fsl-mc drivers is supported.
Signed-off-by: Stuart Yoder
This patch series does some cleanup and further sets the stage for
additional fsl-mc device drivers.
-Patches 1-4 add missing fsl-mc support for modalias and udev-based
module loading of drivers.
-Patch 5 exports a function some drivers rely on.
-Patch 6 makes a needed helper function visible to
For an MSI domain the hwirq is an arbitrary but unique
id to identify an interrupt. Previously the hwirq was set to
the MSI index of the interrupt, but that only works if there is
one DPRC. Additional DPRCs require an expanded namespace. Use
both the ICID (which is unique per DPRC) and the MSI
add missing free of the Linux irq when tearing down interrupts
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c
some drivers (built as modules) rely on mc_get_version()
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/dpmng.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/fsl-mc/bus/dpmng.c
b/drivers/staging/fsl-mc/bus/dpmng.c
index f633fcd..a31fa9b
When unbinding a dprc from the dprc driver the cleanup of
the resource pools must happen after irq pool cleanup
is done.
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git
From: Bharat Bhushan
An mc_io represents a mapped MC portal. Previously, an mc_io was
created for the root dprc in fsl_mc_bus_probe() and for child dprcs
in dprc_probe(). But the free of that data structure happened in the
general bus remove callback. This asymmetry
Replace placeholder code in the uevent callback to properly
set the MODALIAS env variable.
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/mc-bus.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-mc/bus/mc-bus.c
-rename the struct used for fsl-mc device ids to be more
consistent with other busses
-remove the now obsolete and unused version fields
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 2 +-
drivers/staging/fsl-mc/bus/mc-allocator.c | 2 +-
make fsl_mc_is_root_dprc() global so that the dprc driver
can use it
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/mc-bus.c | 28 +---
drivers/staging/fsl-mc/include/mc.h | 2 ++
2 files changed, 15 insertions(+), 15 deletions(-)
diff
In order to support uevent based module loading implement modalias support
for the fsl-mc bus driver. Aliases are based on vendor and object/device
id and are of the form "fsl-mc:vNdN".
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/mc-bus.c | 25
From: Gustavo Padovan
remove file paths in the comments and add short description about each
file.
v2: remove file paths instead of just change them.
Signed-off-by: Gustavo Padovan
---
drivers/staging/android/sw_sync.c| 2
Go to error_ret if sca3000_read_ctrl_reg() failed.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/iio/accel/sca3000_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/iio/accel/sca3000_core.c
b/drivers/staging/iio/accel/sca3000_core.c
sca3000_read_ctrl_reg() returns a negative number on failure, check for
this instead of zero.
Signed-off-by: Luis de Bethencourt
Reviewed-by: Andrew F. Davis
Reviewed-by: Jonathan Cameron
---
drivers/staging/iio/accel/sca3000_core.c | 2
The value assigned to ret will be overwritten before it could be read in a
future iteration of the loop. Removing the unnecessary assignment.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/gdm724x/gdm_usb.c | 8
1 file changed, 4 insertions(+), 4
Hi Niklas,
Thank you for the patch.
On Wednesday 22 Jun 2016 02:19:24 Niklas Söderlund wrote:
> This is done in preparation to move s_stream from v4l2_subdev_video_ops
> to v4l2_subdev_pad_ops. Only wpf implements s_stream so it will no
> longer be possible to share the v4l2_subdev_pad_ops once
From: Ben Evans
These #if 0 blocks have been in place for years. Assume
they are not used and remove them
Signed-off-by: Ben Evans
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8058
Reviewed-on: http://review.whamcloud.com/20414
Reviewed-by: Andreas
The common format to check if a function returned an error pointer is to
use PTR_ERR(). Instead of ERR_PTR() which is used to return said errors.
Also, if there was an error returning -EINVAL instead of -1 is more
appropriate.
Signed-off-by: Luis de Bethencourt
---
A change to the usb gadget core allowed certain API functions to be
part of a loadable module, which breaks having emxx_udc built-in:
drivers/staging/built-in.o: In function `nbu2ss_drv_probe':
(.text+0x2428): undefined reference to `usb_ep_set_maxpacket_limit'
The original patch already fixed
Hi,
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.7-rc4 next-20160622]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Binoy-Jayan/staging-wilc1000-Replace
Replace the interface 'wilc_mq_send' with 'wilc_enqueue_cmd'
and remove the now unused structures 'message' and 'message_queue'.
Restructure switch statement in the work queue helper function
host_if_work and remove unwanted indentation.
Signed-off-by: Binoy Jayan
---
Move the contents of wilc_msgqueue.c and wilc_msgqueue.h into
host_interface.c, remove 'wilc_msgqueue.c' and 'wilc_msgqueue.h'.
This is done so as to restructure the implementation of the kthread
'hostIFthread' using a work queue.
Signed-off-by: Binoy Jayan
---
Deconstruct the kthread / message_queue logic, replacing it with
create_singlethread_workqueue() / queue_work() setup, by adding a
'struct work_struct' to 'struct host_if_msg'. The current kthread
hostIFthread() is converted to a work queue helper with the name
'host_if_work'.
Signed-off-by:
This patchset [v3] is part of the second patch series for 'wilc1000'.
The original patch series consisted 7 patches of which only the first 5
are good. The patch 6 and 7 are being worked on in this series
in a different way.
This patch series removes the semaphore 'sem' in 'wilc1000' and also
32 matches
Mail list logo