Re: [PATCH 32/32] Staging/octeon-usb/octeon-hcd.c: Compression of lines for immediate return This patch compresses two lines in to a single line in file octeon-hcd.c

2016-07-23 Thread Markus Böhme
Nadim, several points stand out in your patch: On 07/22/2016 12:17 PM, Nadim almas wrote: > if immediate return statement is found. It also removes variable > bytes_written as > it is no longer needed. > > It is done using script Coccinelle. And coccinelle uses following > semantic > patch for t

Re: [PATCH 32/32] Staging/octeon-usb/octeon-hcd.c: Compression of lines for immediate return This patch compresses two lines in to a single line in file octeon-hcd.c

2016-07-23 Thread Julia Lawall
On Sat, 23 Jul 2016, Markus Böhme wrote: > Nadim, > > several points stand out in your patch: > > On 07/22/2016 12:17 PM, Nadim almas wrote: > > if immediate return statement is found. It also removes variable > > bytes_written as > > it is no longer needed. > > > > It is done using script Cocci

[PATCH] staging: sm750fb: Fix block comment style

2016-07-23 Thread Edward Lipinsky
This patch fixes the checkpatch.pl warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Edward Lipinsky --- drivers/staging/sm750fb/ddk750_dvi.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/stagi

Re: [PATCH 12/15] staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<

2016-07-23 Thread Joe Perches
On Sat, 2016-07-23 at 02:37 -0400, Oleg Drokin wrote: > From: Emoly Liu unrelated trivial notes: > diff --git a/drivers/staging/lustre/lustre/obdecho/echo_internal.h > b/drivers/staging/lustre/lustre/obdecho/echo_internal.h [] > @@ -33,9 +33,9 @@ >   >  /* The persistent object (i.e. actually s

Re: [PATCH 12/15] staging/lustre: Add spaces preferred around that '{+, -, *, /, |, <<

2016-07-23 Thread Oleg Drokin
On Jul 23, 2016, at 1:31 PM, Joe Perches wrote: > On Sat, 2016-07-23 at 02:37 -0400, Oleg Drokin wrote: >> From: Emoly Liu > > unrelated trivial notes: > >> diff --git a/drivers/staging/lustre/lustre/obdecho/echo_internal.h >> b/drivers/staging/lustre/lustre/obdecho/echo_internal.h > [] >> @@