Re: [PATCH] android: binder: Remove deprecated create_singlethread_workqueue

On Sat, Aug 13, 2016 at 10:16:24PM +0530, Bhaktipriya Shridhar wrote: > The workqueue is being used to run deferred work for the android binder. > > The "binder_deferred_workqueue" queues only a single work item and hence > does not require ordering. Also, this workqueue is not being used on a >

Re: Building a subdirectory ignores parent subdir-ccflags

On Tue, 2016-08-16 at 00:07 +0200, Michal Marek wrote: Hi Michal. > > Perhaps making a specific directory should also walk up > > any parent directory Makefiles looking for subdir flags. > > > > Is that unreasonable?  Any suggestions? > I suggest to do make drivers/staging/lustre/. If building

RE: [PATCH v2 RESEND 2/4] Drivers: hv: balloon: account for gaps in hot add regions

> @@ -676,35 +686,63 @@ static void hv_mem_hot_add(unsigned long start, > unsigned long size, > > static void hv_online_page(struct page *pg) { > - struct list_head *cur; > struct hv_hotadd_state *has; > + struct hv_hotadd_gap *gap; > unsigned long cur_start_pgp; >

Re: Building a subdirectory ignores parent subdir-ccflags

Dne 15.8.2016 v 23:29 Joe Perches napsal(a): > On Mon, 2016-08-15 at 14:14 -0700, Joe Perches wrote: >> On Mon, 2016-08-15 at 23:04 +0200, Greg Kroah-Hartman wrote: >>> On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote: Start to rationalize include paths in source code files. >> []

Re: [PATCH 19/58] staging: lustre: llite: add md_op_data parameter to ll_get_dir_page

> > From: wang di > > > > Pass in struct md_op_data for ll_get_dir_page function. > > > > Signed-off-by: wang di > > Reviewed-on: http://review.whamcloud.com/7043 > > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531 > > Reviewed-by: John L.

Re: [PATCH 1/2] staging: lustre: Add include path to Makefile

On Mon, 2016-08-15 at 23:04 +0200, Greg Kroah-Hartman wrote: > On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote: > > Start to rationalize include paths in source code files. [] > > diff --git a/drivers/staging/lustre/Makefile > > b/drivers/staging/lustre/Makefile [] > > @@ -1,2 +1,5 @@

Building a subdirectory ignores parent subdir-ccflags (was: Re: [PATCH 1/2] staging: lustre: Add include path to Makefile)

On Mon, 2016-08-15 at 14:14 -0700, Joe Perches wrote: > On Mon, 2016-08-15 at 23:04 +0200, Greg Kroah-Hartman wrote: > > On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote: > > > Start to rationalize include paths in source code files. > [] > > > diff --git

Re: [lustre-devel] [PATCH 1/2] staging: lustre: Add include path to Makefile

> On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote: > > Start to rationalize include paths in source code files. > > > > Signed-off-by: Joe Perches > > --- > > drivers/staging/lustre/Makefile | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git

Re: [PATCH 1/2] staging: lustre: Add include path to Makefile

On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote: > Start to rationalize include paths in source code files. > > Signed-off-by: Joe Perches > --- > drivers/staging/lustre/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

[PATCH 0/2] staging: lustre: #include neatening

Make it a bit easier to grep and help a future move out of staging. Joe Perches (2): staging: lustre: Add include path to Makefile staging: lustre: Remove .. paths from '#include "' uses drivers/staging/lustre/Makefile | 3 +++

Re: [PATCH net v2 0/5] hv_netvsc: fixes for VF removal path

From: Vitaly Kuznetsov Date: Mon, 15 Aug 2016 17:48:38 +0200 > Kernel crash is reported after VF is removed and detached from netvsc > device. Turns out we have multiple different (but related) issues on the > VF removal path which I'm trying to address with PATCHes 2-5 of

[PATCH 2/2] staging: lustre: Remove .. paths from '#include "' uses

Make the include paths a bit easier to find and more compatible to a future move out of the staging tree. Signed-off-by: Joe Perches --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h | 6 +++--- drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 8

[PATCH 1/2] staging: lustre: Add include path to Makefile

Start to rationalize include paths in source code files. Signed-off-by: Joe Perches --- drivers/staging/lustre/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/lustre/Makefile b/drivers/staging/lustre/Makefile index 95ffe33..9d00237 100644 ---

Re: [PATCH 2/9] staging: most: hdm-usb: fix race between enqueue and most_stop_enqueue

On Mon, Jul 18, 2016 at 05:25:28PM +0200, Christian Gromm wrote: > The "broken in pipe" handler of the USB-HDM calls most_stop_enqueue() to > stop the MBO traffic before returning all MBOs back to the Mostcore. As > the enqueue() call from the Mostcore may run in parallel with the >

[PATCH] hv: make mmio resource local

From: Stephen Hemminger This fixes a sparse warning because hyperv_mmio resources are only used in this one file and should be static. Signed-off-by: Stephen Hemminger --- a/drivers/hv/vmbus_drv.c2016-08-05 15:19:55.0 -0700

Re: [PATCH 01/15 RESEND] staging: dgnc: remove redundant NULL checks in

On Wed, Jul 06, 2016 at 03:11:13PM +0900, Daeseok Youn wrote: > The dgnc_block_til_ready() is only used in dgnc_tty_open(). > The unit data(struct un_t) was stored into tty->driver_data in > dgnc_tty_open(). > And also tty and un were tested about NULL so these variables doesn't > need to check

Re: [PATCH 07/15] lustre: ->kss_scratch... are unused now

On Sat, Jul 23, 2016 at 02:37:04AM -0400, Oleg Drokin wrote: > From: Al Viro > > Signed-off-by: Al Viro > --- > drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 4 > 1 file changed, 4 deletions(-) > > diff --git

Re: [PATCH] hv: mark hv_driver read only after init

On Mon, 15 Aug 2016 09:11:38 -0700 Kees Cook wrote: > On Mon, Aug 15, 2016 at 8:41 AM, Stephen Hemminger > wrote: > > On Fri, 12 Aug 2016 20:05:27 -0700 > > Kees Cook wrote: > > > >> On Fri, Aug 12, 2016 at 4:35 PM,

Re: [PATCH 19/58] staging: lustre: llite: add md_op_data parameter to ll_get_dir_page

On Thu, Jul 21, 2016 at 10:44:12PM -0400, James Simmons wrote: > From: wang di > > Pass in struct md_op_data for ll_get_dir_page function. > > Signed-off-by: wang di > Reviewed-on: http://review.whamcloud.com/7043 > Intel-bug-id:

Re: [PATCH] hv: mark hv_driver read only after init

On Mon, Aug 15, 2016 at 8:41 AM, Stephen Hemminger wrote: > On Fri, 12 Aug 2016 20:05:27 -0700 > Kees Cook wrote: > >> On Fri, Aug 12, 2016 at 4:35 PM, Stephen Hemminger >> wrote: >> > >> > For hardening, the driver

Re: [PATCH 0/2] Drivers: hv: vmbus: make bus ids in sysfs persistent

KY Srinivasan writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Thursday, August 11, 2016 2:17 AM >> To: KY Srinivasan >> Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; Haiyang Zhang >>

RE: [PATCH net v2 5/5] hv_netvsc: fix bonding devices check in netvsc_netdev_event()

> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Monday, August 15, 2016 11:49 AM > To: net...@vger.kernel.org > Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; Haiyang > Zhang ; KY Srinivasan ;

[PATCH] staging: wilc1000: correctly check if associatedsta has not been found

From: Colin Ian King The current check for associatedsta being set to -1 to indicate it has not been found is not working because associatedsta is initialized to zero and will never be -1. Fix this by initializing it to ~0 and checking for ~0 instead. Signed-off-by:

[PATCH net v2 5/5] hv_netvsc: fix bonding devices check in netvsc_netdev_event()

Bonding driver sets IFF_BONDING on both master (the bonding device) and slave (the real NIC) devices and in netvsc_netdev_event() we want to skip master devices only. Currently, there is an uncertainty when a slave interface is removed: if bonding module comes first in netdev_chain it clears

[PATCH net v2 0/5] hv_netvsc: fixes for VF removal path

Kernel crash is reported after VF is removed and detached from netvsc device. Turns out we have multiple different (but related) issues on the VF removal path which I'm trying to address with PATCHes 2-5 of this series. PATCH1 is required to support the change. Changes since v1: - Re-arrange

[PATCH net v2 4/5] hv_netvsc: protect module refcount by checking net_device_ctx->vf_netdev

We're not guaranteed to see NETDEV_REGISTER/NETDEV_UNREGISTER notifications only once per VF but we increase/decrease module refcount unconditionally. Check vf_netdev to make sure we don't take/release it twice. We presume that only one VF per netvsc device may exist. Signed-off-by: Vitaly

[PATCH net v2 3/5] hv_netvsc: reset vf_inject on VF removal

We reset vf_inject on VF going down (netvsc_vf_down()) but we don't on VF removal (netvsc_unregister_vf()) so vf_inject stays 'true' while vf_netdev is already NULL and we're trying to inject packets into NULL net device in netvsc_recv_callback() causing kernel to crash. Signed-off-by: Vitaly

[PATCH net v2 1/5] hv_netvsc: don't lose VF information

struct netvsc_device is not suitable for storing VF information as this structure is being destroyed on MTU change / set channel operation (see rndis_filter_device_remove()). Move all VF related stuff to struct net_device_context which is persistent. Signed-off-by: Vitaly Kuznetsov

[PATCH net v2 2/5] hv_netvsc: avoid deadlocks between rtnl lock and vf_use_cnt wait

Here is a deadlock scenario: - netvsc_vf_up() schedules netvsc_notify_peers() work and quits. - netvsc_vf_down() runs before netvsc_notify_peers() gets executed. As it is being executed from netdev notifier chain we hold rtnl lock when we get here. - we enter while

Re: [PATCH] hv: mark hv_driver read only after init

On Fri, 12 Aug 2016 20:05:27 -0700 Kees Cook wrote: > On Fri, Aug 12, 2016 at 4:35 PM, Stephen Hemminger > wrote: > > > > For hardening, the driver structure containing function pointers can > > be marked read only after initial registration is

Re: [Linaro-mm-sig] [RESEND][PATCH 0/5] Ion cleanup

Hi Laura, On 14 August 2016 at 14:17, Benjamin Gaignard wrote: > This series of patches look good for me, thanks for the clean up > > Reviewed-by: Benjamin Gaignard > > 2016-08-08 18:52 GMT+02:00 Laura Abbott : >> I

Re: [PATCH v2] android: binder: fix dangling pointer comparison

On Thu, Jun 16, 2016 at 12:45:33AM +0200, Jann Horn wrote: > If /dev/binder is opened and the opener process then e.g. calls execve, > proc->vma_vm_mm will still point to the location of the now-freed > mm_struct. If the process then calls ioctl(binder_fd, ...), the dangling > proc->vma_vm_mm

Re: [PATCH] Staging: android: ion_cma_heap: Fixed a extra blank line coding style issue

On Mon, Jun 06, 2016 at 08:34:36AM -0700, Akshay Shipurkar wrote: > Fixed a coding style issue. What coding style issue was fixed here? be specific please. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] android: binder: fix dangling pointer comparison

On Sat, Jun 18, 2016 at 02:12:32PM +0200, Jann Horn wrote: > On Sat, Jun 18, 2016 at 11:19 AM, ZhaoJunmin Zhao(Junmin) > wrote: > > 在 2016/6/16 6:39, Jann Horn 写道: > >> On Thu, Jun 16, 2016 at 12:31 AM, Arve Hjønnevåg wrote: > >>> On Wed, Jun 15, 2016 at

Re: [PATCH] staging: android: sw_sync: checkpatch fixes

On Wed, Aug 10, 2016 at 09:16:12PM +0200, Johanna Abrahamsson wrote: > This patch fixes the checkpatch.pl check: > > CHECK: Alignment should match open parenthesis > > Signed-off-by: Johanna Abrahamsson > --- > drivers/staging/android/sw_sync.c | 6 +++--- This file has now

Re: [PATCH 1/1] Remove checkpatch.pl cleanups todo

On Sat, Jul 30, 2016 at 03:13:38PM +0200, Matthias Beyer wrote: > Signed-off-by: Matthias Beyer I can't take patches without any changelog comments in them :( Please put the info you put in the 0/1 email in here. And for a single patch, you never need a 0/1 email.

Re: [PATCH] Staging:android: fix alignment match open paranthesis

On Mon, Aug 01, 2016 at 08:50:27PM +0530, ksourav wrote: > This is a patch to fix alignment should match open paranthesis > warning given by checkpatch.pl in files sw_sync.c and sync_debug.c > > Signed-off-by: ksourav I need a "full" name for a signed-off-by line, please.

Re: [PATCH] Staging: android: ion: fixed a kzalloc coding style issue.

On Thu, May 26, 2016 at 01:31:14PM +0530, Shubham Bansal wrote: > Fixed a coding style issue. Issue reported by checkpatch.pl. What coding style issue was fixed? Be specific please. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] Staging: android: modify memory allocation style in ion_cma_heap.c

On Sun, May 22, 2016 at 08:37:02PM +0200, Ben Marsh wrote: > Modify memory allocation style in ion_cma_heap.c in order to silence a > checkpatch.pl warning What warning? Be specific please. thanks, greg k-h ___ devel mailing list

Re: [PATCH] Staging: android: fix coding style warning

On Sun, May 22, 2016 at 10:52:15PM -0500, Jaime Arrocha wrote: > From: Jaime Arrocha > > Fixed checkpatch.pl warning about 'line over 80 characters'. > > Signed-off-by: Jaime Arrocha > --- > drivers/staging/android/ion/ion.c | 6 -- > 1 file

Re: [PATCH] Staging: android: ion: fixed a kzalloc coding style issue.

On Sun, May 15, 2016 at 06:56:05AM +0530, Shubham Bansal wrote: > Fixed a coding style issue. Issue reported by checkpatch.pl. > > Signed-off-by: Shubham Bansal > --- > drivers/staging/android/ion/ion.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Doesn't

[PATCH] staging: ks7010: don't print skb->dev->name if skb is null

From: Colin Ian King A null pointer dereference will occur when skb is null and skb->dev->name is printed. Replace the skb->dev->name with plain text "ks_wlan" to fix this. Signed-off-by: Colin Ian King ---

Re: [RESEND][PATCH 0/5] Ion cleanup

On Mon, Aug 08, 2016 at 09:52:53AM -0700, Laura Abbott wrote: > I never saw any feedback or action on these patches so this is a resend. > Probably hit the window when everyone was busy/traveling. Yes, sorry about that, the old ones are still in my queue, but I'll take these now! greg k-h

[PATCH] staging: rts5208: Change data type to unsigned int.

This patch fixes a minor checkpatch warning: "WARNING: Prefer 'unsigned int' to bare use of 'unsigned'" Signed-off-by: Louie Lu --- drivers/staging/rts5208/rtsx_scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [RFC 2/2] netvsc: use RCU for VF net device reference

Stephen Hemminger writes: > Rather than keeping a pointer, a flag, and reference count, use RCU and > existing > device reference count to protect the synthetic to VF relationship. Thanks! I like the idea. Some nitpicks below ... > > One other change is that

Re: [PATCH] Staging: rtl8723au: os_intfs: fixed case statement is variable issue

On Sun, 2016-08-14 at 05:23 -0700, Joe Perches wrote: >  > Maybe this test should be sparse version checked after > sparse is updated. *If* sparse ever gets updated :) I don't think it's been updated much lately. That said, I'm not even sure how, and what version, etc. so obviously that'd have to