Re: [PATCH] staging: i4l: icn: fix memdup_user.cocci warnings

2016-08-22 Thread Sudip Mukherjee
On Mon, Aug 22, 2016 at 09:19:36PM -0400, Greg Kroah-Hartman wrote: > On Tue, Aug 23, 2016 at 08:36:58AM +0800, kbuild test robot wrote: > > drivers/staging/i4l/icn/icn.c:813:11-18: WARNING opportunity for memdup_user > > > > Use memdup_user rather than duplicating its implementation > > This is

Re: [PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings.

2016-08-22 Thread Sudip Mukherjee
On Tue, Aug 23, 2016 at 08:19:46AM +0800, Ming-Chia Chung wrote: > On Mon, Aug 22, 2016 at 10:51:27PM +0530, Sudip Mukherjee wrote: > > On Tue, Aug 23, 2016 at 12:54:17AM +0800, MingChia Chung wrote: > > > This patch fixes a minor checkpatch warnings: > > > > > > "WARNING: Block comments use a

[PATCH 5/5] PCI: hv: hv_pci_generic_compl(): handle the error case

2016-08-22 Thread Dexuan Cui
'completetion_status' is used in some places, e.g., hv_pci_protocol_negotiation(), so we should make sure it's initialized in error case too, though the error is unlikely here. I didn't get a real issue. Cc: Jake Oshins Cc: K. Y. Srinivasan Cc: Haiyang Zhang Cc: Vitaly Kuznetsov Signed-off-b

[PATCH 4/5] PCI: hv: hv_compose_msi_msg: handle the 'ret' value

2016-08-22 Thread Dexuan Cui
I happened to find this when reading the code. I didn't get a real issue however. Cc: Jake Oshins Cc: K. Y. Srinivasan Cc: Haiyang Zhang Cc: Vitaly Kuznetsov Signed-off-by: Dexuan Cui --- drivers/pci/host/pci-hyperv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a

[PATCH 3/5] PCI: hv: remove the unused 'wrk' in struct hv_pcibus_device

2016-08-22 Thread Dexuan Cui
The member is not used. Cc: Jake Oshins Cc: K. Y. Srinivasan Cc: Haiyang Zhang Cc: Vitaly Kuznetsov Signed-off-by: Dexuan Cui --- drivers/pci/host/pci-hyperv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c index cdbadea5..ae

[PATCH 2/5] PCI: hv: use pci_function_description[0] in struct definitions

2016-08-22 Thread Dexuan Cui
The 2 structs can use a zero-length array here, because dynamic memory of the correct size is allocated in hv_pci_devices_present() and we don't need this extra element. No functional change. Cc: Jake Oshins Cc: K. Y. Srinivasan Cc: Haiyang Zhang Cc: Vitaly Kuznetsov Signed-off-by: Dexuan Cu

[PATCH 1/5] PCI: hv: use zero-length array in struct pci_packet

2016-08-22 Thread Dexuan Cui
And, rename struct pci_message's field "message_type" to "type. This makes the code more readable. No functionality change. Cc: Jake Oshins Cc: K. Y. Srinivasan Cc: Haiyang Zhang Cc: Vitaly Kuznetsov Signed-off-by: Dexuan Cui --- drivers/pci/host/pci-hyperv.c | 42

[PATCH 0/5] PCI: hv: some minor bug fixes and cleanups

2016-08-22 Thread Dexuan Cui
1. use zero-length array to make the code more readable. 2. remove an unused struct member. 3. small error handling improvement to some error cases. Dexuan Cui (5): PCI: hv: use zero-length message in struct pci_packet PCI: hv: use pci_function_description[0] in struct definitions PCI: hv:

RE: [PATCH 2/2] hv_pci: make hv_irq functions static

2016-08-22 Thread Dexuan Cui
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf > Of sthem...@exchange.microsoft.com > Sent: Tuesday, August 23, 2016 1:33 > To: KY Srinivasan ; Haiyang Zhang > > Cc: de...@linuxdriverproject.org; Stephen Hemminger > > Subject: [PATCH 2/2] hv_pci: make hv_irq funct

RE: [PATCH 0/2] hyperv: minor cleanups

2016-08-22 Thread Dexuan Cui
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf > Of sthem...@exchange.microsoft.com > Sent: Tuesday, August 23, 2016 1:33 > To: KY Srinivasan ; Haiyang Zhang > > Cc: de...@linuxdriverproject.org; Stephen Hemminger > > Subject: [PATCH 0/2] hyperv: minor cleanups >

RE: [PATCH 1/2] hyperv: make mmio resource local

2016-08-22 Thread Dexuan Cui
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf > Of sthem...@exchange.microsoft.com > Sent: Tuesday, August 23, 2016 1:33 > To: KY Srinivasan ; Haiyang Zhang > > Cc: de...@linuxdriverproject.org; Stephen Hemminger > > Subject: [PATCH 1/2] hyperv: make mmio resourc

[PATCH] staging: iio: accel: sca3000: remove extra space

2016-08-22 Thread Clifton Barnes
fix checkpatch.pl warning about 'Statements should start on a tabstop' Signed-off-by: Clifton Barnes --- drivers/staging/iio/accel/sca3000_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core

Re: [PATCH] staging: i4l: icn: fix memdup_user.cocci warnings

2016-08-22 Thread Greg Kroah-Hartman
On Tue, Aug 23, 2016 at 08:36:58AM +0800, kbuild test robot wrote: > drivers/staging/i4l/icn/icn.c:813:11-18: WARNING opportunity for memdup_user > > Use memdup_user rather than duplicating its implementation > This is a little bit restricted to reduce false positives > > Generated by: scripts/

[staging:staging-testing 251/347] drivers/staging/i4l/icn/icn.c:813:11-18: WARNING opportunity for memdup_user

2016-08-22 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: f5a9a15f8fd4168e415e94f5dce367f3cef08e03 commit: ee05e5f7113ea0b0db7eff7011a534c92fec2648 [251/347] staging: i4l: icn: donot assign in if statement coccinelle warnings: (new ones prefixed by >>)

[PATCH] staging: i4l: icn: fix memdup_user.cocci warnings

2016-08-22 Thread kbuild test robot
drivers/staging/i4l/icn/icn.c:813:11-18: WARNING opportunity for memdup_user Use memdup_user rather than duplicating its implementation This is a little bit restricted to reduce false positives Generated by: scripts/coccinelle/api/memdup_user.cocci CC: Sudip Mukherjee Signed-off-by: Fengguang

KЛИЕHTCKИЕ БАЗЫ MАЙЛ:kimmideze-5...@monmail.fr.nf CKАЙП: prodawez389 Для 6ыcmрoй мАccoвoй прoqАжu ВАшuх moвАрoв u уcлуr! Пoqрo6нocmu узнАйme ceйчАc!

2016-08-22 Thread de...@driverdev.osuosl.org
Сo6ерeм qля Ваc по инmeрнет базу qанныx пoтeнциальных клиентов gля Вaшeго Бизнecа! B базe бygym всe koнmaктные gaнные нeо6xодuмые gля мacсoвoй пpoдажи Bашuх товарoв и уcлуr. Пo Вaшему зanросу пpuшлем примeр и nодрo6нyю инфoрмацию. Если uнmeресно зaпpocuтe подрoбноcmи сeйчac МАЙЛ: kimmideze-5...@

Re: [PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings.

2016-08-22 Thread Ming-Chia Chung
On Mon, Aug 22, 2016 at 10:51:27PM +0530, Sudip Mukherjee wrote: > On Tue, Aug 23, 2016 at 12:54:17AM +0800, MingChia Chung wrote: > > This patch fixes a minor checkpatch warnings: > > > > "WARNING: Block comments use a trailing */ on a separate line" > > > > Signed-off-by: Ming-Chia Chung

[RFC PATCH v1 23/28] KVM: SVM: add SEV launch update command

2016-08-22 Thread Brijesh Singh
The command is used for encrypting guest memory region. For more information see [1], section 6.2 [1] http://support.amd.com/TechDocs/55766_SEV-KM%20API_Spec.pdf Signed-off-by: Brijesh Singh --- arch/x86/kvm/svm.c | 126 1 file changed, 126

[RFC PATCH v1 14/28] x86: Don't set the SME MSR bit when SEV is active

2016-08-22 Thread Brijesh Singh
From: Tom Lendacky When SEV is active the virtual machine cannot set the MSR for SME, so don't set the trampoline flag for SME. Signed-off-by: Tom Lendacky --- arch/x86/realmode/init.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/realmode/init.c b/arch/x86/re

[RFC PATCH v1 20/28] KVM: SVM: prepare for SEV guest management API support

2016-08-22 Thread Brijesh Singh
The patch adds initial support required for Secure Encrypted Virtualization (SEV) guest management API's. ASID management: - Reserve asid range for SEV guest, SEV asid range is obtained through CPUID Fn8000_001f[ECX]. A non-SEV guest can use any asid outside the SEV asid range. - SEV guest

[RFC PATCH v1 19/28] KVM: SVM: prepare to reserve asid for SEV guest

2016-08-22 Thread Brijesh Singh
In current implementation, asid allocation starts from 1, this patch adds a min_asid variable in svm_vcpu structure to allow starting asid from something other than 1. Signed-off-by: Brijesh Singh --- arch/x86/kvm/svm.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ar

[RFC PATCH v1 11/28] x86: Don't decrypt trampoline area if SEV is active

2016-08-22 Thread Brijesh Singh
From: Tom Lendacky When Secure Encrypted Virtualization is active instruction fetches are always interpreted as being from encrypted memory so the trampoline area must remain encrypted when SEV is active. Signed-off-by: Tom Lendacky --- arch/x86/realmode/init.c |9 ++--- 1 file changed

[RFC PATCH v1 10/28] x86: Change early_ioremap to early_memremap for BOOT data

2016-08-22 Thread Brijesh Singh
From: Tom Lendacky Signed-off-by: Tom Lendacky --- arch/x86/kernel/acpi/boot.c |4 ++-- arch/x86/kernel/mpparse.c | 10 +- drivers/sfi/sfi_core.c |6 +++--- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/ac

[RFC PATCH v1 13/28] iommu/amd: AMD IOMMU support for SEV

2016-08-22 Thread Brijesh Singh
From: Tom Lendacky DMA must be performed to memory that is not mapped encrypted when running with SEV active. So if SEV is active, do not return the encryption mask to the IOMMU. Signed-off-by: Tom Lendacky --- arch/x86/mm/mem_encrypt.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[RFC PATCH v1 06/28] KVM: SVM: Add SEV feature definitions to KVM

2016-08-22 Thread Brijesh Singh
From: Tom Lendacky Define a new KVM cpu feature for Secure Encrypted Virtualization (SEV). The kernel will check for the presence of this feature to determine if it is running with SEV active. Define the SEV enable bit for the VMCB control structure. The hypervisor will use this bit to enable SE

[RFC PATCH v1 01/28] kvm: svm: Add support for additional SVM NPF error codes

2016-08-22 Thread Brijesh Singh
From: Tom Lendacky AMD hardware adds two additional bits to aid in nested page fault handling. Bit 32 - NPF occurred while translating the guest's final physical address Bit 33 - NPF occurred while translating the guest page tables The guest page tables fault indicator can be used as an aid for

[RFC PATCH v1 08/28] Access BOOT related data encrypted with SEV active

2016-08-22 Thread Brijesh Singh
From: Tom Lendacky When Secure Encrypted Virtualization (SEV) is active, BOOT data (such as EFI related data) is encrypted and needs to be access as such. Update the architecture override in early_memremap to keep the encryption attribute when mapping this data. Signed-off-by: Tom Lendacky ---

[RFC PATCH v1 12/28] x86: DMA support for SEV memory encryption

2016-08-22 Thread Brijesh Singh
From: Tom Lendacky DMA access to memory mapped as encrypted while SEV is active can not be encrypted during device write or decrypted during device read. In order for DMA to properly work when SEV is active, the swiotlb bounce buffers must be used. Signed-off-by: Tom Lendacky --- arch/x86/mm/m

[RFC PATCH v1 04/28] x86: Secure Encrypted Virtualization (SEV) support

2016-08-22 Thread Brijesh Singh
From: Tom Lendacky Provide support for Secure Encyrpted Virtualization (SEV). This initial support defines the SEV active flag in order for the kernel to determine if it is running with SEV active or not. Signed-off-by: Tom Lendacky --- arch/x86/include/asm/mem_encrypt.h |3 +++ arch/x86/k

[RFC PATCH v1 05/28] KVM: SVM: prepare for new bit definition in nested_ctl

2016-08-22 Thread Brijesh Singh
From: Tom Lendacky Currently the nested_ctl variable in the vmcb_control_area structure is used to indicate nested paging support. The nested paging support field is actually defined as bit 0 of the this field. In order to support a new feature flag the usage of the nested_ctl and nested paging s

[RFC PATCH v1 26/28] KVM: SVM: add KVM_SEV_DEBUG_DECRYPT command

2016-08-22 Thread Brijesh Singh
The command decrypts a page of guest memory for debugging purposes. For more information see [1], section 7.1 [1] http://support.amd.com/TechDocs/55766_SEV-KM%20API_Spec.pdf Signed-off-by: Brijesh Singh --- arch/x86/kvm/svm.c | 83 1 file

[RFC PATCH v1 27/28] KVM: SVM: add KVM_SEV_DEBUG_ENCRYPT command

2016-08-22 Thread Brijesh Singh
The command encrypts a region of guest memory for debugging purposes. For more information see [1], section 7.2 [1] http://support.amd.com/TechDocs/55766_SEV-KM%20API_Spec.pdf Signed-off-by: Brijesh Singh --- arch/x86/kvm/svm.c | 100 1 fil

[RFC PATCH v1 16/28] x86: Add support to determine if running with SEV enabled

2016-08-22 Thread Brijesh Singh
From: Tom Lendacky Early in the boot process, add a check to determine if the kernel is running with Secure Encrypted Virtualization (SEV) enabled. If active, the kernel will perform steps necessary to insure the proper kernel initialization process is performed. Signed-off-by: Tom Lendacky ---

[RFC PATCH v1 22/28] KVM: SVM: add SEV launch start command

2016-08-22 Thread Brijesh Singh
The command initate the process to launch this guest into SEV-enabled mode. For more information on command structure see [1], section 6.1 [1] http://support.amd.com/TechDocs/55766_SEV-KM%20API_Spec.pdf Signed-off-by: Brijesh Singh --- arch/x86/kvm/svm.c | 212

[RFC PATCH v1 18/28] crypto: add AMD Platform Security Processor driver

2016-08-22 Thread Brijesh Singh
The driver to communicate with Secure Encrypted Virtualization (SEV) firmware running within the AMD secure processor providing a secure key management interface for SEV guests. Signed-off-by: Tom Lendacky Signed-off-by: Brijesh Singh --- drivers/crypto/Kconfig | 11 + drivers/crypto/Ma

[RFC PATCH v1 21/28] KVM: introduce KVM_SEV_ISSUE_CMD ioctl

2016-08-22 Thread Brijesh Singh
The ioctl will be used by qemu to issue the Secure Encrypted Virtualization (SEV) guest commands to transition a guest into into SEV-enabled mode. a typical usage: struct kvm_sev_launch_start start; struct kvm_sev_issue_cmd data; data.cmd = KVM_SEV_LAUNCH_START; data.opaque = &start; ret = ioct

[RFC PATCH v1 17/28] KVM: SVM: Enable SEV by setting the SEV_ENABLE cpu feature

2016-08-22 Thread Brijesh Singh
From: Tom Lendacky Modify the SVM cpuid update function to indicate if Secure Encrypted Virtualization (SEV) is active by setting the SEV KVM cpu features bit if SEV is active. SEV is active if Secure Memory Encryption is active in the host and the SEV_ENABLE bit of the VMCB is set. Signed-off-

[RFC PATCH v1 15/28] x86: Unroll string I/O when SEV is active

2016-08-22 Thread Brijesh Singh
From: Tom Lendacky Secure Encrypted Virtualization (SEV) does not support string I/O, so unroll the string I/O operation into a loop operating on one element at a time. Signed-off-by: Tom Lendacky --- arch/x86/include/asm/io.h | 26 ++ 1 file changed, 22 insertions(+)

[RFC PATCH v1 09/28] x86/efi: Access EFI data as encrypted when SEV is active

2016-08-22 Thread Brijesh Singh
From: Tom Lendacky EFI data is encrypted when the kernel is run under SEV. Update the page table references to be sure the EFI memory areas are accessed encrypted. Signed-off-by: Tom Lendacky --- arch/x86/platform/efi/efi_64.c | 14 -- 1 file changed, 12 insertions(+), 2 deletion

[RFC PATCH v1 07/28] x86: Do not encrypt memory areas if SEV is enabled

2016-08-22 Thread Brijesh Singh
From: Tom Lendacky When running under SEV, some memory areas that were originally not encrypted under SME are already encrypted. In these situations do not attempt to encrypt them. Signed-off-by: Tom Lendacky --- arch/x86/kernel/head64.c |4 ++-- arch/x86/kernel/setup.c |7 --- 2

[RFC PATCH v1 03/28] kvm: svm: Use the hardware provided GPA instead of page walk

2016-08-22 Thread Brijesh Singh
From: Tom Lendacky When a guest causes a NPF which requires emulation, KVM sometimes walks the guest page tables to translate the GVA to a GPA. This is unnecessary most of the time on AMD hardware since the hardware provides the GPA in EXITINFO2. The only exception cases involve string operation

[RFC PATCH v1 00/28] x86: Secure Encrypted Virtualization (AMD)

2016-08-22 Thread Brijesh Singh
This RFC series provides support for AMD's new Secure Encrypted Virtualization (SEV) feature. This RFC is build upon Secure Memory Encryption (SME) RFC. SEV is an extension to the AMD-V architecture which supports running multiple VMs under the control of a hypervisor. When enabled, SEV hardwa

[RFC PATCH v1 02/28] kvm: svm: Add kvm_fast_pio_in support

2016-08-22 Thread Brijesh Singh
From: Tom Lendacky Update the I/O interception support to add the kvm_fast_pio_in function to speed up the in instruction similar to the out instruction. Signed-off-by: Tom Lendacky --- arch/x86/include/asm/kvm_host.h |1 + arch/x86/kvm/svm.c |5 +++-- arch/x86/kvm/x86.c

[RFC PATCH v1 00/28] x86: Secure Encrypted Virtualization (AMD)

2016-08-22 Thread Brijesh Singh
This RFC series provides support for AMD's new Secure Encrypted Virtualization (SEV) feature. This RFC is build upon Secure Memory Encryption (SME) RFC. SEV is an extension to the AMD-V architecture which supports running multiple VMs under the control of a hypervisor. When enabled, SEV hardwa

[RFC PATCH v1 28/28] KVM: SVM: add command to query SEV API version

2016-08-22 Thread Brijesh Singh
Signed-off-by: Brijesh Singh --- arch/x86/kvm/svm.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 4af195d..88b8f89 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -5779,6 +5779,25 @@ err_1: return r

[RFC PATCH v1 24/28] KVM: SVM: add SEV_LAUNCH_FINISH command

2016-08-22 Thread Brijesh Singh
The command is used for finializing the guest launch into SEV mode. For more information see [1], section 6.3 [1] http://support.amd.com/TechDocs/55766_SEV-KM%20API_Spec.pdf Signed-off-by: Brijesh Singh --- arch/x86/kvm/svm.c | 78 1 file

[RFC PATCH v1 25/28] KVM: SVM: add KVM_SEV_GUEST_STATUS command

2016-08-22 Thread Brijesh Singh
The command is used to query the SEV guest status. For more information see [1], section 6.10 [1] http://support.amd.com/TechDocs/55766_SEV-KM%20API_Spec.pdf Signed-off-by: Brijesh Singh --- arch/x86/kvm/svm.c | 41 + 1 file changed, 41 insertions(+)

Re: [PATCH 0/2] staging: vt6655: fix checkpatch warning for trailing */ on a separate line

2016-08-22 Thread Anson Jacob
On Mon, Aug 22, 2016 at 04:36:26PM -0400, Greg Kroah-Hartman wrote: > On Mon, Aug 22, 2016 at 12:54:12PM -0400, Anson Jacob wrote: > > *** BLURB HERE *** > > You forgot the blurb :) > Sorry about that. Uploaded a new patchset with blurb :) ___ devel mai

[PATCH v2 2/2] staging: vt6655: rxtx.c: Fix checkpatch warning

2016-08-22 Thread Anson Jacob
Fix checkpatch.pl warning for trailing */ on a separate line Remove '+' postfix and '-' prefix from the start and end of block comments Signed-off-by: Anson Jacob --- drivers/staging/vt6655/rxtx.c | 41 - 1 file changed, 24 insertions(+), 17 deletions(-)

[PATCH v2 1/2] staging: vt6655: rf.c: Fix checkpatch warning

2016-08-22 Thread Anson Jacob
Fix checkpatch.pl warning for trailing */ on a separate line Remove '+' postfix and '-' prefix from the start and end of block comments Signed-off-by: Anson Jacob --- drivers/staging/vt6655/rf.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/stag

[PATCH v2 0/2] staging: vt6655: fix checkpatch warning for trailing */ on a separate line

2016-08-22 Thread Anson Jacob
Fix checkpatch.pl warning for trailing */ on a separate line Remove '+' postfix and '-' prefix from the start and end of block comments Anson Jacob (2): staging: vt6655: rf.c: Fix checkpatch warning staging: vt6655: rxtx.c: Fix checkpatch warning drivers/staging/vt6655/rf.c | 19 ++

Re: [staging:staging-testing 201/347] drivers/staging/lustre/lustre/mdc/mdc_request.c:1243:32: error: 'dp' undeclared

2016-08-22 Thread Greg Kroah-Hartman
On Mon, Aug 22, 2016 at 05:48:39PM +0100, James Simmons wrote: > > > On Mon, Aug 22, 2016 at 03:15:23PM +0800, kbuild test robot wrote: > > > tree: > > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > > staging-testing > > > head: f5a9a15f8fd4168e415e94f5dce367f3cef08

Re: [PATCH 0/7] staging: lustre: last missing patches for lustre 2.6

2016-08-22 Thread Greg Kroah-Hartman
On Mon, Aug 22, 2016 at 10:55:42AM -0700, Joe Perches wrote: > On Mon, 2016-08-22 at 18:41 +0100, James Simmons wrote: > > On Fri, 2016-08-19 at 20:44 +0100, James Simmons wrote: > > Hi again James. > > > > I don't _need_ anything, but I think it'd be simpler to > > > have just 2 directories, one

Re: [PATCH 0/2] staging: vt6655: fix checkpatch warning for trailing */ on a separate line

2016-08-22 Thread Greg Kroah-Hartman
On Mon, Aug 22, 2016 at 12:54:12PM -0400, Anson Jacob wrote: > *** BLURB HERE *** You forgot the blurb :) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH -next] PCI: hv: Use list_move_tail instead of list_del/list_add_tail

2016-08-22 Thread Bjorn Helgaas
On Thu, Jul 28, 2016 at 04:16:48PM +, Wei Yongjun wrote: > Using list_move_tail() instead of list_del() + list_add_tail(). > > Signed-off-by: Wei Yongjun Applied to pci/host-hv for v4.9, thanks! > --- > drivers/pci/host/pci-hyperv.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)

[PATCH V2] rtlwifi: Fix missing country code for Great Britain

2016-08-22 Thread Larry Finger
Some RTL8821AE devices sold in Great Britain have the country code of 0x25 encoded in their EEPROM. This value is not tested in the routine that establishes the regulatory info for the chip. The fix is to set this code to have the same capabilities as the EU countries. In addition, the channels all

Re: [PATCH] rtlwifi: Fix missing country code for Great Britain

2016-08-22 Thread Larry Finger
On 08/22/2016 10:36 AM, Kalle Valo wrote: Larry Finger writes: Some RTL8821AE devices sold in Great Britain have the country code of 0x25 encoded in their EEPROM. This value is not tested in the routine that establishes the regulatory info for the chip. The fix is to set this code to have the

[PATCH] Staging: comedi: fix spelling mistake "Firmare" -> "Firmware"

2016-08-22 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in dev_dbg message. Signed-off-by: Colin Ian King --- drivers/staging/comedi/drivers/jr3_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/comedi/drivers/jr3

Re: [PATCH 0/7] staging: lustre: last missing patches for lustre 2.6

2016-08-22 Thread Joe Perches
On Mon, 2016-08-22 at 18:41 +0100, James Simmons wrote: > On Fri, 2016-08-19 at 20:44 +0100, James Simmons wrote: Hi again James. > > I don't _need_ anything, but I think it'd be simpler to > > have just 2 directories, one for lustre kernel stuff > > and another for lustre uapi stuff. > > > > Th

Re: [PATCH 0/7] staging: lustre: last missing patches for lustre 2.6

2016-08-22 Thread James Simmons
> On Fri, 2016-08-19 at 20:44 +0100, James Simmons wrote: > > > 1: I'd like to see the lustre #include files separated into > > >    only two internal/external directories akin to the > > >    include/linux and include/uapi directories used by linux. > [] > > For the first question yes it is reaso

Re: [PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings.

2016-08-22 Thread Sudip Mukherjee
On Tue, Aug 23, 2016 at 12:54:17AM +0800, MingChia Chung wrote: > This patch fixes a minor checkpatch warnings: > > "WARNING: Block comments use a trailing */ on a separate line" > > Signed-off-by: Ming-Chia Chung > --- > drivers/staging/rts5208/rtsx.c | 42 >

[PATCH] staging: vt6656: usbpipe.c: Fix checkpatch warning

2016-08-22 Thread Anson Jacob
Fix checkpatch.pl warning for line over 80 characters Signed-off-by: Anson Jacob --- drivers/staging/vt6656/usbpipe.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c index f546553..e9b6b21 100644 --- a/d

Re: [linux-next:master 1892/3082] drivers/staging/lustre/lustre/llite/xattr.c:309:24: warning: unused variable 'lli'

2016-08-22 Thread James Simmons
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > master > head: d18b09e429ad4520272dcdcd8faa01aabc171fd0 > commit: 1e1f9ff406fd5f6003a5dab2ab5a26c4c5bb8cbd [1892/3082] staging: lustre: > llite: break ll_getxattr_common into 2 functions > config: x86_64-randconfig

Re: [lustre-devel] [PATCH] staging: lustre: mdc: fix NULL pointer dereference in mdc_adjust_dirpages

2016-08-22 Thread Dilger, Andreas
On Aug 22, 2016, at 10:57, James Simmons wrote: > > The function mdc_adjust_dirpages is only called on platforms which > don't have pages 4K in size which is why kbuild only reported this > for platforms like the Alpha. The problem was a typo in ordering of > variables in the beginning of a while

Re: [PATCH 2/2] staging: android: ion: Remove valid_handle variable in ion_free_nolock

2016-08-22 Thread Laura Abbott
On 08/22/2016 03:26 AM, Johanna Abrahamsson wrote: It is not neccessary to save the value of ion_handle_validate since it is only used once. Acked-by: Laura Abbott Signed-off-by: Johanna Abrahamsson --- drivers/staging/android/ion/ion.c | 6 +- 1 file changed, 1 insertion(+), 5 deleti

Re: [PATCH 1/2] staging: android: ion: Do not BUG on handle client mismatch

2016-08-22 Thread Laura Abbott
On 08/22/2016 03:26 AM, Johanna Abrahamsson wrote: The ion_free() and ion_free_nolock() functions should not BUG on a handle client mismatch. It is not necessary to explicitly check for that mismatch when ion_handle_validate is used. The validate and BUG_ON are checking two slightly different

[PATCH] staging: lustre: mdc: fix NULL pointer dereference in mdc_adjust_dirpages

2016-08-22 Thread James Simmons
The function mdc_adjust_dirpages is only called on platforms which don't have pages 4K in size which is why kbuild only reported this for platforms like the Alpha. The problem was a typo in ordering of variables in the beginning of a while loop. We were accessing the dp pointer before it was kmappe

[PATCH 2/2] staging: vt6655: rxtx.c: Fix checkpatch warning

2016-08-22 Thread Anson Jacob
Fix checkpatch.pl warning for trailing */ on a separate line Remove '+' postfix and '-' prefix from the start and end of block comments Signed-off-by: Anson Jacob --- drivers/staging/vt6655/rxtx.c | 41 - 1 file changed, 24 insertions(+), 17 deletions(-)

[PATCH 1/2] staging: vt6655: rf.c: Fix checkpatch warning

2016-08-22 Thread Anson Jacob
Fix checkpatch.pl warning for trailing */ on a separate line Remove '+' postfix and '-' prefix from the start and end of block comments Signed-off-by: Anson Jacob --- drivers/staging/vt6655/rf.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/stag

[PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings.

2016-08-22 Thread MingChia Chung
This patch fixes a minor checkpatch warnings: "WARNING: Block comments use a trailing */ on a separate line" Signed-off-by: Ming-Chia Chung --- drivers/staging/rts5208/rtsx.c | 42 -- 1 file changed, 28 insertions(+), 14 deletions(-) diff --git a/d

[PATCH 0/2] staging: vt6655: fix checkpatch warning for trailing */ on a separate line

2016-08-22 Thread Anson Jacob
*** BLURB HERE *** Anson Jacob (2): staging: vt6655: rf.c: Fix checkpatch warning staging: vt6655: rxtx.c: Fix checkpatch warning drivers/staging/vt6655/rf.c | 19 --- drivers/staging/vt6655/rxtx.c | 41 - 2 files changed, 36 insertio

Re: [staging:staging-testing 201/347] drivers/staging/lustre/lustre/mdc/mdc_request.c:1243:32: error: 'dp' undeclared

2016-08-22 Thread James Simmons
> On Mon, Aug 22, 2016 at 03:15:23PM +0800, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > staging-testing > > head: f5a9a15f8fd4168e415e94f5dce367f3cef08e03 > > commit: 4f76f0ec093c2f9ef049495c78d486bfb48e4de0 [201/347] staging: lust

[PATCH 5/5] staging: i4l: icn: fix incorrect type of arguments

2016-08-22 Thread Sudip Mukherjee
sparse was warning about incorrect type of argument: drivers/staging/i4l/icn/icn.c:1048:49: warning: incorrect type in argument 2 (different address spaces) drivers/staging/i4l/icn/icn.c:1048:49: expected void const [noderef] *from drivers/staging/i4l/icn/icn.c:1048:49: got unsigned char const [us

[PATCH 4/5] staging: i4l: icn: remove blank lines

2016-08-22 Thread Sudip Mukherjee
Blank lines are not needed after starting brace or before a closing brace. Signed-off-by: Sudip Mukherjee --- drivers/staging/i4l/icn/icn.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c index 1f72884..45623fa 100644 --- a/driv

[PATCH 3/5] staging: i4l: icn: space not needed after cast

2016-08-22 Thread Sudip Mukherjee
No need provide a space after a typecast. Signed-off-by: Sudip Mukherjee --- drivers/staging/i4l/icn/icn.c | 66 +-- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c index b2f4055

[PATCH 2/5] staging: i4l: act2000: remove unused macro

2016-08-22 Thread Sudip Mukherjee
The macro EVAL_PLCI and MAKE_PLCI are not being used. Remove them. But keep the comment preceding them as it contains information regarding message format. Signed-off-by: Sudip Mukherjee --- drivers/staging/i4l/act2000/capi.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/stag

[PATCH 1/5] staging: i4l: act2000: remove unused argument

2016-08-22 Thread Sudip Mukherjee
The macro EVAL_NCCI was only being used in capi.c and the argument controller was not used. Remove the argument and at the same time remove the variable which now becomes unused. Signed-off-by: Sudip Mukherjee --- drivers/staging/i4l/act2000/capi.c | 3 +-- drivers/staging/i4l/act2000/capi.h | 3

[PATCH 0/2] hyperv: minor cleanups

2016-08-22 Thread sthemmin
From: Stephen Hemminger Sparse warnings from global data/functions that should be static Stephen Hemminger (2): hyperv: make mmio resource local hv_pci: make hv_irq functions static drivers/hv/vmbus_drv.c|4 ++-- drivers/pci/host/pci-hyperv.c |4 ++-- 2 files changed, 4 ins

[PATCH 1/2] hyperv: make mmio resource local

2016-08-22 Thread sthemmin
From: Stephen Hemminger This fixes a sparse warning because hyperv_mmio resources are only used in this one file and should be static. Signed-off-by: Stephen Hemminger --- drivers/hv/vmbus_drv.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hv/vmbus_drv.c

[PATCH 2/2] hv_pci: make hv_irq functions static

2016-08-22 Thread sthemmin
From: Stephen Hemminger Fix sparse warning because these functions only used in one file. Signed-off-by: Stephen Hemminger --- drivers/pci/host/pci-hyperv.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c

Re: [PATCH] rtlwifi: Fix missing country code for Great Britain

2016-08-22 Thread Kalle Valo
Larry Finger writes: > Some RTL8821AE devices sold in Great Britain have the country code of > 0x25 encoded in their EEPROM. This value is not tested in the routine > that establishes the regulatory info for the chip. The fix is to set > this code to have the same capabilities as the EU countries

[PATCH] staging: most: aim-cdev: destroy ida struct in case of exception

2016-08-22 Thread Christian Gromm
This patch is needed to clean up the initialized ida structure in case the function exits with an exception. Signed-off-by: Christian Gromm --- drivers/staging/most/aim-cdev/cdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/most/aim-cdev/cdev.c b/driv

Re: linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:3533: pointless test ?

2016-08-22 Thread Greg KH
On Mon, Aug 22, 2016 at 03:07:44PM +0100, David Binderman wrote: > Hello there, > > linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:3533]: > (style) Condition 'pBtMgnt.ExtConfig.HCIExtensionVer>=1' is always > true > > Source code is > > if (pBtMgnt->ExtConfig.HCIExtens

Re: [PATCH 3/3] drivers: Add visorbus to the drivers/virt directory

2016-08-22 Thread 'Greg KH'
On Mon, Aug 22, 2016 at 10:02:43AM -0400, 'Greg KH' wrote: > On Mon, Aug 22, 2016 at 10:46:10AM +, Sell, Timothy C wrote: > > > -Original Message- > > > From: 'Greg KH' [mailto:gre...@linuxfoundation.org] > > > Sent: Monday, August 22, 2016 4:16 AM > > > To: Sell, Timothy C > > > Cc: c

linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:3533: pointless test ?

2016-08-22 Thread David Binderman
Hello there, linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:3533]: (style) Condition 'pBtMgnt.ExtConfig.HCIExtensionVer>=1' is always true Source code is if (pBtMgnt->ExtConfig.HCIExtensionVer < 1) { } else if (pBtMgnt->ExtConfig.HCIExtensionVer >=

Re: [PATCH 3/3] drivers: Add visorbus to the drivers/virt directory

2016-08-22 Thread 'Greg KH'
On Mon, Aug 22, 2016 at 10:46:10AM +, Sell, Timothy C wrote: > > -Original Message- > > From: 'Greg KH' [mailto:gre...@linuxfoundation.org] > > Sent: Monday, August 22, 2016 4:16 AM > > To: Sell, Timothy C > > Cc: cor...@lwn.net; t...@linutronix.de; mi...@redhat.com; > > h...@zytor.com

[PATCH V2] Staging: android: ion: fix parenthesis alignment

2016-08-22 Thread Ben LeMasurier
This fixes remaining checkpatch.pl "Alignment should match open parenthesis" issues. Signed-off-by: Ben LeMasurier --- V2: Rebased against current staging-testing staging tree. drivers/staging/android/ion/ion.c | 42 +- drivers/staging/android/ion/ion_chunk_h

RE: [PATCH 3/3] drivers: Add visorbus to the drivers/virt directory

2016-08-22 Thread Sell, Timothy C
> -Original Message- > From: 'Greg KH' [mailto:gre...@linuxfoundation.org] > Sent: Monday, August 22, 2016 4:16 AM > To: Sell, Timothy C > Cc: cor...@lwn.net; t...@linutronix.de; mi...@redhat.com; > h...@zytor.com; Arfvidson, Erik ; > hof...@osadl.org; dzic...@redhat.com; jes.soren...@redh

[PATCH 2/2] staging: android: ion: Remove valid_handle variable in ion_free_nolock

2016-08-22 Thread Johanna Abrahamsson
It is not neccessary to save the value of ion_handle_validate since it is only used once. Signed-off-by: Johanna Abrahamsson --- drivers/staging/android/ion/ion.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android

[PATCH 1/2] staging: android: ion: Do not BUG on handle client mismatch

2016-08-22 Thread Johanna Abrahamsson
The ion_free() and ion_free_nolock() functions should not BUG on a handle client mismatch. It is not necessary to explicitly check for that mismatch when ion_handle_validate is used. Signed-off-by: Johanna Abrahamsson --- drivers/staging/android/ion/ion.c | 4 1 file changed, 4 deletions(-)

[PATCH 0/2] staging: android: ion: cleanup of the ion_free functions

2016-08-22 Thread Johanna Abrahamsson
This is a small cleanup of the ion_free() and ion_free_nolock() methods. They are in a patchset because they depend lightly on each other, as in that patch 2 won't apply due to changes in the context. Since this is my first patchset please let me know if I am doing it wrong. Johanna Abrahamsson

[PATCH] staging: android: ion: Fix alignment

2016-08-22 Thread Johanna Abrahamsson
Alignment should match open parenthesis as per checkpatch.pl. Signed-off-by: Johanna Abrahamsson --- drivers/staging/android/ion/ion.c | 42 +++ 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/stagin

Re: [PATCH 3/3] staging: most: aim-cdev: relocate call to ida_init()

2016-08-22 Thread Greg KH
On Mon, Aug 22, 2016 at 10:58:07AM +0200, Christian Gromm wrote: > On Sun, 21 Aug 2016 16:50:20 +0200 > Greg KH wrote: > > > On Fri, Aug 19, 2016 at 01:09:35PM +0200, Christian Gromm wrote: > > > This patch moves the initialization of the idr structure towards the end > > > of the module's init r

Re: [PATCH] staging/lustre: avoid zero buf for the first time

2016-08-22 Thread Greg Kroah-Hartman
On Mon, Aug 22, 2016 at 04:46:04PM +0800, Shawn Lin wrote: > We only need to zero it when repeating in order to > avoid old garbage. Let's improve it by moving this > before we repeat the calculation to save some cpu > cycle. > > Signed-off-by: Shawn Lin Have you noticed a change with this in a

Re: [staging:staging-testing 201/347] drivers/staging/lustre/lustre/mdc/mdc_request.c:1243:32: error: 'dp' undeclared

2016-08-22 Thread Greg Kroah-Hartman
On Mon, Aug 22, 2016 at 03:15:23PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: f5a9a15f8fd4168e415e94f5dce367f3cef08e03 > commit: 4f76f0ec093c2f9ef049495c78d486bfb48e4de0 [201/347] staging: lustre: > llit

Re: [PATCH 3/3] staging: most: aim-cdev: relocate call to ida_init()

2016-08-22 Thread Christian Gromm
On Sun, 21 Aug 2016 16:50:20 +0200 Greg KH wrote: > On Fri, Aug 19, 2016 at 01:09:35PM +0200, Christian Gromm wrote: > > This patch moves the initialization of the idr structure towards the end > > of the module's init routine. This keeps the code compact and eliminates > > the need of having to

[PATCH] staging/lustre: avoid zero buf for the first time

2016-08-22 Thread Shawn Lin
We only need to zero it when repeating in order to avoid old garbage. Let's improve it by moving this before we repeat the calculation to save some cpu cycle. Signed-off-by: Shawn Lin --- drivers/staging/lustre/lustre/obdclass/llog.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

[staging:staging-testing 168/347] arch/frv/include/asm/atomic.h:186:1: note: in expansion of macro 'ATOMIC_OP'

2016-08-22 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: f5a9a15f8fd4168e415e94f5dce367f3cef08e03 commit: d806f30e639b0ff5abeb012b08932691be795342 [168/347] staging: lustre: osc: revise unstable pages accounting config: frv-allmodconfig (attached as .conf

Re: [PATCH 3/3] drivers: Add visorbus to the drivers/virt directory

2016-08-22 Thread 'Greg KH'
On Mon, Aug 22, 2016 at 02:48:18AM +, Sell, Timothy C wrote: > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Sunday, August 21, 2016 2:05 PM > > To: Kershner, David A > > Cc: cor...@lwn.net; t...@linutronix.de; mi...@redhat.com; > > h...@zytor.com

[staging:staging-testing 201/347] drivers/staging/lustre/lustre/mdc/mdc_request.c:1243:32: error: 'dp' undeclared

2016-08-22 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: f5a9a15f8fd4168e415e94f5dce367f3cef08e03 commit: 4f76f0ec093c2f9ef049495c78d486bfb48e4de0 [201/347] staging: lustre: llite: move dir cache to MDC layer config: alpha-allyesconfig (attached as .confi

  1   2   >