We get 1 warning when building kernel with W=1:
drivers/staging/android/sw_sync.c:56:23: warning: no previous prototype for
'sync_timeline_create' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
s
On 09/02/2016 02:33 PM, Arnd Bergmann wrote:
On Friday, September 2, 2016 1:33:44 PM CEST Laura Abbott wrote:
On 09/02/2016 02:02 AM, Arnd Bergmann wrote:
On Thursday, September 1, 2016 3:40:43 PM CEST Laura Abbott wrote:
--- a/drivers/staging/android/ion/ion-ioctl.c
+++ b/drivers/staging/and
On 09/02/2016 02:37 PM, Arnd Bergmann wrote:
On Friday, September 2, 2016 2:27:21 PM CEST Laura Abbott wrote:
All warnings (new ones prefixed by >>):
drivers/staging/android/ion/ion.c: In function 'ion_query_heaps':
drivers/staging/android/ion/ion.c:1181:3: warning: cast to pointer from in
On Friday, September 2, 2016 2:27:21 PM CEST Laura Abbott wrote:
> >
> > All warnings (new ones prefixed by >>):
> >
> >drivers/staging/android/ion/ion.c: In function 'ion_query_heaps':
> >>> drivers/staging/android/ion/ion.c:1181:3: warning: cast to pointer from
> >>> integer of different siz
Stop using cvmx_helper_link_autoconf(). We want to remove it in the future,
as it duplicates link state information into platform code for no reason.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-rgmii.c | 5 -
drivers/staging/octeon/ethernet.c | 6 --
2 files ch
On Friday, September 2, 2016 1:33:44 PM CEST Laura Abbott wrote:
> On 09/02/2016 02:02 AM, Arnd Bergmann wrote:
> > On Thursday, September 1, 2016 3:40:43 PM CEST Laura Abbott wrote:
> >
> >> --- a/drivers/staging/android/ion/ion-ioctl.c
> >> +++ b/drivers/staging/android/ion/ion-ioctl.c
> >> @@ -2
ion-Drop-heap-type-masks/20160902-071022
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
wget
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
-O ~/bin/make.cross
chmod +x ~/
Update each case to set retval and return that value at the end of the
function. This also replaces most case statement returns with breaks
and collapses some whitespace.
Signed-off-by: Aaron Sierra
---
drivers/staging/vme/devices/vme_user.c | 22 ++
1 file changed, 10 insert
Some bridges support a minimum slave window larger than this driver's
128 KB default buffer size. Also bridges typically require the PCI and
VME bases to be aligned to the size of the window.
Instead of allocating a slave buffer at probe time, allocate an
appropriately sized/aligned buffer in the
Assign a pointer to the image descriptor once at the beginning of
the ioctl to help keep code concise.
Signed-off-by: Aaron Sierra
---
drivers/staging/vme/devices/vme_user.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/vme/devices/vme_user.c
The driver's bus_num parameter is used to select a VME bus during probe.
This parameter is used both as a boolean to indicate that probing should
occur as well as which bus should be probed. However, the first bus in
the system is bus zero, so this method prevents the first bus from being
accepted
Merge guestlinuxdebug into vmcallinterface.h since it is dependent on it
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/guestlinuxdebug.h | 180 --
drivers/staging/unisys/visorbus/visorbus_main.c |
The check for GNUC is redundant and is not needed for vmcallinterface.h.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/vmcallinterface.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/vmcallinterface.h
b/drivers/st
visorbus_main.c does not need to include vbuschannel.h.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers/staging/unisys/visorbus/v
Cleaned up include section of files so that they only
include the files needed by them. If an include file includes
the file already don't repeat it.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 --
1
Guestlinuxdebug.h is only used by visorbus, move the include file
into its directory instead of the global one.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/{include => visorbus}/guestlinuxdebug.h | 0
1 file changed, 0 insertio
iovmcall_gnuc was only being referenced by vmcallinterface, so merge
them together.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/iovmcall_gnuc.h | 48 ---
drivers/staging/unisys/visorbus/vmcallinte
From: Bryan Thompson
The contents of vbushelper.h are now only used by visorbus, so it no longer
needs to be a general include file and it can be incorporated in the
visorbus private header.
Signed-off-by: Bryan Thompson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
Reported-by: Greg Kr
From: Bryan Thompson
Stop ultrainputreport.h from including itself.
Signed-off-by: Bryan Thompson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/ultrainputreport.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/visorinpu
From: David Binder
visorbus_private.h was previously named visorchipset.h. This patch removes
references to the old filename, and updates them with the new filename.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_p
From: Bryan Thompson
Remove unnecessary channel.h include from visorinput.c.
Signed-off-by: Bryan Thompson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/visorinput.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/visorinp
From: Jon Frisch
This patch removes the unused struct putfile_buffer_entry.
Signed-off-by: Jon Frisch
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/u
From: David Binder
Merges the contents of channel_guid.h with channel.h, as the former was
not a proper header file. Therefore, the channel_guid.h is no longer
needed.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
Reported-by: Greg Kroah-Hartman
---
drivers
Visorchannel does not need to include visorbus_private.h; all it was
using it for was function prototypes. A simple reorder causes it to
no longer need to include it.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchannel.c | 245 ---
From: Erik Arfvidson
It is pointless to have a dedicated include for another
include. So I merged them together.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/include/diagchannel.h | 38 -
vbusdeviceinfo.h was only used by vbuschannel.h so merge them
together.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/vbuschannel.h | 212 ++-
drivers/staging/unisys/visorbus/vbusdeviceinfo.h | 234
The completion status are valid only for the controlvm channel
so they should be moved into its header file.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/controlvmchannel.h | 76
.../unisys/visorbus/co
From: Jon Frisch
This patch removes the unused
struct controlvm_message_packet g_devicechangestate_packet.
The struct is set but never called.
Signed-off-by: Jon Frisch
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 --
1
From: Erik Arfvidson
This removes two unused pound defines in the visorbus_main.c
file.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbu
From: Jon Frisch
This patch removes the following lists that were never used:
LIST_HEAD(bus_info_list)
LIST_HEAD(dev_info_list)
LIST_HEAD(putfile_request_list)
Signed-off-by: Jon Frisch
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchi
This patch series starts the process of addressing the issues
raised by Greg-KH on 08/21/2016, more patches will be coming.
This patch series removes unused defines and structures in visorbus.
It also combines and simplifies the headers files for the s-Par
drivers.
Changes since v2:
-
From: Erik Arfvidson
This removes two unused pound defines in the visornic_main.c
file.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
---
drivers/staging/unisys/visornic/visornic_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visornic
From: Erik Arfvidson
This removes three unused pound defines in the visorchipset.c
file.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/driver
On 09/01/2016 11:14 PM, Greg Kroah-Hartman wrote:
On Thu, Sep 01, 2016 at 03:40:44PM -0700, Laura Abbott wrote:
Ion clients currently lack a good method to determine what
heaps are available and what ids they map to. This leads
to tight coupling between user and kernel space and headaches.
Add
On 09/02/2016 02:02 AM, Arnd Bergmann wrote:
On Thursday, September 1, 2016 3:40:43 PM CEST Laura Abbott wrote:
--- a/drivers/staging/android/ion/ion-ioctl.c
+++ b/drivers/staging/android/ion/ion-ioctl.c
@@ -22,6 +22,29 @@
#include "ion_priv.h"
#include "compat_ion.h"
+union ion_ioctl_arg {
On 09/01/2016 11:10 PM, Greg Kroah-Hartman wrote:
On Thu, Sep 01, 2016 at 03:40:43PM -0700, Laura Abbott wrote:
The current Ion ioctls lack a good way to tell what ioctls are
available. Introduce an ioctl to give an ABI version. This way when the
ABI inevitably gets screwed up userspace will ha
were very trival hence did not form two patches, will not happen again
i did use the get_maintainer.pl script, Sumit Semwal
is on it, will check to see where i went
wrong
changes are in response to checkpatch.pl errors
CHECK: Please don't use multiple blank lines
#42: FILE: drivers/staging/and
On 09/02/2016 05:44 AM, Greg Kroah-Hartman wrote:
On Thu, Sep 01, 2016 at 03:40:42PM -0700, Laura Abbott wrote:
The number of Ion ioctls may continue to grow along with necessary
validation. Pull it out into a separate file for easier management
and review.
Signed-off-by: Laura Abbott
---
dr
On Sat, Sep 03, 2016 at 01:12:23AM +0530, Chinmay Nivsarkar wrote:
> im really sorry, im new to mailing lists.
> I'll brush up on the ettiquette
>
> it is in response to the checkpatch.pl error
>
> CHECK: Please don't use multiple blank lines
> #105: FILE: drivers/staging/android/ion/ion_system_h
im really sorry, im new to mailing lists.
I'll brush up on the ettiquette
it is in response to the checkpatch.pl error
CHECK: Please don't use multiple blank lines
#105: FILE: drivers/staging/android/ion/ion_system_heap.c:105:
+
+
and
CHECK: Blank lines aren't necessary after an open brace '{'
Commit 6fba39cf32a3 ("staging: sm750fb: use BIT macro for
PANEL_DISPLAY_CTRL single-bit fields") accidentally changed the
CLOCK_PHASE logic from '|=' to '=' which clears all the previously set
bits.
Fixes: 6fba39cf32a3 ("staging: sm750fb: use BIT macro for PANEL_DISPLAY_CTRL
single-bit fields")
S
On 09/02/2016 06:41 AM, Brian Starkey wrote:
Hi Laura,
On Thu, Sep 01, 2016 at 03:40:41PM -0700, Laura Abbott wrote:
There is no advantage to having heap types be a mask. The ion client has
long since dropped the mask. Drop the notion of heap type masks as well.
I know this is the same patc
On Sat, Sep 03, 2016 at 12:26:51AM +0530, Chinmay Nivsarkar wrote:
> Including
> *Excess newlines
> *Unnecessary braces
Two different things usually means two different patches...
And why aren't you using get_maintainer.pl to determine who to send
these to?
thanks,
greg k-h
On Sat, Sep 03, 2016 at 12:36:10AM +0530, Chinmay Nivsarkar wrote:
> Includes excess newlines
What does this mean?
Please be more specific as to why you are doing the change.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://
Includes excess newlines
Signed-off-by: Chinmay Nivsarkar
---
drivers/staging/android/ion/ion_system_heap.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion_system_heap.c
b/drivers/staging/android/ion/ion_system_heap.c
index 7e023d5..36caeca 100644
--- a/drive
Including
*Excess newlines
*Unnecessary braces
Signed-off-by: Chinmay Nivsarkar
---
drivers/staging/android/ion/ion_cma_heap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion_cma_heap.c
b/drivers/staging/android/ion/ion_cma_heap.c
index 6c7de
This patch fixes checkpatch.pl error WARNING: line over 80 characters #95:
FILE: drivers/staging/android/lowmemorykiller.c:95:
Signed-off-by: Chinmay Nivsarkar
---
drivers/staging/android/lowmemorykiller.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/a
Luca Ceresoli writes:
> These functions have been declared without any implementation since
> the first commit (364e30ebd2dbaccba430c603da03e68746eb932a) and there
> has been no mention of them in following commits.
>
> Signed-off-by: Luca Ceresoli
> Cc: Larry Finger
> Cc: Jes Sorensen
> Cc: G
Hi Laura,
On Thu, Sep 01, 2016 at 03:40:41PM -0700, Laura Abbott wrote:
There is no advantage to having heap types be a mask. The ion client has
long since dropped the mask. Drop the notion of heap type masks as well.
I know this is the same patch you sent last time, so sorry for not
picking
On 09/01/2016 11:02 PM, Greg Kroah-Hartman wrote:
On Wed, Aug 24, 2016 at 03:19:21PM +0700, Ivan Safonov wrote:
Driver does not use this function.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 47 --
drivers/staging/rtl8188eu/includ
fixed comment style and space indent report from checkpatch
in rtl8712/rtl871x_ioctl_linux.c:
* WARNING: Statements should start on a tabstop
* WARNING: Block comments use * on subsequent lines
* WARNING: suspect code indent for conditional statements (16, 32)
Signed-off-by: Louie Lu
---
driver
2016-09-02 20:55 GMT+08:00 Greg KH :
> On Fri, Sep 02, 2016 at 06:16:10PM +0800, Louie Lu wrote:
>> fixed comment style and space indent report from checkpatch:
>>
>> * WARNING: Statements should start on a tabstop
>> * WARNING: Block comments use * on subsequent lines
>> * WARNING: suspect code in
On Fri, Sep 02, 2016 at 09:04:29PM +0800, Louie Lu wrote:
> 2016-09-02 20:55 GMT+08:00 Greg KH :
> > On Fri, Sep 02, 2016 at 06:16:10PM +0800, Louie Lu wrote:
> >> fixed comment style and space indent report from checkpatch:
> >>
> >> * WARNING: Statements should start on a tabstop
> >> * WARNING:
Since the removal of rtw_proc_init_one() the proc filesystem is not
mentioned in this driver. So this include becomes useless.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Arnd Bergmann
Cc: Binoy Jayan
Cc: Anish Bhatt
Cc: "Rémy Oudompheng"
Cc: Alexey Khoroshilov
Cc: Kyle Kufferma
These functions were only mentioned in the rtw_proc_init_one()
function in drivers/staging/rtl8188eu/os_dep/os_intfs.c, which was
under #if 0 and has now been removed completely.
As they are not used anywhere, and also violate the coding style
rules, remove them.
Signed-off-by: Luca Ceresoli
Cc:
rtw_proc_init_one() and rtw_proc_remove_one() are two very long
functions that are supposed to create a bunch of proc entries to
access debugging features of the driver.
But both of them are under #if 0 since their first commit three years
ago (5adef66acf73705ae95ea0b1e6b5fc7f17d82d30), replaced b
These functions have been declared without any implementation since
the first commit (58c434013a22fccfdb14abc2bb8408ca29073b76) and there
has been no mention of them in following commits.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Kyle Kuffermann
Cc: de...@driverdev.osuosl.org
Cc:
This function is only used inside rtw_recv.c. Which is quite logical,
since it's a timer callback: it is passed as the _fn argument to
setup_timer(). So it is internal to rtw_recv.c and should be static.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Bhaktipriya Shridhar
Cc: Andy Shevc
These functions have been declared without any implementation since
the first commit (364e30ebd2dbaccba430c603da03e68746eb932a) and there
has been no mention of them in following commits.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Jes Sorensen
Cc: Greg Kroah-Hartman
Cc: linux-wirel...@v
On Fri, Sep 02, 2016 at 06:16:10PM +0800, Louie Lu wrote:
> fixed comment style and space indent report from checkpatch:
>
> * WARNING: Statements should start on a tabstop
> * WARNING: Block comments use * on subsequent lines
> * WARNING: suspect code indent for conditional statements (16, 32)
>
On Thu, Sep 01, 2016 at 03:15:11PM -0400, David Kershner wrote:
> The check for GNUC is redundant and is not needed for vmcallinterface.h.
>
> Signed-off-by: David Kershner
> Reviewed-by: Tim Sell
> Reported-by: Greg Kroah-Hartman
> ---
> drivers/staging/unisys/visorbus/vmcallinterface.h | 2 -
On Thu, Sep 01, 2016 at 03:14:54PM -0400, David Kershner wrote:
> From: Erik Arfvidson
>
> This removes two unused pound defines in the visorbus_main.c
> file.
>
> Signed-off-by: Erik Arfvidson
> Signed-off-by: David Kershner
> Reported-by: Greg Kroah-Hartman
> ---
> drivers/staging/unisys/v
On Thu, Sep 01, 2016 at 03:40:42PM -0700, Laura Abbott wrote:
>
> The number of Ion ioctls may continue to grow along with necessary
> validation. Pull it out into a separate file for easier management
> and review.
>
> Signed-off-by: Laura Abbott
> ---
> drivers/staging/android/ion/Makefile
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Fri, Sep 02, 2016 at 11:
From: Vitaly Kuznetsov
With wrap around mappings in place we can always provide drivers with
direct links to packets on the ring buffer, even when they wrap around.
Do the required updates to get_next_pkt_raw()/put_pkt_raw()
Signed-off-by: Vitaly Kuznetsov
Signed-off-by: K. Y. Srinivasan
Teste
From: Vitaly Kuznetsov
Make it possible to always use a single memcpy() or to provide a direct
link to a packet on the ring buffer by creating virtual mapping for two
copies of the ring buffer with vmap(). Utilize currently empty
hv_ringbuffer_cleanup() to do the unmap.
While on it, replace size
From: Alex Ng
Hyper-V host will send a VSS_OP_HOT_BACKUP request to check if guest is
ready for a live backup/snapshot. The driver should respond to the check
only if the daemon is running and listening to requests. This allows the
host to fallback to standard snapshots in case the VSS daemon is
From: Vitaly Kuznetsov
With wrap around mappings for ring buffers we can always use a single
memcpy() to do the job.
Signed-off-by: Vitaly Kuznetsov
Signed-off-by: K. Y. Srinivasan
Tested-by: Dexuan Cui
---
drivers/hv/ring_buffer.c | 24 +++-
1 files changed, 3 insertio
From: K. Y. Srinivasan
Introduce a mechanism to control how channels will be affinitized. We will
support two policies:
1. HV_BALANCED: All performance critical channels will be dstributed
evenly amongst all the available NUMA nodes. Once the Node is assigned,
we will assign the CPU based on a s
From: Vitaly Kuznetsov
In preparation for doing wrap around mappings for ring buffers cleanup
vmbus_open() function:
- check that ring sizes are PAGE_SIZE aligned (they are for all in-kernel
drivers now);
- kfree(open_info) on error only after we kzalloc() it (not an issue as it
is valid to c
From: Alex Ng
Multiple VSS_OP_HOT_BACKUP requests may arrive in quick succession, even
though the host only signals once. The driver wass handling the first
request while ignoring the others in the ring buffer. We should poll the
VSS channel after handling a request to continue processing other r
From: K. Y. Srinivasan
Some miscellaneous fixes and enhancements. These patches were all
sent earlier but failed to apply clean on Greg's tree. These have
now been rebased.
Alex Ng (2):
Drivers: hv: utils: Continue to poll VSS channel after handling
requests.
Drivers: hv: utils: Check VS
fixed comment style and space indent report from checkpatch:
* WARNING: Statements should start on a tabstop
* WARNING: Block comments use * on subsequent lines
* WARNING: suspect code indent for conditional statements (16, 32)
Signed-off-by: Louie Lu
---
drivers/staging/rtl8712/rtl871x_ioctl_l
Fixed comment style warning by checkpatch:
* Block comments use * on subsequent lines
* Block comments use a trailing */ on a separate line
Signed-off-by: Louie Lu
---
drivers/staging/rtl8712/rtl871x_cmd.c | 46 +++
1 file changed, 25 insertions(+), 21 deletions(
This patchsets cleanup some warning report from checkpatch
Including:
* space indent
* bad comment style
Louie Lu (3):
staging: rtl8712: delete one space before if statement
staging: rtl8172: fixed comment style in rts871x_cmd.c
staging: rtl8712: fixed comment style and space indent
d
This patch fixed minor checkpatch warning:
WARNING: Statements should start on a tabstop
Signed-off-by: Louie Lu
---
drivers/staging/rtl8712/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/os_intfs.c
b/drivers/staging/rtl8712/os_intfs.c
in
On Thursday, September 1, 2016 3:40:43 PM CEST Laura Abbott wrote:
> --- a/drivers/staging/android/ion/ion-ioctl.c
> +++ b/drivers/staging/android/ion/ion-ioctl.c
> @@ -22,6 +22,29 @@
> #include "ion_priv.h"
> #include "compat_ion.h"
>
> +union ion_ioctl_arg {
> + struct ion_fd_data fd;
>
There were (mostly) two kinds of warnings that I've handled, "80
character line length" and block comments structure.
Some of the changes involve handling two separate warnings in a single comment.
Where this occurs, should I break down the change into two steps -
fixing a warning at a time?
Or sho
78 matches
Mail list logo
