Re: [PATCH 1/7] selftest: sync: basic tests for sw_sync framework

Emilio López writes: > El 22/09/16 a las 06:43, Michael Ellerman escribió: >> Emilio López writes: >> >> Please don't include the *kernel* headers, they're really not meant to >> be used in userspace programs :) >> >>> +CFLAGS +=

[PATCH] staging: rtl8192e: fixed statements should start on a tabstop

checkpatch.pl repairs: corrected: statements should start on a tabstop corrected: block comments use * on subsequent lines corrected: use a blank line after function/struct/union/enum declarations Signed-off-by: Darryl T. Agostinelli ---

[PATCH v3 3/5] staging: iio: isl29018: fixed race condition in in_illuminance_scale_available_show()

in_illuminance_scale_available_show() references the isl29018_chip->int_time variable in three places inside a for loop. The value of the int_time variable can be updated by the isl29018_set_integration_time() function, which is called by the isl29018_write_raw() function. isl29018_write_raw()

[PATCH v3 5/5] staging: iio: isl29018: check if the chip is in a suspended state

Add a check to isl29018_write_raw() to ensure that the chip is not in a suspended state. This makes the code consistent with what is present in isl29018_read_raw(). Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 7 ++- 1 file changed, 6

[PATCH v3 2/5] staging: iio: isl29018: use IIO_DEVICE_ATTR_{RO, RW} macros

Use the IIO_DEVICE_ATTR_RO and IIO_DEVICE_ATTR_RW macros to create the device attributes. Signed-off-by: Brian Masney --- This version of the patch now applies cleanly to the iio.git/testing branch. drivers/staging/iio/light/isl29018.c | 33

[PATCH v3 1/5] include: linux: iio: add IIO_ATTR_{RO, WO, RW} and IIO_DEVICE_ATTR_{RO, WO, RW} macros

Add new macros: IIO_ATTR_RO, IIO_ATTR_WO, IIO_ATTR_RW, IIO_DEVICE_ATTR_RO, IIO_DEVICE_ATTR_WO and IIO_DEVICE_ATTR_RW to reduce the amount of boiler plate code that is needed for creating new attributes. This mimics the *_RO, *_WO, and *_RW macros that are found in include/linux/device.h and

[PATCH v3 4/5] staging: iio: isl29018: change isl29018_read_raw() to only have one exit point

When the chip is in a suspended state, isl29018_read_raw() will return -EBUSY. Change the function so that it only has a single exit point. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[PATCH] staging: rtl8192e: fixed statements should start on a tabstop

checkpatch.pl repairs: corrected: statements should start on a tabstop corrected: block comments use * on subsequent lines corrected: use a blank line after function/struct/union/enum declarations Signed-off-by: Darryl T. Agostinelli save ---

[PATCH V3] staging: rtl8172: usb_intf.c: Fixed block comment coding style

Fixed a block comment indentation in the rtl8712 usb_intf.c file. Signed-off-by: Gonçalo Salazar --- Made this as a first commit. Resubmitted with updated subject. Removed text from the permanent record. Please let me know of any feedback you have. Thanks, Gonçalo Salazar

Re: [PATCH] staging: vt6656: Add spaces around '+' operator

On Mon, 2016-09-26 at 14:48 -0300, Martin Alonso wrote: > Fix coding style issue "spaces preferred around '+' > detected by checkpatch.pl in dpc.c file. [] > diff --git a/drivers/staging/vt6656/dpc.c b/drivers/staging/vt6656/dpc.c [] > @@ -75,8 +75,8 @@ int vnt_rx_data(struct vnt_private *priv,

Re: [lustre-devel] [PATCH] staging/lustre/obdclass: add missing header dependencies

> We get 1 warning when building kernel with W=1: > drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:157:5: warning: > no previous prototype for 'obd_sysctl_init' [-Wmissing-prototypes] > > In fact, this function is declared in ../../include/obd_class.h, > so this patch add missing

Re: [lustre-devel] [PATCH] staging/lustre/lov: add missing header dependencies

> We get 1 warning when building kernel with W=1: > drivers/staging/lustre/lustre/lov/lov_object.c:956:23: warning: no previous > prototype for 'lov_lsm_get' [-Wmissing-prototypes] > drivers/staging/lustre/lustre/lov/lov_object.c:972:6: warning: no previous > prototype for 'lov_lsm_put'

Re: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style

On 09/26/2016 06:20 AM, Gonçalo Salazar wrote: 2016-09-26 1:53 GMT+01:00 Larry Finger : On 09/25/2016 06:00 PM, Gonçalo Salazar wrote: Fixed a block comment indentation in the rtl8712 usb_intf.c file. Made this as a first commit. Resubmitted with updated subject.

[PATCH] staging: vt6656: Add spaces around '+' operator

Fix coding style issue "spaces preferred around '+' detected by checkpatch.pl in dpc.c file. Signed-off-by: Martin Alonso --- drivers/staging/vt6656/dpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6656/dpc.c

[PATCH] Staging: dgnc: Align the * on a block comment

This patch corrects a misalligned * in a block comment warning found by checkpatch.pl Signed-off-by: Ramiro Oliveira --- drivers/staging/dgnc/dgnc_cls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_cls.c

[PATCH V2] staging: ks7010: Fix warnings on printk() usage

This patch fixes the following warnings on ks7010_sdio.c 1. printk() should include KERN_ facility level 2. Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Sabitha George ---

Re: [PATCH] staging: skein: Remove extra blank lines

Ok Joe, Thanks and sorry for the annoyance. On Mon, Sep 26, 2016 at 09:26:12AM -0700, Joe Perches wrote: > On Mon, 2016-09-26 at 11:56 -0300, Martin wrote: > > Fix coding style issue "multiple blank lines" > > detected by checkpatch.pl in threefish_block.c file. > > This has been submitted

[PATCH] staging: slicoss: cleaning up codestyle warnings

This removes checkpatch.pl warnings: WARNING: Block comments should align the * on each line Signed-off-by: Grygorii Maistrenko --- drivers/staging/slicoss/slic.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/slicoss/slic.h

Re: [PATCH] staging: skein: Remove extra blank lines

On Mon, 2016-09-26 at 11:56 -0300, Martin wrote: > Fix coding style issue "multiple blank lines" > detected by checkpatch.pl in threefish_block.c file. This has been submitted and rejected a couple times already. The extra blank lines are to separate blocks. Whatever the blocks are, perhaps

[PATCH] staging: wilc1000: fix sparse warning: symbol was not declared. Should it be static?

- Fixed a sparse warning: wilc_debugfs.c:32:10: warning: symbol 'WILC_DEBUG_LEVEL' was not declared. Should it be static? Signed-off-by: Matias Mucciolo --- drivers/staging/wilc1000/wilc_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] staging: wilc1000: fix symbol 'WILC_DEBUG_LEVEL' was not declared.

On Mon, Sep 26, 2016 at 12:44:24PM -0300, Matias Mucciolo wrote: > > hi > > sorry...this is the full warning: > > drivers/staging/wilc1000/wilc_debugfs.c:32:10: warning: symbol > 'WILC_DEBUG_LEVEL' was not declared. Should it be static? the "should it be static" is the key here, right? Care

Re: [PATCH] staging: wilc1000: fix symbol 'WILC_DEBUG_LEVEL' was not declared.

On Mon, Sep 26, 2016 at 12:15:18PM -0300, Matias Mucciolo wrote: > > - Fixed a sparse warning: symbol 'WILC_DEBUG_LEVEL' was not declared. I don't think that was the full warning, as that does not make much sense to me, does it to you? thanks, greg k-h

[PATCH 2/9] staging: unisys: visorbus: remove driver version from visorchipset.c

From: Jon Frisch This patch removes the driver version and the version.h include from visorchipset.c Signed-off-by: Jon Frisch Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner

Re: [PATCH] staging: wilc1000: fix symbol 'WILC_DEBUG_LEVEL' was not declared.

hi sorry...this is the full warning: drivers/staging/wilc1000/wilc_debugfs.c:32:10: warning: symbol 'WILC_DEBUG_LEVEL' was not declared. Should it be static? -- Matias Mucciolo Area de Infraestructura. Piedras 737 C.A.B.A SUTEBA On Monday 26 September 2016 17:37:33 Greg Kroah-Hartman

[PATCH] staging: wilc1000: fix symbol 'WILC_DEBUG_LEVEL' was not declared.

- Fixed a sparse warning: symbol 'WILC_DEBUG_LEVEL' was not declared. Signed-off-by: Matias Mucciolo --- drivers/staging/wilc1000/wilc_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_debugfs.c

[PATCH 6/9] staging: unisys: make MODULE_DESCRIPTIONs consistent

From: Jon Frisch This patch ensures that consistent verbiage is used in the MODULE_DESCRIPTION text (reported by 'modinfo') for all of the Unisys s-Par drivers. Signed-off-by: Jon Frisch Signed-off-by: David Kershner ---

[PATCH 5/9] staging: unisys: remove version.h

From: Jon Frisch This patch removes version.h and the last version.h include in visorchannel.c. Signed-off-by: Jon Frisch Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner ---

[PATCH 4/9] staging: unisys: visornic: remove driver version from visornic_main.c

From: Jon Frisch This patch removes the driver version from visornic_main.c Signed-off-by: Jon Frisch Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner ---

[PATCH 1/9] staging: unisys: remove driver version from struct visor_driver

From: Jon Frisch This patch removes the all instances of the driver version from struct visor_driver. This includes removing version, vertag (a human readable version string of the driver version) and version_attr from struct visor_driver. This resulted in removing the bus

[PATCH 9/9] staging: unisys: visorbus: Convert visorchannel_signalinsert() return val

From: David Binder Per Documentation/CodingStyle, function names that convey an action or an imperative command should return an integer. This commit converts the visorbus API function, visorchannel_signalinsert(), to returning integer values. All uses of this function

[PATCH] staging: skein: Remove extra blank lines

Fix coding style issue "multiple blank lines" detected by checkpatch.pl in threefish_block.c file. Signed-off-by: Martin --- drivers/staging/skein/threefish_block.c | 16 1 file changed, 16 deletions(-) diff --git

[PATCH 7/9] staging: unisys: visorbus: Change support functions to integer return vals

From: David Binder Per Documentation/CodingStyle, function names that convey an action or an imperative command should return an integer value. This commit changes several functions and a macro, internal to visorchannel.c, to follow this paradigm. These changes will be

[PATCH 0/9] staging: unisys: Remove version information

This patch series removes the Unisys s-Par specific versioning and replaces it where approrpriate with the kernel version. This series also converts several bool return types to the more appropriate error returns. It does not completely fix error handling with the new functions; that will be

[PATCH 8/9] staging: unisys: visorbus: Convert visorchannel_signalremove() return val

From: David Binder Per Documentation/CodingStyle, function names that convey an action or an imperative command should return an integer. This commit converts the visorbus API function, visorchannel_signalremove(), to returning integer values. All uses of this function

[PATCH 01/37] staging: lustre: llite: add missing LMV_MAGIC_V1 case

From: wang di The port to upstream dropped handling the LMV_MAGIC_V1 case for ll_dir_getstripe. This adds it back. Signed-off-by: wang di Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531 Reviewed-on: http://review.whamcloud.com/7228 Reviewed-by:

[PATCH] staging: rtl8192e: fixed block comments should align the * on each line

shifted over comment block one space Signed-off-by: Darryl T. Agostinelli --- drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.c

[PATCH] staging: rtl8192e: fixed block comments should align the * on each line

shifted over comment block one space Signed-off-by: Darryl T. Agostinelli --- drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.c

Re: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style

2016-09-26 1:53 GMT+01:00 Larry Finger : > On 09/25/2016 06:00 PM, Gonçalo Salazar wrote: >> >> Fixed a block comment indentation in the rtl8712 usb_intf.c file. >> Made this as a first commit. >> Resubmitted with updated subject. >> >> Please let me know of any feedback

Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function

On Mon, Sep 26, 2016 at 1:24 PM, Greg KH wrote: > On Mon, Sep 26, 2016 at 01:11:50PM +0300, Yannis Damigos wrote: >> Hi Greg, >> >> On Fri, Sep 23, 2016 at 3:06 PM, Greg KH wrote: >> > >> > Have you tested that this works? >> > >> >> In

Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function

On Mon, Sep 26, 2016 at 01:11:50PM +0300, Yannis Damigos wrote: > Hi Greg, > > On Fri, Sep 23, 2016 at 3:06 PM, Greg KH wrote: > > > > Have you tested that this works? > > > > In order to test the change I need a board with Hi6220 SoC. > If I do not own the hardware

Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function

Hi Greg, On Fri, Sep 23, 2016 at 3:06 PM, Greg KH wrote: > > Have you tested that this works? > In order to test the change I need a board with Hi6220 SoC. If I do not own the hardware to test the change, how should I proceed? thanks, Yannis

Re: [PATCH -next] staging: most: fix error return code in audio_probe_channel()

On Mon, 26 Sep 2016 09:47:19 +0200 Andrey Shvetsov wrote: > On Sun, Sep 25, 2016 at 03:41:11PM +, Wei Yongjun wrote: > > From: Wei Yongjun > > > > Fix to return a negative error code from the audio_set_hw_params() error > > handling case

Re: [PATCH v2 1/2] include: linux: iio: add IIO_ATTR_{RO, WO, RW} and IIO_DEVICE_ATTR_{RO, WO, RW} macros

On Sun, Sep 25, 2016 at 03:27:54PM -0400, Brian Masney wrote: > Add new macros: IIO_ATTR_RO, IIO_ATTR_WO, IIO_ATTR_RW, > IIO_DEVICE_ATTR_RO, IIO_DEVICE_ATTR_WO and IIO_DEVICE_ATTR_RW to reduce > the amount of boiler plate code that is needed for creating new > attributes. This mimics the *_RO,

Re: [PATCH] staging: rtl8192e: fixed block comments should align the * on each line

On Mon, Sep 26, 2016 at 12:03:04AM -0500, Darryl T. Agostinelli wrote: > Signed-off-by: Darryl T. Agostinelli > --- > drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I can't take patches without any changelog text

Re: [PATCH -next] staging: most: fix error return code in audio_probe_channel()

On Sun, Sep 25, 2016 at 03:41:11PM +, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return a negative error code from the audio_set_hw_params() error > handling case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun