This replaces uses of __attribute__((packed)) with __packed, which is
recommended to be used over the direct __attribute__. This patch then
includes as necessary to use __packed.
Signed-off-by: Matthew Kilgore
---
drivers/staging/ks7010/eap_packet.h | 10 ++--
drivers/staging/ks7010/ks_hostif.h
Emilio López writes:
> El 22/09/16 a las 06:43, Michael Ellerman escribió:
>> Emilio López writes:
>>
>> Please don't include the *kernel* headers, they're really not meant to
>> be used in userspace programs :)
>>
>>> +CFLAGS += -I../../../../usr/include/
>>
>> That is the correct place to get t
checkpatch.pl repairs:
corrected: statements should start on a tabstop
corrected: block comments use * on subsequent lines
corrected: use a blank line after function/struct/union/enum declarations
Signed-off-by: Darryl T. Agostinelli
---
drivers/staging/rtl8192e/rtllib_tx.c | 75
in_illuminance_scale_available_show() references the
isl29018_chip->int_time variable in three places inside a for loop.
The value of the int_time variable can be updated by the
isl29018_set_integration_time() function, which is called by the
isl29018_write_raw() function. isl29018_write_raw() lock
Add a check to isl29018_write_raw() to ensure that the chip is not in a
suspended state. This makes the code consistent with what is present
in isl29018_read_raw().
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/isl29018.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
d
Use the IIO_DEVICE_ATTR_RO and IIO_DEVICE_ATTR_RW macros to
create the device attributes.
Signed-off-by: Brian Masney
---
This version of the patch now applies cleanly to the iio.git/testing
branch.
drivers/staging/iio/light/isl29018.c | 33 +++--
1 file changed, 15
Add new macros: IIO_ATTR_RO, IIO_ATTR_WO, IIO_ATTR_RW,
IIO_DEVICE_ATTR_RO, IIO_DEVICE_ATTR_WO and IIO_DEVICE_ATTR_RW to reduce
the amount of boiler plate code that is needed for creating new
attributes. This mimics the *_RO, *_WO, and *_RW macros that are found
in include/linux/device.h and include
When the chip is in a suspended state, isl29018_read_raw() will return
-EBUSY. Change the function so that it only has a single exit point.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/isl29018.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/stagi
checkpatch.pl repairs:
corrected: statements should start on a tabstop
corrected: block comments use * on subsequent lines
corrected: use a blank line after function/struct/union/enum declarations
Signed-off-by: Darryl T. Agostinelli
save
---
drivers/staging/rtl8192e/rtllib_tx.c | 75 ++
Fixed a block comment indentation in the rtl8712 usb_intf.c file.
Signed-off-by: Gonçalo Salazar
---
Made this as a first commit.
Resubmitted with updated subject.
Removed text from the permanent record.
Please let me know of any feedback you have.
Thanks,
Gonçalo Salazar
drivers/staging/rtl87
On Mon, 2016-09-26 at 14:48 -0300, Martin Alonso wrote:
> Fix coding style issue "spaces preferred around '+'
> detected by checkpatch.pl in dpc.c file.
[]
> diff --git a/drivers/staging/vt6656/dpc.c b/drivers/staging/vt6656/dpc.c
[]
> @@ -75,8 +75,8 @@ int vnt_rx_data(struct vnt_private *priv, str
> We get 1 warning when building kernel with W=1:
> drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:157:5: warning:
> no previous prototype for 'obd_sysctl_init' [-Wmissing-prototypes]
>
> In fact, this function is declared in ../../include/obd_class.h,
> so this patch add missing he
> We get 1 warning when building kernel with W=1:
> drivers/staging/lustre/lustre/lov/lov_object.c:956:23: warning: no previous
> prototype for 'lov_lsm_get' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/lov/lov_object.c:972:6: warning: no previous
> prototype for 'lov_lsm_put' [-Wmissi
On 09/26/2016 06:20 AM, Gonçalo Salazar wrote:
2016-09-26 1:53 GMT+01:00 Larry Finger :
On 09/25/2016 06:00 PM, Gonçalo Salazar wrote:
Fixed a block comment indentation in the rtl8712 usb_intf.c file.
Made this as a first commit.
Resubmitted with updated subject.
Please let me know of any fee
Fix coding style issue "spaces preferred around '+'
detected by checkpatch.pl in dpc.c file.
Signed-off-by: Martin Alonso
---
drivers/staging/vt6656/dpc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vt6656/dpc.c b/drivers/staging/vt6656/dpc.c
index 601
This patch corrects a misalligned * in a block comment warning found by
checkpatch.pl
Signed-off-by: Ramiro Oliveira
---
drivers/staging/dgnc/dgnc_cls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
index 4e
This patch fixes the following warnings on ks7010_sdio.c
1. printk() should include KERN_ facility level
2. Prefer [subsystem eg: netdev]_err([subsystem]dev, ...
then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
Signed-off-by: Sabitha George
---
drivers/staging/ks7010/ks7010_sdio.c |
Ok Joe,
Thanks and sorry for the annoyance.
On Mon, Sep 26, 2016 at 09:26:12AM -0700, Joe Perches wrote:
> On Mon, 2016-09-26 at 11:56 -0300, Martin wrote:
> > Fix coding style issue "multiple blank lines"
> > detected by checkpatch.pl in threefish_block.c file.
>
> This has been submitted an
This removes checkpatch.pl warnings:
WARNING: Block comments should align the * on each line
Signed-off-by: Grygorii Maistrenko
---
drivers/staging/slicoss/slic.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss
On Mon, 2016-09-26 at 11:56 -0300, Martin wrote:
> Fix coding style issue "multiple blank lines"
> detected by checkpatch.pl in threefish_block.c file.
This has been submitted and rejected a couple times already.
The extra blank lines are to separate blocks.
Whatever the blocks are, perhaps _addi
- Fixed a sparse warning:
wilc_debugfs.c:32:10: warning: symbol 'WILC_DEBUG_LEVEL' was not declared.
Should it be static?
Signed-off-by: Matias Mucciolo
---
drivers/staging/wilc1000/wilc_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wil
On Mon, Sep 26, 2016 at 12:44:24PM -0300, Matias Mucciolo wrote:
>
> hi
>
> sorry...this is the full warning:
>
> drivers/staging/wilc1000/wilc_debugfs.c:32:10: warning: symbol
> 'WILC_DEBUG_LEVEL' was not declared. Should it be static?
the "should it be static" is the key here, right? Care t
On Mon, Sep 26, 2016 at 12:15:18PM -0300, Matias Mucciolo wrote:
>
> - Fixed a sparse warning: symbol 'WILC_DEBUG_LEVEL' was not declared.
I don't think that was the full warning, as that does not make much
sense to me, does it to you?
thanks,
greg k-h
__
From: Jon Frisch
This patch removes the driver version and the version.h include
from visorchipset.c
Signed-off-by: Jon Frisch
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchipset.c | 5 +
1 file changed, 1 insertion(+), 4 deletio
hi
sorry...this is the full warning:
drivers/staging/wilc1000/wilc_debugfs.c:32:10: warning: symbol
'WILC_DEBUG_LEVEL' was not declared. Should it be static?
--
Matias Mucciolo
Area de Infraestructura.
Piedras 737 C.A.B.A
SUTEBA
On Monday 26 September 2016 17:37:33 Greg Kroah-Hartman wr
- Fixed a sparse warning: symbol 'WILC_DEBUG_LEVEL' was not declared.
Signed-off-by: Matias Mucciolo
---
drivers/staging/wilc1000/wilc_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
b/drivers/staging/wilc1000/wilc_debugfs.c
From: Jon Frisch
This patch ensures that consistent verbiage is used in the
MODULE_DESCRIPTION text (reported by 'modinfo') for all of
the Unisys s-Par drivers.
Signed-off-by: Jon Frisch
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
drivers/staging/
From: Jon Frisch
This patch removes version.h and the last version.h
include in visorchannel.c.
Signed-off-by: Jon Frisch
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/version.h | 45 --
drivers/staging/unisys/v
From: Jon Frisch
This patch removes the driver version from visornic_main.c
Signed-off-by: Jon Frisch
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Kershner
---
drivers/staging/unisys/visornic/visornic_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/driver
From: Jon Frisch
This patch removes the all instances of the driver version from
struct visor_driver. This includes removing version, vertag
(a human readable version string of the driver version) and
version_attr from struct visor_driver. This resulted in removing the
bus attributes and driver a
From: Jon Frisch
This patch removes the driver version and the version.h include
from visorinput.c
Signed-off-by: Jon Frisch
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorinput/visorinput.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/d
From: David Binder
Per Documentation/CodingStyle, function names that convey an action or an
imperative command should return an integer. This commit converts the
visorbus API function, visorchannel_signalinsert(), to returning integer
values. All uses of this function are updated accordingly.
S
Fix coding style issue "multiple blank lines"
detected by checkpatch.pl in threefish_block.c file.
Signed-off-by: Martin
---
drivers/staging/skein/threefish_block.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/staging/skein/threefish_block.c
b/drivers/staging/sk
From: David Binder
Per Documentation/CodingStyle, function names that convey an action or an
imperative command should return an integer value. This commit changes
several functions and a macro, internal to visorchannel.c, to follow this
paradigm. These changes will be necessary later on to chang
This patch series removes the Unisys s-Par specific versioning
and replaces it where approrpriate with the kernel version.
This series also converts several bool return types to the
more appropriate error returns. It does not completely fix error
handling with the new functions; that will be addre
From: David Binder
Per Documentation/CodingStyle, function names that convey an action or an
imperative command should return an integer. This commit converts the
visorbus API function, visorchannel_signalremove(), to returning integer
values. All uses of this function are updated accordingly.
S
From: wang di
The port to upstream dropped handling the LMV_MAGIC_V1
case for ll_dir_getstripe. This adds it back.
Signed-off-by: wang di
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-on: http://review.whamcloud.com/7228
Reviewed-by: Andreas Dilger
Reviewed-by: John L. Hamm
shifted over comment block one space
Signed-off-by: Darryl T. Agostinelli
---
drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.c
b/drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.c
shifted over comment block one space
Signed-off-by: Darryl T. Agostinelli
---
drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.c
b/drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.c
2016-09-26 1:53 GMT+01:00 Larry Finger :
> On 09/25/2016 06:00 PM, Gonçalo Salazar wrote:
>>
>> Fixed a block comment indentation in the rtl8712 usb_intf.c file.
>> Made this as a first commit.
>> Resubmitted with updated subject.
>>
>> Please let me know of any feedback you have.
>
>
> I missed th
On Mon, Sep 26, 2016 at 1:24 PM, Greg KH wrote:
> On Mon, Sep 26, 2016 at 01:11:50PM +0300, Yannis Damigos wrote:
>> Hi Greg,
>>
>> On Fri, Sep 23, 2016 at 3:06 PM, Greg KH wrote:
>> >
>> > Have you tested that this works?
>> >
>>
>> In order to test the change I need a board with Hi6220 SoC.
>>
On Mon, Sep 26, 2016 at 01:11:50PM +0300, Yannis Damigos wrote:
> Hi Greg,
>
> On Fri, Sep 23, 2016 at 3:06 PM, Greg KH wrote:
> >
> > Have you tested that this works?
> >
>
> In order to test the change I need a board with Hi6220 SoC.
> If I do not own the hardware to test the change, how shoul
Hi Greg,
On Fri, Sep 23, 2016 at 3:06 PM, Greg KH wrote:
>
> Have you tested that this works?
>
In order to test the change I need a board with Hi6220 SoC.
If I do not own the hardware to test the change, how should I proceed?
thanks,
Yannis
___
devel
On Mon, 26 Sep 2016 09:47:19 +0200
Andrey Shvetsov wrote:
> On Sun, Sep 25, 2016 at 03:41:11PM +, Wei Yongjun wrote:
> > From: Wei Yongjun
> >
> > Fix to return a negative error code from the audio_set_hw_params() error
> > handling case instead of 0, as done elsewhere in this function.
> >
On Sun, Sep 25, 2016 at 03:27:54PM -0400, Brian Masney wrote:
> Add new macros: IIO_ATTR_RO, IIO_ATTR_WO, IIO_ATTR_RW,
> IIO_DEVICE_ATTR_RO, IIO_DEVICE_ATTR_WO and IIO_DEVICE_ATTR_RW to reduce
> the amount of boiler plate code that is needed for creating new
> attributes. This mimics the *_RO, *_WO
On Mon, Sep 26, 2016 at 12:03:04AM -0500, Darryl T. Agostinelli wrote:
> Signed-off-by: Darryl T. Agostinelli
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I can't take patches without any changelog text :(
__
On Sun, Sep 25, 2016 at 03:41:11PM +, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Fix to return a negative error code from the audio_set_hw_params() error
> handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun
Signed-off-by: Andrey Shvetsov
> ---
>
47 matches
Mail list logo
