Fix checkpatch.pl warning:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Wayne Porter
---
drivers/staging/android/ion/hisilicon/hi6220_ion.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Alignment fixes
Signed-off-by: Wayne Porter
---
drivers/staging/android/ion/hisilicon/hi6220_ion.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c
Cleanup extra line found by checkpatch.pl
Signed-off-by: Wayne Porter
---
drivers/staging/android/uapi/ion_test.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/android/uapi/ion_test.h
b/drivers/staging/android/uapi/ion_test.h
index ffef06f..480242e
Fixed coding style issue.
Signed-off-by: Nadim Almas
---
drivers/staging/dgnc/dgnc_neo.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
index e794056..bc15584 100644
---
On Fri, Sep 30, 2016 at 07:53:00PM +0100, Malcolm Priestley wrote:
> On 28/09/16 08:40, Dan Carpenter wrote:
> >On Tue, Sep 27, 2016 at 02:52:49PM -0300, Martin Alonso wrote:
> >>Change the type and uses of rx_rate.
> >>
> >>Signed-off-by: Martin Alonso
> >>---
> >>
Fix code indentation warnings detected by checkpatch.pl
Signed-off-by: Wayne Porter
---
drivers/staging/rts5208/ms.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
On 28/09/16 08:40, Dan Carpenter wrote:
On Tue, Sep 27, 2016 at 02:52:49PM -0300, Martin Alonso wrote:
Change the type and uses of rx_rate.
Signed-off-by: Martin Alonso
---
drivers/staging/vt6656/dpc.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Thursday, September 29, 2016 2:22 AM
> To: KY Srinivasan ; Long Li
> Cc: Haiyang Zhang ;
> de...@linuxdriverproject.org;
When checking for command flags field if response is not available we
really need to compare it with the right define and not bitwise AND it.
smatch warn:
drivers/staging/greybus/sdio.c:481 gb_sdio_command()
warn: bitwise AND condition is false here
Reported-by: Dan Carpenter
Fix several warnings reported by the good tool smatch (another tool to add to
the git pre-commit hook).
They are related to the greybus sdio and light protocol drivers.
Cheers,
Rui
v1 -> v2:
Dan Carpenter:
. use sizeof channel::attrs pointer instead of struct attribute itself.
Rui Miguel
Fix allocation of attributes with the correct size, this also fix smatch
warning:
drivers/staging/greybus/light.c:293 channel_attr_groups_set()
warn: double check that we're allocating correct size: 8 vs 16
Signed-off-by: Rui Miguel Silva
---
drivers/staging/greybus/light.c |
Even though we trust leds core that the pointers should be valid, we are
safer to check delay_{on|off} before use.
Also, this avoid a smatch warning:
drivers/staging/greybus/light.c:484 gb_blink_set()
warn: variable dereferenced before check 'delay_on' (see line 476)
Signed-off-by: Rui Miguel
HiDan,
On Fri, Sep 30, 2016 at 09:04:30PM +0300, Dan Carpenter wrote:
On Fri, Sep 30, 2016 at 06:24:06PM +0100, Rui Miguel Silva wrote:
Fix allocation of attributes with the correct size, this also fix smatch
warning:
drivers/staging/greybus/light.c:293 channel_attr_groups_set()
warn: double
On Fri, Sep 30, 2016 at 06:24:06PM +0100, Rui Miguel Silva wrote:
> Fix allocation of attributes with the correct size, this also fix smatch
> warning:
>
> drivers/staging/greybus/light.c:293 channel_attr_groups_set()
> warn: double check that we're allocating correct size: 8 vs 16
>
>
When checking the value of delay_on to set the channel as active, it was
checked the pointer and not the value, as it should be.
Fixes: cc43368a3c ("greybus: lights: Control runtime pm suspend/resume on AP
side")
Signed-off-by: Rui Miguel Silva
---
Fix allocation of attributes with the correct size, this also fix smatch
warning:
drivers/staging/greybus/light.c:293 channel_attr_groups_set()
warn: double check that we're allocating correct size: 8 vs 16
Signed-off-by: Rui Miguel Silva
---
drivers/staging/greybus/light.c |
Even though we trust leds core that the pointers should be valid, we are
safer to check delay_{on|off} before use.
Also, this avoid a smatch warning:
drivers/staging/greybus/light.c:484 gb_blink_set()
warn: variable dereferenced before check 'delay_on' (see line 476)
Signed-off-by: Rui Miguel
When checking for command flags field if response is not available we
really need to compare it with the right define and not bitwise AND it.
smatch warn:
drivers/staging/greybus/sdio.c:481 gb_sdio_command()
warn: bitwise AND condition is false here
Reported-by: Dan Carpenter
Fix several warnings reported by the good tool smatch (another tool to add to
the git pre-commit hook).
They are related to the greybus sdio and light protocol drivers.
Cheers,
Rui
Rui Miguel Silva (3):
staging: greybus: sdio: fix cmd_flags check for none response
staging: greybus:
Fix following static checker warning:
drivers/staging/rtl8188eu/os_dep/usb_intf.c:311 rtw_resume_process()
error: double unlock 'mutex:>mutex_lock'
Fixes: eaf47b713b60 ("staging: rtl8188eu: fix missing unlock on
error in rtw_resume_process()")
Reported-By: Dan Carpenter
It is a declaration of the non-existent function.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/drv_types.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/drv_types.h
This member does not used.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 1 -
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
GEN_EVT_CODE is redundant macro.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c| 10 ++---
drivers/staging/rtl8188eu/include/rtw_event.h| 2 -
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 52
3 files
This macro does not used.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_mlme_ext.h
b/drivers/staging/rtl8188eu/include/rtw_mlme_ext.h
index
prframe is (void *), but function used only with (struct recv_frame *).
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 5 ++---
drivers/staging/rtl8188eu/include/rtl8188e_recv.h | 3 ++-
2 files changed, 4 insertions(+), 4 deletions(-)
These macros does not used.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/drv_types.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/drv_types.h
b/drivers/staging/rtl8188eu/include/drv_types.h
index
GEN_CMD_CODE is redundant macro.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 24 +--
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 14 +++---
drivers/staging/rtl8188eu/include/rtw_cmd.h | 62 +--
3
GEN_MLME_EXT_HANDLER is redundant macro.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 32 +++-
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_mlme_ext.h
Remove multiple blank lines as reported by checkpatch
Signed-off-by: Ramiro Oliveira
---
drivers/staging/fsl-mc/bus/dpmcp.c | 1 -
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/dpmcp.c
Align the * in some block comments as reported by checkpatch.
Signed-off-by: Ramiro Oliveira
---
drivers/staging/fsl-mc/bus/dpbp.c | 60 ++---
drivers/staging/fsl-mc/bus/dpmng.c| 60 ++---
drivers/staging/fsl-mc/bus/dprc.c
This set of patches corrects some errors reported by checkpatch in
drivers/staging/fsl-mc
v2: Split the patch in 2 parts, one for unaligned * in block comments,
other for multiple blank lines.
Ramiro Oliveira (2):
Staging: fsl-mc: Fix unaligned * in block comments
Staging: fsl-mc: Remove
On Fri, Sep 30, 2016 at 03:43:18PM +0530, Aditya Shankar wrote:
> This reverts commit 2518ac59eb27 ("staging: wilc1000: Replace kthread
> with workqueue for host interface")
>
> This commit breaks wilc1000 driver init. A crash was seen
> everytime the wlan interface was brought up and wilc device
On Fri, Sep 30, 2016 at 12:13:02PM +0100, Ramiro Oliveira wrote:
> This patch corrects some errors reported using checkpatch such as
> unaligned * in some block comments and multiple blank lines
Please only do one type of thing at a time, so break this up into
multiple patches.
thanks,
greg k-h
I have not been able to try out your second patch.
So once that happens you can add my name.
Cathy
On 09/27/2016 07:54 PM, Long Li wrote:
Thanks for pointing that out.
If you don't mind, I will also add "Tested-by: Cathy Avery ".
-Original Message-
From: devel
Hello Martyn Welch,
The patch 658bcdae9c67: "vme: Adding Fake VME driver" from Jul 7,
2016, leads to the following static checker warning:
drivers/vme/bridges/vme_fake.c:338 fake_master_set()
warn: 'spin_lock:>lock' is sometimes locked here and sometimes
unlocked.
Hello Wei Yongjun,
The patch eaf47b713b60: "staging: rtl8188eu: fix missing unlock on
error in rtw_resume_process()" from Aug 26, 2016, leads to the
following static checker warning:
drivers/staging/rtl8188eu/os_dep/usb_intf.c:311 rtw_resume_process()
error: double unlock
This patch corrects some errors reported using checkpatch such as
unaligned * in some block comments and multiple blank lines
Signed-off-by: Ramiro Oliveira
---
drivers/staging/fsl-mc/bus/dpbp.c | 60 ++---
drivers/staging/fsl-mc/bus/dpmng.c
Hi Dan,
On Fri, Sep 30, 2016 at 12:55:59PM +0300, Dan Carpenter wrote:
Hello Rui Miguel Silva,
The patch 3b6ecd6de6b4: "greybus: sdio: extend sdio implementation"
from Jun 22, 2015, leads to the following static checker warning:
drivers/staging/greybus/sdio.c:481 gb_sdio_command()
Align the * on each line of block comments as reported by checkpatch
Signed-off-by: Ramiro Oliveira
---
drivers/staging/comedi/drivers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
On Fri, Sep 30, 2016 at 3:25 PM, Dan Carpenter wrote:
> Hello Rui Miguel Silva,
>
> The patch 3b6ecd6de6b4: "greybus: sdio: extend sdio implementation"
> from Jun 22, 2015, leads to the following static checker warning:
>
> drivers/staging/greybus/sdio.c:481
Hello Rui Miguel Silva,
The patch 3b6ecd6de6b4: "greybus: sdio: extend sdio implementation"
from Jun 22, 2015, leads to the following static checker warning:
drivers/staging/greybus/sdio.c:481 gb_sdio_command()
warn: bitwise AND condition is false here
ion_alloc may get into slow path to get free page,
the call stack:
__alloc_pages_slowpath
ion_page_pool_alloc_pages
alloc_buffer_page
ion_system_heap_allocate
ion_buffer_create <-- hold ion_device->lock
ion_alloc
after that, kernel invokes low-memory killer to kill some apps in
order to free
42 matches
Mail list logo