From: Long Li
A PCI_EJECT message can arrive at the same time we are calling
pci_scan_child_bus in the workqueue for the previous PCI_BUS_RELATIONS message
or in create_root_hv_pci_bus(), in this case we could potentailly modify the
bus from multiple places. Properly lock the bus access.
Than
From: Long Li
hv_pci_devices_present is called in hv_pci_remove when we remove a PCI device
from host (e.g. by disabling SRIOV on a device). In hv_pci_remove, the bus is
already removed before the call, so we don't need to rescan the bus in the
workqueue scheduled from hv_pci_devices_present.
El 2016年10月03日 a las 20:18, Joe Perches escribió:
On Mon, 2016-10-03 at 20:12 +0200, Sergio Paracuellos wrote:
El 2016年10月03日 a las 18:16, Joe Perches escribió:
Perhaps better as hw->scanresults = kmemdup(inf, sizeof(*inf),
GFP_ATOMIC);
I agree. But because all the code is full of sizeo
On Monday 03 October 2016 04:21 PM, Sidhant Gupta wrote:
> Fixes a comment coding style warning by adding 2 blank lines. Issue
> found by checkpatch.
>
> Signed-off-by: Sidhant Gupta
Reviewed-by: Vaishali Thakkar
> ---
>
> Changes since v3:
> * Corrected checkpatch.pl error earlier caused b
On Mon, Oct 3, 2016 at 8:15 PM, Hisao Tanabe wrote:
> This patch fix the coding style problem of block comment detected by the
> checkpatch.pl.
>
> WARNING: Block comments use a trailing */ on a separate line
>
> Signed-off-by: Hisao Tanabe
> ---
> drivers/staging/greybus/arche-apb-ctrl.c | 8 ++
On Mon, 2016-10-03 at 23:17 +, Wayne Porter wrote:
> Checkpatch detected multiple instances of logical continuation warnings
[]
> diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
[]
> @@ -819,11 +819,11 @@ static int reset_xd(struct rtsx_chip *chip)
>
Covert CamelCase as checkpatch suggests
Signed-off-by: Wayne Porter
---
drivers/staging/rts5208/xd.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index ccc5dd9..ad16672 10064
Checkpatch found multiple assignments on one line so move
them to their own lines.
Signed-off-by: Wayne Porter
---
drivers/staging/rts5208/xd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index ad16672..f1b1090
Checkpatch recommended changes
Signed-off-by: Wayne Porter
---
drivers/staging/rts5208/xd.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index 4d8733f..ccc5dd9 100644
--- a/drivers/staging/rts5208/xd.c
Issues found with checkpatch
Signed-off-by: Wayne Porter
---
drivers/staging/rts5208/xd.c | 64 ++--
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index 604740f..4d8733f 100644
-
Checkpatch detected multiple instances of logical continuation warnings
Signed-off-by: Wayne Porter
---
drivers/staging/rts5208/xd.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index
Coding style checks found by checkpatch
Signed-off-by: Wayne Porter
---
drivers/staging/rts5208/xd.c | 332 +++
1 file changed, 179 insertions(+), 153 deletions(-)
diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index 1fab4ee..e3a
Convert CamelCase to recommended style.
Signed-off-by: Wayne Porter
---
drivers/staging/rts5208/xd.c | 8
drivers/staging/rts5208/xd.h | 8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index 1de02bb..
Change alignment to match open parenthesis
Signed-off-by: Wayne Porter
---
drivers/staging/rts5208/xd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rts5208/xd.h b/drivers/staging/rts5208/xd.h
index 675b0bf..33ad1f4 100644
--- a/drivers/staging/rts5208/xd.h
This patchset is just clean-up in xd.c and xd.h in the rts5208 driver.
All checkpatch.pl issues have been resolved except for lines over 80
characters. Most of those should be refactored.
Wayne Porter (8):
staging: rts5208: Fix CamelCase found by checkpatch
staging: rts5208: xd.h: Alignment fi
On Sun, Oct 02, 2016 at 02:30:45AM +0530, Harman Kalra wrote:
> static int iss_video_queue_setup(struct vb2_queue *vq,
> - unsigned int *count, unsigned int *num_planes,
> - unsigned int sizes[], struct device
> *alloc_devs[])
> +
El 2016年10月03日 a las 18:16, Joe Perches escribió:
On Mon, 2016-10-03 at 18:04 +0200, Sergio Paracuellos wrote:
This patch fix the following checkpatch.pl warnings in prism2sta.c:
WARNING: line over 80 characters
[]
diff --git a/drivers/staging/wlan-ng/prism2sta.c
b/drivers/staging/wlan-ng/p
On Mon, 2016-10-03 at 18:04 +0200, Sergio Paracuellos wrote:
> This patch fix the following checkpatch.pl warnings in prism2sta.c:
> WARNING: line over 80 characters
[]
> diff --git a/drivers/staging/wlan-ng/prism2sta.c
> b/drivers/staging/wlan-ng/prism2sta.c
[]
> @@ -1099,7 +1101,8 @@ static void
This patch fix the following sparse warnings in prism2fw.c:
warning: memset with byte count of 12
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/prism2fw.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2fw.c
b/dri
This patch fix the following checkpatch.pl warnings in prism2mgmt.c:
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/prism2mgmt.c | 518 ++---
This patch fix the following checkpatch.pl warnings in prism2sta.c:
WARNING: line over 80 characters
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/prism2sta.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2sta.c
b/drive
This patch fix the following checkpatch.pl warnings in p80211wep.c:
WARNING: line over 80 characters
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211wep.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211wep.c
b/drivers/st
This patch fix the following checkpatch.pl warnings in hfa384x_usb.c:
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x_usb.c | 2370 +--
Fixed coding style issue by replacing ENOSYS with EINVAL.
This patch fix the following checkpatch.pl warnings in p80211netdev.c:
WARNING: ENOSYS means 'invalid syscall nr' and nothing else
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211netdev.c | 6 +++---
1 file changed, 3
This patch fix the following checkpatch.pl warnings in hfa384x_usb.c:
WARNING: line over 80 characters
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x_usb.c | 71 +++
1 file changed, 38 insertions(+), 33 deletions(-)
diff --git a/drivers/sta
This patch fix the following checkpatch.pl warnings in p80211netdev.c:
WARNING: line over 80 characters
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211netdev.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211netdev.c
This patch series fix some of the following checkpatch.pl reported warnings:
WARNING: line over 80 characters
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
WARNING: ENOSYS means 'invalid syscall nr' and nothing else
Sergio Para
This patch fixes the following checkpatch.pl warning in p80211req.h
Block comments should align the * on each line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211req.h | 90 ++---
1 file changed, 45 insertions(+), 45 deletions(-)
diff --git a
This patch fixes the following checkpatch.pl warning in p80211conv.h:
Block comments should align the * on each line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211conv.h | 100 +--
1 file changed, 50 insertions(+), 50 deletions(-)
diff --git
This patch fixes the following checkpatch.pl warning in p80211netdev.h
Block comments should align the * on each line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211netdev.h | 100 -
1 file changed, 50 insertions(+), 50 deletions(-)
diff --gi
This patch fixes the following checkpatch.pl warning in p80211ioctl.h
Block comments should align the * on each line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211ioctl.h | 120 +-
1 file changed, 60 insertions(+), 60 deletions(-)
diff --git
This patch fixes the following checkpatch.pl warning in p80211msg.h
Block comments should align the * on each line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211msg.h | 90 ++---
1 file changed, 45 insertions(+), 45 deletions(-)
diff --git a
This patch fixes the following checkpatch.pl warning in p80211hdr.h:
Block comments should align the * on each line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211hdr.h | 114 ++--
1 file changed, 57 insertions(+), 57 deletions(-)
diff --git
This patch fixes the following checkpatch.pl warning in p80211mgmt.h:
Block comments should align the * on each line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211mgmt.h | 194 +--
1 file changed, 97 insertions(+), 97 deletions(-)
diff --g
This patch fixes the following checkpatch.pl warning in prism2mgmt.h
Block comments should align the * on each line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/prism2mgmt.h | 122 ++-
1 file changed, 62 insertions(+), 60 deletions(-)
diff --git
This patch fixes the following checkpatch.pl warning in p80211metadef.h
Block comments should align the * on each line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211metadef.h | 88 -
1 file changed, 44 insertions(+), 44 deletions(-)
diff --g
This patch series fix checkpatch.pl script reported warning
Block comments should align the * on each line
Sergio Paracuellos (9):
staging: wlang-ng: fix block comments style in p80211conv.h
staging: wlang-ng: fix block comments style in p80211hdr.h
staging: wlang-ng: fix block comments style
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef CTLX_STATE
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 3 +--
drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-
2 files changed, 2 insertions(
This patch fix the following checkpatch.pl warnings in p80211wep.c:
WARNING: Block comments should align the * on each line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211wep.c | 90 ++---
1 file changed, 45 insertions(+), 45 deletions(-)
dif
This patch fix the following checkpatch.pl warnings in prism2sta.c:
WARNING: Block comments should align the * on each line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/prism2sta.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff
This patch fix the following checkpatch.pl warnings in prism2fw.c
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/prism2fw.c | 485 +++---
This patch fix the following checkpatch.pl warnings in prism2mib.c:
WARNING: Block comments should align the * on each line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/prism2mib.c | 100 ++--
1 file changed, 50 insertions(+), 50 deletions(-)
dif
This patch fix the following checkpatch.pl warnings in p80211req.c:
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211req.c | 166 ++-
This patch fix the following checkpatch.pl warnings in p80211netdev.c:
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211netdev.c | 613 +
This patch fix the following checkpatch.pl warnings in p80211conv.c:
WARNING: Block comments should align the * on each line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211conv.c | 318 +--
1 file changed, 159 insertions(+), 159 deletions(-)
This patch fix the following checkpatch.pl warnings in p80211req.c:
WARNING: line over 80 characters
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211req.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211req.c
b/drivers/
This patch fix the coding style problem of block comment detected by the
checkpatch.pl.
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Hisao Tanabe
---
drivers/staging/greybus/arche-apb-ctrl.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
On Mon, Oct 3, 2016 at 4:21 PM, Sidhant Gupta wrote:
> Fixes a comment coding style warning by adding 2 blank lines. Issue
> found by checkpatch.
>
> Signed-off-by: Sidhant Gupta
> ---
>
> Changes since v3:
> * Corrected checkpatch.pl error earlier caused by this patch.
>
> drivers/staging/greyb
On Mon, Oct 03, 2016 at 04:21:09PM +0530, Sidhant Gupta wrote:
> Fixes a comment coding style warning by adding 2 blank lines. Issue
> found by checkpatch.
>
> Signed-off-by: Sidhant Gupta
Acked-by: Johan Hovold
Thanks,
Johan
___
devel mailing list
de
Fixes a comment coding style warning by adding 2 blank lines. Issue
found by checkpatch.
Signed-off-by: Sidhant Gupta
---
Changes since v3:
* Corrected checkpatch.pl error earlier caused by this patch.
drivers/staging/greybus/arche-apb-ctrl.c | 6 --
1 file changed, 4 insertions(+), 2 dele
Em Sat, 1 Oct 2016 16:37:46 -0700
Wayne Porter escreveu:
> Checks found by checkpatch
>
> Signed-off-by: Wayne Porter
> ---
> drivers/staging/media/omap4iss/iss_regs.h | 76
> +++
> 1 file changed, 38 insertions(+), 38 deletions(-)
>
> diff --git a/drivers/staging
On Monday 03 Oct 2016 06:58:22 Mauro Carvalho Chehab wrote:
> Em Sat, 1 Oct 2016 16:37:46 -0700 Wayne Porter escreveu:
> > Checks found by checkpatch
> >
> > Signed-off-by: Wayne Porter
> > ---
> >
> > drivers/staging/media/omap4iss/iss_regs.h | 76 --
> > 1 file changed
Hi Wayne,
Thank you for the patch.
On Saturday 01 Oct 2016 16:37:46 Wayne Porter wrote:
> Checks found by checkpatch
>
> Signed-off-by: Wayne Porter
> ---
> drivers/staging/media/omap4iss/iss_regs.h | 76 +---
> 1 file changed, 38 insertions(+), 38 deletions(-)
>
> diff
Hello Harman,
Thank you for the patch.
The subject of your commit message should at least contain the name of the
driver. Furthermore, you can mention that the patch originates from warnings
output by checkpatch.pl, but the subject should describe what you fix (in this
case what type of warnin
On Fri, Sep 30, 2016 at 11:54 PM, Rui Miguel Silva wrote:
> Even though we trust leds core that the pointers should be valid, we are
> safer to check delay_{on|off} before use.
As these routines are getting called from core, I am not sure if it will
be right to have such checks.
Though, I saw th
On Fri, Sep 30, 2016 at 11:54 PM, Rui Miguel Silva wrote:
> Fix allocation of attributes with the correct size, this also fix smatch
> warning:
>
> drivers/staging/greybus/light.c:293 channel_attr_groups_set()
> warn: double check that we're allocating correct size: 8 vs 16
>
> Signed-off-by: Rui
On Fri, Sep 30, 2016 at 11:54 PM, Rui Miguel Silva wrote:
> When checking for command flags field if response is not available we
> really need to compare it with the right define and not bitwise AND it.
>
> smatch warn:
> drivers/staging/greybus/sdio.c:481 gb_sdio_command()
> warn
Hell no. If you had actually read the changelog you'd see that there
is a reason the functions went away, and simply calling the underlying
methods (which also will go away) will not fix it.
Please go back reading the changelogs, and while we're at it read some
basic introductions into the RDMA p
58 matches
Mail list logo