[patch] staging: android/ion: testing the wrong variable

2016-10-11 Thread Dan Carpenter
We're testing "pdev" but we intended to test "heap_pdev". This is a static checker fix and it's unlikely that anyone is affected by this bug. Fixes: 13439479c7de ('staging: ion: Add files for parsing the devicetree') Signed-off-by: Dan Carpenter diff --git a/drivers/staging/android/ion/ion_of.c

Re: [PATCH 32/41] staging: lustre: llite: restart short read/write for normal IO

2016-10-11 Thread Greg Kroah-Hartman
On Wed, Oct 12, 2016 at 12:22:35AM +0100, James Simmons wrote: > > > On Sun, Oct 02, 2016 at 10:28:28PM -0400, James Simmons wrote: > > > From: Bobi Jam > > > > > > If normal IO got short read/write, we'd restart the IO from where > > > we've accomplished until we meet EOF or error happens. > >

Re: [PATCH] drivers: staging: greybus: audio_topology.c: Fixed CHECKS for brace issues

2016-10-11 Thread Vaibhav Agarwal
On Wed, Oct 12, 2016 at 5:19 AM, Chase Metzger wrote: > Added braces for else and else if statements where checkpatch complained. > > Signed-off-by: Chase Metzger > --- > drivers/staging/greybus/audio_topology.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/driv

Re: [PATCH] drivers: staging: greybus: audio_manager_sysfs.c: Fixed CHECK for brace issue

2016-10-11 Thread Vaibhav Agarwal
On Wed, Oct 12, 2016 at 4:52 AM, Chase Metzger wrote: > Added braces to else and else if statements where checkpatch complained. > > Signed-off-by: Chase Metzger > --- > drivers/staging/greybus/audio_manager_sysfs.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/dr

Re: [RFC 6/6] drivers: staging: ion: add ION_IOC_TAG ioctl

2016-10-11 Thread Hillf Danton
On Wednesday, October 12, 2016 7:50 AM Ruchi Kandoi wrote: > +/** > + * struct ion_fd_data - metadata passed from userspace for a handle s/fd/tag/ ? > + * @handle: a handle > + * @tag: a string describing the buffer > + * > + * For ION_IOC_TAG userspace populates the handle field with > + * the

[PATCH 2/2] Staging: greybus: uart: Use gbphy_dev->dev instead of bundle->dev

2016-10-11 Thread Viresh Kumar
Some of the print messages are using the incorrect device pointer, fix them. Signed-off-by: Viresh Kumar --- drivers/staging/greybus/uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index 5ee7954bd9f9..2633

[PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev

2016-10-11 Thread Viresh Kumar
Some of the print messages are using the incorrect device pointer, fix them. Signed-off-by: Viresh Kumar --- drivers/staging/greybus/gpio.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c index 5e06e4229e42

Re: [PATCH v2] RFC: staging: greybus: shape up greybus GPIO

2016-10-11 Thread Viresh Kumar
I was looking to exactly do thanks, thanks for doing it before us :) On 10-10-16, 10:39, Linus Walleij wrote: > static int gb_gpio_probe(struct gbphy_device *gbphy_dev, >const struct gbphy_device_id *id) > { > @@ -690,7 +556,6 @@ static int gb_gpio_probe(struct gbphy_devi

Re: [RFC 0/6] Module for tracking/accounting shared memory buffers

2016-10-11 Thread Rob Clark
On Tue, Oct 11, 2016 at 7:50 PM, Ruchi Kandoi wrote: > This patchstack introduces a new "memtrack" module for tracking and accounting > memory exported to userspace as shared buffers, like dma-buf fds or GEM > handles. btw, I wouldn't care much about the non-dmabuf case.. dri2/flink is kind of l

Re: [RFC 0/6] Module for tracking/accounting shared memory buffers

2016-10-11 Thread Al Viro
On Tue, Oct 11, 2016 at 04:50:04PM -0700, Ruchi Kandoi wrote: > memtrack maintains a per-process list of shared buffer references, which is > exported to userspace as /proc/[pid]/memtrack. Buffers can be optionally > "tagged" with a short string: for example, Android userspace would use this > ta

[RFC 5/6] memtrack: Add memtrack accounting for forked processes.

2016-10-11 Thread Ruchi Kandoi
When a process is forked, all the buffers are shared with the forked process too. Adds the functionality to add memtrack accounting for the forked processes. Forked process gets a copy of the mapped pages of the parent process. This patch makes sure that the new mapped pages are attributed to the

[RFC 0/6] Module for tracking/accounting shared memory buffers

2016-10-11 Thread Ruchi Kandoi
This patchstack introduces a new "memtrack" module for tracking and accounting memory exported to userspace as shared buffers, like dma-buf fds or GEM handles. Any process holding a reference to these buffers will keep the kernel from reclaiming its backing pages. mm counters don't provide a comp

[RFC 1/6] fs: add installed and uninstalled file_operations

2016-10-11 Thread Ruchi Kandoi
These optional file_operations notify a file implementation when it is installed or uninstalled from a task's fd table. This can be used for accounting of file-backed shared resources like dma-buf. This involves some changes to the __fd_install() and __close_fd() APIs to actually pass along the r

[PATCH] drivers: staging: greybus: audio_topology.c: Fixed CHECKS for brace issues

2016-10-11 Thread Chase Metzger
Added braces for else and else if statements where checkpatch complained. Signed-off-by: Chase Metzger --- drivers/staging/greybus/audio_topology.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging/greybus/audio

[PATCH] drivers: staging: greybus: audio_manager_sysfs.c: Fixed CHECK for brace issue

2016-10-11 Thread Chase Metzger
Added braces to else and else if statements where checkpatch complained. Signed-off-by: Chase Metzger --- drivers/staging/greybus/audio_manager_sysfs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/staging/greybu

Re: [PATCH 32/41] staging: lustre: llite: restart short read/write for normal IO

2016-10-11 Thread James Simmons
> On Sun, Oct 02, 2016 at 10:28:28PM -0400, James Simmons wrote: > > From: Bobi Jam > > > > If normal IO got short read/write, we'd restart the IO from where > > we've accomplished until we meet EOF or error happens. > > > > Signed-off-by: Bobi Jam > > Signed-off-by: Jinshan Xiong > > Intel-b

Re: [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace

2016-10-11 Thread Zach Brown
On Tue, Oct 11, 2016 at 02:14:07PM -0700, Stephen Hemminger wrote: > On Tue, 11 Oct 2016 15:26:18 -0500 > Zach Brown wrote: > > > Adding led support for phy causes namespace conflicts for some > > phy drivers. > > > > The marvel skge driver declared an enum for representing the states of > > Link

Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change

2016-10-11 Thread Andrew Lunn
> Andrew, are you happy with this implementation? Sorry, been to busy with other things to follow the discussion. What would be nice to see is a comment about how the link to LEDs in the PHYs is made. Often there is a couple of LEDs in the RJ45 socket driven by the PHY. They can show link, speed,

Re: [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace

2016-10-11 Thread Stephen Hemminger
On Tue, 11 Oct 2016 15:26:18 -0500 Zach Brown wrote: > Adding led support for phy causes namespace conflicts for some > phy drivers. > > The marvel skge driver declared an enum for representing the states of > Link LED Register. The enum contained constant LED_OFF which conflicted > with declart

[PATCH v4 2/3] net: phy: Encapsulate actions performed during link state changes into function phy_adjust_link

2016-10-11 Thread Zach Brown
During phy state machine state transitions some set of actions should occur whenever the link state changes. These actions should be encapsulated into a single function This patch adds the phy_adjust_link function, which is called whenever phydev->adjust_link would have been called before. Actions

[PATCH v4 0/3] Add support for led triggers on phy link state change

2016-10-11 Thread Zach Brown
Fix skge driver that declared enum contants that conflicted with enum constants in linux/leds.h Create function that encapsulates actions taken during the adjust phy link step of phy state changes. Add support for led triggers on phy link state changes by adding a config option. When set the conf

[PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change

2016-10-11 Thread Zach Brown
From: Josh Cartwright Create an option CONFIG_LED_TRIGGER_PHY (default n), which will create a set of led triggers for each instantiated PHY device. There is one LED trigger per link-speed, per-phy. This allows for a user to configure their system to allow a set of LEDs to represent link state

[PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace

2016-10-11 Thread Zach Brown
Adding led support for phy causes namespace conflicts for some phy drivers. The marvel skge driver declared an enum for representing the states of Link LED Register. The enum contained constant LED_OFF which conflicted with declartation found in linux/leds.h. LED_OFF changed to LED_REG_OFF Also ch

[PATCH] Staging:greybus:arche-apb-ctrl: fixed some coding style issue

2016-10-11 Thread Nadim Almas
fixed trailing */ Block comments and 80 character line limit coding style issue Signed-off-by: Nadim Almas --- drivers/staging/greybus/arche-apb-ctrl.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/gre

Re: [PATCH] Staging: iio: fix a MAINTAINERS entry

2016-10-11 Thread Jonathan Cameron
On 11/10/16 12:12, Dan Carpenter wrote: > The "drivers/" part of the path name was missing. > > Signed-off-by: Dan Carpenter Applied - thanks. Jonathan > > diff --git a/MAINTAINERS b/MAINTAINERS > index 0c7d973..63f15c9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -779,7 +779,7 @@ S:

Re: [bug report] staging: lustre: create striped directory

2016-10-11 Thread Wang, Di
Hello, On 10/11/16, 4:37 AM, "Dan Carpenter" wrote: >Hello wang di, > >The patch 2de353860782: "staging: lustre: create striped directory" >from Aug 16, 2016, leads to the following static checker warning: > > drivers/staging/lustre/lustre/llite/namei.c:294 ll_md_blocking_ast() > war

Re: [bug report] staging: lustre: lmv: try all stripes for unknown hash functions

2016-10-11 Thread Wang, Di
Hello, > > 376 tgt = lmv_locate_mds(lmv, op_data, &op_data->op_fid1); > 377 if (IS_ERR(tgt) && (PTR_ERR(tgt) != -EBADFD)) > 378 return PTR_ERR(tgt); > 379 > 380 /* > 381 * Both migrating dir and unknown hash dir need to try > 38

[bug report] staging: lustre: create striped directory

2016-10-11 Thread Dan Carpenter
Hello wang di, The patch 2de353860782: "staging: lustre: create striped directory" from Aug 16, 2016, leads to the following static checker warning: drivers/staging/lustre/lustre/llite/namei.c:294 ll_md_blocking_ast() warn: 'master_inode' isn't an ERR_PTR drivers/staging/lustre/l

[bug report] staging: lustre: lmv: try all stripes for unknown hash functions

2016-10-11 Thread Dan Carpenter
Hello wang di, The patch 893ab7479263: "staging: lustre: lmv: try all stripes for unknown hash functions" from Aug 16, 2016, leads to the following static checker warning: drivers/staging/lustre/lustre/lmv/lmv_intent.c:397 lmv_intent_lookup() error: 'tgt' dereferencing possible ER

[PATCH] Staging: iio: fix a MAINTAINERS entry

2016-10-11 Thread Dan Carpenter
The "drivers/" part of the path name was missing. Signed-off-by: Dan Carpenter diff --git a/MAINTAINERS b/MAINTAINERS index 0c7d973..63f15c9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -779,7 +779,7 @@ S: Supported F: drivers/iio/*/ad* X: drivers/iio/*/adjd* F: drivers/staging/

[bug report] staging: lustre: fix comparison between signed and unsigned

2016-10-11 Thread Dan Carpenter
Hello Dmitry Eremin, The patch 97cba1302d89: "staging: lustre: fix comparison between signed and unsigned" from Sep 18, 2016, leads to the following static checker warning: drivers/staging/lustre/lustre/osc/osc_request.c:973 osc_init_grant() warn: unsigned 'cli->cl_avail_grant' is

[PATCH] Staging: fbtft: Fix too many leading tabs warning

2016-10-11 Thread Gustavo A. R. Silva
This is a patch to the fb_agm1264k-fl.c file that fixes up the following issue: WARNING: Too many leading tabs - consider code refactoring Add new function iterate_diffusion_matrix() to refactor a piece of code inside write_vmem(). Signed-off-by: Gustavo A. R. Silva --- drivers/staging/fbtft/f

[staging:staging-testing 190/192] undefined reference to `dmam_alloc_coherent'

2016-10-11 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: b5596d52a3715a37d6d0875791d93ae5b73c6f21 commit: ecbc62fd441210e54e25fa9683422bbc0143049d [190/192] staging: vc04_services: add CONFIG_COMPILE_TEST ability config: m32r-allyesconfig (attached as .co