Re: [PATCH] staging: greybus: es2: fix arpc request size

2016-10-19 Thread Johan Hovold
On Wed, Oct 19, 2016 at 01:44:25PM +0100, Rui Miguel Silva wrote: > Fix size field of arpc message request by using the header size and not > the pointer size. > > Signed-off-by: Rui Miguel Silva Good catch, Rui. Guess the firmware is missing some sanity checks. Reviewed-by:

Re: [PATCH 5/7] iio: light: tsl2583: check return values from taos_chip_{on, off}

2016-10-19 Thread Brian Masney
On Wed, Oct 19, 2016 at 02:22:49PM +0300, Dan Carpenter wrote: > On Wed, Oct 19, 2016 at 06:32:08AM -0400, Brian Masney wrote: > > @@ -775,14 +778,20 @@ static ssize_t illuminance0_lux_table_store(struct > > device *dev, > > goto luxable_store_done; > > } > > > > - if

[PATCH] staging: greybus: es2: fix arpc request size

2016-10-19 Thread Rui Miguel Silva
Fix size field of arpc message request by using the header size and not the pointer size. Signed-off-by: Rui Miguel Silva --- drivers/staging/greybus/es2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/es2.c

Re: [PATCH 2/7] iio: light: tsl2583: change functions to only have a single exit point

2016-10-19 Thread Brian Masney
On Wed, Oct 19, 2016 at 02:08:59PM +0300, Dan Carpenter wrote: > On Wed, Oct 19, 2016 at 06:32:05AM -0400, Brian Masney wrote: > > Change the following functions to only have a single exit point: > > taos_i2c_read(), taos_als_calibrate(), taos_chip_on(), > > taos_gain_store(),

Re: [PATCH 6/7] iio: light: tsl2583: add locking to sysfs *_store() functions

2016-10-19 Thread Dan Carpenter
I appologize for laughing, but I am still secretly amused in my heart. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 6/7] iio: light: tsl2583: add locking to sysfs *_store() functions

2016-10-19 Thread Dan Carpenter
On Wed, Oct 19, 2016 at 06:32:09AM -0400, Brian Masney wrote: > @@ -778,6 +796,8 @@ static ssize_t illuminance0_lux_table_store(struct device > *dev, > goto luxable_store_done; > } > > + mutex_lock(>als_mutex); > + > if (chip->taos_chip_status ==

[PATCH] staging: unisys: visorbus: visorchannel: Refactor locking code to be statically deterministic.

2016-10-19 Thread Cathal Mullaney
This patch makes locking in visorchannel_signalempty statically deterministic. As a result this patch fixes the sparse warning: Context imbalance in 'visorchannel_signalempty' - different lock contexts for basic block. The logic of the locking code doesn't change but the layout of the original

Re: [PATCH 3/7] iio: light: tsl2583: use DEVICE_ATTR_{RO, RW, WO} macros

2016-10-19 Thread Dan Carpenter
What does illuminance0_ mean? Can we remove that? regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 5/7] iio: light: tsl2583: check return values from taos_chip_{on, off}

2016-10-19 Thread Dan Carpenter
On Wed, Oct 19, 2016 at 06:32:08AM -0400, Brian Masney wrote: > @@ -775,14 +778,20 @@ static ssize_t illuminance0_lux_table_store(struct > device *dev, > goto luxable_store_done; > } > > - if (chip->taos_chip_status == TSL258X_CHIP_WORKING) > -

Re: [PATCH 2/7] iio: light: tsl2583: change functions to only have a single exit point

2016-10-19 Thread Dan Carpenter
On Wed, Oct 19, 2016 at 06:32:05AM -0400, Brian Masney wrote: > Change the following functions to only have a single exit point: > taos_i2c_read(), taos_als_calibrate(), taos_chip_on(), > taos_gain_store(), taos_gain_available_show(), taos_luxtable_store() > and taos_probe(). > What's the point

Re: [PATCH 3/7] iio: light: tsl2583: use DEVICE_ATTR_{RO, RW, WO} macros

2016-10-19 Thread Peter Meerwald-Stadler
> Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO > macros to create the device attributes. great that you work on cleaning this up! the patch does a bit more than is claimed, it also renames stuff; eventually, a proper prefix ('tsl2583_') should be used... maybe you can

[PATCH 4/7] iio: light: tsl2583: return proper error code in sysfs store functions

2016-10-19 Thread Brian Masney
illuminance0_calibbias_store(), illuminance0_input_target_store(), and illuminance0_calibrate_store() did not return an error code when an invalid value was passed in. The input was checked to see if the input was valid, however the caller would not be notified that an invalid value was passed in.

[PATCH 3/7] iio: light: tsl2583: use DEVICE_ATTR_{RO, RW, WO} macros

2016-10-19 Thread Brian Masney
Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO macros to create the device attributes. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 117 ++-- 1 file changed, 57 insertions(+), 60 deletions(-)

[PATCH 1/7] iio: light: tsl2583: return proper error code

2016-10-19 Thread Brian Masney
taos_gain_store() and taos_als_calibrate() both have a code path where -1 was returned. This patch changes the code so that a proper error code is returned to make the code consistent with the error paths that are present within those same functions. Signed-off-by: Brian Masney

[PATCH 7/7] iio: light: tsl2583: fix concurrency issue in taos_get_lux()

2016-10-19 Thread Brian Masney
taos_get_lux() calls mutex_trylock(). If the lock could not be acquired, then chip->als_cur_info.lux is returned. The issue is that this value is updated while the mutex is held and could cause a half written value to be returned to the caller. This patch changes the call to mutex_trylock() with

[PATCH 5/7] iio: light: tsl2583: check return values from taos_chip_{on, off}

2016-10-19 Thread Brian Masney
The return values from taos_chip_on() and taos_chip_off() was not checked in several places. This patch adds proper error checking to these function calls. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 25 ++--- 1 file changed,

[PATCH 6/7] iio: light: tsl2583: add locking to sysfs *_store() functions

2016-10-19 Thread Brian Masney
The sysfs attributes modifies variables that are accessed elsewhere when a mutex is locked. Add locking to the sysfs *_store() functions to avoid a possible race condition when measurements are taken. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c |

[PATCH 2/7] iio: light: tsl2583: change functions to only have a single exit point

2016-10-19 Thread Brian Masney
Change the following functions to only have a single exit point: taos_i2c_read(), taos_als_calibrate(), taos_chip_on(), taos_gain_store(), taos_gain_available_show(), taos_luxtable_store() and taos_probe(). Signed-off-by: Brian Masney ---

[PATCH 3/3] tools: hv: remove unnecessary header files and netlink related code

2016-10-19 Thread Weibing Zhang
Remove unnecessary header files and netlink related code as the daemons do not use netlink to communicate with the kernel now. Signed-off-by: Weibing Zhang --- tools/hv/hv_fcopy_daemon.c | 7 --- tools/hv/hv_kvp_daemon.c | 7 --- 2 files changed, 14

[PATCH 2/3] tools: hv: fix a compile warning in snprintf

2016-10-19 Thread Weibing Zhang
hv_kvp_daemon.c: In function ‘kvp_mac_to_if_name’: hv_kvp_daemon.c:705:2: warning: format not a string literal and no format arguments [-Wformat-security] snprintf(dev_id, sizeof(dev_id), kvp_net_dir); ^ hv_kvp_daemon.c:705:2: warning: format not a string literal and no format arguments

[PATCH 1/3] tools: hv: remove unnecessary link flag

2016-10-19 Thread Weibing Zhang
The link flag pthread is not needed. Signed-off-by: Weibing Zhang --- tools/hv/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/hv/Makefile b/tools/hv/Makefile index a8c4644..0d1e61b 100644 --- a/tools/hv/Makefile +++

Re: [PATCH] tools: hv: clean up code, remove unnecessary header files and link flags

2016-10-19 Thread Dan Carpenter
On Wed, Oct 19, 2016 at 11:43:28AM +0800, Weibing Zhang wrote: > Remove unnecessary header files and netlink related code as the daemons > do not use netlink to communicate with the kernel now. > Fix a compile warning in snprintf. > Pthread is also not needed. > > Signed-off-by: Weibing Zhang

Re: [PATCH] staging: slicoss.ko: slicoss.c: Fixed incorrect argument type

2016-10-19 Thread Dan Carpenter
On Tue, Oct 18, 2016 at 02:03:31PM -0400, Ryan Swan wrote: > sparse produced > warning: incorrect type in argument 2 (different address spaces) > expected void const volatile [noderef] *src > got struct slic_stats *stats > > casting argument 2 to what is expected by memcpy_fromio() fixed this >

Re: [PATCH] [staging/comedi] use kernel integer types

2016-10-19 Thread Greg Kroah-Hartman
On Tue, Oct 18, 2016 at 06:46:05PM +, Thomas Weißschuh wrote: > Signed-off-by: Thomas Weißschuh I can't take patches without any changelog text, sorry. And your subject doesn't make much sense either :( thanks, greg k-h ___

Re: [PATCH] Staging: media: bcm2048: Use octal permissions '0444'

2016-10-19 Thread Greg KH
On Wed, Oct 19, 2016 at 01:34:44AM +0530, Shyam Saini wrote: > On Tue, 2016-10-18 at 14:36 +0200, Greg KH wrote: > > On Tue, Oct 18, 2016 at 05:52:21PM +0530, Shyam Saini wrote: > > > > > > On Mon, 2016-10-17 at 21:37 +0200, Greg KH wrote: > > > > > > > > On Mon, Oct 17, 2016 at 10:10:08PM

Re: [PATCH] staging: rtl8188eu: os_dep: fix checkpatch issues

2016-10-19 Thread Greg Kroah-Hartman
On Tue, Oct 18, 2016 at 11:30:29PM +0200, Pierre-Yves Kerbrat wrote: > This patch fixes the following: > - fix 2 block comments > - add missing spaces around operators > - remove unnecessary kzalloc fail message > - fix line over 80 char > ... When you find yourself listing all of the different

<    1   2