On Wed, Oct 19, 2016 at 01:44:25PM +0100, Rui Miguel Silva wrote:
> Fix size field of arpc message request by using the header size and not
> the pointer size.
>
> Signed-off-by: Rui Miguel Silva
Good catch, Rui. Guess the firmware is missing some sanity checks.
Reviewed-by:
On Wed, Oct 19, 2016 at 02:22:49PM +0300, Dan Carpenter wrote:
> On Wed, Oct 19, 2016 at 06:32:08AM -0400, Brian Masney wrote:
> > @@ -775,14 +778,20 @@ static ssize_t illuminance0_lux_table_store(struct
> > device *dev,
> > goto luxable_store_done;
> > }
> >
> > - if
Fix size field of arpc message request by using the header size and not
the pointer size.
Signed-off-by: Rui Miguel Silva
---
drivers/staging/greybus/es2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/es2.c
On Wed, Oct 19, 2016 at 02:08:59PM +0300, Dan Carpenter wrote:
> On Wed, Oct 19, 2016 at 06:32:05AM -0400, Brian Masney wrote:
> > Change the following functions to only have a single exit point:
> > taos_i2c_read(), taos_als_calibrate(), taos_chip_on(),
> > taos_gain_store(),
I appologize for laughing, but I am still secretly amused in my heart.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Oct 19, 2016 at 06:32:09AM -0400, Brian Masney wrote:
> @@ -778,6 +796,8 @@ static ssize_t illuminance0_lux_table_store(struct device
> *dev,
> goto luxable_store_done;
> }
>
> + mutex_lock(>als_mutex);
> +
> if (chip->taos_chip_status ==
This patch makes locking in visorchannel_signalempty statically deterministic.
As a result this patch fixes the sparse warning:
Context imbalance in 'visorchannel_signalempty' - different lock contexts for
basic block.
The logic of the locking code doesn't change but the layout of the original
What does illuminance0_ mean? Can we remove that?
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Oct 19, 2016 at 06:32:08AM -0400, Brian Masney wrote:
> @@ -775,14 +778,20 @@ static ssize_t illuminance0_lux_table_store(struct
> device *dev,
> goto luxable_store_done;
> }
>
> - if (chip->taos_chip_status == TSL258X_CHIP_WORKING)
> -
On Wed, Oct 19, 2016 at 06:32:05AM -0400, Brian Masney wrote:
> Change the following functions to only have a single exit point:
> taos_i2c_read(), taos_als_calibrate(), taos_chip_on(),
> taos_gain_store(), taos_gain_available_show(), taos_luxtable_store()
> and taos_probe().
>
What's the point
> Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO
> macros to create the device attributes.
great that you work on cleaning this up!
the patch does a bit more than is claimed, it also renames stuff;
eventually, a proper prefix ('tsl2583_') should be used...
maybe you can
illuminance0_calibbias_store(), illuminance0_input_target_store(), and
illuminance0_calibrate_store() did not return an error code when
an invalid value was passed in. The input was checked to see if the
input was valid, however the caller would not be notified that an
invalid value was passed in.
Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO
macros to create the device attributes.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/tsl2583.c | 117 ++--
1 file changed, 57 insertions(+), 60 deletions(-)
taos_gain_store() and taos_als_calibrate() both have a code path where
-1 was returned. This patch changes the code so that a proper error code
is returned to make the code consistent with the error paths that are
present within those same functions.
Signed-off-by: Brian Masney
taos_get_lux() calls mutex_trylock(). If the lock could not be acquired,
then chip->als_cur_info.lux is returned. The issue is that this value
is updated while the mutex is held and could cause a half written value
to be returned to the caller. This patch changes the call to
mutex_trylock() with
The return values from taos_chip_on() and taos_chip_off() was not
checked in several places. This patch adds proper error checking to
these function calls.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/tsl2583.c | 25 ++---
1 file changed,
The sysfs attributes modifies variables that are accessed elsewhere when
a mutex is locked. Add locking to the sysfs *_store() functions to avoid
a possible race condition when measurements are taken.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/tsl2583.c |
Change the following functions to only have a single exit point:
taos_i2c_read(), taos_als_calibrate(), taos_chip_on(),
taos_gain_store(), taos_gain_available_show(), taos_luxtable_store()
and taos_probe().
Signed-off-by: Brian Masney
---
Remove unnecessary header files and netlink related code as the daemons
do not use netlink to communicate with the kernel now.
Signed-off-by: Weibing Zhang
---
tools/hv/hv_fcopy_daemon.c | 7 ---
tools/hv/hv_kvp_daemon.c | 7 ---
2 files changed, 14
hv_kvp_daemon.c: In function ‘kvp_mac_to_if_name’:
hv_kvp_daemon.c:705:2: warning: format not a string literal and no format
arguments [-Wformat-security]
snprintf(dev_id, sizeof(dev_id), kvp_net_dir);
^
hv_kvp_daemon.c:705:2: warning: format not a string literal and no format
arguments
The link flag pthread is not needed.
Signed-off-by: Weibing Zhang
---
tools/hv/Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/hv/Makefile b/tools/hv/Makefile
index a8c4644..0d1e61b 100644
--- a/tools/hv/Makefile
+++
On Wed, Oct 19, 2016 at 11:43:28AM +0800, Weibing Zhang wrote:
> Remove unnecessary header files and netlink related code as the daemons
> do not use netlink to communicate with the kernel now.
> Fix a compile warning in snprintf.
> Pthread is also not needed.
>
> Signed-off-by: Weibing Zhang
On Tue, Oct 18, 2016 at 02:03:31PM -0400, Ryan Swan wrote:
> sparse produced
> warning: incorrect type in argument 2 (different address spaces)
> expected void const volatile [noderef] *src
> got struct slic_stats *stats
>
> casting argument 2 to what is expected by memcpy_fromio() fixed this
>
On Tue, Oct 18, 2016 at 06:46:05PM +, Thomas Weißschuh wrote:
> Signed-off-by: Thomas Weißschuh
I can't take patches without any changelog text, sorry.
And your subject doesn't make much sense either :(
thanks,
greg k-h
___
On Wed, Oct 19, 2016 at 01:34:44AM +0530, Shyam Saini wrote:
> On Tue, 2016-10-18 at 14:36 +0200, Greg KH wrote:
> > On Tue, Oct 18, 2016 at 05:52:21PM +0530, Shyam Saini wrote:
> > >
> > > On Mon, 2016-10-17 at 21:37 +0200, Greg KH wrote:
> > > >
> > > > On Mon, Oct 17, 2016 at 10:10:08PM
On Tue, Oct 18, 2016 at 11:30:29PM +0200, Pierre-Yves Kerbrat wrote:
> This patch fixes the following:
> - fix 2 block comments
> - add missing spaces around operators
> - remove unnecessary kzalloc fail message
> - fix line over 80 char
> ...
When you find yourself listing all of the different
101 - 126 of 126 matches
Mail list logo