[PATCH] staging: vc04_services: fix array_size.cocci warnings

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:193:39-40: WARNING: Use ARRAY_SIZE Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element Semantic patch information: This makes an effort to find cases where ARRAY_SIZE can be used such as where there is a division

[PATCH] staging: vc04_services: fix returnvar.cocci warnings

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1788:16-22: Unneeded variable: "status". Return "VCHIQ_SUCCESS" on line 1824 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Signed-off-by: Fengguang Wu --- Please take t

[PATCH] staging: vc04_services: fix setup_timer.cocci warnings

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1817:2-12: Use setup_timer function for function on line 1818. Use setup_timer function instead of initializing timer with the function and data fields Generated by: scripts/coccinelle/api/setup_timer.cocci Signed-off-by: Fengguang

[staging:staging-testing 514/514] drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:193:39-40: WARNING: Use ARRAY_SIZE

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: abbdc56b17d662ae710bc0c30cf0d0e9da805fd4 commit: abbdc56b17d662ae710bc0c30cf0d0e9da805fd4 [514/514] staging: vc04_services: add CONFIG_COMPILE_TEST ability coccinelle warnings: (new ones prefixed

[PATCH] Staging: media: davinci_vpfe: - Fix for memory leak if

From: "Shailendra Verma" Fix to avoid possible memory leak if the decoder initialization got failed.Free the allocated memory for file handle object before return in case decoder initialization fails. Signed-off-by: Shailendra Verma --- drivers/staging/media/davinci_vpfe/vpfe_video.c |1 +

Beneficial

Good day, I tried to get in contact with you previously because i have an idea that you might be interested in my proposal. My name is Benjamin Todd, i work with the Security and Management firm in England. Please acknowledge receipt of my mail for further details. Regards, Benjamin Todd

[PATCH 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'

Follow the kernel type preferrences of using 's32' over 'int32_t'. Signed-off-by: Shiva Kerdel Acked-by: Stuart Yoder --- Changes for v2: - None Changes for v3: - None Changes for v4: - corrected patch version number. drivers/staging/fsl-mc/include/mc.h | 2 +- 1 file changed, 1 in

[PATCH 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

Follow the kernel type preferrences of using 's16' over 'int16_t'. Signed-off-by: Shiva Kerdel Acked-by: Stuart Yoder --- Changes for v2: - corrected an error in the log message, wrote 's32' instead of 's16'. Changes for v3: - added the missing annotates. Changes for v4: - corrected

[PATCH v5 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

Follow the kernel type preferrences of using 's16' over 'int16_t'. Signed-off-by: Shiva Kerdel Acked-by: Stuart Yoder --- Changes for v2: - corrected an error in the log message, wrote 's32' instead of 's16'. Changes for v3: - added the missing annotates. Changes for v4: - corrected

[PATCH v5 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'

Follow the kernel type preferrences of using 's32' over 'int32_t'. Signed-off-by: Shiva Kerdel Acked-by: Stuart Yoder --- Changes for v2: - None Changes for v3: - None Changes for v4: - corrected patch version number. Changes for v5: - version tag was missing. drivers/staging/f

Re: [PATCH 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

On Fri, Nov 11, 2016 at 12:07:39PM +0100, Shiva Kerdel wrote: > Follow the kernel type preferrences of using 's16' over 'int16_t'. > > Signed-off-by: Shiva Kerdel > Acked-by: Stuart Yoder > --- > Changes for v2: > - corrected an error in the log message, wrote 's32' instead of 's16'. > Chang

Re: [PATCH 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'

On Fri, Nov 11, 2016 at 12:07:40PM +0100, Shiva Kerdel wrote: > Follow the kernel type preferrences of using 's32' over 'int32_t'. > > Signed-off-by: Shiva Kerdel > Acked-by: Stuart Yoder > --- > Changes for v2: > - None > Changes for v3: > - None > Changes for v4: > - corrected patc

[PATCH] staging: vc04_services: Remove explicit NULL pointer

Replace direct comparisons to NULL i.e. 'x == NULL' with '!x' 'x != NULL' with 'x' Signed-off-by: Maninder Singh --- .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 32 ++-- .../vc04_services/interface/vchiq_arm/vchiq_core.c |4 +-- .../vc04_services/interface/vchiq_ar

[PATCH] staging: wlang-ng: Fix block comments style warnings in prism2sta.h

This patch fixes the following checkpatch.pl warning in prism2sta.h: WARNING: Block comments should align the * on each line No more warnings block comments warnings for this file. Signed-off-by: Timo Schmid --- drivers/staging/wlan-ng/prism2sta.c | 36 ++-- 1 fi

RE: [PATCH 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Friday, November 11, 2016 5:23 AM > To: Shiva Kerdel > Cc: Stuart Yoder ; de...@driverdev.osuosl.org; > german.riv...@freescale.com; > gre...@linuxfoundation.org; Nipun Gupta ; > linux-ker...@vger.kern

[staging:staging-testing 514/514] drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c:65:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursi

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: abbdc56b17d662ae710bc0c30cf0d0e9da805fd4 commit: abbdc56b17d662ae710bc0c30cf0d0e9da805fd4 [514/514] staging: vc04_services: add CONFIG_COMPILE_TEST ability coccinelle warnings: (new ones prefixed

[PATCH] staging: vc04_services: fix ifnullfree.cocci warnings

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c:65:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some

Re: [PATCH] staging: vc04_services: fix array_size.cocci warnings

kbuild test robot writes: > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:193:39-40: > WARNING: Use ARRAY_SIZE > > Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element > > Semantic patch information: > This makes an effort to find cases where ARRAY_SIZE can be

Re: [PATCH] staging: vc04_services: fix ifnullfree.cocci warnings

kbuild test robot writes: > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c:65:2-7: > WARNING: NULL check before freeing functions like kfree, debugfs_remove, > debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider > reorganizing relevant code to avoid passing N

[PATCH] [STYLE 1/2]staging:speakup:i18n.c Block align on *

Made suggested modifications from checkpatch in reference to: WARNING: Block comments should align the * on each line Signed-off-by: Walt Feasel --- drivers/staging/speakup/i18n.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/speakup/i18n.c b/

[PATCH] [STYLE 2/2]staging:speakup:i18n.c Align match parenthesis

Made suggested modifications from checkpatch in reference to: CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- drivers/staging/speakup/i18n.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/

[PATCH] [STYLE]staging:speakup:keyhelp.c Align match on parenthesis

Made suggested modifications from checkpatch in reference to: CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- drivers/staging/speakup/keyhelp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/keyhelp.c b/drivers/stagi

[PATCH][STYLE 1/3]staging:speakup:kobjects.c Align match on parenthesis

Made suggested modifications from checkpatch in reference to: CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- drivers/staging/speakup/kobjects.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/staging/speak

[PATCH][STYLE 2/3]staging:speakup:kobjects.c Align match on parenthesis

Made suggested modifications from checkpatch in reference to: CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- drivers/staging/speakup/kobjects.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/staging/speakup/kob

[PATCH] [STYLE 3/3]staging:speakup:kobjects.c Align match on parenthesis and no space after cast

Made suggested modifications from checkpatch in reference to: CHECK: Alignment should match open parenthesis CHECK: No space is necessary after a cast Signed-off-by: Walt Feasel --- drivers/staging/speakup/kobjects.c | 24 1 file changed, 12 insertions(+), 12 deletio

[PATCH] [STYLE 1/3]staging:speakup:main.c Modify block comments

Made suggested modifications from checkpatch in reference to WARNING: Block comments should align the * on each line CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by: Walt Feasel --- drivers/staging/speakup/main.c | 3 ++- 1 file changed, 2 insertions

[PATCH] [STYLE 2/3]staging:speakup:main.c Align on Parenthesis

Made suggested modifications from checkpatch in reference to CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- drivers/staging/speakup/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speak

[PATCH] [STYLE 3/3]staging:speakup:main.c Operators to end of line

Made suggested modifications from checkpatch in reference to CHECK: Alignment should match open parenthesis additionally moved operators to end of line Signed-off-by: Walt Feasel --- drivers/staging/speakup/main.c | 40 ++-- 1 file changed, 18 insert

[PATCH] [STYLE]staging:speakup:selection.c Align to parenthesis

Made suggested modifications from checkpatch in reference to CHECK: Alignment should match open parenthesis Additionally add space around operators Signed-off-by: Walt Feasel --- drivers/staging/speakup/selection.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH] [STYLE]staging:speakup:serialio.c Align and Space for operators

Made suggested modifications from checkpatch in reference to: CHECK: spaces preferred around that '+' CHECK: Please use a blank line after function/struct/union/enum declarations CHECK: Alignment should match open parenthesis Combined "CHECKS" in patch since multiple issues affect the same

[PATCH] [STYLE]staging:speakup:speakup_acntpc.c Spaces perferred around

Made suggested modifications from checkpatch in reference to: CHECK: spaces preferred around that '|,+,-' CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_acntpc.c | 42 1 file changed, 21 insertion

Re: [PATCH 1/2 v3] pci-hyperv: properly handle pci bus remove

On Mon, Oct 03, 2016 at 11:42:47PM -0700, Long Li wrote: > From: Long Li > > hv_pci_devices_present is called in hv_pci_remove when we remove a PCI device > from host (e.g. by disabling SRIOV on a device). In hv_pci_remove, the bus is > already removed before the call, so we don't need to resca

[PATCH] [STYLE 1/2]staging:speakup:speakup_acntsa.c Modify block comments

Made suggested modifications from checkpatch in reference to WARNING: Block comments should align the * on each line Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_acntsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/speakup_acntsa.

[PATCH] [STYLE 2/2]staging:speakup:speakup_acntsa.c Spaces preferred around

Made suggested modifications from checkpatch in reference to CHECK: spaces preferred around that '|' Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_acntsa.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/speakup/speaku

[PATCH] [STYLE 1/3]staging:speakup:speakup_apollo.c Block align on *

Made suggested modifications from checkpatch in reference to: WARNING: Block comments should align the * on each line Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_apollo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/speakup_apollo

[PATCH] [STYLE 2/3]staging:speakup:speakup_apollo.c Spaces perferred around

Made suggested modifications from checkpatch in reference to: CHECK: spaces preferred around that '|' Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_apollo.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/speakup/sp

[PATCH] [STYLE 3/3]staging:speakup:speakup_apollo.c Align match parenthesis

Made suggested modifications from checkpatch in reference to: CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_apollo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/speakup_apollo.c b/dr

RE: [PATCH 1/2 v3] pci-hyperv: properly handle pci bus remove

> -Original Message- > From: Bjorn Helgaas [mailto:helg...@kernel.org] > Sent: Friday, November 11, 2016 1:04 PM > To: Long Li > Cc: KY Srinivasan ; Haiyang Zhang > ; Bjorn Helgaas ; > de...@linuxdriverproject.org; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org; Long Li > Su

[PATCH] [STYLE]staging:speakup:speakup_audptr.c Spaces around that

Made suggested modifications from checkpatch in reference to CHECK: spaces preferred around that '|' Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_audptr.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/speakup/spe

[PATCH] [STYLE 1/2]staging:speakup:speakup_bns.c Block text modifications

Made suggested modifications from checkpatch in reference to: WARNING: Block comments should align the * on each line Modified a multi line block to single. Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_bns.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff

[PATCH] [STYLE 2/2]staging:speakup:speakup_bns.c Spaces around that

Made suggested modifications from checkpatch in reference to: CHECK: spaces preferred around that '|' Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_bns.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/speakup/speakup

[PATCH] [STYLE 1/2]staging:speakup:speakup_decext.c Block text modifications

Made suggested modifications from checkpatch in reference to: WARNING: Block comments should align the * on each line Modified a multi line block text to single Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_decext.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-

[PATCH] [STYLE 2/2]staging:speakup:speakup_decext.c Align match parenthesis

Made suggested modifications from checkpatch in reference to: CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_decext.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/speakup_decext.c b

RE: [PATCH 7/9] bus: fsl-mc: dpio: add the DPAA2 DPIO service interface

> > +/** > > + * dpaa2_io_service_rearm() - Rearm the notification for the given DPIO > > service. > > + * @service: the given DPIO service. > > + * @ctx: the notification context. > > + * > > + * Once a FQDAN/CDAN has been produced, the corresponding FQ/channel > > is > > + * considered "disarmed"

[PATCH] [STYLE 1/3]staging:speakup:speakup_decpc.c Block align text

Made suggested modifications from checkpatch in reference to: WARNING: Block comments should align the * on each line Modified horizontal spacing for consistency/legibility Modified multi line comment to single Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_decpc.c | 97 +

[PATCH] [STYLE 2/3]staging:speakup:speakup_decpc.c Perferred spaces around

Made suggested modifications from checkpatch in reference to: CHECK: spaces preferred around that '|,+,&' Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_decpc.c | 46 - 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/staging

[PATCH] [STYLE 3/3]staging:speakup:speakup_decpc.c Align match parenthesis

Made suggested modifications from checkpatch in reference to: CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_decpc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/speakup/speakup_decpc.c

[PATCH] [STYLE 1/3]staging:speakup:speakup_dectlk.c Block text modification

Modified multi line text to single Removed unneeded blankline at end Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_dectlk.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/speakup/speakup_dectlk.c b/drivers/staging/speakup/speakup_dectl

RE: [PATCH 2/3] PCI: hv: fix hv_pci_remove() for hot-remove

> -Original Message- > From: Dexuan Cui > Sent: Wednesday, November 9, 2016 11:19 PM > To: Bjorn Helgaas ; linux-...@vger.kernel.org; > de...@linuxdriverproject.org > Cc: gre...@linuxfoundation.org; KY Srinivasan ; > Haiyang Zhang ; Stephen Hemminger > ; Jake Oshins ; Hadden > Hoppert ; Vit

[PATCH] [STYLE 2/3]staging:speakup:speakup_dectlk.c Spaces preferred around

Made suggested modifications from checkpatch in reference to: CHECK: spaces preferred around that '|' Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_dectlk.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/speakup/spe

RE: [PATCH 3/3] PCI: hv: delete the device earlier from hbus->children for hot-remove

> -Original Message- > From: Dexuan Cui > Sent: Wednesday, November 9, 2016 11:20 PM > To: Bjorn Helgaas ; linux-...@vger.kernel.org; > de...@linuxdriverproject.org > Cc: gre...@linuxfoundation.org; KY Srinivasan ; > Haiyang Zhang ; Stephen Hemminger > ; Jake Oshins ; Hadden > Hoppert ; Vit

[PATCH] [STYLE 3/3]staging:speakup:speakup_dectlk.c Align match parenthesis

Made suggested modifications from checkpatch in reference to: CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_dectlk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/speakup_dectlk.c b

[PATCH] [STYLE]staging:speakup:speakup_dtlk.h Modify block comments

Made suggested modifications from checkpatch in reference to WARNING: Block comments should align the * on each line Modified block text alignment for consistency Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_dtlk.h | 16 1 file changed, 8 insertions(+), 8 de

[PATCH] [STYLE 1/2]staging:speakup:speakup_dummy.c Modify block comments

Made suggested modifications from checkpatch in reference to Modified multiline block text to single Removed blank line from the end Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_dummy.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging

[PATCH] [STYLE 2/2]staging:speakup:speakup_dummy.c Spaces prefered around

Made suggested modifications from checkpatch in reference to: CHECK: spaces preferred around that '|' Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_dummy.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/speakup/speaku

[PATCH] [STYLE]staging:speakup:speakup.h Space preferred around

Made suggested modifications from checkpatch in reference to CHECK: spaces preferred around that '|,+' Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/speakup/speakup.h b/drivers/stag

[PATCH] [STYLE 1/3]staging:speakup:speakup_keypc.c Block text modification

Modified multi line comment to single Removed blankline at end Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_keypc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/speakup/speakup_keypc.c b/drivers/staging/speakup/speakup_keypc.c index

[PATCH] [STYLE 2/3]staging:speakup:speakup_keypc.c Preferred space around

Made suggested modifications from checkpatch in reference to: CHECK: spaces preferred around that '|,+,-' Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_keypc.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/sp

[PATCH] [STYLE 3/3]staging:speakup:speakup_keypc.c Align around parenthesis

Made suggested modifications from checkpatch in reference to: CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_keypc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/speakup_keypc.c b/d

[PATCH] [STYLE 1/2]staging:speakup:speakup_ltlk.c Block align on *

Made suggested modifications from checkpatch in reference to: WARNING: Block comments should align the * on each line Modified multi line comment to single Removed blankline at end Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_ltlk.c | 8 +++- 1 file changed, 3 inser

[PATCH] [STYLE 2/2]staging:speakup:speakup_ltlk.c Preferred space around

Made suggested modifications from checkpatch in reference to: CHECK: spaces preferred around that '|,+' Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_ltlk.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/speak