Re: [PATCH 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

-Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Monday, November 14, 2016 4:06 AM To: Stuart Yoder Cc: Shiva Kerdel ; de...@driverdev.osuosl.org; gre...@linuxfoundation.org; linux- ker...@vger.kernel.org; Nipun Gupta

Re: Patch procedure

On Mon, Nov 14, 2016 at 12:16:08PM -0500, feas wrote: > Here is how I am going about making the patches. It is basically > what I have picked up from kernel newbies among other sites > and videos on making patches. I would be greatful for any > pointers on what seems to be the problem(s) with why

Problems with item delivery, n.2553686726

Hello, We could not deliver your parcel. You can review complete details of your order in the find attached. Steffanie Iverson - Area Manager FedEx , CA Regards FedEx.doc Description: MS-Word document ___ devel mailing list

RE: [PATCH 3/3] PCI: hv: delete the device earlier from hbus->children for hot-remove

> -Original Message- > From: Dexuan Cui > Sent: Wednesday, November 9, 2016 11:20 PM > To: Bjorn Helgaas ; linux-...@vger.kernel.org; > de...@linuxdriverproject.org > Cc: gre...@linuxfoundation.org; KY Srinivasan ; > Haiyang Zhang

RE: [PATCH 2/3] PCI: hv: fix hv_pci_remove() for hot-remove

> -Original Message- > From: Dexuan Cui > Sent: Wednesday, November 9, 2016 11:19 PM > To: Bjorn Helgaas ; linux-...@vger.kernel.org; > de...@linuxdriverproject.org > Cc: gre...@linuxfoundation.org; KY Srinivasan ; > Haiyang Zhang

RE: [PATCH 1/3] PCI: hv: use the correct buffer size in new_pcichild_device()

> -Original Message- > From: Dexuan Cui > Sent: Wednesday, November 9, 2016 11:18 PM > To: Bjorn Helgaas ; linux-...@vger.kernel.org; > de...@linuxdriverproject.org > Cc: gre...@linuxfoundation.org; KY Srinivasan ; > Haiyang Zhang

Re: [PATCH v2] [STYLE]staging:vme:vme_user.c Correct spelling mistakes

On Sun, Nov 13, 2016 at 08:28:34PM -0500, Walt Feasel wrote: > Make spelling corrections for 'correctly' and > 'unregister'. > > Signed-off-by: Walt Feasel Acked-by: Martyn Welch > --- > > Removed the previously submitted U.S. spelling for >

[PATCH 1/3] staging: comedi: ni_mio_common: fix M Series ni_ai_insn_read() data mask

For NI M Series cards, the Comedi `insn_read` handler for the AI subdevice is broken due to ANDing the value read from the AI FIFO data register with an incorrect mask. The incorrect mask clears all but the most significant bit of the sample data. It should preserve all the sample data bits.

[PATCH 2/3] staging: comedi: ni_mio_common: fix E series ni_ai_insn_read() data

Commit 0557344e2149 ("staging: comedi: ni_mio_common: fix local var for 32-bit read") changed the type of local variable `d` from `unsigned short` to `unsigned int` to fix a bug introduced in commit 9c340ac934db ("staging: comedi: ni_stc.h: add read/write callbacks to struct ni_private") when

[PATCH 3/3] staging: comedi: ni_mio_common: remove variable 'dl' in ni_ai_insn_read()

In `ni_ai_insn_read()`, local variable `dl` is declared as `unsigned long`, but `unsigned int` will do. Get rid of it and use local variable `d` instead. (That used to be `unsigned short`, but has been `unsigned int` since kernel version 3.18.) Signed-off-by: Ian Abbott ---

[PATCH 0/3] staging: comedi: ni_mio_common: ni_ai_insn_read() fixes

A couple of bug fixes for incorrect sample data read by ni_ai_insn_read(), plus removal of an unnecessary variable. 1) staging: comedi: ni_mio_common: fix M Series ni_ai_insn_read() data mask 2) staging: comedi: ni_mio_common: fix E series ni_ai_insn_read() data 3) staging: comedi:

Re: [PATCH 00/35] second batch of missing lustre 2.8 patches

> On Thu, Nov 10, 2016 at 12:30:30PM -0500, James Simmons wrote: > > More fixes missing from the upstream client. Also a nice cleanup > > with the removal of cl_req which is no longer needed. More cleanup > > for lustre_idl.h which is a uapi header. Like the last batch these > > patches are

Re: [PATCH v2] staging: vc04_services: rework ioctl code path

On Mon, 2016-11-14 at 12:48 +0300, Dan Carpenter wrote: > On Thu, Nov 10, 2016 at 10:15:31PM -0800, Michael Zoran wrote: > > +static void * > > +vchiq_ioctl_kmalloc(struct vchiq_ioctl_call_context *ctxt, size_t > > size) > > +{ > > + void *mem; > > + > > + if (!ctxt->stackmem_used && size <

Re: [PATCH v4] staging: lustre: mdc: manage number of modify RPCs in flight

> On Mon, Nov 14, 2016 at 04:59:48PM +, James Simmons wrote: > > > > > On Thu, Nov 10, 2016 at 10:51:13AM -0500, James Simmons wrote: > > > > From: Gregoire Pichon > > > > > > > > This patch is the main client part of a new feature that supports > > > > multiple

Re: [PATCH v4] staging: lustre: mdc: manage number of modify RPCs in flight

On Mon, Nov 14, 2016 at 04:59:48PM +, James Simmons wrote: > > > On Thu, Nov 10, 2016 at 10:51:13AM -0500, James Simmons wrote: > > > From: Gregoire Pichon > > > > > > This patch is the main client part of a new feature that supports > > > multiple modify metadata

Patch procedure

Here is how I am going about making the patches. It is basically what I have picked up from kernel newbies among other sites and videos on making patches. I would be greatful for any pointers on what seems to be the problem(s) with why it does not produce a proper patch. I will use

Re: [PATCH v4] staging: lustre: mdc: manage number of modify RPCs in flight

> On Thu, Nov 10, 2016 at 10:51:13AM -0500, James Simmons wrote: > > From: Gregoire Pichon > > > > This patch is the main client part of a new feature that supports > > multiple modify metadata RPCs in parallel. Its goal is to improve > > metadata operations

Re: [PATCH v4] staging: lustre: mdc: manage number of modify RPCs in flight

On Thu, Nov 10, 2016 at 10:51:13AM -0500, James Simmons wrote: > From: Gregoire Pichon > > This patch is the main client part of a new feature that supports > multiple modify metadata RPCs in parallel. Its goal is to improve > metadata operations performance of a single

Re: [PATCH 00/35] second batch of missing lustre 2.8 patches

On Thu, Nov 10, 2016 at 12:30:30PM -0500, James Simmons wrote: > More fixes missing from the upstream client. Also a nice cleanup > with the removal of cl_req which is no longer needed. More cleanup > for lustre_idl.h which is a uapi header. Like the last batch these > patches are independent of

Re: [PATCH 32/35] staging: lustre: mount: fix lmd_parse() to handle commas in expr_list

On Thu, Nov 10, 2016 at 12:31:02PM -0500, James Simmons wrote: > From: Jian Yu > > The lmd_parse() function parses mount options with comma as > delimiter without considering commas in expr_list as follows > is a valid LNET nid range syntax: > > :== '[' [ ',' ] ']' > >

RE: [PATCH 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Monday, November 14, 2016 4:06 AM > To: Stuart Yoder > Cc: Shiva Kerdel ; de...@driverdev.osuosl.org; > gre...@linuxfoundation.org; linux- >

Re: [PATCH 31/35] staging: lustre: obdclass: add export for lprocfs_stats_alloc_one()

On Thu, Nov 10, 2016 at 12:31:01PM -0500, James Simmons wrote: > From: Chennaiah Palla > > When compiling the kernel without optimization, when using GCOV, > the lprocfs_stats_alloc_one() symbol is not properly exported to > other modules and causes the ptlrpc module

Re: [PATCH] staging: wlang-ng: Fix block comments style warnings in prism2sta.h

On Fri, Nov 11, 2016 at 02:13:06PM +0100, Timo Schmid wrote: > This patch fixes the following checkpatch.pl warning in prism2sta.h: > WARNING: Block comments should align the * on each line > > No more warnings block comments warnings for this file. > > Signed-off-by: Timo Schmid

Re: [PATCH] staging: rtl8192e: Fix checkpatch warnings

On Thu, Nov 10, 2016 at 10:31:32PM +0530, Yamanappagouda Patil wrote: > Fixed checkpatch.pl warning on Block comments. > > Signed-off-by: Yamanappagouda Patil > --- Both of your patches did different things, yet you had the same subject line :( Please fix them up and

Re: [PATCH] staging: vc04_services: Remove explicit NULL pointer

On Fri, Nov 11, 2016 at 05:46:45PM +0530, Maninder Singh wrote: > Replace direct comparisons to NULL i.e. > 'x == NULL' with '!x' > 'x != NULL' with 'x' > > Signed-off-by: Maninder Singh A patch that was sent right before yours causes this patch to now have conflicts.

Re: [PATCH 2/4] Staging: vme: Use BIT macro for bit field definitions.

On Thu, Nov 10, 2016 at 10:17:23PM +0300, Dan Carpenter wrote: > On Wed, Nov 02, 2016 at 01:27:09AM +0300, Anton Leshchenko wrote: > > #define PIO2_CNTR_MODE00 > > -#define PIO2_CNTR_MODE1(1 << 1) > > -#define PIO2_CNTR_MODE2(2 << 1) > >

Re: [PATCH] [STYLE]staging:braille:braille_console.c [1/2]

On Thu, Nov 10, 2016 at 08:12:07PM -0500, Walt Feasel wrote: > Made suggested modifications from checkpatch in reference > to ERROR: Use 4 digit octal (0777) not decimal permissions > > Signed-off-by: Walt Feasel > --- > drivers/accessibility/braille/braille_console.c | 2

Re: [PATCH] [STYLE]staging:skein:threefish_block.c remove blank lines

On Mon, Nov 14, 2016 at 01:34:15PM +0300, Dan Carpenter wrote: > Please just delete the blank lines. You aren't that special like a snow > flake. I agree, they need to be removed so that we don't have people waste time on this, and the code gets closer to the correct kernel style rules. thanks,

Re: [PATCH] [STYLE]staging:xgifb:XGI_main.h Align columns

Your subjects are still wrong... regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] [STYLE]staging:skein:threefish_block.c remove blank lines

Please just delete the blank lines. You aren't that special like a snow flake. regards, dan carpetner ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Revert "[STYLE]staging:MAINTAINERS email revision speakup"

This is not at all how revert commits work. Anyway, no one applied the original patch. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] [STYLE 1/2]staging:speakup:i18n.c Block align on *

These patches are ok, but the subjects are all wrong. Please fix and resend. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

On Fri, Nov 11, 2016 at 02:52:31PM +, Stuart Yoder wrote: > > > diff --git a/drivers/staging/fsl-mc/include/mc-bus.h > > > b/drivers/staging/fsl-mc/include/mc-bus.h > > > index e915574..c7cad87 100644 > > > --- a/drivers/staging/fsl-mc/include/mc-bus.h > > > +++

Re: [PATCH v2] staging: vc04_services: rework ioctl code path

On Thu, Nov 10, 2016 at 10:15:31PM -0800, Michael Zoran wrote: > +static void * > +vchiq_ioctl_kmalloc(struct vchiq_ioctl_call_context *ctxt, size_t size) > +{ > + void *mem; > + > + if (!ctxt->stackmem_used && size < sizeof(ctxt->stackmem)) { > + ctxt->stackmem_used = true; >

[PATCH] [STYLE]staging:xgifb:XGI_main.h Align columns

Make alignment changes to tabular data for consistency Signed-off-by: Walt Feasel --- drivers/staging/xgifb/XGI_main.h | 52 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main.h

[PATCH v3] Staging: ks7010: Prefer using the BIT macro

Replace all occurences of (1< --- * Subject made more clear * Remove unnecessary indentation drivers/staging/ks7010/ks7010_sdio.h | 16

Re: [PATCH v2] Subject: Staging: ks7010: Prefer using the BIT macro

On Mon, Nov 14, 2016 at 02:33:01PM +0530, Punit Vara wrote: > Replace all occurences of (1< ks7010_sdio.h to get rid of checkpatch.pl "CHECK" output "Prefer > using BIT macro". > > Signed-off-by: Punit Vara > --- > * remove unecessary indentation

Re: [PATCH] Staging: ks7010: Prefer using the BIT macro

Sorry for that. I have updated the patch and sent you version 2. If I am still wrong could you please share me link to the sample commit ? thanks, PV On Mon, Nov 14, 2016 at 12:30 PM, Greg KH wrote: > On Mon, Nov 14, 2016 at 12:20:40PM +0530, Punit Vara wrote: >>

[PATCH v2] Subject: Staging: ks7010: Prefer using the BIT macro

Replace all occurences of (1< --- * remove unecessary indentation drivers/staging/ks7010/ks7010_sdio.h | 16 1 file

[PATCH] [STYLE 9/9]staging:xgifb:XGI_main_26.c Align on parenthesis

Make suggested modification from checkpatch in reference to: CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- drivers/staging/xgifb/XGI_main_26.c | 37 - 1 file changed, 16 insertions(+), 21 deletions(-)

[PATCH] [STYLE 8/9]staging:xgifb:XGI_main_26.c Align on parenthesis

Make suggested modification from checkpatch in reference to: CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- drivers/staging/xgifb/XGI_main_26.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git

[PATCH] [STYLE 7/9]staging:xgifb:XGI_main_26.c Align on parenthesis

Make suggested modification from checkpatch in reference to: CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- drivers/staging/xgifb/XGI_main_26.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git

[PATCH] [STYLE 6/9]staging:xgifb:XGI_main_26.c No space after cast

Make suggested modification from checkpatch in reference to: CHECK: No space is necessary after a cast Signed-off-by: Walt Feasel --- drivers/staging/xgifb/XGI_main_26.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH] [STYLE 5/9]staging:xgifb:XGI_main_26.c No space after cast

Make suggested modification from checkpatch in reference to: CHECK: No space is necessary after a cast Signed-off-by: Walt Feasel --- drivers/staging/xgifb/XGI_main_26.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH] [STYLE 4/9]staging:xgifb:XGI_main_26.c Logical continuations

Make suggested modification from checkpatch in reference to: CHECK: Logical continuations should be on the previous line Signed-off-by: Walt Feasel --- drivers/staging/xgifb/XGI_main_26.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff

[PATCH] [STYLE 3/9]staging:xgifb:XGI_main_26.c Spaces preferred around

Make suggested modification from checkpatch in reference to: CHECK: spaces preferred around that '-,&' Signed-off-by: Walt Feasel --- drivers/staging/xgifb/XGI_main_26.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH] [STYLE 2/9]staging:xgifb:XGI_main_26.c Remove blank lines after {

Make suggested modification from checkpatch in reference to: CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: Walt Feasel --- drivers/staging/xgifb/XGI_main_26.c | 12 1 file changed, 12 deletions(-) diff --git

[PATCH] [STYLE 1/9]staging:xgifb:XGI_main_26.c Remove blank lines before }

Make suggested modification from checkpatch in reference to: CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by: Walt Feasel --- drivers/staging/xgifb/XGI_main_26.c | 2 -- 1 file changed, 2 deletions(-) diff --git