On Thu, Nov 17, 2016 at 06:29:08PM -0500, James Simmons wrote:
> From: Mikhail Pershin
>
> - llh_cat_idx may become bigger than llog bitmap size in
> llog_cat_set_first_idx() function
> - it is wrong to use previous cur_offset as new buffer offset,
> new offset should be calculated from value
On Thu, Nov 17, 2016 at 12:46:12PM +0100, Sergio Paracuellos wrote:
> On Thu, Nov 17, 2016 at 12:33 PM, Dan Carpenter
> wrote:
> > Give it a shot and see if the warnings go away. I don't think the tag
> > is correct.
>
> Just removing __iomem tag in shmem_data field of slic_shmemory struct
> mak
Make modifications to data column alignment
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/xgifb/XGI_main.h | 54
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/drivers/stagin
Make suggested checkpatch modification for
CHECK: No space is necessary after a cast
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/xgifb/vb_util.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/stagi
Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/xgifb/vb_setmode.c | 299 +
1 file changed, 141 insertions(+
Make comment style modifications.
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/xgifb/vb_setmode.c | 234 ++---
1 file changed, 117 insertions(+), 117 deletions(-)
diff --git a/drivers/staging/xgifb/
Make suggested checkpatch modificationfor
CHECK: spaces preferred around that '+'
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/xgifb/vb_setmode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/x
Make suggested checkpatch modificationfor
WARNING: braces {} are not necessary for single
statement blocks
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/xgifb/vb_setmode.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
Make suggested checkpatch modification for
CHECK: No space is necessary after a cast
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/xgifb/vb_setmode.c | 139 ++---
1 file changed, 69 insertions(+), 70
Make suggested checkpatch modification for
CHECK: Logical continuations should be on the
previous line
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/xgifb/vb_setmode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Make spelling correction for 'vertical'.
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/xgifb/vb_setmode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/
Make Linux kernel coding style modifications for vb_setmode.c to include:
CHECK: spaces preferred around that
CHECK: Alignment should match open parenthesis
CHECK: No space is necessary after a cast
WARNING: braces {} are not necessary for single statement blocks
CHECK: Logical continuations shoul
From: Mikhail Pershin
- llh_cat_idx may become bigger than llog bitmap size in
llog_cat_set_first_idx() function
- it is wrong to use previous cur_offset as new buffer offset,
new offset should be calculated from value returned by
llog_next_block().
- optimize llog_skip_over() to find llog
Hi Mikhail,
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on next-20161117]
[cannot apply to v4.9-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/James
From: Mikhail Pershin
- llh_cat_idx may become bigger than llog bitmap size in
llog_cat_set_first_idx() function
- it is wrong to use previous cur_offset as new buffer offset,
new offset should be calculated from value returned by
llog_next_block().
- optimize llog_skip_over() to find llog
Testing != 0 is not kernel style so remove this
type of testing from libcfs.
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/libcfs/debug.c |4 +-
drivers/staging/lustre/lnet/libcfs/hash.c | 24 ++--
drivers/staging/lustre/lnet/libcfs/libcfs_st
Testing == 0 is not kernel style so remove this
type of testing from libcfs.
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/libcfs/debug.c |8 +++---
drivers/staging/lustre/lnet/libcfs/hash.c | 27 +--
drivers/staging/lustre/lnet/libcfs/libcfs
While checkpatch reported an alignment issue
its just ugly to fill in a data structure being
passed to a function. Instead fill in a lnet_md_t
on the stack and pass that to LNetMDBind.
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/lnet/router.c | 17 +
1 files ch
Remove != NULL which is not needed to test key existence.
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/libcfs/libcfs_lock.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/lustre/lnet/libcfs/libcfs_lock.c
b/drivers/staging/lustre/lnet/li
Some of the defines for lnet selftest can use the BIT
macros.
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/timer.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lnet/selftest/timer.c
b/drivers/staging/lustre/lnet/self
Cleanup some of the checkpatch over 80 character lines
reported.
Signed-off-by: James Simmons
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c| 31 ++-
.../staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 40 +---
.../lustre/lnet/klnds/socklnd/socklnd_lib.c
The envp char array can be made static constant.
Signed-off-by: James Simmons
---
.../staging/lustre/lnet/libcfs/linux/linux-debug.c | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/lustre/lnet/libcfs/linux/linux-debug.c
b/drivers/staging/lus
Change the static const array libcfs_debug_subsystems
to use static const char const * as pointed out by
checkpatch.
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/libcfs/debug.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/ln
Fix typo for correct spelling.
Signed-off-by: James Simmons
---
.../lustre/lnet/libcfs/linux/linux-crypto.c|2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/lustre/lnet/libcfs/linux/linux-crypto.c
b/drivers/staging/lustre/lnet/libcfs/linux/linux-c
The __[u|s]* types are for UAPI headers or user
space. They shouldn't be used in core kernel code.
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/libcfs/fail.c |4 ++--
drivers/staging/lustre/lnet/libcfs/hash.c | 16
drivers/staging/lustre/l
Make alignment match open parenthesis for
parameters to wait_event_interruptible_exclusive()
call.
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/libcfs/workitem.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/lustre/lnet/libcfs/workitem.
Remove unused lib_me_dump.
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/lnet/lib-me.c | 18 --
1 files changed, 0 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib-me.c
b/drivers/staging/lustre/lnet/lnet/lib-me.c
index b430046..e
Turn all bare unsigned to unsigned int that were
detected by checkpatch in the LNet/libcfs layer.
Signed-off-by: James Simmons
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.h|4 +-
drivers/staging/lustre/lnet/libcfs/debug.c |2 +-
drivers/staging/lustre/lnet/libcfs/hash.c
Add in missing blank line in lnet_copy_iov2iter() after
variable declarations.
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/lnet/lib-move.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c
b/drivers/staging/lust
This patch resolves the checkpatch error:
Block comments use a trailing */ on a separate line
for the LNet/libcfs layer
Signed-off-by: James Simmons
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.h| 128 +---
drivers/staging/lustre/lnet/libcfs/hash.c |2 +-
Remove white space present for variable declarations
or initialization. Cleanup structs was strange
alignments due to white spacing.
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/libcfs/debug.c | 16 ++--
drivers/staging/lustre/lnet/libcfs/hash.c | 24 +++---
Checkpatch for some reason doesn't like the way
libcfs_str2net_internal. Lets just replace it with
nf being set to NULL instead
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/lnet/nidstrings.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging
Checkpatch recommended that we use pr_*() instead
of printk directly.
Signed-off-by: James Simmons
---
.../lustre/lnet/libcfs/linux/linux-tracefile.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lnet/libcfs/linux/linux-tracefile.c
Fix misspelling of destroy in LNet core.
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/lnet/api-ni.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c
b/drivers/staging/lustre/lnet/lnet/api-ni.c
index 4daf828
Sweep of the LNet/libcfs layer to cleanup various
checkpatch issues. Also more cleanups to match
the kernel coding style.
James Simmons (19):
staging: lustre: lnet: don't use bare unsigned
staging: lustre: lnet: resolve trailing */ checkpatch errors
staging: lustre: libcfs: use static const
Hi Ping-Ke,
[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on v4.9-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Larry-Finger/rtlwifi-rtl8723be-Fix-bug-in-a
On 11/17/2016 12:05 PM, Larry Finger wrote:
From: Ping-Ke Shih
In commit c18d8f509571 ("rtlwifi: rtl8723be: Add antenna select module
parameter"), wifi was fixed for those laptops that have only a single
antenna but have an incorrectly coded EEPROM. This error causes the
driver to select the wr
From: Ping-Ke Shih
In commit c18d8f509571 ("rtlwifi: rtl8723be: Add antenna select module
parameter"), wifi was fixed for those laptops that have only a single
antenna but have an incorrectly coded EEPROM. This error causes the
driver to select the wrong antenna. In that commit, one necessary cha
On Thu, Nov 17, 2016 at 12:33 PM, Dan Carpenter
wrote:
> Give it a shot and see if the warnings go away. I don't think the tag
> is correct.
Just removing __iomem tag in shmem_data field of slic_shmemory struct
makes sparse happy. No warnings around.
Should I send a v4 patch with the tag remove
On Thu, Nov 17, 2016 at 12:22:00PM +0100, Sergio Paracuellos wrote:
> On Thu, Nov 17, 2016 at 11:51 AM, Dan Carpenter
> wrote:
> > Hm... I seem to duplicate the Sparse warnings at all. That's weird.
> >
>
> With this patch applied, sparse warnings dissapear for me... That's weird.
>
I understa
On Thu, Nov 17, 2016 at 11:51 AM, Dan Carpenter
wrote:
> Hm... I seem to duplicate the Sparse warnings at all. That's weird.
>
With this patch applied, sparse warnings dissapear for me... That's weird.
> Anyway as far as I can tell the warnings are false positives... Can't
> you just remove t
Hm... I seem to duplicate the Sparse warnings at all. That's weird.
Anyway as far as I can tell the warnings are false positives... Can't
you just remove the __iomem tag? Have you tested this change?
regards,
dan carpenter
___
devel mailing list
de
Fixed checkpatch warning "Statements should start on a tabstop" in
rtl8712 module.
Signed-off-by: Yamanappagouda Patil
---
drivers/staging/rtl8712/rtl8712_led.c | 24
drivers/staging/rtl8712/rtl871x_recv.c | 2 +-
2 files changed, 13 insertions(+), 13 deletions(-)
dif
43 matches
Mail list logo
