> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Sunday, November 27, 2016 01:06
> To: Vitaly Kuznetsov
> Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; KY Srinivasan
> ; Haiyang Zhang ; Dexuan Cui
>
> Subject: Re: [PATCH 0/7] hv: CPU onlining/offlining fixes
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Friday, November 25, 2016 20:49
> To: de...@linuxdriverproject.org
> Cc: linux-ker...@vger.kernel.org; KY Srinivasan ; Haiyang
> Zhang ; Dexuan Cui ;
> Stephen Hemminger
> Subject: [PATCH 1/7] hv: acquire vmbus_connection.channel_mutex
On 11/26/2016 04:20 AM, Lino Sanfilippo wrote:
> Add driver for Alacritech gigabit ethernet cards with SLIC (session-layer
> interface control) technology. The driver provides basic support without
> SLIC for the following devices:
>
> - Mojave cards (single port PCI Gigabit) both copper and fiber
On Sun, Nov 27, 2016 at 3:43 AM, Andrea Ghittino wrote:
> Fixes greybus "line over 80 characters" style warnings
> found by checkpatch.pl tool
>
It is always trade-off between readability vs 80 character restriction.
I give preference and precedence to readability, so I kept it as is
during devel
On 11/27/16 13:11, Andrea Ghittino wrote:
> Fixes sm750fb function definition argument style warning
> found by checkpatch.pl tool
>
> Signed-off-by: Andrea Ghittino
> ---
Does checkpatch not complain about the camelcase variable names and
function names?
--
~Randy
___
Fixes sm750fb function definition argument style warning
found by checkpatch.pl tool
Signed-off-by: Andrea Ghittino
---
diff --git a/drivers/staging/sm750fb/ddk750_chip.h
b/drivers/staging/sm750fb/ddk750_chip.h
index e97e859..30653dd 100644
--- a/drivers/staging/sm750fb/ddk750_chip.h
+++ b/drive
Hi Andrea,
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on next-20161125]
[cannot apply to v4.9-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Andrea-Ghittino/s
Hello Lino,
just some things barely worth mentioning:
On 11/26/2016 01:20 PM, Lino Sanfilippo wrote:
> Add driver for Alacritech gigabit ethernet cards with SLIC (session-layer
> interface control) technology. The driver provides basic support without
> SLIC for the following devices:
>
> - Moja
Fixes sm750fb tabstop style warning
found by checkpatch.pl tool
Signed-off-by: Andrea Ghittino
---
diff --git a/drivers/staging/sm750fb/sm750_accel.c
b/drivers/staging/sm750fb/sm750_accel.c
index 6fd18d2..af0db57 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm
Fixes sm750fb function definition argument style warning
found by checkpatch.pl tool
Signed-off-by: Andrea Ghittino
---
diff --git a/drivers/staging/sm750fb/ddk750_chip.h
b/drivers/staging/sm750fb/ddk750_chip.h
index e97e859..30653dd 100644
--- a/drivers/staging/sm750fb/ddk750_chip.h
+++ b/drive
Fixes sm750fb user/groups permission style warning
found by checkpatch.pl tool
Signed-off-by: Andrea Ghittino
---
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 2d22c51..2d33b80 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.
On 26/11/16 22:39, Boyan Vladinov wrote:
> Fixes warnings found by checkpatch.pl:
> - sysfs entries user/group modes to use their octal representation
> - use the IIO_DEVICE_ATTR_[RO|RW] macroses
> - coding style
>
> Signed-off-by: Boyan Vladinov
Unfortunately this isn't quite as straight forward
On 27/11/16 08:37, Boyan Vladinov wrote:
> Fixes warnings found by checkpatch.pl:
> - AD7280A_DEVADDR macro to use typeof, because of possible side effects
Such as? I can't tell from this description whether this is a bug, or just
some good coding practice stuff.
> - sysfs entries user/group modes
Fixes warnings found by checkpatch.pl:
- AD7280A_DEVADDR macro to use typeof, because of possible side effects
- sysfs entries user/group modes to use their octal representation
- coding style (open parenthesis alignment, CamelCase...)
Signed-off-by: Boyan Vladinov
---
drivers/staging/iio/adc/ad
14 matches
Mail list logo