[PATCH v2] staging: wilc1000: Connect to highest RSSI value for required SSID

Connect to the highest rssi with the required SSID in the shadow table if the connection criteria is based only on the SSID. For the first matching SSID, an index to the table is saved. Later the index is updated if matching SSID has a higher RSSI value than the last saved index. However if

Re: [PATCH] staging: wilc1000: Connect to highest RSSI value for required SSID

On Thu, 5 Jan 2017 15:14:50 +0300 Dan Carpenter wrote: > On Thu, Jan 05, 2017 at 01:03:41PM +0530, Aditya Shankar wrote: > > Connect to the highest rssi with the required SSID in the shadow > > table if the connection criteria is based only on the SSID. > > For the

Re: [PATCH] Staging: lustre: lustre: lmv: Compress return logic into one line.

On Jan 4, 2017, at 22:14, Gustavo A. R. Silva wrote: > > Simplify return logic to avoid unnecessary variable assignments. > These issues were detected using Coccinelle and the following semantic patch: > > @@ > local idexpression ret; > expression e; > @@ > > -ret

[PATCH] Staging: speakup: style fix, octal file permissions

Changed file permission to octal style, Can't use __ATTR_RW() as the handler is in standard format. Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/speakup/kobjects.c | 54 +++--- 1 file changed, 27 insertions(+), 27

[PATCH 2/2] staging/media/s5p-cec/exynos_hdmi_cecctrl.c Fixed blank line before closing brace '}'

Fixed checkpatch check blank line before closing brace '}' Signed-off-by: Scott Matheina --- drivers/staging/media/s5p-cec/exynos_hdmi_cecctrl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/media/s5p-cec/exynos_hdmi_cecctrl.c

[PATCH 1/2] staging:media:s5p-cec:exynos_hdmi_cecctrl.c Fixed Alignment should match open parenthesis

Fixed Checkpatch check "Alignment should match open parenthesis" Signed-off-by: Scott Matheina --- drivers/staging/media/s5p-cec/exynos_hdmi_cecctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/s5p-cec/exynos_hdmi_cecctrl.c

[PATCH 8/9] staging: vc04_services: Fix indentation

This should fix the indentation issues found by checkpatch. Signed-off-by: Stefan Wahren --- .../interface/vchiq_arm/vchiq_2835_arm.c | 42 ++-- .../vc04_services/interface/vchiq_arm/vchiq_arm.c |4 +-

[PATCH 5/9] staging: vc04_services: Use preferred kernel types

This patch fixes issues reported by checkpatch.pl about preferred kernel types. Signed-off-by: Stefan Wahren --- .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 10 +- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 12 ++-- 2 files changed,

[PATCH 9/9] staging: vc04_services: Fix space issues

This fixes the space coding styles issues complained by checkpatch. Signed-off-by: Stefan Wahren --- .../interface/vchiq_arm/vchiq_2835_arm.c | 14 +++--- .../vc04_services/interface/vchiq_arm/vchiq_arm.c |4 ++--

[PATCH 3/9] staging: vc04_services: make local functions static

The functions vchiq_dump_shared_state() and vchiq_is_connected() are only used locally. So make them static. Signed-off-by: Stefan Wahren --- .../vc04_services/interface/vchiq_arm/vchiq_core.c |2 +- .../interface/vchiq_arm/vchiq_kern_lib.c |2 +- 2

[PATCH 7/9] staging: vc04_services: Drop vchiq_2835.h

There is no need for a vchiq_2835.h with its 2 local defines. Signed-off-by: Stefan Wahren --- .../vc04_services/interface/vchiq_arm/vchiq_2835.h | 42 .../interface/vchiq_arm/vchiq_2835_arm.c |5 ++- 2 files changed, 4 insertions(+),

[PATCH 0/9] staging: vc04_services: Clean up vchiq driver

This is a loose bunch of clean up patches for the bcm2835 vchiq driver. Stefan Wahren (9): staging: staging: vchiq_arm: remove vchiq_platform_check_resume staging: vchiq_core: remove unused variable type staging: vc04_services: make local functions static staging: vchiq_core: make local

[PATCH 4/9] staging: vchiq_core: make local spinlock static

The quota_spinlock is only local. So make it static. Signed-off-by: Stefan Wahren --- .../vc04_services/interface/vchiq_arm/vchiq_core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c

[PATCH 2/9] staging: vchiq_core: remove unused variable type

This variable is assigned a value, but never used. So remove it. Signed-off-by: Stefan Wahren --- .../vc04_services/interface/vchiq_arm/vchiq_core.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c

[PATCH 1/9] staging: vchiq_arm: remove vchiq_platform_check_resume

This function is never used, so we could remove it. Signed-off-by: Stefan Wahren --- .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 46 1 file changed, 46 deletions(-) diff --git

[PATCH 6/9] staging: vc04_services: Improve readability of kthread names

This patch tries to make the kernel thread names of vchiq a little bit more self explaining and look closer to the existing ones: slot handler: VCHIQ-%d -> vchiq-slot/%d recycle thread: VCHIQr-%d -> vchiq-recy/%d sync thread: VCHIQs-%d -> vhciq-sync/%d keep-alive thread: VCHIQka-%d ->

[PATCH 0/2] staging: greybus: loopback: Fix two oops paths in gb_loopback

Alexandre reported a bug in the loopback rmmod path subsequent to a failure in gb_pm_runtime_get_sync - something that can happen when you are developing device-side firmware easily. Doing some cursory rmmod testing on gb_loopback then showed a second (and long standing) error pertaining to

[PATCH 1/2] staging: greybus: loopback: fix gb_pm_runtime_get_sync error handling

commit e854ff58ed70 ("greybus: loopback: add runtime pm support") introduces pm runtime support to the loopback code. If a gb_pm_runtime_get_sync() fails, currently we immediately return from the loopback thread. Alexandre reports that later on, subsequent to the afore mentioned failure, doing an

[PATCH 2/2] staging: greybus: loopback: fix oops on rmmod gb_loopback

Doing an rmmod gb_loopback will cause an oops with the following backtrace. Call Trace: debugfs_remove+0xaf/0x180 gb_loopback_disconnect+0x36/0x160 [gb_loopback] greybus_remove+0x87/0x1a0 [greybus] device_release_driver_internal+0x14a/0x200 driver_detach+0x39/0x60

[PATCH 1/4] staging: olpc_dcon: olpc_dcon: Fix open parenthesis alignment.

This issue is caught by checkpatch.pl and is related to the following warning: - CHECK: Alignment should match open parenthesis Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/olpc_dcon/olpc_dcon.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH 2/4] staging: olpc_dcon: olpc_dcon_xo_1_5: Remove redundant return statement.

dcon_was_irq(); should return a boolean value if PMIO_Rx50[6] is either set or unset, which is evaluated in the first return statement. Therefore, the following return statement is redundant and thus, removed. Signed-off-by: Emmanuil Chatzipetru ---

[PATCH 3/4] staging: olpc_dcon: olpc_dcon: Fix spaces between operator and variables.

This issue is caught by checkpatch.pl and is related to the following warning: - CHECK: spaces preferred around that '/' (ctx:VxV) Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/olpc_dcon/olpc_dcon.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 4/4] staging: olpc_dcon: olpc_dcon_xo_1_5: Remove multiple blank lines.

This issue is caught by checkpatch.pl and is related to the following warning: - CHECK: Please don't use multiple blank lines Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c | 1 - 1 file changed, 1 deletion(-) diff --git

[GIT PULL] Staging/IIO driver fixes for 4.10-rc3

The following changes since commit 0c744ea4f77d72b3dcebb7a8f2684633ec79be88: Linux 4.10-rc2 (2017-01-01 14:31:53 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.10-rc3 for you to fetch changes up to

Re: [PATCH] Staging: speakup: styel fix, octal file permissions

On Sun, Jan 08, 2017 at 06:01:31PM +1300, Derek Robson wrote: > On Sat, Jan 07, 2017 at 08:39:45AM +0100, Greg KH wrote: > > On Sat, Jan 07, 2017 at 05:11:16PM +1300, Derek Robson wrote: > > > Changed file permission to octal style, > > > Found using checkpatch > > > > Typo in your subject line

Re: [PATCH 19/19] staging: iio: isl29028: remove legacy device tree binding

Sorry all, appears some replies got stuck in my outbox and have just managed to send for some reason! Jonathan On 04/12/16 11:55, Jonathan Cameron wrote: > On 04/12/16 02:19, Brian Masney wrote: >> The isl29028 staging driver contains a legacy binding of "isl,isl29028" >> that is marked as

Re: [PATCH 02/19] staging: iio: isl29028: remove enable flag from isl29028_enable_proximity()

On 04/12/16 02:19, Brian Masney wrote: > isl29028_enable_proximity() has a boolean argument named enable. This > function is only called once and the enable flag is set to true in that > call. This patch removes the enable parameter from that function. > > Signed-off-by: Brian Masney

Re: [PATCH] staging:iio:addac Fixes Alignment should match open parenthesis

On 04/01/17 01:50, Scott Matheina wrote: > Fixes style issue where Alignment doesn't match open parenthesis > > Signed-off-by: Scott Matheina Please include the part number in the patch title. It's more important than the directory it happens to be in. Here you have space to

Re: [PATCH 05/19] staging: iio: isl29028: made alignment of #defines consistent

On 04/12/16 02:19, Brian Masney wrote: > The alignment of the #defines at the top of the file is not consistent. > This changes all of the defines to use consistent alignment to improve > the code readability. > > Signed-off-by: Brian Masney Skipped patch 4 for now, but

Re: [PATCH 02/19] staging: iio: isl29028: remove enable flag from isl29028_enable_proximity()

On 04/12/16 02:19, Brian Masney wrote: > isl29028_enable_proximity() has a boolean argument named enable. This > function is only called once and the enable flag is set to true in that > call. This patch removes the enable parameter from that function. > > Signed-off-by: Brian Masney

Re: [PATCH 04/19] staging: iio: isl29028: add power management support

On 04/12/16 02:19, Brian Masney wrote: > This patch adds power management support to the isl29028 driver. > > Signed-off-by: Brian Masney Hmm. I'm not sure why we need the suspended boolean. I 'think' it's impossible to have a sysfs read in progress during suspend or

Re: [PATCH 13/19] staging: iio: isl29028: move failure logging into isl29028_set_proxim_sampling()

On 04/12/16 02:19, Brian Masney wrote: > When isl29028_set_proxim_sampling() fails, it was up to both callers to > log the failure message. This patch moves the logging into > isl29028_set_proxim_sampling() to reduce the overall amount of code in > the driver. > > Signed-off-by: Brian Masney

Re: [PATCH 14/19] staging: iio: isl29028: move failure logging into isl29028_set_als_scale()

On 04/12/16 02:19, Brian Masney wrote: > When isl29028_set_als_scale() fails, it was up to both callers to log > the failure message. This patch moves the logging into > isl29028_set_als_scale() to reduce the overall amount of code in the > driver. > > Signed-off-by: Brian Masney

Re: [PATCH 11/19] staging: iio: isl29028: made column alignment in isl29028_channels consistent

On 04/12/16 02:19, Brian Masney wrote: > The three info_mask_separate members OR several BIT(xxx) fields > together. This patch changes the column alignment of these fields to be > aligned at the same column to improve the overall code readability. It > also moves the { for the next channel to the

Re: [PATCH 19/19] staging: iio: isl29028: remove legacy device tree binding

On 04/12/16 02:19, Brian Masney wrote: > The isl29028 staging driver contains a legacy binding of "isl,isl29028" > that is marked as legacy and to not use. There are no in tree references > to that binding. This patch removes the legacy binding in preparation > for moving the driver out of

Re: [PATCH 03/19] staging: iio: isl29028: remove chip test and defaults from isl29028_chip_init()

On 04/12/16 02:19, Brian Masney wrote: > isl29028_chip_init() contains the device driver defaults and > two I2C calls that detect the presence of the chip. This patch > moves these into isl29028_probe() so that this function can > be used by the power management runtinme in a followup patch. This