Populate header function signatures with variable names as well, not
just variable types.
Signed-off-by: Bogdan Purcareata
---
drivers/staging/android/ion/ion_priv.h | 38 +-
1 file changed, 19 insertions(+), 19 deletions(-)
diff
Signed-off-by: Bogdan Purcareata
---
drivers/staging/android/ion/ion_of.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_of.c
b/drivers/staging/android/ion/ion_of.c
index 46b2bb9..7791c70 100644
---
On Wed, Jan 11, 2017 at 10:39:22PM +0100, Fabian Arnold wrote:
> The tty_port.c file is now accordingly to the linux style guidelines.
That's the vaguest changelog text ever :(
Please describe what you did here, and why you did it. And if you fixed
more than one "type" of style issue, you need
On Wed, Jan 11, 2017 at 11:20:39PM +0200, Bogdan Purcareata wrote:
> Fix following checkpatch warnings:
> - Lines over 80 characters
> - void function with return statement
> - Unaligned comment mark
> - Header function prototypes missing variable names
That's a lot of different things to be
On Wed, Jan 11, 2017 at 04:00:35PM +0100, Roman Sommer wrote:
> Note that this patch does not fix all checkpatch warnings for the
> affected files.
>
A lot of ways that display git commits put the changelog and the summary
far apart. The changelog is pretty useless by itself in this case.
On 11-01-17, 16:00, Roman Sommer wrote:
> Note that this patch does not fix all checkpatch warnings for the
> affected files.
>
> Signed-off-by: Christian Bewermeyer
> Signed-off-by: Roman Sommer
>
> ---
> drivers/staging/greybus/gpio.c |
Changed permissions to be in octal style.
Found by checkpatch.
Signed-off-by: Derek Robson
---
drivers/staging/greybus/camera.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
Fixed Alignment should match open parenthesis checkpatch CHECK.
Signed-off-by: Scott Matheina
---
drivers/staging/wlan-ng/cfg80211.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/cfg80211.c
Fixes checkpatch CHECK: Alignment should match open parenthesis
Signed-off-by: Scott Matheina
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c
Fixes checkpatch CHECK: Alignment should match open parenthesis
Signed-off-by: Scott Matheina
---
drivers/staging/wilc1000/wilc_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
Fixes checkpatch warning: braces {} should be used on all arms of
this statement
Signed-off-by: Scott Matheina
---
drivers/staging/wilc1000/host_interface.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
Fixes checkpatch CHECK:
Blank lines aren't necessary before a close brace '}'
Please don't use multiple blank lines
Signed-off-by: Scott Matheina
---
drivers/staging/wilc1000/wilc_sdio.c | 3 ---
1 file changed, 3 deletions(-)
diff --git
Fixes checkpatch CHECK: Alignment should match open parenthesis
Signed-off-by: Scott Matheina
---
drivers/staging/wilc1000/wilc_sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_sdio.c
Fixes checkpatch CHECK: Please don't use multiple blank lines
Signed-off-by: Scott Matheina
---
drivers/staging/wilc1000/wilc_debugfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
b/drivers/staging/wilc1000/wilc_debugfs.c
Hi Tim,
On 01/11/2017 03:14 PM, Tim Harvey wrote:
Hi Steve,
I took a stab at testing this today on a gw51xx which has an adv7180
hooked up as follows:
- i2c3@0x20
- 8bit data bus from DAT12 to DAT19, HSYNC, VSYNC, PIXCLK on CSI0 pads
(CSI0_IPU1)
- PWRDWN# on
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Tuesday, January 10, 2017 9:27 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com;
>
Remove one unnecessary white line.
Signed-off-by: Javier Rodriguez
---
drivers/staging/rtl8192u/r8180_93cx6.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8180_93cx6.h
b/drivers/staging/rtl8192u/r8180_93cx6.h
index 8e48b24..643d465 100644
---
On Fri, Jan 6, 2017 at 6:11 PM, Steve Longerbeam wrote:
> In version 3:
>
> Changes suggested by Rob Herring :
>
> - prepended FIM node properties with vendor prefix "fsl,".
>
> - make mipi csi-2 receiver compatible string SoC specific:
>
Correct code style error. Add a character in every line of the
comment block.
Signed-off-by: Javier Rodriguez
---
drivers/staging/rtl8192u/r8180_93cx6.h | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git
The tty_port.c file is now accordingly to the linux style guidelines.
Signed-off-by: Fabian Arnold
Signed-off-by: Philip Thiemann
---
drivers/tty/tty_port.c | 38 +++---
1 file changed, 23 insertions(+), 15
On 01/11/2017 08:53 AM, Arnd Bergmann wrote:
gcc-7 detects that wlanhdr_to_ethhdr() in two drivers calls memcpy() with
a destination argument that an earlier function call may have set to NULL:
staging/rtl8188eu/core/rtw_recv.c: In function 'wlanhdr_to_ethhdr':
Fix following checkpatch warnings:
- Lines over 80 characters
- void function with return statement
- Unaligned comment mark
- Header function prototypes missing variable names
Signed-off-by: Bogdan Purcareata
---
drivers/staging/android/ion/ion-ioctl.c | 3 ++-
Den 11.01.2017 15:43, skrev Andy Shevchenko:
On Tue, 2017-01-03 at 20:29 +0200, Andy Shevchenko wrote:
This series enables 64x48 OLED display and fixes the driver to work
with DMA
enabled SPI properly.
Has been tested on Intel Edison board with Adafruit 2'8" and SSD1306
64x48
(Sparkfun for
gcc-7 detects that wlanhdr_to_ethhdr() in two drivers calls memcpy() with
a destination argument that an earlier function call may have set to NULL:
staging/rtl8188eu/core/rtw_recv.c: In function 'wlanhdr_to_ethhdr':
staging/rtl8188eu/core/rtw_recv.c:1318:2: warning: argument 1 null where
On Wed, Jan 11, 2017 at 04:00:35PM +0100, Roman Sommer wrote:
> Note that this patch does not fix all checkpatch warnings for the
> affected files.
>
> Signed-off-by: Christian Bewermeyer
> Signed-off-by: Roman Sommer
Next time I suggest you
Note that this patch does not fix all checkpatch warnings for the
affected files.
Signed-off-by: Christian Bewermeyer
Signed-off-by: Roman Sommer
---
drivers/staging/greybus/gpio.c | 24
>> You forgot to fix the Subject prefix ("staging: greybus: ").
>>
>> Care to fix that up and resend?
>>
>> Thanks,
>> Johan
>>
>
> As I added the fix for loopback.c, I did not include the "gpio" prefix.
> This is what I thought was correct after reading your last mail.
> Apparently I
> You forgot to fix the Subject prefix ("staging: greybus: ").
>
> Care to fix that up and resend?
>
> Thanks,
> Johan
>
As I added the fix for loopback.c, I did not include the "gpio" prefix.
This is what I thought was correct after reading your last mail.
Apparently I misunderstood.
What
On Tue, 2017-01-03 at 20:29 +0200, Andy Shevchenko wrote:
> This series enables 64x48 OLED display and fixes the driver to work
> with DMA
> enabled SPI properly.
>
> Has been tested on Intel Edison board with Adafruit 2'8" and SSD1306
> 64x48
> (Sparkfun for Intel Edison) OLED displays at their
On Wed, Jan 11, 2017 at 02:48:38PM +0100, Roman Sommer wrote:
> Note that this patch does not fix all checkpatch warnings for the
> affected files.
>
> Signed-off-by: Christian Bewermeyer
> Signed-off-by: Roman Sommer
You forgot to fix the
Note that this patch does not fix all checkpatch warnings for the
affected files.
Signed-off-by: Christian Bewermeyer
Signed-off-by: Roman Sommer
---
drivers/staging/greybus/gpio.c | 24
On Wed, Jan 11, 2017 at 01:29:36AM +, Abdul Rauf wrote:
> Fix the following Errors:
> Bad function definition - void abort() should probably be void abort(void)
>
> Signed-off-by: Abdul Rauf
Acked-by: Johan Hovold
On 10 January 2017 at 10:45, Augusto Mecking Caringi
wrote:
> In ca91cx42_slave_get function, the value pointed by vme_base pointer is
> set through:
>
> *vme_base = ioread32(bridge->base + CA91CX42_VSI_BS[i]);
>
> So it must be dereferenced to be used in calculation of
33 matches
Mail list logo