Re: [PATCH 2/5] staging/lustre/mgc: Combine two seq_printf() calls into one call in lprocfs_mgc_rd_ir_state()

On Fri, Jan 13, 2017 at 01:58:37AM -0500, Oleg Drokin wrote: > > On Jan 1, 2017, at 11:35 AM, SF Markus Elfring wrote: Oleg, please realize that I have blacklisted this patch author, and don't take contributions from them, unless you, or someone else wishes to properly review and pass them on.

Re: [PATCH 4/5] staging/lustre/obdclass: Combine two seq_printf() calls into one call in lprocfs_rd_state()

On Jan 1, 2017, at 11:38 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 1 Jan 2017 16:26:36 +0100 > > Some data were printed into a sequence by two separate function calls. > Print the same data by a single function call instead. > > This issue

Re: [PATCH 2/5] staging/lustre/mgc: Combine two seq_printf() calls into one call in lprocfs_mgc_rd_ir_state()

On Jan 1, 2017, at 11:35 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 1 Jan 2017 15:40:29 +0100 > > Some data were printed into a sequence by two separate function calls. > Print the same data by a single function call instead. > > This issue

Re: [lustre-devel] [PATCH] staging: lustre: selftest: Make brw_inject_one_error() static

On Dec 23, 2016, at 08:42, Karthik Nayak wrote: > > Since the function brw_inject_one_error() is used only within > brw_test.c, make it static. This was reported as a warning by sparse. > > Signed-off-by: Karthik Nayak Reviewed-by: Andreas Dilger

Re: [PATCH v3 10/24] ARM: dts: imx6-sabreauto: add pinctrl for gpt input capture

On 01/12/2017 11:37 AM, Tim Harvey wrote: On Fri, Jan 6, 2017 at 6:11 PM, Steve Longerbeam wrote: Add pinctrl groups for both GPT input capture channels. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 12

[PATCH v2 4/4] staging: android/ion: Use variable names in header

Populate header function signatures with variable names as well, not just variable types. Signed-off-by: Bogdan Purcareata --- v1 -> v2: - fix CHECK report from checkpatch drivers/staging/android/ion/ion_priv.h | 38 +- 1 file

[PATCH v2 3/4] staging: android/ion: Align comment mark

Fix missing space right before multiple line comment closing. Signed-off-by: Bogdan Purcareata --- v1 -> v2 - add changelog drivers/staging/android/ion/ion_priv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 1/4] staging: android/ion: Split function call

Fix checkpatch error of line exceeding 80 characters. Signed-off-by: Bogdan Purcareata --- v1 -> v2: - add changelog - fix CHECK reports from checkpatch drivers/staging/android/ion/ion-ioctl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v2 2/4] staging: android/ion: Don't use return in void function

Return statements are superfluous in void functions, and checkpatch complains about them too. Remove offending return. Signed-off-by: Bogdan Purcareata --- v1 -> v2 - add changelog drivers/staging/android/ion/ion_of.c | 1 - 1 file changed, 1 deletion(-) diff

Re: [PATCH 1/4] staging: android/ion: Fix line over 80 characters

On Thu, Jan 12, 2017 at 11:56 AM, Greg KH wrote: > On Thu, Jan 12, 2017 at 12:32:26PM +0300, Dan Carpenter wrote: >> On Thu, Jan 12, 2017 at 09:54:16AM +0200, Bogdan Purcareata wrote: >> > Signed-off-by: Bogdan Purcareata >> >> All staging

Re: [PATCH v3 10/24] ARM: dts: imx6-sabreauto: add pinctrl for gpt input capture

On Fri, Jan 6, 2017 at 6:11 PM, Steve Longerbeam wrote: > Add pinctrl groups for both GPT input capture channels. > > Signed-off-by: Steve Longerbeam > --- > arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 12 > 1 file changed, 12

Re: [PATCH] staging: unisys: fix checkpatch block comments warning

On 01/10/2017 06:57 PM, Kershner, David A wrote: >> -Original Message- >> From: Abdul Rauf Mujahid [mailto:abdulraufmuja...@gmail.com] >> Sent: Tuesday, January 10, 2017 6:51 PM >> To: Kershner, David A ; >> gre...@linuxfoundation.org; j...@redhat.com;

Re: [PATCH 01/18] Drivers: hv: vmbus: Move the definition of hv_x64_msr_hypercall_contents

On Thu, 12 Jan 2017 02:32:24 + KY Srinivasan wrote: > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, January 10, 2017 9:27 AM > > To: KY Srinivasan > > Cc: linux-ker...@vger.kernel.org;

Re: [next] rtlwifi: rtl8192de: fix missing curly braces

Vincent wrote: > Restore some curly braces that have been removed in commit c93ac39da006457f > ("rtlwifi: Remove some redundant code") while removing redundant messages > and extraneous braces. > > This fixes the following smatch warning: > >

Re: [PATCH 9/9] treewide: Inline ib_dma_map_*() functions

On Tue, Jan 10, 2017 at 04:56:48PM -0800, Bart Van Assche wrote: > Almost all changes in this patch except the removal of local variables > that became superfluous and the actual removal of the ib_dma_map_*() > functions have been generated as follows: > > git grep -lE 'ib_(sg_|)dma_' | > xargs

[PATCH] staging: vme: vme_user.c: fix warning 'line over 80 characters'

Removed checkpatch.pl warning 'line over 80 characters' by inserting a linebreak in the comment line 50. Signed-off-by: Philip Thiemann Signed-off-by: Fabian Arnold --- drivers/staging/vme/devices/vme_user.c | 3 ++- 1 file changed, 2

Re: [PATCH 9/9] treewide: Inline ib_dma_map_*() functions

Reviewed-by: Sagi Grimberg ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/4] staging: android/ion: Fix line over 80 characters

On Thu, Jan 12, 2017 at 12:32:26PM +0300, Dan Carpenter wrote: > On Thu, Jan 12, 2017 at 09:54:16AM +0200, Bogdan Purcareata wrote: > > Signed-off-by: Bogdan Purcareata > > All staging patches need a changelog, no matter how trivial. s/staging//g :)

Re: [PATCH 1/4] staging: android/ion: Fix line over 80 characters

On Thu, Jan 12, 2017 at 09:54:16AM +0200, Bogdan Purcareata wrote: > Signed-off-by: Bogdan Purcareata All staging patches need a changelog, no matter how trivial. > --- > drivers/staging/android/ion/ion-ioctl.c | 3 ++- > 1 file changed, 2 insertions(+), 1

[PATCH 7/7] staging:r8188eu: remove unused rx_head member of struct recv_frame

Value of rx_head member of struct recv_frame does not used. Remove it. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_recv.h | 1 - drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 - 2 files changed, 2 deletions(-) diff --git

[PATCH 5/7] staging:r8188eu: remove unused struct wifidirect_info and all corresponding code

wifidirect_info structure is unused. Big amount of another definitions used only for wifidirect_info definition. Remove all. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_mlme.h | 177 ---

[PATCH 3/7] staging:r8188eu: remove unused EOR macro

EOR macro is not unused, remove it. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_recv.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index

[PATCH 2/7] staging:r8188eu: remove unused WPA_(GET|PUT)_(BE|LE)_xx macro

WPA_(GET|PUT)_(BE|LE)_xx macros are unused, remove it. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_security.h | 29 1 file changed, 29 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_security.h

[PATCH 6/7] staging:r8188eu: remove unnecessary trace output in rtw_recv_indicatepkt()

Trace output for each received packet in rtw_recv_indicatepkt() is redudant. Remove it. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/os_dep/recv_linux.c | 15 --- 1 file changed, 15 deletions(-) diff --git

[PATCH 1/7] staging:r8188eu: remove unused (GET|PUT)U32 macros

(GET|PUT)U32 macros are unused, remove it. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_security.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_security.h

[PATCH 4/7] staging:r8188eu: remove unused get_rxmem()

get_rxmem() is not unused, remove it. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_recv.h | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index

Re: [PATCH RESEND] Staging: greybus: style fix, permissions as octal

On Thu, Jan 12, 2017 at 05:59:40PM +1300, Derek Robson wrote: > Changed permissions to be in octal style. > Found by checkpatch. > > Signed-off-by: Derek Robson > --- Acked-by: Johan Hovold Next time, please include a module prefix in your Subject (i.e.

Re: [PATCH v3] staging: greybus: checkpatch: Change parameter type unsigned to unsigned int

On Thu, Jan 12, 2017 at 10:05:10AM +0300, Dan Carpenter wrote: > On Wed, Jan 11, 2017 at 04:00:35PM +0100, Roman Sommer wrote: > > Note that this patch does not fix all checkpatch warnings for the > > affected files. > > > > A lot of ways that display git commits put the changelog and the

[PATCH 1/4] staging: android/ion: Fix line over 80 characters

Signed-off-by: Bogdan Purcareata --- drivers/staging/android/ion/ion-ioctl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion-ioctl.c b/drivers/staging/android/ion/ion-ioctl.c index 7e7431d..e28fffb 100644 ---

[PATCH 3/4] staging: android/ion: Align comment mark

Signed-off-by: Bogdan Purcareata --- drivers/staging/android/ion/ion_priv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_priv.h b/drivers/staging/android/ion/ion_priv.h index 3c3b324..00d8b53 100644 ---