[PATCH] drivers: staging: rtl8188eu: include: Removed unnecssary defined macros

2017-01-14 Thread Kartikey Singh
Removed macros not in use. Signed-off-by: Kartikey Singh --- drivers/staging/rtl8188eu/include/wifi.h | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/wifi.h b/drivers/staging/rtl8188eu/include/wifi.h

[PATCH] Drivers: staging: rtl8192e: style fix, octal file permissions

2017-01-14 Thread Derek Robson
Changed file permissions to octal. Found with checkpatch. Signed-off-by: Derek Robson --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c

[PATCH] Staging: media: davinci_vpfe: style fix, using octal file permissions

2017-01-14 Thread Derek Robson
Change file permissions to octal style. Found using checkpatch. Signed-off-by: Derek Robson --- drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c

[PATCH] staging: ks7010: Fix brace style issue in ks_wlan_net.c

2017-01-14 Thread David Wittman
This change fixes a checkpatch error for "that open brace { should be on the previous line" as well as a related spacing warning. Signed-off-by: David Wittman --- drivers/staging/ks7010/ks_wlan_net.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-14 Thread Steve Longerbeam
(sorry sending again w/o html) On 01/13/2017 07:20 AM, Philipp Zabel wrote: Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: +For image capture, the IPU contains the following internal subunits: + +- Image DMA Controller (IDMAC) +- Camera Serial Interface (CSI) +- Image

Re: [PATCH 02/19] staging: iio: isl29028: remove enable flag from isl29028_enable_proximity()

2017-01-14 Thread Brian Masney
On Sun, Dec 04, 2016 at 11:16:04AM +, Jonathan Cameron wrote: > On 04/12/16 02:19, Brian Masney wrote: > > isl29028_enable_proximity() has a boolean argument named enable. This > > function is only called once and the enable flag is set to true in that > > call. This patch removes the enable

Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro

2017-01-14 Thread Ivan Safonov
On 01/14/2017 10:40 PM, Greg KH wrote: On Sun, Jan 15, 2017 at 12:44:41AM +0530, Kartikey singh wrote: Even better yet, remove it and rebuild the driver and see if it breaks :) Only if the code is not between #ifn?def / #endif... ___ devel mailing

Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro

2017-01-14 Thread Kartikey Singh
On Sat, Jan 14, 2017 at 07:38:01PM +0100, Greg KH wrote: > On Sat, Jan 14, 2017 at 11:53:36PM +0530, Kartikey Singh wrote: > > do while loop removed from single statement macro > > > > Signed-off-by: Kartikey Singh > > --- > > drivers/staging/rtl8188eu/include/wifi.h |

Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro

2017-01-14 Thread Greg KH
On Sun, Jan 15, 2017 at 12:44:41AM +0530, Kartikey singh wrote: > I think that macro is required. Anyway I won't have trouble cleaning it up if > you say so. I don't see it being used anywhere, do you? Use 'git grep' to search for it. Even better yet, remove it and rebuild the driver and see if

Re: [PATCH] drivers: staging: rtl8188eu: include: Fix semicolon after macro definition

2017-01-14 Thread Greg KH
On Sat, Jan 14, 2017 at 11:47:56PM +0530, Kartikey Singh wrote: > fixed a trailing semicolon after macro definition > > Signed-off-by: Kartikey Singh > --- > drivers/staging/rtl8188eu/include/basic_types.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro

2017-01-14 Thread Greg KH
On Sat, Jan 14, 2017 at 11:53:36PM +0530, Kartikey Singh wrote: > do while loop removed from single statement macro > > Signed-off-by: Kartikey Singh > --- > drivers/staging/rtl8188eu/include/wifi.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff

[PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro

2017-01-14 Thread Kartikey Singh
do while loop removed from single statement macro Signed-off-by: Kartikey Singh --- drivers/staging/rtl8188eu/include/wifi.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/wifi.h

[PATCH] drivers: staging: rtl8188eu: include: Fix semicolon after macro definition

2017-01-14 Thread Kartikey Singh
fixed a trailing semicolon after macro definition Signed-off-by: Kartikey Singh --- drivers/staging/rtl8188eu/include/basic_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/basic_types.h

[PATCH 1/4] staging: greybus: audio: Avoid less than zero check for le32 variable

2017-01-14 Thread Vaibhav Agarwal
mixer control->info call back function checks for -ve values to rebase min and max values. However, le32 variable is used to fetch values from GB module FW. Thus -ve value checking is not required. Fix this!! Signed-off-by: Vaibhav Agarwal ---

[PATCH 2/4] staging: greybus: audio: Initialize sig_bits before configuring hwparams

2017-01-14 Thread Vaibhav Agarwal
From: Vaibhav Agarwal Uninitialized variable sig_bits was used while configuring stream params for codec module. These params are used to configure PCM settings for APBridgeA. Usually, this is dependent on codec capability and thus populated via codec dai_driver

[PATCH 4/4] staging: greybus: audio: Ensure proper byte order

2017-01-14 Thread Vaibhav Agarwal
From: Vaibhav Agarwal Proper byte order was completely disregarded for multi byte data shared between AP and module (and APB1). Fix this. Signed-off-by: Vaibhav Agarwal Signed-off-by: Vaibhav Agarwal ---

[PATCH 0/4] Cleanup greybus audio driver

2017-01-14 Thread Vaibhav Agarwal
This patch series include following cleanup changes in GB Audio driver. - Avoid unnecessary checks for le32 variables - Initialize sig_bits before configuring hw_params - Remove junk codec register mapping - Ensure proper byte ordering Next task is to enable build for GB codec driver. However

[PATCH 3/4] staging: greybus: audio: Cleanup junk codec registers

2017-01-14 Thread Vaibhav Agarwal
From: Vaibhav Agarwal Dummy codec register were initially added while populating dummy codec mixer controls until module topology parser was available. Now, these dummy registers are nowhere used and thus can be safely removed. Since ASoC framework requires a valid

[PATCH] drivers: staging: rts5208: fix endianness handling

2017-01-14 Thread Omri Arad
'cb' and 'sgb' were assigned __le values but were not marked as such, this fixes the following sparse warnings: drivers/staging/rts5208/rtsx_transport.c:220:34: warning: incorrect type in assignment (different base types) drivers/staging/rts5208/rtsx_transport.c:220:34:expected unsigned int

Re: pull-request: vmbus 2017-01-13

2017-01-14 Thread Greg KH
On Fri, Jan 13, 2017 at 11:45:21AM -0800, Stephen Hemminger wrote: > Here is an update with cleanups based on recent changes. > > The following changes since commit b0f2d7d546d37697d3f50753904f6f0c549b62bc: > > VME: Remove node entry from vme_driver (2017-01-11 09:21:41 +0100) > > are