Re: pull-request: vmbus 2017-01-13

2017-01-18 Thread Greg KH
On Wed, Jan 18, 2017 at 02:57:13PM -0800, Stephen Hemminger wrote: > On Sat, 14 Jan 2017 14:16:07 +0100 > Greg KH wrote: > > > On Fri, Jan 13, 2017 at 11:45:21AM -0800, Stephen Hemminger wrote: > > > Here is an update with cleanups based on recent changes. > > > > > > The

Re: [PATCH 2/9] VC04_SERVICES: Add top level compat ioctl handler

2017-01-18 Thread Michael Zoran
On Thu, 2017-01-19 at 02:01 +0300, Dan Carpenter wrote: > On Wed, Jan 18, 2017 at 07:04:46AM -0800, Michael Zoran wrote: > > Add the top level compat ioctl handler as a placeholder > > for adding additional handlers. > > > > The ioctls are first filtered and forwarded to the > > regular ioctl

Re: [PATCH V2 00/18] *** SUBJECT HERE ***

2017-01-18 Thread Greg KH
On Wed, Jan 18, 2017 at 04:44:32PM -0700, k...@exchange.microsoft.com wrote: > From: K. Y. Srinivasan "interesting" subject :( ___ devel mailing list de...@linuxdriverproject.org

[greybus-dev] [PATCH] staging: greybus: loopback_test: use octal permissions instead of symbolic

2017-01-18 Thread Igor Pylypiv
checkpatch.pl warning: Symbolic permissions are not preferred. Consider using octal permissions. Signed-off-by: Igor Pylypiv --- drivers/staging/greybus/tools/loopback_test.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-18 Thread Steve Longerbeam
On 01/14/2017 02:42 PM, Steve Longerbeam wrote: +/* parse inputs property from a sensor node */ +static void of_parse_sensor_inputs(struct imx_media_dev *imxmd, + struct imx_media_subdev *sensor, + struct device_node

Re: pull-request: vmbus 2017-01-13

2017-01-18 Thread Stephen Hemminger
On Sat, 14 Jan 2017 14:16:07 +0100 Greg KH wrote: > On Fri, Jan 13, 2017 at 11:45:21AM -0800, Stephen Hemminger wrote: > > Here is an update with cleanups based on recent changes. > > > > The following changes since commit b0f2d7d546d37697d3f50753904f6f0c549b62bc: > > > >

Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host.

2017-01-18 Thread Dan Carpenter
On Wed, Jan 18, 2017 at 03:28:58PM -0500, Cathy Avery wrote: > Enable FC lightweight host option so that the luns exposed by > the driver may be manually scanned. > > Signed-off-by: Cathy Avery > --- > drivers/scsi/storvsc_drv.c | 6 +- > 1 file changed, 1 insertion(+), 5

Re: [PATCH] iio: trigger: free trigger resource correctly

2017-01-18 Thread Alison Schofield
On Wed, Jan 18, 2017 at 12:56:29PM +0300, Dan Carpenter wrote: > On Tue, Jan 17, 2017 at 07:00:28PM -0800, Alison Schofield wrote: > > Using iio_trigger_put() to free a trigger leads to release of > > a resource we never held. Replace with iio_trigger_free(). > > They're basically the same

Re: [PATCH 2/9] VC04_SERVICES: Add top level compat ioctl handler

2017-01-18 Thread Dan Carpenter
On Wed, Jan 18, 2017 at 07:04:46AM -0800, Michael Zoran wrote: > Add the top level compat ioctl handler as a placeholder > for adding additional handlers. > > The ioctls are first filtered and forwarded to the > regular ioctl handler if the ioctl does not require > any extra compatibility

Re: [PATCH net-next] net: Remove usage of net_device last_rx member

2017-01-18 Thread David Miller
From: Tobias Klauser Date: Wed, 18 Jan 2017 17:45:01 +0100 > The network stack no longer uses the last_rx member of struct net_device > since the bonding driver switched to use its own private last_rx in > commit 9f242738376d ("bonding: use last_arp_rx in slave_last_rx()").

[PATCH 1/2] scsi: scsi_transport_fc: Provide a lightweight option for Virtual FC Hosts.

2017-01-18 Thread Cathy Avery
The patch provides a means to offer a lightweight option to the current FC transport class. The new option is selected by a driver when it indicates it wants the lightweight transport via fc_function_template. Signed-off-by: Cathy Avery --- drivers/scsi/scsi_transport_fc.c |

[PATCH 2/2] scsi: storvsc: Add support for FC lightweight host.

2017-01-18 Thread Cathy Avery
Enable FC lightweight host option so that the luns exposed by the driver may be manually scanned. Signed-off-by: Cathy Avery --- drivers/scsi/storvsc_drv.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c

[PATCH 0/2] scsi: Create a lightweight FC Transport option for Virtual FC Hosts.

2017-01-18 Thread Cathy Avery
Currently virtual FC hosts or lightweight hosts are not able to be manually scanned via sysfs due to the fact that they do not contain the complete characteristic set associated with a normal FC host ( missing rports, vports, etc ) and are not consistent with the current FC transport model.

Re: [PATCH v3 0/4] Cleanup greybus audio driver

2017-01-18 Thread Mark Greer
On Wed, Jan 18, 2017 at 10:51:49PM +0530, Vaibhav Agarwal wrote: > This patch series include following cleanup changes in GB Audio driver. > - Avoid unnecessary checks for le32 variables > - Initialize sig_bits before configuring hw_params > - Remove junk codec register mapping > - Ensure proper

Re: [PATCH net-next] net: Remove usage of net_device last_rx member

2017-01-18 Thread Jay Vosburgh
Tobias Klauser wrote: >The network stack no longer uses the last_rx member of struct net_device >since the bonding driver switched to use its own private last_rx in >commit 9f242738376d ("bonding: use last_arp_rx in slave_last_rx()"). > >However, some drivers still (ab)use

Re: [PATCH 1/9] VC04_SERVICES: Add compat ioctl data structures

2017-01-18 Thread Michael Zoran
On Wed, 2017-01-18 at 18:23 +0100, Greg KH wrote: > On Wed, Jan 18, 2017 at 09:18:43AM -0800, Michael Zoran wrote: > > On Wed, 2017-01-18 at 18:13 +0100, Greg KH wrote: > > > On Wed, Jan 18, 2017 at 07:04:45AM -0800, Michael Zoran wrote: > > > > This change adds the compatibility data structures

[PATCH v3 3/4] staging: greybus: audio: Cleanup junk codec registers

2017-01-18 Thread Vaibhav Agarwal
From: Vaibhav Agarwal Dummy codec register were initially added while populating dummy codec mixer controls until module topology parser was available. Now, these dummy registers are nowhere used and thus can be safely removed. Since ASoC framework requires a valid

Re: [PATCH net-next] net: Remove usage of net_device last_rx member

2017-01-18 Thread Eric Dumazet
On Wed, 2017-01-18 at 17:45 +0100, Tobias Klauser wrote: > The network stack no longer uses the last_rx member of struct net_device > since the bonding driver switched to use its own private last_rx in > commit 9f242738376d ("bonding: use last_arp_rx in slave_last_rx()"). > > However, some

Re: [PATCH 1/9] VC04_SERVICES: Add compat ioctl data structures

2017-01-18 Thread Greg KH
On Wed, Jan 18, 2017 at 09:18:43AM -0800, Michael Zoran wrote: > On Wed, 2017-01-18 at 18:13 +0100, Greg KH wrote: > > On Wed, Jan 18, 2017 at 07:04:45AM -0800, Michael Zoran wrote: > > > This change adds the compatibility data structures for > > > compatibility > > > ioctls and defines

[PATCH v3 1/4] staging: greybus: audio: Avoid less than zero check for le32 variable

2017-01-18 Thread Vaibhav Agarwal
mixer control->info call back function checks for -ve values to rebase min and max values. However, le32 variable is used to fetch values from GB module FW. Thus negative value checking is not required. Fix this!! Signed-off-by: Vaibhav Agarwal ---

[PATCH v3 2/4] staging: greybus: audio: Initialize sig_bits before configuring hwparams

2017-01-18 Thread Vaibhav Agarwal
From: Vaibhav Agarwal Uninitialized variable sig_bits was used while configuring stream params for codec module. These params are used to configure PCM settings for APBridgeA. Usually, this is dependent on codec capability and thus populated via codec dai_driver

[PATCH v3 4/4] staging: greybus: audio: Ensure proper byte order

2017-01-18 Thread Vaibhav Agarwal
From: Vaibhav Agarwal Proper byte order was completely disregarded for multi byte data shared between AP and module (and APB1). Fix this. Signed-off-by: Vaibhav Agarwal Signed-off-by: Vaibhav Agarwal ---

Re: [PATCH v2] staging: fsl-mc: fix coding stye errors

2017-01-18 Thread Greg KH
On Wed, Jan 18, 2017 at 11:53:07AM +0100, Dhananjay Balan wrote: > Split line at boolean operator. > > Error was reported by checkpatch.pl as > WARNING: Avoid multiple line dereference - prefer 'mc_msi_domain->host_data' > > Signed-off-by: Dhananjay Balan > --- >

[PATCH v3 0/4] Cleanup greybus audio driver

2017-01-18 Thread Vaibhav Agarwal
This patch series include following cleanup changes in GB Audio driver. - Avoid unnecessary checks for le32 variables - Initialize sig_bits before configuring hw_params - Remove junk codec register mapping - Ensure proper byte ordering Next task is to enable build for GB codec driver. However

Re: [PATCH 1/9] VC04_SERVICES: Add compat ioctl data structures

2017-01-18 Thread Michael Zoran
On Wed, 2017-01-18 at 18:13 +0100, Greg KH wrote: > On Wed, Jan 18, 2017 at 07:04:45AM -0800, Michael Zoran wrote: > > This change adds the compatibility data structures for > > compatibility > > ioctls and defines compatibility ioctl definitions for the ioctls > > that have changed. > > > >

Re: [PATCH 1/9] VC04_SERVICES: Add compat ioctl data structures

2017-01-18 Thread Greg KH
On Wed, Jan 18, 2017 at 07:04:45AM -0800, Michael Zoran wrote: > This change adds the compatibility data structures for compatibility > ioctls and defines compatibility ioctl definitions for the ioctls > that have changed. > > Signed-off-by: Michael Zoran > --- >

Re: [PATCH v2 4/4] staging: greybus: audio: Ensure proper byte order

2017-01-18 Thread Vaibhav Agarwal
On Tue, Jan 17, 2017 at 11:22 PM, Mark Greer wrote: > On Tue, Jan 17, 2017 at 08:19:30PM +0530, Vaibhav Agarwal wrote: >> From: Vaibhav Agarwal >> >> Proper byte order was completely disregarded for multi byte data shared >> between AP and

[PATCH net-next] net: Remove usage of net_device last_rx member

2017-01-18 Thread Tobias Klauser
The network stack no longer uses the last_rx member of struct net_device since the bonding driver switched to use its own private last_rx in commit 9f242738376d ("bonding: use last_arp_rx in slave_last_rx()"). However, some drivers still (ab)use the field for their own purposes and some driver

Re: [PATCH v2 3/4] staging: greybus: audio: Cleanup junk codec registers

2017-01-18 Thread Vaibhav Agarwal
On Tue, Jan 17, 2017 at 11:04 PM, Mark Greer wrote: > On Tue, Jan 17, 2017 at 08:19:29PM +0530, Vaibhav Agarwal wrote: >> From: Vaibhav Agarwal >> >> Dummy codec register were initially added while populating dummy codec >> mixer controls until

Re: [PATCH v2 1/4] staging: greybus: audio: Avoid less than zero check for le32 variable

2017-01-18 Thread Vaibhav Agarwal
On Tue, Jan 17, 2017 at 10:56 PM, Mark Greer wrote: > Hi Vaibhav. > > On Tue, Jan 17, 2017 at 08:19:27PM +0530, Vaibhav Agarwal wrote: >> mixer control->info call back function checks for -ve values to rebase >> min and max values. However, le32 variable is used to fetch

[PATCH 1/9] VC04_SERVICES: Add compat ioctl data structures

2017-01-18 Thread Michael Zoran
This change adds the compatibility data structures for compatibility ioctls and defines compatibility ioctl definitions for the ioctls that have changed. Signed-off-by: Michael Zoran --- .../interface/vchiq_arm/vchiq_ioctl.h | 96 ++ 1 file

[PATCH 9/9] VC04_SERVICES: Add compat ioctl handler for "dump mem"

2017-01-18 Thread Michael Zoran
Add compat handler for "dump mem" ioctl. Signed-off-by: Michael Zoran --- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

[PATCH 3/9] VC04_SERVICES: Add compat ioctl handler for "create service"

2017-01-18 Thread Michael Zoran
Add compat handler for "create service" ioctl and move parts in common with the regular ioctl to vchiq_ioctl_create_service Signed-off-by: Michael Zoran --- .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 180 + 1 file changed, 112 insertions(+), 68

[PATCH 2/9] VC04_SERVICES: Add top level compat ioctl handler

2017-01-18 Thread Michael Zoran
Add the top level compat ioctl handler as a placeholder for adding additional handlers. The ioctls are first filtered and forwarded to the regular ioctl handler if the ioctl does not require any extra compatibility processing. Signed-off-by: Michael Zoran ---

[PATCH 6/9] VC04_SERVICES: Add compat ioctl handler for "await completion"

2017-01-18 Thread Michael Zoran
Add compat handler for "await_completion" ioctl and move parts in common with the regular ioctl to vchiq_ioctl_await_completion Signed-off-by: Michael Zoran --- .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 398 ++--- 1 file changed, 267

[PATCH 5/9] VC04_SERVICES: Add compat ioctl handler for "queue bulk"

2017-01-18 Thread Michael Zoran
Add compat handler for "queue bulk" ioctls and move parts in common with the regular ioctls to vchiq_ioctl_queue_bulk Signed-off-by: Michael Zoran --- .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 206 ++--- 1 file changed, 141 insertions(+), 65

[PATCH 7/9] VC04_SERVICES: Add compat ioctl handler for "dequeue message"

2017-01-18 Thread Michael Zoran
Add compat handler for "dequeue messagen" ioctl and move parts in common with the regular ioctl to vchiq_ioctl_dequeue_message. Signed-off-by: Michael Zoran --- .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 168 - 1 file changed, 100

[PATCH 0/9] vc04_services: Add compat ioctls

2017-01-18 Thread Michael Zoran
These set of changes add compat ioctls for vc04_services. When possible and practical common code between the native ioctl and the compat ioctl has been moved into a common function. This set includes one ioctl per patch with the first two patchs being common changes. No attempt is being made to

[PATCH 4/9] VC04_SERVICES: Add compat ioctl handler for "queue message"

2017-01-18 Thread Michael Zoran
Add compat handler for "queue message" ioctl. Signed-off-by: Michael Zoran --- .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 36 ++ 1 file changed, 36 insertions(+) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

[PATCH 8/9] VC04_SERVICES: Add compat ioctl handler for "get config"

2017-01-18 Thread Michael Zoran
Add compat handler for "get config" ioctl. Signed-off-by: Michael Zoran --- .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 32 ++ 1 file changed, 32 insertions(+) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

[PATCH v2] staging: fsl-mc: fix coding stye errors

2017-01-18 Thread Dhananjay Balan
Split line at boolean operator. Error was reported by checkpatch.pl as WARNING: Avoid multiple line dereference - prefer 'mc_msi_domain->host_data' Signed-off-by: Dhananjay Balan --- drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 4 ++-- 1 file changed, 2

Re: [PATCH v2] staging: fsl-mc: fix coding stye errors

2017-01-18 Thread Greg KH
On Wed, Jan 18, 2017 at 11:53:07AM +0100, Dhananjay Balan wrote: > Split line at boolean operator. > > Error was reported by checkpatch.pl as > WARNING: Avoid multiple line dereference - prefer 'mc_msi_domain->host_data' > > Signed-off-by: Dhananjay Balan > --- >

Re: [PATCH] iio: trigger: free trigger resource correctly

2017-01-18 Thread Dan Carpenter
On Tue, Jan 17, 2017 at 07:00:28PM -0800, Alison Schofield wrote: > Using iio_trigger_put() to free a trigger leads to release of > a resource we never held. Replace with iio_trigger_free(). They're basically the same except iio_trigger_put() puts the module and the device and free only puts the