Re: [PATCH] staging: octeon-usb: Fix coding style issues

2017-01-26 Thread Greg Kroah-Hartman
On Thu, Jan 26, 2017 at 10:46:02PM -0500, William Blough wrote: > Wrap lines that exceed 80 characters. > > Signed-off-by: William Blough > --- > drivers/staging/octeon-usb/octeon-hcd.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/

[PATCH] staging: octeon-usb: Fix coding style issues

2017-01-26 Thread William Blough
Wrap lines that exceed 80 characters. Signed-off-by: William Blough --- drivers/staging/octeon-usb/octeon-hcd.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index 9a7858a

[PATCH] staging: vt6656: Add missing identifier names

2017-01-26 Thread =?UTF-8?q?Simon=20Sandstr=C3=B6m?=
Fix multiple checkpatch.pl warnings: function definition argument '...' should also have an identifier name Signed-off-by: Simon Sandström --- drivers/staging/vt6656/card.h | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/drivers/staging/vt

[PATCH] staging: rtl8192u: Adding space after ','

2017-01-26 Thread simran singhal
This patch fixes the checkpatch issue by adding space after ','. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/

[PATCH] staging: rtl8192u: Adding space around '='

2017-01-26 Thread simran singhal
This patch fixes the checkpatch issue by adding space around '='. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers

Re: [PATCH 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-26 Thread Eric Anholt
Michael Zoran writes: > The vchi_msg_queue function which is used by other drivers > to queue a message is difficult to understand and overly > generic. Remove it and replace it with two more specific functions. > > int > vchi_queue_kernel_message(VCHI_SERVICE_HANDLE_T handle, >

[PATCH] staging/rtl8192u: add endianness conversions

2017-01-26 Thread Colin Vidal
Fields frag_size and playload_size of struct ieee80211_txb are encoded as short little-endian. This patch adds conversions to / from cpu byte order when copy / write these values in variables of architecture independent byte order. It also avoid a sparse type warning. Signed-off-by: Colin Vidal -

RE: [PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

2017-01-26 Thread KY Srinivasan
> -Original Message- > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Thursday, January 26, 2017 2:28 AM > To: Dexuan Cui > Cc: Stephen Hemminger ; driverdev- > de...@linuxdriverproject.org; KY Srinivasan ; Haiyang > Zhang ; Stephen Hemminger > ; o...@aepfle

Re: [PATCH] Corrected some Coding Style Issues V2

2017-01-26 Thread Greg Kroah-Hartman
On Thu, Jan 26, 2017 at 11:09:44PM +0530, Daksh Anand wrote: > From: daksh anand > > Signed-off-by: daksh anand > --- > drivers/staging/speakup/i18n.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Please stop now. Go read the links I sent you previously, all of these are not able to

Re: [PATCH] Corrected some Coding Style Issues

2017-01-26 Thread Greg Kroah-Hartman
On Thu, Jan 26, 2017 at 10:54:30PM +0530, Daksh Anand wrote: > From: daksh anand > > Signed-off-by: daksh anand > --- > drivers/staging/speakup/i18n.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have

[PATCH] Corrected some Coding Style Issues V2

2017-01-26 Thread Daksh Anand
From: daksh anand Signed-off-by: daksh anand --- drivers/staging/speakup/i18n.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c index b8f5bed..56ce386 100644 --- a/drivers/staging/speakup/i18n.c +++ b/drivers/st

[PATCH] Corrected some Coding Style Issues

2017-01-26 Thread Daksh Anand
From: daksh anand Signed-off-by: daksh anand --- drivers/staging/speakup/i18n.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c index 8960079..b8f5bed 100644 --- a/drivers/staging/speakup/i18n

[PATCH] Fixed some Coding Style Issues

2017-01-26 Thread Daksh Anand
From: daksh anand Signed-off-by: daksh anand --- drivers/staging/speakup/speakup_apollo.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/speakup/speakup_apollo.c b/drivers/staging/speakup/speakup_apollo.c index 3cbc8a7..3f43

[PATCH] Fixed some Coding Style Issues

2017-01-26 Thread Daksh Anand
From: daksh anand Signed-off-by: daksh anand --- drivers/staging/speakup/speakup_apollo.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/speakup/speakup_apollo.c b/drivers/staging/speakup/speakup_apollo.c index 3cbc8a7..3f43

Re: [PATCH] Corrected some Coding Style Issues

2017-01-26 Thread Stephen Hemminger
On Thu, 26 Jan 2017 22:54:30 +0530 Daksh Anand wrote: > - while ((next_percent != NULL) && !found) { > + while ((next_percent) && !found) { Remove unnecessary parenthesis here. ___ devel mailing list de...@linuxdriverproject.org http://driverde

[PATCH] Corrected some Coding Style Issues

2017-01-26 Thread Daksh Anand
From: daksh anand Signed-off-by: daksh anand --- drivers/staging/speakup/i18n.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c index 8960079..b8f5bed 100644 --- a/drivers/staging/speakup/i18n

Re: [PATCH v2 0/2] scsi: storvsc: Add support for FC lightweight host.

2017-01-26 Thread Christoph Hellwig
On Thu, Jan 26, 2017 at 08:38:58AM -0500, Cathy Avery wrote: > Included in the current storvsc driver for Hyper-V is the ability > to access luns on an FC fabric via a virtualized fiber channel > adapter exposed by the Hyper-V host. This was done to provide an > interface for existing customer tool

Re: [PATCH] staging: bcm2835-audio: initial staging submission

2017-01-26 Thread Michael Zoran
On Thu, 2017-01-26 at 14:04 +, Peter Robinson wrote: > On Thu, Jan 26, 2017 at 1:54 PM, Michael Zoran > wrote: > > On Thu, 2017-01-26 at 13:21 +, Peter Robinson wrote: > > > On Thu, Jan 26, 2017 at 12:39 AM, Michael Zoran > > net> > > > wrote: > > > > Initial cleanup of bcm2835-audio driv

Re: [PATCH] staging: bcm2835-audio: initial staging submission

2017-01-26 Thread Peter Robinson
On Thu, Jan 26, 2017 at 1:54 PM, Michael Zoran wrote: > On Thu, 2017-01-26 at 13:21 +, Peter Robinson wrote: >> On Thu, Jan 26, 2017 at 12:39 AM, Michael Zoran >> wrote: >> > Initial cleanup of bcm2835-audio driver for the >> > bcm2535(Raspberry PI) >> > >> > Driver provides HDMI audio throug

Re: [PATCH] staging: bcm2835-audio: initial staging submission

2017-01-26 Thread Michael Zoran
On Thu, 2017-01-26 at 13:21 +, Peter Robinson wrote: > On Thu, Jan 26, 2017 at 12:39 AM, Michael Zoran > wrote: > > Initial cleanup of bcm2835-audio driver for the > > bcm2535(Raspberry PI) > > > > Driver provides HDMI audio through ALSA and is built > > on top of the vc04_services driver. >

Re: [PATCH] staging: bcm2835-audio: initial staging submission

2017-01-26 Thread Michael Zoran
On Thu, 2017-01-26 at 16:25 +0300, Dan Carpenter wrote: > On Thu, Jan 26, 2017 at 05:13:02AM -0800, Michael Zoran wrote: > > On Thu, 2017-01-26 at 15:56 +0300, Dan Carpenter wrote: > > Send it.  Absolutely. > > > > > > regards, > > > dan carpenter > > > > > > > Does it need to compile on all pla

[PATCH v2 0/2] scsi: storvsc: Add support for FC lightweight host.

2017-01-26 Thread Cathy Avery
This patch set is based on the following patch submission and email exchange: [PATCH 1/1] scsi: storvsc: Support manual scan of FC hosts on Hyper-V K. Y. Srinivasan kys at microsoft.com Sat Mar 12 21:52:48 UTC 2016 http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2016-March/08711

[PATCH v2 1/2] scsi: scsi_transport_fc: Provide a lightweight option for Virtual FC Hosts.

2017-01-26 Thread Cathy Avery
This patch provides a means to offer a lightweight option to the current FC transport class. This new transport option is more suitable for FC transports running on a VM that virtualizes their FCs and that do not possess rports or vports whereas the heavyweight option maintains the standard physica

[PATCH v2 2/2] scsi: storvsc: Add support for FC lightweight host.

2017-01-26 Thread Cathy Avery
Included in the current storvsc driver for Hyper-V is the ability to access luns on an FC fabric via a virtualized fiber channel adapter exposed by the Hyper-V host. This was done to provide an interface for existing customer tools that was more consistent with a conventional FC device. The driver

Re: [PATCH] staging: bcm2835-audio: initial staging submission

2017-01-26 Thread Peter Robinson
On Thu, Jan 26, 2017 at 12:39 AM, Michael Zoran wrote: > Initial cleanup of bcm2835-audio driver for the > bcm2535(Raspberry PI) > > Driver provides HDMI audio through ALSA and is built > on top of the vc04_services driver. > > Original version of the driver is available at: > http://www.github.co

Re: [PATCH] staging: bcm2835-audio: initial staging submission

2017-01-26 Thread Dan Carpenter
On Thu, Jan 26, 2017 at 05:13:02AM -0800, Michael Zoran wrote: > On Thu, 2017-01-26 at 15:56 +0300, Dan Carpenter wrote: > Send it.  Absolutely. > > > > regards, > > dan carpenter > > > > Does it need to compile on all platforms, or can it simply compile on > arm32 until a few small issues get

Re: [PATCH] staging: bcm2835-audio: initial staging submission

2017-01-26 Thread Michael Zoran
On Thu, 2017-01-26 at 15:56 +0300, Dan Carpenter wrote: Send it.  Absolutely. > > regards, > dan carpenter > Does it need to compile on all platforms, or can it simply compile on arm32 until a few small issues get worked out. ___ devel mailing list

Re: [PATCH] staging: bcm2835-audio: initial staging submission

2017-01-26 Thread Dan Carpenter
Send it. Absolutely. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: bcm2835-audio: initial staging submission

2017-01-26 Thread Michael Zoran
On Thu, 2017-01-26 at 09:27 +0300, Dan Carpenter wrote: > Thanks! > > regards, > dan carpenter Dan, the bcm2835-camera driver is generally very high quality code. I was looking at it just now. Very clean compared to the driver I e- mailed. The camera driver does have a 64 bit issue, but for th

[PATCH] staging: greybus: loopback: fix broken udelay

2017-01-26 Thread Johan Hovold
The loopback driver allows the user to set a minimum delay of up to one second to be inserted between test iterations (i.e. request submissions). The delay is currently specified in microseconds and is implemented using udelay. Busy looping for long periods is not just anti-social; udelay must not

Re: [PATCH] This patch fixes a minor checkpatch

2017-01-26 Thread Dan Carpenter
No. The original was more clear to read. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] This patch fixes a minor checkpatch

2017-01-26 Thread Linus Liu
WARNING: line has more than 80 characters Signed-off-by: Linus Liu --- drivers/staging/octeon-usb/octeon-hcd.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index 9a7858a..5390655

[PATCH v2] Drivers: hv: balloon: add a fall through comment to hv_memory_notifier()

2017-01-26 Thread Vitaly Kuznetsov
Coverity scan gives a warning when there is fall through in a switch without a comment. This fall through is intentional as ol_waitevent needs to be completed to unblock hv_mem_hot_add() allowing it to process next requests regardless of the result of if we were able to online this block. Reported

RE: [PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

2017-01-26 Thread Dexuan Cui
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > To: Dexuan Cui > > > > v4.4.44 needs 2 patches, i.e. a389fcfd2cb5, and this patch (which is not in > > Linus's tree yet). Only backporting the first patch immediately is not > > enough > > and is also improper IMO, because

RE: [PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

2017-01-26 Thread Dexuan Cui
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > Hi Greg, > > I expect this patch (i.e. the "real" patch) would go in your char-misc tree > > first, > > then it would be merged into Linus's tree, as we usually did. > > That's fine, I'll wait for the maintainer of the sub

Re: [PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

2017-01-26 Thread gre...@linuxfoundation.org
On Thu, Jan 26, 2017 at 10:24:32AM +, Dexuan Cui wrote: > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > To: Dexuan Cui > > > > > > v4.4.44 needs 2 patches, i.e. a389fcfd2cb5, and this patch (which is not > > > in > > > Linus's tree yet). Only backporting the firs

Re: [PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

2017-01-26 Thread gre...@linuxfoundation.org
On Thu, Jan 26, 2017 at 09:31:32AM +, Dexuan Cui wrote: > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > > > > > > It's interesting v4.4.44 is not impacted, but actually it needs > > > > >

RE: [PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

2017-01-26 Thread Dexuan Cui
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > > > > > It's interesting v4.4.44 is not impacted, but actually it needs > > > > > > both the 2 > > > patches: > > > > > > i.e. this patch, and the p

Re: [PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

2017-01-26 Thread gre...@linuxfoundation.org
On Thu, Jan 26, 2017 at 08:27:26AM +, Dexuan Cui wrote: > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > > > > It's interesting v4.4.44 is not impacted, but actually it needs both > > > > > the 2 > > patches: > > > > > i.e. this patch, and the previous one: > > > >

RE: [PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

2017-01-26 Thread Dexuan Cui
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > > > It's interesting v4.4.44 is not impacted, but actually it needs both > > > > the 2 > patches: > > > > i.e. this patch, and the previous one: > > > > Commit a389fcfd2cb5 ("Drivers: hv: vmbus: Fix signaling logic in > > >