Re: Staging: ks7010: clean up ks_hostif.h

On Tue, Jan 31, 2017 at 09:53:33PM -0800, Logan Gorence wrote: > >From 58defc62d53cb473f9d745127d98df834a10b321 Mon Sep 17 00:00:00 2001 > From: Logan Gorence > Date: Tue, 31 Jan 2017 21:51:05 -0800 > Subject: [PATCH] Staging: ks7010: clean up ks_hostif.h Why is this all

Staging: ks7010: clean up ks_hostif.h

From 58defc62d53cb473f9d745127d98df834a10b321 Mon Sep 17 00:00:00 2001 From: Logan Gorence Date: Tue, 31 Jan 2017 21:51:05 -0800 Subject: [PATCH] Staging: ks7010: clean up ks_hostif.h Clean up the errors in ks_hostif.h put out by checkpatch.pl. Signed-off by: Logan

Re: [PATCH 6/6] staging: bcm2835-v4l2: Apply spelling fixes from checkpatch.

On Tue, 2017-01-31 at 10:30 -0800, Eric Anholt wrote: > Joe Perches writes: > > > On Mon, 2017-01-30 at 12:05 -0800, Eric Anholt wrote: > > > Joe Perches writes: > > > > > > > On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote: > > > > > Generated with

Re: [PATCH v3 00/24] i.MX Media Driver

On 01/31/2017 04:23 PM, Russell King - ARM Linux wrote: On Tue, Jan 31, 2017 at 03:43:22PM -0800, Steve Longerbeam wrote: On 01/31/2017 03:00 AM, Russell King - ARM Linux wrote: Just like smiapp, the camera sensor block (which is the very far end of the pipeline) is marked with

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

On 01/31/2017 08:48 AM, Philipp Zabel wrote: On Tue, 2017-01-31 at 16:51 +0100, Philipp Zabel wrote: On Fri, 2017-01-06 at 18:11 -0800, Steve Longerbeam wrote: [...] +static int csi_set_fmt(struct v4l2_subdev *sd, + struct v4l2_subdev_pad_config *cfg, +

Re: [PATCH v3 00/24] i.MX Media Driver

On 01/31/2017 05:54 AM, Philipp Zabel wrote: Hi Steve, I have just tested the imx-media-staging-md-wip branch on a Nitrogen6X with a tc358743 (BD_HDMI_MIPI HDMI to MIPI CSI-2 receiver board). Some observations: # Link pipeline media-ctl -l "'tc358743 1-000f':0->'imx6-mipi-csi2':0[1]"

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

Hi Steve, On Tue, Jan 31, 2017 at 05:02:40PM -0800, Steve Longerbeam wrote: > But this also puts a requirement on MIPI sensors that s_power(ON) > should only place the D_PHY in LP-11, and _not_ start the clock lane. > But perhaps that is correct behavior anyway. If the CSI2 DPHY is held in reset

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

On 01/31/2017 01:49 AM, Philipp Zabel wrote: On Tue, 2017-01-31 at 00:01 +, Russell King - ARM Linux wrote: [...] The iMX6 manuals call for a very specific seven sequence of initialisation for CSI2, which begins with: 1. reset the D-PHY. 2. place MIPI sensor in LP-11 state 3. perform

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

On Tue, Jan 31, 2017 at 04:31:55PM -0800, Steve Longerbeam wrote: > > > On 01/31/2017 03:20 AM, Russell King - ARM Linux wrote: > >On Fri, Jan 06, 2017 at 06:11:35PM -0800, Steve Longerbeam wrote: > >>+static int csi_link_validate(struct v4l2_subdev *sd, > >>+struct

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

On 01/31/2017 03:20 AM, Russell King - ARM Linux wrote: On Fri, Jan 06, 2017 at 06:11:35PM -0800, Steve Longerbeam wrote: +static int csi_link_validate(struct v4l2_subdev *sd, +struct media_link *link, +struct v4l2_subdev_format

Re: [PATCH v3 00/24] i.MX Media Driver

On Tue, Jan 31, 2017 at 03:43:22PM -0800, Steve Longerbeam wrote: > > > On 01/31/2017 03:00 AM, Russell King - ARM Linux wrote: > >Just like smiapp, the camera sensor block (which is the very far end > >of the pipeline) is marked with MEDIA_ENT_F_CAM_SENSOR. However, in > >front of that is the

Re: [PATCH v3 00/24] i.MX Media Driver

On 01/31/2017 03:00 AM, Russell King - ARM Linux wrote: On Mon, Jan 30, 2017 at 05:22:01PM -0800, Steve Longerbeam wrote: I'm also having trouble finding a datasheet for it, but from what I've read, it has a MIPI CSI-2 interface. It should work fine as long as it presents a single source pad,

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

On 01/31/2017 03:30 PM, Russell King - ARM Linux wrote: On Tue, Jan 31, 2017 at 02:36:53PM -0800, Steve Longerbeam wrote: On 01/31/2017 02:04 PM, Russell King - ARM Linux wrote: I don't want master though, I want v4.10-rc1, and if I ask for that it tells me it knows nothing about v4.10-rc1,

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

On Tue, Jan 31, 2017 at 02:36:53PM -0800, Steve Longerbeam wrote: > On 01/31/2017 02:04 PM, Russell King - ARM Linux wrote: > >I don't want master though, I want v4.10-rc1, and if I ask for that > >it tells me it knows nothing about v4.10-rc1, despite the fact that's > >a tag in the mainline

Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

On Tue, 2017-01-31 at 21:24 +0200, Martin Karamihov wrote: > This is checkpatch fix for hal/bb_cfg.c file: > remove not necessary braces {} > > Signed-off-by: Martin Karamihov > --- > drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

On 01/31/2017 02:04 PM, Russell King - ARM Linux wrote: On Tue, Jan 31, 2017 at 09:55:29PM +, Ian Arkver wrote: On 31/01/17 20:33, Russell King - ARM Linux wrote: On Tue, Jan 31, 2017 at 10:21:26AM -0800, Steve Longerbeam wrote: On 01/31/2017 05:42 AM, Russell King - ARM Linux wrote:

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

On 31/01/17 22:04, Russell King - ARM Linux wrote: On Tue, Jan 31, 2017 at 09:55:29PM +, Ian Arkver wrote: On 31/01/17 20:33, Russell King - ARM Linux wrote: On Tue, Jan 31, 2017 at 10:21:26AM -0800, Steve Longerbeam wrote: On 01/31/2017 05:42 AM, Russell King - ARM Linux wrote: On Fri,

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

On Tue, Jan 31, 2017 at 09:55:29PM +, Ian Arkver wrote: > On 31/01/17 20:33, Russell King - ARM Linux wrote: > >On Tue, Jan 31, 2017 at 10:21:26AM -0800, Steve Longerbeam wrote: > >>On 01/31/2017 05:42 AM, Russell King - ARM Linux wrote: > >>>On Fri, Jan 20, 2017 at 03:38:28PM +0100, Hans

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

On 31/01/17 20:33, Russell King - ARM Linux wrote: On Tue, Jan 31, 2017 at 10:21:26AM -0800, Steve Longerbeam wrote: On 01/31/2017 05:42 AM, Russell King - ARM Linux wrote: On Fri, Jan 20, 2017 at 03:38:28PM +0100, Hans Verkuil wrote: Should be set to something like

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

On Tue, Jan 31, 2017 at 10:21:26AM -0800, Steve Longerbeam wrote: > On 01/31/2017 05:42 AM, Russell King - ARM Linux wrote: > >On Fri, Jan 20, 2017 at 03:38:28PM +0100, Hans Verkuil wrote: > >>Should be set to something like 'platform:imx-media-camif'. v4l2-compliance > >>should complain about

[PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

This is checkpatch fix for hal/bb_cfg.c file: remove not necessary braces {} Signed-off-by: Martin Karamihov --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c

[PATCH] staging: gdm724x: fix sparse warnings in file gdm_lte.c

drivers/staging/gdm724x/gdm_lte.c:201:33: warning: incorrect type in assignment (different base types) drivers/staging/gdm724x/gdm_lte.c:201:33:expected unsigned int [unsigned] [addressable] [usertype] ph_len drivers/staging/gdm724x/gdm_lte.c:201:33:got restricted __be16 [usertype]

Re: [PATCH 6/6] staging: bcm2835-v4l2: Apply spelling fixes from checkpatch.

Joe Perches writes: > On Mon, 2017-01-30 at 12:05 -0800, Eric Anholt wrote: >> Joe Perches writes: >> >> > On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote: >> > > Generated with checkpatch.pl --fix-inplace and git add -p out of the >> > > results. >> >

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

On 01/31/2017 05:42 AM, Russell King - ARM Linux wrote: On Fri, Jan 20, 2017 at 03:38:28PM +0100, Hans Verkuil wrote: Should be set to something like 'platform:imx-media-camif'. v4l2-compliance should complain about this. ... and more. Right, in version 3 that you are working with, no

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

On Tue, 2017-01-31 at 16:51 +0100, Philipp Zabel wrote: > On Fri, 2017-01-06 at 18:11 -0800, Steve Longerbeam wrote: > [...] > > +static int csi_set_fmt(struct v4l2_subdev *sd, > > + struct v4l2_subdev_pad_config *cfg, > > + struct v4l2_subdev_format *sdformat) >

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

On Fri, 2017-01-06 at 18:11 -0800, Steve Longerbeam wrote: [...] > +static int csi_set_fmt(struct v4l2_subdev *sd, > +struct v4l2_subdev_pad_config *cfg, > +struct v4l2_subdev_format *sdformat) > +{ > + struct csi_priv *priv = v4l2_get_subdevdata(sd); >

Re: [PATCH v3 00/24] i.MX Media Driver

On Tue, Jan 31, 2017 at 03:25:10PM +0100, Philipp Zabel wrote: > On Tue, 2017-01-31 at 14:54 +0100, Philipp Zabel wrote: > > Hi Steve, > > > > I have just tested the imx-media-staging-md-wip branch on a Nitrogen6X > > with a tc358743 (BD_HDMI_MIPI HDMI to MIPI CSI-2 receiver board). Some > >

Re: [PATCH v3 00/24] i.MX Media Driver

On Tue, 2017-01-31 at 14:54 +0100, Philipp Zabel wrote: > Hi Steve, > > I have just tested the imx-media-staging-md-wip branch on a Nitrogen6X > with a tc358743 (BD_HDMI_MIPI HDMI to MIPI CSI-2 receiver board). Some > observations: > > # Link pipeline > media-ctl -l "'tc358743

[PATCH v2] staging: wlan-ng: This patch fixes the checkpatch.pl warning:

Fix checkpatch.pl warning: WARNING: Statements should start on a tabstop V2: whole if statement cleared up Signed-off-by: Maksymilian Piechota --- drivers/staging/wlan-ng/prism2mgmt.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [PATCH v3 00/24] i.MX Media Driver

On Tue, Jan 31, 2017 at 02:35:00PM +0100, Philipp Zabel wrote: > On Tue, 2017-01-31 at 13:14 +, Russell King - ARM Linux wrote: > > This isn't limited to the serial side - the parallel bus side between > > the CSI2 interface and CSI2IPU wrapper, and the CSI2IPU wrapper and > > the CS0/1

Re: [PATCH v3 00/24] i.MX Media Driver

Hi Steve, I have just tested the imx-media-staging-md-wip branch on a Nitrogen6X with a tc358743 (BD_HDMI_MIPI HDMI to MIPI CSI-2 receiver board). Some observations: # Link pipeline media-ctl -l "'tc358743 1-000f':0->'imx6-mipi-csi2':0[1]" media-ctl -l "'imx6-mipi-csi2':1->'ipu1_csi0_mux':0[1]"

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

On Fri, Jan 20, 2017 at 03:38:28PM +0100, Hans Verkuil wrote: > Should be set to something like 'platform:imx-media-camif'. v4l2-compliance > should complain about this. ... and more. Driver Info: Driver name : imx-media-camif Card type : imx-media-camif Bus info

Re: [PATCH v3 00/24] i.MX Media Driver

On Tue, 2017-01-31 at 13:14 +, Russell King - ARM Linux wrote: > On Tue, Jan 31, 2017 at 11:09:24AM +0100, Philipp Zabel wrote: > > On Mon, 2017-01-30 at 13:06 +, Russell King - ARM Linux wrote: > > > To help illustrate my point, consider the difference between > > >

Re: [PATCH v3 00/24] i.MX Media Driver

On Tue, Jan 31, 2017 at 11:09:24AM +0100, Philipp Zabel wrote: > On Mon, 2017-01-30 at 13:06 +, Russell King - ARM Linux wrote: > > To help illustrate my point, consider the difference between > > MEDIA_BUS_FMT_RGB565_1X16 and MEDIA_BUS_FMT_RGB565_2X8_BE or > > MEDIA_BUS_FMT_RGB565_2X8_LE.

Re: [PATCH 001] staging: wlan-ng: Add tabstop preceding the statement

On Tue, Jan 31, 2017 at 04:07:04AM -0800, Joe Perches wrote: > On Tue, 2017-01-31 at 06:33 -0500, Maksymilian Piechota wrote: > > On Tue, Jan 31, 2017 at 03:18:45AM -0800, Joe Perches wrote: > > > checkpatch is just a guide, it's brainless. > > > > > > The reason these lines are > 80 columns is >

Re: [PATCH 001] staging: wlan-ng: Add tabstop preceding the statement

On Tue, 2017-01-31 at 06:33 -0500, Maksymilian Piechota wrote: > On Tue, Jan 31, 2017 at 03:18:45AM -0800, Joe Perches wrote: > > checkpatch is just a guide, it's brainless. > > > > The reason these lines are > 80 columns is > > overly long/verbose identifiers. > > > > If you really want to

Re: [PATCH 001] staging: wlan-ng: Add tabstop preceding the statement

On Tue, Jan 31, 2017 at 03:18:45AM -0800, Joe Perches wrote: > On Tue, 2017-01-31 at 06:04 -0500, Maksymilian Piechota wrote: > > On Mon, Jan 30, 2017 at 08:00:36PM -0800, Joe Perches wrote: > > > On Mon, 2017-01-30 at 17:44 +0100, Greg Kroah-Hartman wrote: > > > > On Mon, Jan 30, 2017 at

Re: [PATCH 001] staging: wlan-ng: Add tabstop preceding the statement

On Tue, 2017-01-31 at 06:04 -0500, Maksymilian Piechota wrote: > On Mon, Jan 30, 2017 at 08:00:36PM -0800, Joe Perches wrote: > > On Mon, 2017-01-30 at 17:44 +0100, Greg Kroah-Hartman wrote: > > > On Mon, Jan 30, 2017 at 11:31:42AM -0500, Maksymilian Piechota wrote: > > > > This patch fixes the

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

On Fri, Jan 06, 2017 at 06:11:35PM -0800, Steve Longerbeam wrote: > +static int csi_link_validate(struct v4l2_subdev *sd, > + struct media_link *link, > + struct v4l2_subdev_format *source_fmt, > + struct v4l2_subdev_format

Re: [PATCH 001] staging: wlan-ng: Add tabstop preceding the statement

On Mon, Jan 30, 2017 at 08:00:36PM -0800, Joe Perches wrote: > On Mon, 2017-01-30 at 17:44 +0100, Greg Kroah-Hartman wrote: > > On Mon, Jan 30, 2017 at 11:31:42AM -0500, Maksymilian Piechota wrote: > > > This patch fixes the checkpatch.pl warning: > > > > > > WARNING: Statements should start on a

Re: [PATCH v3 00/24] i.MX Media Driver

On Mon, Jan 30, 2017 at 05:22:01PM -0800, Steve Longerbeam wrote: > I'm also having trouble finding a datasheet for it, but from what > I've read, it has a MIPI CSI-2 interface. It should work fine as long > as it presents a single source pad, registers asynchronously, and > sets its entity

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

On Fri, Jan 06, 2017 at 06:11:35PM -0800, Steve Longerbeam wrote: > This is a media entity subdevice for the i.MX Camera > Serial Interface module. > > Signed-off-by: Steve Longerbeam > --- The lack of s_frame_interval/g_frame_interval in this driver means:

Re: [PATCH v3 00/24] i.MX Media Driver

On Mon, Jan 30, 2017 at 05:22:01PM -0800, Steve Longerbeam wrote: > Edit: I see a subdev that is missing: the video mux. Did you enable > CONFIG_VIDEO_MULTIPLEXER? Yes, and that's where the problem is - the video-multiplexer is missing the module aliases to allow it to be automatically loaded.

Re: [PATCH v3 00/24] i.MX Media Driver

On Mon, 2017-01-30 at 13:06 +, Russell King - ARM Linux wrote: > > The central issue seems to be that I think media pad links / media bus > > formats should describe physical links, such as parallel or serial > > buses, and the formats of pixels flowing through them, whereas Steve > > would

Re: [PATCH 6/6] Drivers: hv: Log the negotiated IC versions.

On Sat, Jan 28, 2017 at 12:37:18PM -0700, k...@exchange.microsoft.com wrote: > From: Alex Ng > > Log the negotiated IC versions. I'll take this, but really, don't do this at all. Keep the kernel log quiet, there's no need for this. In fact, want me to just

Re: [PATCH v3 00/24] i.MX Media Driver

On Mon, 2017-01-30 at 17:22 -0800, Steve Longerbeam wrote: > > On 01/30/2017 04:45 PM, Russell King - ARM Linux wrote: > > > > Hi, > > > > Trying this driver with an imx219 camera (which works with Philipp's > > driver) results in not much happening... no /dev/media* node for it, > > no subdevs,

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

On Tue, 2017-01-31 at 00:01 +, Russell King - ARM Linux wrote: [...] > The iMX6 manuals call for a very specific seven sequence of initialisation > for CSI2, which begins with: > > 1. reset the D-PHY. > 2. place MIPI sensor in LP-11 state > 3. perform D-PHY initialisation > 4. configure CSI2

Re: [PATCH] staging: bcm2835-audio: Strengthen build dependencies

On Sat, Jan 28, 2017 at 11:07:15PM -0800, Michael Zoran wrote: > This driver makes no sense outside of ARM or ARM64. > Add an explicit build dependency on: > (ARM || ARM64 || COMPILE_TEST) > > Also set the default build to n > > Signed-off-by: Michael Zoran > --- >

Re: [PATCH 22/60] staging: lustre: fid: fix race in fid allocation

On Sat, Jan 28, 2017 at 07:04:50PM -0500, James Simmons wrote: > - if (!fid_is_zero(>lcs_fid) && > - fid_oid(>lcs_fid) < seq->lcs_width) { > + if (unlikely(!fid_is_zero(>lcs_fid) && > + fid_oid(>lcs_fid) < seq->lcs_width)) { What

Re: [PATCH 21/60] staging: lustre: ptlrpc: correct use of list_add_tail()

On Sat, Jan 28, 2017 at 07:04:49PM -0500, James Simmons wrote: > From: "John L. Hammond" > > In sptlrpc_gc_add_sec() swap the arguments to list_add_tail() so that > it does what we meant it to do. > Huh... This is from before lustre was merged into staging. What are

Re: [PATCH 14/60] staging: lustre: lov: Ensure correct operation for large object sizes

On Sat, Jan 28, 2017 at 07:04:42PM -0500, James Simmons wrote: > From: Nathaniel Clark > > If a backing filesystem (ZFS) returns that it supports very large > (LLONG_MAX) object sizes, that should be correctly supported. This > fixes the check for unitialized

Re: [PATCH 60/60] staging: lustre: libcfs: fix minimum size check for libcfs ioctl

On Tue, Jan 31, 2017 at 02:25:22AM +, James Simmons wrote: > This sounds like a separate patch. I will open a ticket about this and > your comments below. There are a some other places that need a size requirement like LNetCtl(). It really feels like it should be a part of this patch because