Re: [PATCH] staging: lustre: shut up clang warnings on CLASSERT()

On Feb 1, 2017, at 09:52, Arnd Bergmann wrote: > > lustre uses a fake switch() statement as a compile-time assert, but > unfortunately > each use of that causes a warning when building with clang: > > drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2907:2: warning: no case

Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

On 02/01/2017 08:11 PM, Joe Perches wrote: ...and clarifying the code for a human reader is much more important than making a file not have any checkpatch warnings. I agree. I respect the developers' own coding style and believe that some things (>80 characters long lines, name conventions,

Re: [PATCH] staging: vt6656: Avoid multiple line dereference

On Wed, 2017-02-01 at 21:43 +, Craig Kewley wrote: > This patch fixes the checkpatch.pl warning: > WARNING: Avoid multiple line dereference Hi Craig. Please try to make the code more sensible in preference to just fixing checkpatch warnings. > diff --git a/drivers/staging/vt6656/rxtx.c

Re: [PATCH v3 00/24] i.MX Media Driver

On 02/01/2017 01:30 AM, Philipp Zabel wrote: On Tue, 2017-01-31 at 17:26 -0800, Steve Longerbeam wrote: [...] # Set pad formats media-ctl --set-v4l2 "'tc358743 1-000f':0[fmt:UYVY/1920x1080]" media-ctl --set-v4l2 "'imx6-mipi-csi2':1[fmt:UYVY2X8/1920x1080]" media-ctl --set-v4l2

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

On 02/01/2017 03:44 PM, Russell King - ARM Linux wrote: On Fri, Jan 06, 2017 at 06:11:39PM -0800, Steve Longerbeam wrote: +static int imxcsi2_get_fmt(struct v4l2_subdev *sd, + struct v4l2_subdev_pad_config *cfg, + struct v4l2_subdev_format

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

On Fri, Jan 06, 2017 at 06:11:39PM -0800, Steve Longerbeam wrote: > +static int imxcsi2_get_fmt(struct v4l2_subdev *sd, > +struct v4l2_subdev_pad_config *cfg, > +struct v4l2_subdev_format *sdformat) > +{ > + struct imxcsi2_dev *csi2 =

[PATCH 07/10] staging: unisys: visorbus: remove putfile data structures

There were several unused data structures dealing with putfile that are no longer being used. So get rid of them. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 54 +---

[PATCH 00/10] staging: unisys: additional error handling and channel cleanups.

This series fixes a problem where we were using a Linux specific data structure in our s-Par channel. These channels are shared across multiple OS types and should not use OS specific structures unless absolutely needed. It also adds some additional error handling and other cleanup. This patchset

[PATCH 04/10] staging: unisys: visorbus: Consolidate kobject functions

From: David Binder Simplifies kobject usage in visorchipset.c by combining pairs of functions that are better expressed combined. Signed-off-by: David Binder Signed-off-by: David Kershner Reported-by: Greg

[PATCH 09/10] staging: unisys: visorbus: Clarify reason for bus pointer checks

From: David Binder Clarifies why the pointers returned from visorbus_get_device_by_id() in visorbus are validated. The check is performed in order to be extra careful, for the sake of added security, that the s-Par backend is providing us with a valid bus.

[PATCH 08/10] staging: unisys: visorbus: get rid of unused payload info

We no longer send payloads back to the s-Par firmware, we can get rid of the initialize and destroy functions since they weren't actually being used just created and destroyed. Signed-off-by: David Kershner Reviewed-by: David Binder ---

[PATCH 01/10] staging: unisys: include: fix improper use of dma_data_direction

From: Steven Matthews Replace use of standard Linux dma_data_direction with a Unisys- specific uis_dma_data_direction and provide a function to convert from the latter to the former. This is necessary because Unisys s-Par depends on the exact format of this field in

[PATCH 03/10] staging: unisys: visorbus: Check controlvm message payload size

From: David Binder Checks the controlvm message's payload size before copying it into a parser_context struct's name region. Signed-off-by: David Binder Signed-off-by: David Kershner Reported-by: Greg Kroah-Hartman

[PATCH 06/10] staging: unisys: visornic: prevent hang doing 'modprobe -r visornic'

From: Tim Sell A stray+extraneous 'netif_napi_add()' that we were doing in visornic_probe() was causing havoc when we got into visornic_remove(), called during 'modprobe -r visornic'. The symptom was a processor busy-wait loop on the modprobe process, which

[PATCH 02/10] staging: unisys: visorbus: Remove unused struct in visorchannel.c

From: David Binder Removes struct safe_uis_queue, which is within struct visorchannel. The struct is not used anywhere in the s-Par drivers. Signed-off-by: David Binder Signed-off-by: David Kershner ---

[PATCH 10/10] staging: unisys: visorbus: Clarify reason for device pointer checks

From: David Binder Clarifies why the pointers returned from visorbus_get_device_by_id() in visorbus are validated. The check is performed in order to be extra careful, for the sake of added security, that the s-Par backend is providing us with a valid device.

[PATCH 05/10] staging: unisys: visorbus: Clarify reason for pointer check in bus_destroy()

From: David Binder Clarifies why the pointer returned from visorbus_get_device_by_id() in bus_destroy() is validated. The check is performed in order to be extra careful, for the sake of added security, that the s-Par backend is providing us with a valid bus/device pair.

Re: [PATCH] staging: rtl8192e: Aligning the * on each line in block comments

On Thu, 2017-02-02 at 03:22 +0530, Arushi wrote: > This patch fixes the issue by aligning the * on each line in block comments. [] > diff --git a/drivers/staging/speakup/speakup_decpc.c > b/drivers/staging/speakup/speakup_decpc.c [] > @@ -85,8 +85,8 @@ > #define CTRL_io_priority

Re: [PATCH] Staging: ks7010: Fix tabs in ks_hostif.h.

On Wed, 2017-02-01 at 12:59 -0800, Logan Gorence wrote: > Convert spaces to tabs in ks_hostif.h, according to > the checkpatch.pl script. [] > diff --git a/drivers/staging/ks7010/ks_hostif.h > b/drivers/staging/ks7010/ks_hostif.h [] > @@ -569,18 +569,18 @@ struct hostif_mic_failure_confirm_t { >

[PATCH] staging: rtl8192e: Aligning the * on each line in block comments

This patch fixes the issue by aligning the * on each line in block comments. Signed-off-by: Arushi --- drivers/staging/speakup/fakekey.c| 10 +- drivers/staging/speakup/i18n.c | 14 +++--- drivers/staging/speakup/main.c

[PATCH] staging: vt6656: Avoid multiple line dereference

This patch fixes the checkpatch.pl warning: WARNING: Avoid multiple line dereference Signed-off-by: Craig Kewley --- drivers/staging/vt6656/rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c

[PATCH] Staging: ks7010: Fix tabs in ks_hostif.h.

Convert spaces to tabs in ks_hostif.h, according to the checkpatch.pl script. Signed-off-by: Logan Gorence --- drivers/staging/ks7010/ks_hostif.h | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git

Re: [PATCH 1/2] staging: bcm2835-audio: Replace call to vchi_msg_queue with vchi_queue_kernel_message

On Wed, 2017-02-01 at 18:04 +0100, Stefan Wahren wrote: > Am 01.02.2017 um 15:31 schrieb Michael Zoran: > > The function vchi_msg_queue was made static in vc04_services > > and replaced with vchi_queue_kernel_message. > > > > Change the call to vchi_msg_queue to vchi_queue_kernel_message > > > >

[PATCH] staging: rtl8192u: Adding a blank line after declarations

This patch fixes the checkpatch warning by adding a blank line after declarations. WARNING: Missing a blank line after declarations Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 9 + 1 file changed, 9 insertions(+)

[PATCH] staging: rtl8192e: Aligning the * on each line in block comments

This patch fixes the issue by aligning the * on each line in block comments. Signed-off-by: Arushi --- drivers/staging/rtl8192e/dot11d.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/dot11d.h

[PATCH] staging: rtl8192u: Adding a blank line after declarations

This patch fixes the checkpatch warning by adding a blank line after declarations. WARNING: Missing a blank line after declarations Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 1 file changed, 8 insertions(+)

Re: [PATCH v3 18/24] media: imx: Add SMFC subdev driver

On 02/01/2017 10:39 AM, Russell King - ARM Linux wrote: Hi Steve, On Fri, Jan 06, 2017 at 06:11:36PM -0800, Steve Longerbeam wrote: +/* + * Min/Max supported width and heights. + * + * We allow planar output from the SMFC, so we have to align + * output width by 16 pixels to meet IDMAC

Re: [PATCH v3 18/24] media: imx: Add SMFC subdev driver

Hi Steve, On Fri, Jan 06, 2017 at 06:11:36PM -0800, Steve Longerbeam wrote: > +/* > + * Min/Max supported width and heights. > + * > + * We allow planar output from the SMFC, so we have to align > + * output width by 16 pixels to meet IDMAC alignment requirements, > + * which also means input

Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

On Wed, 2017-02-01 at 18:36 +0200, Martin Karamihov wrote: > > On 02/01/2017 12:39 AM, Joe Perches wrote: > > On Tue, 2017-01-31 at 21:24 +0200, Martin Karamihov wrote: > > > This is checkpatch fix for hal/bb_cfg.c file: > > > remove not necessary braces {} > > > > > > Signed-off-by: Martin

[PATCH 08/14] vmbus: put related per-cpu variable together

The hv_context structure had several arrays which were per-cpu and was allocating small structures (tasklet_struct). Instead use a single per-cpu array. Signed-off-by: Stephen Hemminger --- drivers/hv/channel_mgmt.c | 35 - drivers/hv/connection.c | 20

Re: [PATCH 1/2] staging: bcm2835-audio: Replace call to vchi_msg_queue with vchi_queue_kernel_message

Am 01.02.2017 um 15:31 schrieb Michael Zoran: > The function vchi_msg_queue was made static in vc04_services > and replaced with vchi_queue_kernel_message. > > Change the call to vchi_msg_queue to vchi_queue_kernel_message > > Signed-off-by: Michael Zoran > --- >

[PATCH 00/14] hyperv: vmbus related patches

This is a rebase/resend of earlier patches. I skipped the pure cosmetic patches for now. Mostly this is consolidation earlier changes, removing dead code etc. The important part is the change for allowing a vmbus channel to get callback directly in interrupt mode; this is necessary for NAPI

[PATCH 14/14] vmbus: replace modulus operation with subtraction

Takes less clock cycles to check for ring wrap and subtract than to do a modulus instruction. Signed-off-by: Stephen Hemminger --- drivers/hv/ring_buffer.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/hv/ring_buffer.c

[PATCH] staging: lustre: shut up clang warnings on CLASSERT()

lustre uses a fake switch() statement as a compile-time assert, but unfortunately each use of that causes a warning when building with clang: drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2907:2: warning: no case matching constant switch condition '42'

Re: [lustre-devel] [PATCH 60/60] staging: lustre: libcfs: fix minimum size check for libcfs ioctl

On Wed, Feb 01, 2017 at 02:32:13PM +0100, Olaf Weber wrote: > On 31-01-17 03:25, James Simmons wrote: > > [...] > > > > Also I'm uncomfortable with: > > > > > > data = container_of(hdr, struct libcfs_ioctl_data, ioc_hdr); > > > > > > If hdr isn't the first member of the struct then the code

[PATCH 05/14] netvsc: remove no longer needed receive staging buffers

Since commit aed8c164ca5199 ("Drivers: hv: ring_buffer: count on wrap around mappings") it is no longer necessary to handle ring wrapping by having a special receive buffer. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 5 ---

Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

On 02/01/2017 12:39 AM, Joe Perches wrote: On Tue, 2017-01-31 at 21:24 +0200, Martin Karamihov wrote: This is checkpatch fix for hal/bb_cfg.c file: remove not necessary braces {} Signed-off-by: Martin Karamihov --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +-- 1

[PATCH 11/14] vmbus: remove conditional locking of vmbus_write

All current usage of vmbus write uses the acquire_lock flag, therefore having it be optional is unnecessary. This also fixes a sparse warning since sparse doesn't like when a function has conditional locking. Signed-off-by: Stephen Hemminger --- drivers/hv/channel.c

[PATCH 09/14] vmbus: change to per channel tasklet

Make the event handling tasklet per channel rather than per-cpu. This allows for better fairness when getting lots of data on the same cpu. Signed-off-by: Stephen Hemminger --- drivers/hv/channel.c | 2 +- drivers/hv/channel_mgmt.c | 16 +-

[PATCH 03/14] vmbus: remove no longer used signal_policy

The explicit signal policy is no longer used. A different mechanism will be added later when xmit_more is supported. Signed-off-by: Stephen Hemminger --- include/linux/hyperv.h | 18 -- 1 file changed, 18 deletions(-) diff --git a/include/linux/hyperv.h

[PATCH 12/14] vmbus: expose hv_begin/end_read

In order to implement NAPI in netvsc, the driver needs access to control host interrupt mask. Signed-off-by: Stephen Hemminger --- drivers/hv/hyperv_vmbus.h | 4 drivers/hv/ring_buffer.c | 20 include/linux/hyperv.h| 30

[PATCH 13/14] vmbus: constify parameters where possible

Functions that just query state of ring buffer can have parameters marked const. Signed-off-by: Stephen Hemminger --- drivers/hv/hyperv_vmbus.h | 6 +++--- drivers/hv/ring_buffer.c | 22 ++ include/linux/hyperv.h| 12 ++-- 3 files

[PATCH 10/14] vmbus: add direct isr callback mode

Change the simple boolean batched_reading into a tri-value. For future NAPI support in netvsc driver, the callback needs to occur directly in interrupt handler. Batched mode is also changed to disable host interrupts immediately in interrupt routine (to avoid unnecessary host signals), and the

[PATCH 02/14] vmbus: drop no longer used kick_q argument

The flag to cause notification of host is unused after commit a01a291a282f7c2e ("Drivers: hv: vmbus: Base host signaling strictly on the ring state"). Therefore remove it from the ring buffer internal API. Signed-off-by: Stephen Hemminger --- drivers/hv/channel.c |

[PATCH 06/14] vmbus: remove per channel state

The netvsc no longer needs per channel state hook to track receive buffer. Signed-off-by: Stephen Hemminger --- include/linux/hyperv.h | 14 -- 1 file changed, 14 deletions(-) diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index

[PATCH 01/14] vmbus: use kernel bitops for traversing interrupt mask

Use standard kernel operations for find first set bit to traverse the channel bit array. This has added benefit of speeding up lookup on 64 bit and because it uses find first set instruction. Signed-off-by: Stephen Hemminger --- drivers/hv/channel.c | 8 ++-

[PATCH 07/14] vmbus: callback is in softirq not workqueue

The callback is done via tasklet not workqueue. Signed-off-by: Stephen Hemminger --- include/linux/hyperv.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index 39d493ce550d..b30808f740f9 100644 ---

[PATCH 04/14] vmbus: remove unused kickq argument to sendpacket

Since sendpacket no longer uses kickq argument remove it. Remove it no longer used xmit_more in sendpacket in netvsc as well. Signed-off-by: Stephen Hemminger --- drivers/hv/channel.c| 19 +-- drivers/net/hyperv/netvsc.c | 21 +++--

[PATCH] staging: bcm2835-audio: remove incorrect include path

The driver introduces a new instance of the missing-include-dirs warning that is enabled at the "make W=1" level but has no other output: cc1: error: /git/arm-soc/drivers/staging/vc04_services/interface/vcos/linuxkernel: No such file or directory [-Werror=missing-include-dirs] In order to let

[PATCH] staging: bcm2835-audio: fix empty-body warning

gcc-7 warns about debug statements being left out here: drivers/staging/bcm2835-audio/bcm2835-vchiq.c: In function 'bcm2835_audio_set_ctls': drivers/staging/bcm2835-audio/bcm2835-vchiq.c:572:54: error: suggest braces around empty body in an 'else' statement [-Werror=empty-body] It's better to

[PATCH] staging: bcm2835-v4l: remove incorrect include path

The driver introduces a new instance of the missing-include-dirs warning that is enabled at the "make W=1" level but has no other output: cc1: error: drivers/staging/vc04_services/interface/vcos/linuxkernel: No such file or directory [-Werror=missing-include-dirs] cc1: all warnings being treated

[PATCH 1/2] staging: bcm2835-audio: Replace call to vchi_msg_queue with vchi_queue_kernel_message

The function vchi_msg_queue was made static in vc04_services and replaced with vchi_queue_kernel_message. Change the call to vchi_msg_queue to vchi_queue_kernel_message Signed-off-by: Michael Zoran --- drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 15 +++ 1

[PATCH 2/2] staging: bcm2835/mmal-vchiq: Replace call to vchi_msg_queue with vchi_queue_kernel_message

The function vchi_msg_queue was made static in vc04_services and replaced with vchi_queue_kernel_message. Change the call to vchi_msg_queue to vchi_queue_kernel_message Signed-off-by: Michael Zoran --- .../staging/media/platform/bcm2835/mmal-vchiq.c| 23

Re: [lustre-devel] [PATCH 60/60] staging: lustre: libcfs: fix minimum size check for libcfs ioctl

On 31-01-17 03:25, James Simmons wrote: [...] Also I'm uncomfortable with: data = container_of(hdr, struct libcfs_ioctl_data, ioc_hdr); If hdr isn't the first member of the struct then the code is broken but container_of() implies that that isn't a hard requirement. It should just

[PATCH 4/9] staging: fsl-mc: don't use devres api for refcounted objects

From: Laurentiu Tudor Mixing two memory management systems, in this case managed device resource api and refcounted objects is a bad idea. Lifetime of an object is controlled by its refcount so allocating it with other apis that have their own lifetime control is not ok.

[PATCH 1/9] staging: fsl-mc: drop root dprc counting

From: Laurentiu Tudor It was used just to sanity check some obscure cases that are unlikely to ever happen. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 26 +- 1 file changed, 1

[PATCH 8/9] staging: fsl-mc: dpbp: add a few missing EXPORT_SYMBOL()s

From: Laurentiu Tudor Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dpbp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/fsl-mc/bus/dpbp.c b/drivers/staging/fsl-mc/bus/dpbp.c index 1fa7257..d9e450a

[PATCH 0/9] staging: fsl-mc: fixes and cleanups

From: Laurentiu Tudor First 4 patches fix several driver model related issues and drop an useless atomic global. The rest of the patches are cleanups mostly consisting in removing dead code. For context, see these threads: https://lkml.org/lkml/2016/12/7/382

[PATCH 2/9] staging: fsl-mc: fix device ref counting

From: Laurentiu Tudor Drop unneeded get_device() call at device creation and, as per documentation, drop reference count after using device_find_child() return. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dprc-driver.c | 1 +

[PATCH 5/9] staging: fsl-mc: dpmcp: drop unused APIs

From: Laurentiu Tudor These APIs are not used yet, so drop the dead code. The patch is mostly mechanical, with a couple exceptions: - getters/setters were not removed even if only one of them is being used - versioning API was also left in place Also in this patch,

[PATCH 7/9] staging: fsl-mc: dpbp: drop unused APIs

From: Laurentiu Tudor Leave only APIs that will be used in upcomming drivers. The patch is mostly mechanical, with a couple exceptions: - getters/setters were not removed even if only one of them is being used - versioning API was also left in place They will be

[PATCH 3/9] staging: fsl-mc: add device release callback

From: Laurentiu Tudor When hot unplugging a mc-bus device the kernel displays this pertinent message, followed by a stack dump: "Device 'foo.N' does not have a release() function, it is broken and must be fixed." Add the required callback to fix. Signed-off-by:

[PATCH 9/9] staging: fsl-mc: dprc: drop unused APIs

From: Laurentiu Tudor Leave only APIs that area actually used in the bus driver. The patch is mostly mechanical, with a couple exceptions: - getters/setters were not removed even if only one of them is being used - versioning API was also left in place They will be

[PATCH] staging: bcm2835-audio: use | instead of || otherwise result is just boolean 1

From: Colin Ian King The incorrect or operator is being used resulting in cookies being set to 1 (true) rather than the intended hex value. Fix this by using | instead of ||. Issue found with static analysis with cppcheck Fixes: 0cec463e391e05b807a ("staging:

[PATCH 6/9] staging: fsl-mc: dpmng: drop unused prototype

From: Laurentiu Tudor The implementation was removed in commit: decd3d0cf (staging: fsl-mc: uprev binary interface to match MC v10.x) but the prototype was left behind. Also fix a message that was wrongly mentioning it. Signed-off-by: Laurentiu Tudor

Re: [PATCH v3 00/24] i.MX Media Driver

On Wed, Feb 01, 2017 at 11:42:31AM +0100, Philipp Zabel wrote: > On Wed, 2017-02-01 at 10:11 +, Russell King - ARM Linux wrote: > Right, it's just that in the latest version there is no v4l2_subdev for > fifos and idmac. There is the capture interface entity that represents > one of the IDMAC

Re: [PATCH v3 00/24] i.MX Media Driver

On Wed, 2017-02-01 at 10:11 +, Russell King - ARM Linux wrote: > On Wed, Feb 01, 2017 at 10:30:57AM +0100, Philipp Zabel wrote: > > On Tue, 2017-01-31 at 17:26 -0800, Steve Longerbeam wrote: > > [...] > > > right, need to fix that. Probably by poking the attached > > > source subdev (csi or

Re: [PATCH v3 00/24] i.MX Media Driver

On Wed, Feb 01, 2017 at 10:30:57AM +0100, Philipp Zabel wrote: > On Tue, 2017-01-31 at 17:26 -0800, Steve Longerbeam wrote: > [...] > > right, need to fix that. Probably by poking the attached > > source subdev (csi or prpenc/vf) for its supported formats. > > You are right, in bayer/raw mode

Re: [PATCH v3 00/24] i.MX Media Driver

On Tue, 2017-01-31 at 17:26 -0800, Steve Longerbeam wrote: [...] > > # Set pad formats > > media-ctl --set-v4l2 "'tc358743 1-000f':0[fmt:UYVY/1920x1080]" > > media-ctl --set-v4l2 "'imx6-mipi-csi2':1[fmt:UYVY2X8/1920x1080]" > > media-ctl --set-v4l2 "'ipu1_csi0_mux':2[fmt:UYVY2X8/1920x1080]" > >

Re: [PATCH v3 00/24] i.MX Media Driver

On Tue, Jan 31, 2017 at 05:54:52PM -0800, Steve Longerbeam wrote: > On 01/31/2017 04:23 PM, Russell King - ARM Linux wrote: > First, thank you for the explanation, it clears up a lot. > > But of_parse_subdev() is used to parse the OF graph starting > from the CSI ports, to discover all the nodes