Re: [PATCH v1 1/3] PCI: xilinx: Configure PCIe MPS settings

2017-02-08 Thread Christoph Hellwig
On Wed, Feb 08, 2017 at 04:49:30PM -0600, Bjorn Helgaas wrote: > + list_for_each_entry(child, >children, node) > + pcie_bus_configure_settings(child); This loop is duplicated in just about every driver, so it it might be a good idea to provide a littler helper for it.

Re: [PATCH 1/1] Ddrivers: hv: Turn off write permission on the hypercall page

2017-02-08 Thread Greg KH
On Wed, Feb 08, 2017 at 06:30:56PM -0700, k...@exchange.microsoft.com wrote: > From: K. Y. Srinivasan > > The hypercall page only needs to be executable but currently it is setup to > be writable as well. Fix the issue. > > Signed-off-by: K. Y. Srinivasan

[PATCH 0/7] iio: isl29028: move out of staging

2017-02-08 Thread Brian Masney
This is my last series of staging cleanups for the ISL29028 driver. Highlights of this patch series include some cleanups to the timing code, a fix for runtime power management support, and documentation. I mentioned in one of my earlier patch series that I was having issues getting the proximity

[PATCH 7/7] staging: iio: isl29028: move out of staging

2017-02-08 Thread Brian Masney
Move ISL29028 ALS / Proximity Sensor out of staging and into mainline. Signed-off-by: Brian Masney --- drivers/iio/light/Kconfig | 10 ++ drivers/iio/light/Makefile | 1 + drivers/{staging => }/iio/light/isl29028.c | 0

[PATCH 5/7] staging: iio: isl29028: add copyright

2017-02-08 Thread Brian Masney
Add Brian Masney's copyright to the header for the several rounds of staging cleanups that has been done to this driver. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 6/7] iio: Documentation: add ABI documentation for in_proximity_sampling_frequency_available

2017-02-08 Thread Brian Masney
Add entry for the in_proximity_sampling_frequency_available sysfs entry to the existing sampling_frequency_available ABI documentation. Signed-off-by: Brian Masney --- Documentation/ABI/testing/sysfs-bus-iio | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 1/7] staging: iio: isl29028: change mdelay() to msleep()

2017-02-08 Thread Brian Masney
This driver in some cases can busy wait for upwards of 100 ms. Since the kernel at this point is not running in atomic context, and is running in process context, we can safely use msleep() instead. This patch changes the two occurrences of mdelay() to msleep(). Signed-off-by: Brian Masney

[PATCH 2/7] staging: iio: isl29028: fix incorrect sleep time when taking initial proximity reading

2017-02-08 Thread Brian Masney
When proximity is enabled in isl29028_enable_proximity(), the function msleep() is called with the sampling frequency, which is not correct. This patch changes the code to sleep the specified amount of time listed in the datasheet instead. Signed-off-by: Brian Masney ---

[PATCH 4/7] staging: iio: isl29028: use the runtime power management for system sleep

2017-02-08 Thread Brian Masney
With the introduction of runtime power management in commit 2db5054ac28d ("staging: iio: isl29028: add runtime power management support"), the system could go to sleep and turn off the device without notifying the runtime power management code. This patch changes the system suspend and resume to

[PATCH 3/7] staging: iio: isl29028: fix incorrect sampling frequency value

2017-02-08 Thread Brian Masney
The sysfs attribute in_proximity_sampling_frequency_available currently shows the values 1 3 5 10 13 20 83 100. These values are supposed to correspond to the sleep values 800 400 200 100 75 50 12 0 (all in ms). When passing in a sampling frequency of 3, it actually uses a sleep time of 200ms

RE: [PATCH v1 0/3] PCI: Configure PCIe MPS settings

2017-02-08 Thread KY Srinivasan
> -Original Message- > From: Bjorn Helgaas [mailto:helg...@kernel.org] > Sent: Wednesday, February 8, 2017 2:49 PM > To: linux-...@vger.kernel.org > Cc: Rob Herring ; Haiyang Zhang > ; Michal Simek ; Jon > Mason

[PATCH] staging: rtl8712: rtl8712: fixed missing conversion to le32

2017-02-08 Thread Carlos Palminha
Fixed missing conversion to le32, detected by sparse (invalid assignment from int to __le32) --- drivers/staging/rtl8712/rtl8712_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl8712/rtl8712_xmit.c index

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-08 Thread Russell King - ARM Linux
On Wed, Feb 08, 2017 at 03:23:53PM -0800, Steve Longerbeam wrote: > >Actually, this exact function already exists as dw_mipi_dsi_phy_write in > >drivers/gpu/drm/rockchip/dw-mipi-dsi.c, and it looks like the D-PHY > >register 0x44 might contain a field called HSFREQRANGE_SEL. > > Thanks for

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-08 Thread Steve Longerbeam
On 02/02/2017 03:50 AM, Philipp Zabel wrote: + struct v4l2_subdev *src_sd; + struct v4l2_subdev *sink_sd[CSI2_NUM_SRC_PADS]; I see no reason to store pointers to the remote v4l2_subdevs. + intinput_pad; + struct clk

[PATCH v1 2/3] PCI: versatile: Configure PCIe MPS settings

2017-02-08 Thread Bjorn Helgaas
From: Bjorn Helgaas Make sure PCIe MPS settings are valid when we enumerate a new hierarchy. Based-on-patch-by: Jon Mason Signed-off-by: Bjorn Helgaas --- drivers/pci/host/pci-versatile.c |4 +++- 1 file changed, 3

[PATCH v1 3/3] PCI: xgene: Configure PCIe MPS settings

2017-02-08 Thread Bjorn Helgaas
From: Bjorn Helgaas Make sure PCIe MPS settings are valid when we enumerate a new hierarchy. Based-on-patch-by: Jon Mason Signed-off-by: Bjorn Helgaas --- drivers/pci/host/pci-xgene.c |4 +++- 1 file changed, 3

[PATCH v1 1/3] PCI: xilinx: Configure PCIe MPS settings

2017-02-08 Thread Bjorn Helgaas
From: Bjorn Helgaas Make sure PCIe MPS settings are valid when we enumerate a new hierarchy. Based-on-patch-by: Jon Mason Signed-off-by: Bjorn Helgaas --- drivers/pci/host/pcie-xilinx.c |4 +++- 1 file changed, 3

[PATCH v1 0/3] PCI: Configure PCIe MPS settings

2017-02-08 Thread Bjorn Helgaas
[Some of you will get this twice because Gmail and I aren't getting along today; sorry] The PCI core doesn't configure the PCIe MPS settings by itself. Each host bridge driver has to call pcie_bus_configure_settings() to make this happen. Jon fixed this already for pcie-iproc.c. I propose

[PATCH v1 3/3] PCI: xgene: Configure PCIe MPS settings

2017-02-08 Thread Bjorn Helgaas
Make sure PCIe MPS settings are valid when we enumerate a new hierarchy. Based-on-patch-by: Jon Mason Signed-off-by: Bjorn Helgaas --- drivers/pci/host/pci-xgene.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH v1 2/3] PCI: versatile: Configure PCIe MPS settings

2017-02-08 Thread Bjorn Helgaas
Make sure PCIe MPS settings are valid when we enumerate a new hierarchy. Based-on-patch-by: Jon Mason Signed-off-by: Bjorn Helgaas --- drivers/pci/host/pci-versatile.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH v1 1/3] PCI: xilinx: Configure PCIe MPS settings

2017-02-08 Thread Bjorn Helgaas
Make sure PCIe MPS settings are valid when we enumerate a new hierarchy. Based-on-patch-by: Jon Mason Signed-off-by: Bjorn Helgaas --- drivers/pci/host/pcie-xilinx.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH v1 0/3] PCI: Configure PCIe MPS settings

2017-02-08 Thread Bjorn Helgaas
The PCI core doesn't configure the PCIe MPS settings by itself. Each host bridge driver has to call pcie_bus_configure_settings() to make this happen. Jon fixed this for pcie-iproc.c. I propose these similar patches for other drivers. HV guys, I included you because create_root_hv_pci_bus()

RE: [PATCH 1/1] hv_netvsc: fix a netvsc stats typo

2017-02-08 Thread Simon Xiao
Please ignore this patch. I will resubmit it to net-next. > -Original Message- > From: Simon Xiao [mailto:six...@microsoft.com] > Sent: Tuesday, February 7, 2017 10:03 AM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger >

RE: [PATCH v3 00/10] staging: fsl-mc: fixes and cleanups

2017-02-08 Thread Stuart Yoder
> -Original Message- > From: laurentiu.tu...@nxp.com [mailto:laurentiu.tu...@nxp.com] > Sent: Tuesday, February 07, 2017 9:44 AM > To: gre...@linuxfoundation.org > Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; ag...@suse.de; > a...@arndb.de; Ioana > Ciornei

[PATCH] staging: comedi: Fix incorrect type assignment

2017-02-08 Thread Karthik Nayak
This patch fixes the following sparse error: drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers//ni_pcimio.c:1229:32:expected restricted __be32 [usertype] serial_number

Re: [PATCH 2/2] staging: comedi: drop unused variable from struct 'ni_private'

2017-02-08 Thread Karthik Nayak
Hello, >> >> ... to here. And remove the serial_number_eeprom_length, >> serial_number_eeprom_offset, and serial_number variables too. There is no >> need to continue reading the serial number bytes from the EEPROM. >> > > Ah! I'll do that and send a patch, thanks :) > Sorry for the multiple

Re: [PATCH 2/2] staging: comedi: drop unused variable from struct 'ni_private'

2017-02-08 Thread Karthik Nayak
Hey, On Wed, Feb 8, 2017 at 11:10 PM, Ian Abbott wrote: > On 08/02/2017 16:55, Karthik Nayak wrote: >> >> Drop the 'serial_number' variable from the struct 'ni_private' since >> its never used after assignment. >> >> Signed-off-by: Karthik Nayak >> ---

[PATCH] staging: most: dim2_hdm octal permissions fix

2017-02-08 Thread stephen knipe
This patch is to make the permissions sent to module_param be explicitly octal in accordance with the linux style conventions. Issues found by checkpatch.pl. Signed-off-by: stephen knipe --- drivers/staging/most/hdm-dim2/dim2_hdm.c | 4 ++-- 1 file changed, 2

Re: [PATCH] staging: comedi: Fix incorrect type assignment

2017-02-08 Thread Ian Abbott
On 07/02/17 19:06, Karthik Nayak wrote: This patch fixes the following sparse error: drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers//ni_pcimio.c:1229:32:expected restricted __be32 [usertype]

Re: [PATCH RFC 2/2] x86/vdso: Add VCLOCK_HVCLOCK vDSO clock read method

2017-02-08 Thread Thomas Gleixner
On Wed, 8 Feb 2017, Andy Lutomirski wrote: > > +#ifdef CONFIG_HYPERV_CLOCK > > +/* (a * b) >> 64 implementation */ > > +static inline u64 mul64x64_hi(u64 a, u64 b) > > +{ > > + u64 a_lo, a_hi, b_lo, b_hi, p1, p2; > > + > > + a_lo = (u32)a; > > + a_hi = a >> 32; > > + b_lo =

Re: [PATCH 2/2] staging: comedi: drop unused variable from struct 'ni_private'

2017-02-08 Thread Ian Abbott
On 08/02/2017 16:55, Karthik Nayak wrote: Drop the 'serial_number' variable from the struct 'ni_private' since its never used after assignment. Signed-off-by: Karthik Nayak --- This is to be based on top of "staging: comedi: Fix incorrect type assignment" to which this

Re: [PATCH RFC 2/2] x86/vdso: Add VCLOCK_HVCLOCK vDSO clock read method

2017-02-08 Thread Vitaly Kuznetsov
Andy Lutomirski writes: > On Wed, Feb 8, 2017 at 9:07 AM, Vitaly Kuznetsov wrote: >> Hyper-V TSC page clocksource is suitable for vDSO, however, the protocol >> defined by the hypervisor is different from VCLOCK_PVCLOCK. Implement the >> required

Re: [PATCH RFC 2/2] x86/vdso: Add VCLOCK_HVCLOCK vDSO clock read method

2017-02-08 Thread Andy Lutomirski
On Wed, Feb 8, 2017 at 9:07 AM, Vitaly Kuznetsov wrote: > Hyper-V TSC page clocksource is suitable for vDSO, however, the protocol > defined by the hypervisor is different from VCLOCK_PVCLOCK. Implement the > required support re-using pvclock_page VVAR as VCLOCK_PVCLOCK is

[PATCH RFC 0/2] x86/vdso: Add Hyper-V TSC page clocksource support

2017-02-08 Thread Vitaly Kuznetsov
Hi, Hyper-V TSC page clocksource is suitable for vDSO, however, the protocol defined by the hypervisor is different from VCLOCK_PVCLOCK. I implemented the required support re-using pvclock_page VVAR. Simple sysbench test shows the following results: Before: # time sysbench --test=memory

[PATCH RFC 1/2] hyperv: implement hv_get_tsc_page()

2017-02-08 Thread Vitaly Kuznetsov
To use Hyper-V TSC page clocksource from vDSO we need to make tsc_pg available. Implement hv_get_tsc_page() and add CONFIG_HYPERV_CLOCK to make #ifdef-s simple. Signed-off-by: Vitaly Kuznetsov --- arch/x86/hyperv/hv_init.c | 5 + arch/x86/include/asm/mshyperv.h |

[PATCH RFC 2/2] x86/vdso: Add VCLOCK_HVCLOCK vDSO clock read method

2017-02-08 Thread Vitaly Kuznetsov
Hyper-V TSC page clocksource is suitable for vDSO, however, the protocol defined by the hypervisor is different from VCLOCK_PVCLOCK. Implement the required support re-using pvclock_page VVAR as VCLOCK_PVCLOCK is mutually exclusive with VCLOCK_HVCLOCK at run time. Signed-off-by: Vitaly Kuznetsov

[PATCH 2/2] staging: comedi: drop unused variable from struct 'ni_private'

2017-02-08 Thread Karthik Nayak
Drop the 'serial_number' variable from the struct 'ni_private' since its never used after assignment. Signed-off-by: Karthik Nayak --- This is to be based on top of "staging: comedi: Fix incorrect type assignment" to which this is replied to.

Re: [PATCH] Staging: comedi: drivers: comedi_test: Add auto-configuration capability

2017-02-08 Thread Cheah Kok Cheong
On Thu, Jan 26, 2017 at 01:31:29AM +0800, Cheah Kok Cheong wrote: > Currently this module needs to be manually configured by COMEDI > userspace tool before the test waveform can be read by a COMEDI > compatible application. > > This patch adds auto-configuration capability and makes it the

Re: [PATCH] staging: comedi: Fix incorrect type assignment

2017-02-08 Thread Karthik Nayak
Hi, On Wed, Feb 8, 2017 at 7:18 PM, Ian Abbott wrote: > On 08/02/17 13:26, Karthik Nayak wrote: >> >> Hello, >> >> On Wed, Feb 8, 2017 at 6:43 PM, Ian Abbott wrote: >>> >>> On 07/02/17 19:06, Karthik Nayak wrote: This patch fixes the

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-02-08 Thread Bryan O'Donoghue
On 08/02/17 14:16, Johan Hovold wrote: > On Wed, Feb 08, 2017 at 02:05:15PM +, Bryan O'Donoghue wrote: >> On 08/02/17 11:55, Johan Hovold wrote: >>> On Wed, Feb 08, 2017 at 11:43:57AM +, Bryan O'Donoghue wrote: On 08/02/17 09:43, Johan Hovold wrote: > On Tue, Feb 07, 2017 at

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-02-08 Thread Johan Hovold
On Wed, Feb 08, 2017 at 02:05:15PM +, Bryan O'Donoghue wrote: > On 08/02/17 11:55, Johan Hovold wrote: > > On Wed, Feb 08, 2017 at 11:43:57AM +, Bryan O'Donoghue wrote: > >> On 08/02/17 09:43, Johan Hovold wrote: > >>> On Tue, Feb 07, 2017 at 02:31:04PM +, Bryan O'Donoghue wrote: >

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-02-08 Thread Bryan O'Donoghue
On 08/02/17 11:55, Johan Hovold wrote: > On Wed, Feb 08, 2017 at 11:43:57AM +, Bryan O'Donoghue wrote: >> On 08/02/17 09:43, Johan Hovold wrote: >>> On Tue, Feb 07, 2017 at 02:31:04PM +, Bryan O'Donoghue wrote: On 07/02/17 14:19, Johan Hovold wrote: > On Mon, Jan 23, 2017 at

Re: [PATCH] staging: comedi: Fix incorrect type assignment

2017-02-08 Thread Ian Abbott
On 08/02/17 13:26, Karthik Nayak wrote: Hello, On Wed, Feb 8, 2017 at 6:43 PM, Ian Abbott wrote: On 07/02/17 19:06, Karthik Nayak wrote: This patch fixes the following sparse error: drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in assignment

Re: [PATCH] staging: comedi: Fix incorrect type assignment

2017-02-08 Thread Karthik Nayak
Hello, On Wed, Feb 8, 2017 at 6:43 PM, Ian Abbott wrote: > On 07/02/17 19:06, Karthik Nayak wrote: >> >> This patch fixes the following sparse error: >> drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect >> type in assignment (different base types) >>

[PATCH v2] staging: davinci_vpfe: fix multiline comment style

2017-02-08 Thread Avraham Shukron
Aligned asterisks in multi-line comment. Signed-off-by: Avraham Shukron --- drivers/staging/media/davinci_vpfe/dm365_resizer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c

Re: [PATCH] staging: davinci_vpfe: fix multiline comment style

2017-02-08 Thread Greg Kroah-Hartman
On Wed, Feb 08, 2017 at 01:52:05PM +0200, Avraham Shukron wrote: > Signed-off-by: Avraham Shukron I can't take patches without a changelog text, and neither should any other maintainer... ___ devel mailing list

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-02-08 Thread Johan Hovold
On Wed, Feb 08, 2017 at 11:43:57AM +, Bryan O'Donoghue wrote: > On 08/02/17 09:43, Johan Hovold wrote: > > On Tue, Feb 07, 2017 at 02:31:04PM +, Bryan O'Donoghue wrote: > >> On 07/02/17 14:19, Johan Hovold wrote: > >>> On Mon, Jan 23, 2017 at 01:04:14PM +0100, Johan Hovold wrote: >

[PATCH] staging: davinci_vpfe: fix multiline comment style

2017-02-08 Thread Avraham Shukron
Signed-off-by: Avraham Shukron --- drivers/staging/media/davinci_vpfe/dm365_resizer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c b/drivers/staging/media/davinci_vpfe/dm365_resizer.c

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-02-08 Thread Bryan O'Donoghue
On 08/02/17 09:43, Johan Hovold wrote: > On Tue, Feb 07, 2017 at 02:31:04PM +, Bryan O'Donoghue wrote: >> On 07/02/17 14:19, Johan Hovold wrote: >>> On Mon, Jan 23, 2017 at 01:04:14PM +0100, Johan Hovold wrote: Add a struct timer_list to struct gb_operation and use that to implement

Re: [PATCH] staging: vc04_services: remove unused functions

2017-02-08 Thread Arnd Bergmann
On Tuesday, February 7, 2017 3:09:44 PM CET Dan Carpenter wrote: > There is a bunch of vc04_services that we're still looking to merge in > the near future. Please hold off deleting these until we are further > along on that. > More generally speaking, I'd like to see all the

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-02-08 Thread Laurent Pinchart
Hi Philipp, On Wednesday 08 Feb 2017 10:47:15 Philipp Zabel wrote: > On Tue, 2017-02-07 at 22:46 +0200, Sakari Ailus wrote: > > On Fri, Jan 06, 2017 at 06:11:31PM -0800, Steve Longerbeam wrote: > >> From: Philipp Zabel > >> > >> This driver can handle SoC internal and

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-02-08 Thread Philipp Zabel
Hi Sakari, On Tue, 2017-02-07 at 22:46 +0200, Sakari Ailus wrote: > Hi Steve, > > On Fri, Jan 06, 2017 at 06:11:31PM -0800, Steve Longerbeam wrote: > > From: Philipp Zabel > > > > This driver can handle SoC internal and external video bus multiplexers, > > controlled

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-02-08 Thread Johan Hovold
On Tue, Feb 07, 2017 at 02:31:04PM +, Bryan O'Donoghue wrote: > On 07/02/17 14:19, Johan Hovold wrote: > > On Mon, Jan 23, 2017 at 01:04:14PM +0100, Johan Hovold wrote: > >> Add a struct timer_list to struct gb_operation and use that to implement > >> generic operation timeouts. > >> > >> This