[PATCH 13/15] Staging: rtl8192u: ieee80211: ieee80211_tx.c - style fix

Fixed style of block comments Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 290 +++--- 1 file changed, 150 insertions(+), 140 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c b/drivers/stag

[PATCH 15/15] Staging: rtl8192u: ieee80211: ieee80211.h - style fix

Fixed style of block comments Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 61 +++--- 1 file changed, 36 insertions(+), 25 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/r

[PATCH 14/15] Staging: rtl8192u: ieee80211: ieee80211_rx.c - style fix

Fixed style of block comments Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 91 +++ 1 file changed, 58 insertions(+), 33 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/stagin

[PATCH 12/15] Staging: rtl8192u: ieee80211: rtl819x_BA.h - style fix

Fixed style of block comments Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h b/drivers/staging/rtl8192u/ieee80

[PATCH 11/15] Staging: rtl8192u: ieee80211: rtl819x_HT.h - style fix

Fixed style of block comments Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 69 + 1 file changed, 35 insertions(+), 34 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h b/drivers/staging/

[PATCH 10/15] Staging: rtl8192u: ieee80211: rtl819x_BAProc.c - style fix

Fixed style of block comments Found using checkpatch Signed-off-by: Derek Robson --- .../staging/rtl8192u/ieee80211/rtl819x_BAProc.c| 28 +++--- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c b/drivers/stag

[PATCH 09/15] Staging: rtl8192u: ieee80211: rtl819x_HTProc.c - style fix

Fixed style of block comments Found using checkpatch Signed-off-by: Derek Robson --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 164 ++--- 1 file changed, 82 insertions(+), 82 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/stag

[PATCH 08/15] Staging: rtl8192u: ieee80211: ieee80211_module.c - style fix

Fixed style of block comments Found using checkpatch Signed-off-by: Derek Robson --- .../staging/rtl8192u/ieee80211/ieee80211_module.c | 60 +++--- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/st

[PATCH 07/15] Staging: rtl8192u: ieee80211: ieee80211_softmac.c - style fix

Fixed style of block comments Found using checkpatch Signed-off-by: Derek Robson --- .../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 71 +++--- 1 file changed, 36 insertions(+), 35 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/s

[PATCH 06/15] Staging: rtl8192u: ieee80211: rtl819x_TSProc.c - style fix

Fixed style of block comments Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c b/drivers/staging/rtl8192u/ieee802

[PATCH 05/15] Staging: rtl8192u: r8192U.h - style fix

Fixed style of block comments Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/rtl8192u/r8192U.h | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U.h b/drivers/staging/rtl8192u/r8192

[PATCH 04/15] Staging: rtl8192u: r8192U_core.c - style fix

Fixed style of block comments Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/rtl8192u/r8192U_core.c | 70 +- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/

[PATCH 02/15] Staging: rtl8192u: r819xU_cmdpkt.c - style fix

Fixed style of block comments Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 82 1 file changed, 52 insertions(+), 30 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c b/drivers/staging/rtl8192

[PATCH 03/15] Staging: rtl8192u: r8192U_dm.c - style fix

Fixed style of block comments Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/rtl8192u/r8192U_dm.c | 175 +++ 1 file changed, 97 insertions(+), 78 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8

[PATCH 01/15] Staging: rtl8192u: ieee80211: ieee80211_wx.c - style fix

Fixed style of block comments Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 87 --- 1 file changed, 47 insertions(+), 40 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c b/drivers/stagin

[PATCH 00/15] Staging: rtl8192u - fixed block comments

Fixed style of block comments across all of the rtl8192u driver This driver has a lot of code commented out that could be deleted, I have not changed that. This is a new series as only some of the 25 set sent last week got applied. Derek Robson (15): Staging: rtl8192u: ieee80211: ieee80211_wx.

[PATCH] staging: speakup: Clean up checkpatch warnings

Fix checkpatch warnings. Signed-off-by: Olav Haugan --- drivers/staging/speakup/synth.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c index a61c02ba06da..8340748ae9cb 100644 --- a/drive

Re: [PATCH] greybus: fw-management: Replace strncpy with strlcpy

Hi Tobin, On Wed, Feb 15, 2017 at 5:39 AM, Tobin C. Harding wrote: > Greybus currently uses strncpy() coupled with a check for '\0' on the > last byte of various buffers. strncpy() is passed size parameter equal > to the size of the buffer in all instances. If the source string is > larger than t

[PATCH] staging: vt6656: rxtx.c Removed multiple dereferencing

Fixes checkpatch warning: Avoid multiple line dereference Signed-off-by: Michael S. Hansen --- drivers/staging/vt6656/rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c index aa59e7f..7f526c0 100644 --- a/d

Re: [PATCH v4 32/36] media: imx: csi/fim: add support for frame intervals

Sorry, I forgot to change authorship on this patch. It should be authored by Russell King . Steve On 02/15/2017 06:19 PM, Steve Longerbeam wrote: Add support to CSI for negotiation of frame intervals, and use this information to configure the frame interval monitor. Signed-off-by: Russell King

[PATCH v4 30/36] media: imx: update capture dev format on IDMAC output pad set_fmt

When configuring the IDMAC output pad formats (in ipu_csi, ipu_ic_prpenc, and ipu_ic_prpvf subdevs), the attached capture device format must also be updated. Signed-off-by: Steve Longerbeam Suggested-by: Philipp Zabel --- drivers/staging/media/imx/imx-ic-prpencvf.c | 9 + drivers/stagin

[PATCH v4 27/36] media: imx: csi: add support for bayer formats

From: Russell King Bayer formats must be treated as generic data and passthrough mode must be used. Add the correct setup for these formats. Signed-off-by: Russell King - added check to csi_link_validate() to verify that destination is IDMAC output pad when passthrough conditions exist: bay

[PATCH v4 35/36] media: imx: csi: fix crop rectangle reset in sink set_fmt

From: Philipp Zabel The csi_try_crop call in set_fmt should compare the cropping rectangle to the currently set input format, not to the previous input format. Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 11 +-- 1 file c

[PATCH v4 16/36] UAPI: Add media UAPI Kbuild file

Add an empty UAPI Kbuild file for media UAPI headers. Signed-off-by: Steve Longerbeam --- include/uapi/Kbuild | 1 + include/uapi/media/Kbuild | 1 + 2 files changed, 2 insertions(+) create mode 100644 include/uapi/media/Kbuild diff --git a/include/uapi/Kbuild b/include/uapi/Kbuild index

[PATCH v4 36/36] media: imx: propagate sink pad formats to source pads

Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-ic-prp.c | 11 ++- drivers/staging/media/imx/imx-ic-prpencvf.c | 22 ++ drivers/staging/media/imx/imx-media-csi.c | 26 +- drivers/staging/media/imx/imx-media-vdic.c | 15

[PATCH v4 34/36] media: imx: csi: add frame skipping support

From: Philipp Zabel The CSI can skip any out of up to 6 input frames, allowing to reduce the frame rate at the output pads by small fractions. Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 119 +- 1 fil

[PATCH v4 33/36] media: imx: redo pixel format enumeration and negotiation

The previous API and negotiation of mbus codes and pixel formats was broken, and has been completely redone. The negotiation of media bus codes should be as follows: CSI: sink pad direct src pad IDMAC src pad - RGB (any)IPU RGB

[PATCH v4 31/36] media: imx: csi: add __csi_get_fmt

Add __csi_get_fmt() and use it to return the correct mbus format (active or try) in get_fmt. Use it in other places as well. Signed-off-by: Steve Longerbeam Suggested-by: Russell King --- drivers/staging/media/imx/imx-media-csi.c | 52 --- 1 file changed, 40 insertio

[PATCH v4 24/36] [media] add Omnivision OV5640 sensor driver

This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta branch, modified heavily to bring forward to latest interfaces and code cleanup. Signed-off-by: Steve Longerbeam --- .../devicetree/bindings/media/i2c/ov5640.txt | 43 + drivers/media/i2c/Kconfig

[PATCH v4 32/36] media: imx: csi/fim: add support for frame intervals

Add support to CSI for negotiation of frame intervals, and use this information to configure the frame interval monitor. Signed-off-by: Russell King Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 36 --- drivers/staging/media/imx/imx-

[PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

From: Russell King Setting and getting frame rates is part of the negotiation mechanism between subdevs. The lack of support means that a frame rate at the sensor can't be negotiated through the subdev path. Add support at MIPI CSI2 level for handling this part of the negotiation. Signed-off-b

[PATCH v4 28/36] media: imx: csi: fix crop rectangle changes in set_fmt

From: Philipp Zabel The cropping rectangle was being modified by the output pad's set_fmt, which is the wrong pad to do this. The crop rectangle should not be modified by the output pad set_fmt. It instead should be reset to the full input frame when the input pad format is set. The output pad s

[PATCH v4 26/36] media: imx: add support for bayer formats

From: Russell King Add the bayer formats to imx-media's list of supported pixel and bus formats. Signed-off-by: Russell King - added a bayer boolean to struct imx_media_pixfmt. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-utils.c | 68 +

[PATCH v4 22/36] media: imx: Add IC subdev drivers

This is a set of four media entity subdevice drivers for the i.MX Image Converter: - Pre-process Router: Takes input frames from CSI0, CSI1, or VDIC. Two output pads enable either or both of the preprocess tasks below. If the input is from one of the CSIs, both proprocess task links can be e

[PATCH v4 25/36] ARM: imx_v6_v7_defconfig: Enable staging video4linux drivers

Enable i.MX v4l2 media staging driver. For video capture on i.MX, the video multiplexer subdev is required. On the SabreAuto, the ADV7180 video decoder is required along with i2c-mux-gpio. The Sabrelite and SabreSD require the OV5640 and the SabreLite requires PWM clocks for the OV5640. Increase m

[PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

Adds MIPI CSI-2 Receiver subdev driver. This subdev is required for sensors with a MIPI CSI2 interface. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Makefile | 1 + drivers/staging/media/imx/imx6-mipi-csi2.c | 573 + 2 files changed, 574 ins

[PATCH v4 21/36] media: imx: Add VDIC subdev driver

This is a media entity subdevice driver for the i.MX Video De-Interlacing or Combining Block. So far this entity does not implement the Combining function but only motion compensated deinterlacing. Video frames are received from the CSI and are routed to the IC PRPVF entity. Signed-off-by: Steve L

[PATCH v4 19/36] media: imx: Add Capture Device Interface

This is the capture device interface driver that provides the v4l2 user interface. Frames can be received from various sources: - directly from CSI for capturing unconverted images directly from camera sensors. - from the IC pre-process encode task. - from the IC pre-process viewfinder task.

[PATCH v4 20/36] media: imx: Add CSI subdev driver

This is a media entity subdevice for the i.MX Camera Sensor Interface module. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Kconfig | 13 + drivers/staging/media/imx/Makefile|2 + drivers/staging/media/imx/imx-media-csi.c | 1220 +

[PATCH v4 17/36] media: Add userspace header file for i.MX

This adds a header file for use by userspace programs wanting to interact with the i.MX media driver. It defines custom v4l2 controls and events generated by the i.MX v4l2 subdevices. Signed-off-by: Steve Longerbeam --- include/uapi/media/Kbuild | 1 + include/uapi/media/imx.h | 29 +++

[PATCH v4 18/36] media: Add i.MX media core driver

Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam --- Documentation/media/v4l-drivers/imx.rst | 542 + drivers/staging/media/Kconfig | 2 + drivers/staging/media/Makefile| 1 + drivers/staging/media/imx/K

[PATCH v4 15/36] platform: add video-multiplexer subdevice driver

From: Philipp Zabel This driver can handle SoC internal and external video bus multiplexers, controlled either by register bit fields or by a GPIO. The subdevice passes through frame interval and mbus configuration of the active input to the output side. Signed-off-by: Sascha Hauer Signed-off-b

[PATCH v4 07/36] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux. The OV5640 connects to the input port on the MIPI CSI-2 receiver on mipi_csi. Until the OV5652 sensor module compatible with the SabreSD becomes avai

[PATCH v4 03/36] ARM: dts: imx6qdl: Add mipi_ipu1/2 multiplexers, mipi_csi, and their connections

From: Philipp Zabel This patch adds the device tree graph connecting the input multiplexers to the IPU CSIs and the MIPI-CSI2 gasket on i.MX6. The MIPI_IPU multiplexers are added as children of the iomuxc-gpr syscon device node. On i.MX6Q/D two two-input multiplexers in front of IPU1 CSI0 and IPU

[PATCH v4 04/36] ARM: dts: imx6qdl: add capture-subsystem device

Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6dl.dtsi | 5 + arch/arm/boot/dts/imx6q.dtsi | 5 + 2 files changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi index 371288a..f1743fc 100644 --- a/arch/arm/boot/dts/imx6dl.dtsi +++

[PATCH v4 12/36] add mux and video interface bridge entity functions

From: Philipp Zabel Signed-off-by: Philipp Zabel - renamed MEDIA_ENT_F_MUX to MEDIA_ENT_F_VID_MUX Signed-off-by: Steve Longerbeam --- Documentation/media/uapi/mediactl/media-types.rst | 22 ++ include/uapi/linux/media.h| 6 ++ 2 files changed,

[PATCH v4 13/36] [media] v4l2: add a frame timeout event

Add a new FRAME_TIMEOUT event to signal that a video capture or output device has timed out waiting for reception or transmit completion of a video frame. Signed-off-by: Steve Longerbeam --- Documentation/media/uapi/v4l/vidioc-dqevent.rst | 5 + Documentation/media/videodev2.h.rst.exceptions

[PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

v4l2_pipeline_inherit_controls() will add the v4l2 controls from all subdev entities in a pipeline to a given video device. Signed-off-by: Steve Longerbeam --- drivers/media/v4l2-core/v4l2-mc.c | 48 +++ include/media/v4l2-mc.h | 25 +

[PATCH v4 11/36] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

Enables the ADV7180 decoder sensor. The ADV7180 connects to the parallel-bus mux input on ipu1_csi0_mux. The ADV7180 power pin is via max7310_b port expander. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 58 1 file changed, 58 i

[PATCH v4 10/36] ARM: dts: imx6-sabreauto: add pinctrl for gpt input capture

Add pinctrl groups for both GPT input capture channels. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi index 967c3b

[PATCH v4 09/36] ARM: dts: imx6-sabreauto: add reset-gpios property for max7310_b

The reset pin to the port expander chip (MAX7310) is controlled by a gpio, so define a reset-gpios property to control it. There are three MAX7310's on the SabreAuto CPU card (max7310_[abc]), but all use the same pin for their reset. Since all can't acquire the same pin, assign it to max7310_b, tha

[PATCH v4 06/36] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

Adds the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. Both hang off the same i2c2 bus, so they require different (and non- default) i2c slave addresses. The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux. The OV5640 connects to the input port on the MIPI CSI-

[PATCH v4 08/36] ARM: dts: imx6-sabreauto: create i2cmux for i2c3

The sabreauto uses a steering pin to select between the SDA signal on i2c3 bus, and a data-in pin for an SPI NOR chip. Use i2cmux to control this steering pin. Idle state of the i2cmux selects SPI NOR. This is not a classic way to use i2cmux, since one side of the mux selects something other than a

[PATCH v4 05/36] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

There is a pin conflict with GPIO_6. This pin functions as a power input pin to the OV5642 camera sensor, but ENET uses it as the h/w workaround for erratum ERR006687, to wake-up the ARM cores on normal RX and TX packet done events. So we need to remove the h/w workaround to support the OV5642. The

[PATCH v4 02/36] ARM: dts: imx6qdl: Add compatible, clocks, irqs to MIPI CSI-2 node

Add to the MIPI CSI2 receiver node: compatible strings, interrupt sources, and clocks. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index 61569c8..aac7

[PATCH v4 01/36] [media] dt-bindings: Add bindings for i.MX media driver

Add bindings documentation for the i.MX media driver. Signed-off-by: Steve Longerbeam --- Documentation/devicetree/bindings/media/imx.txt | 66 + 1 file changed, 66 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/imx.txt diff --git a/Documentati

[PATCH v4 00/36] i.MX Media Driver

In version 4: Changes suggested by Philipp Zabel and Jean-Michel Hautbois : - split out VDIC from imx-ic-prpvf into a distinct VDIC subdev. Changes suggested by Philipp Zabel : - Re-org of pre-process entities. Created an ipuX_ic_prp entity that receives on a single sink pad from the CSIs an

[PATCH] staging: rtl8192e: Fix endianness issue

Fix endianness issue about Mk16_le function Signed-off-by: maomao xu diff --git a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c index ae103b0..05b66d4 100644 --- a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c +++ b/drivers/staging/rtl8192e/rtllib_cr

Re: [PATCH v2 3/5] pci: set msi_domain_ops as __ro_after_init

On Wed, 15 Feb 2017, Bjorn Helgaas wrote: > We know at build-time what all the function pointers will be, so in > principle we should be able to make the struct const, which would be > even better than __ro_after_init. Not everywhere unfortunately. In some instances it's a runtime decision, but ye

Re: [PATCH v2 3/5] pci: set msi_domain_ops as __ro_after_init

On Wed, Feb 15, 2017 at 12:33 PM, Bjorn Helgaas wrote: > [+cc Kees, Thomas, Marc] > > Hi Jess, > > Thanks for the patch! > > On Fri, Feb 10, 2017 at 05:37:56PM -0800, Jess Frazelle wrote: >> Marked msi_domain_ops structs as __ro_after_init when called only during >> init. >> This protects the dat

Re: [PATCH v2 3/5] pci: set msi_domain_ops as __ro_after_init

[+cc Kees, Thomas, Marc] Hi Jess, Thanks for the patch! On Fri, Feb 10, 2017 at 05:37:56PM -0800, Jess Frazelle wrote: > Marked msi_domain_ops structs as __ro_after_init when called only during init. > This protects the data structure from accidental corruption. > > Suggested-by: Kees Cook > S

Re: [PATCH] staging: rtl8192u: Fix warnings about endianness

On Wed, Feb 15, 2017 at 09:33:15AM +0100, Arnd Bergmann wrote: > I see the same warning was addressed very differently in 99277c1f9962 > ("Staging: rtl8192e: Fix Sparse warning of cast to restricted __le16 in > rtllib_crypt_tkip.c"), which was for a close relative of that driver. > > Only one of

Re: [PATCH] staging:bcm2048 : Add parentheses around variable x

On Fri, Feb 3, 2017 at 3:42 PM, Dan Carpenter wrote: > On Sat, Dec 03, 2016 at 03:14:26PM +0530, Tabrez khan wrote: >> Add parentheses around variable x for the readability purpose. >> > > It's not really about readability... > > regards, > dan carpenter > I will resend it again. -- Regards Tab

RE: [PATCH] staging: visorbus, replace init_timer with setup_timer

> -Original Message- > From: Jiri Slaby [mailto:jsl...@suse.cz] > Sent: Wednesday, February 15, 2017 11:04 AM > To: Kershner, David A > Cc: linux-ker...@vger.kernel.org; Stefan Svinciak ; Jiri > Slaby ; Greg Kroah-Hartman > ; *S-Par-Maintainer > ; de...@driverdev.osuosl.org > Subject: [PAT

Re: [PATCH] staging: rtl8712: Fix sparse warnings about endianness

On 02/14/2017 08:57 PM, maomao xu wrote: drivers/staging/rtl8712/rtl871x_xmit.c:350:44: warning: restricted __le32 degrades to integer Signed-off-by: maomao xu You are using the wrong tree. In the staging-next branch of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git, ther

[PATCH] staging: visorbus, replace init_timer with setup_timer

From: Stefan Svinciak Newer version is more readable and needs less changes if/when timer_struct is to be changed. Signed-off-by: Stefan Svinciak Signed-off-by: Jiri Slaby Cc: David Kershner Cc: Greg Kroah-Hartman Cc: Cc: --- drivers/staging/unisys/visorbus/visorbus_main.c | 4 +--- 1 fil

Re: [PATCH 6/8] vmbus: remove unused low_latency option

On Wed, 15 Feb 2017 15:05:18 + KY Srinivasan wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Tuesday, February 14, 2017 10:21 PM > > To: KY Srinivasan ; Haiyan Yang > > > > Cc: de...@linuxdriverproject.org; Stephen Hemminger > >

[PATCH v7 2/2] staging: wlan-ng: move logical continuation at the end of line

move logical continuations at the end of line Signed-off-by: Maksymilian Piechota --- drivers/staging/wlan-ng/prism2mgmt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c index a45ff00..1cc6c9a 1

[PATCH v7 1/2] staging: wlan-ng: move else if statement to a single line

move else if statement to a single line Signed-off-by: Maksymilian Piechota --- drivers/staging/wlan-ng/prism2mgmt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c index 16fb2d3..a45ff00 100644 --

[PATCH v7 0/2] staging: wlan-ng: align else if statement to coding standard

PATCHv0: - Spaces replaced with tabs Maksymilian Piechota (1): staging: wlan-ng: This patch fixes the checkpatch.pl warning: else if statement still did not fulfill coding standard requirements. PATCHv2: - else if statement moved to single line Maksymilian Piechota (1): staging: wlan

RE: [PATCH 6/8] vmbus: remove unused low_latency option

> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, February 14, 2017 10:21 PM > To: KY Srinivasan ; Haiyan Yang > > Cc: de...@linuxdriverproject.org; Stephen Hemminger > > Subject: [PATCH 6/8] vmbus: remove unused low_latency option > >

Re: [PATCH 1/3 staging-next] android: Collect statistics from lowmemorykiller

On Wed, Feb 15, 2017 at 09:21:56AM +0100, peter enderborg wrote: > On 02/14/2017 05:51 PM, Greg KH wrote: > > On Tue, Feb 14, 2017 at 05:09:30PM +0100, peter.enderb...@sonymobile.com > > wrote: > >> From: Peter Enderborg > >> > >> This collects stats for shrinker calls and how much > >> waste wor

Re: [PATCH 1/3 staging-next] android: Collect statistics from lowmemorykiller

On Wed, Feb 15, 2017 at 09:22:10AM +0100, peter enderborg wrote: > On 02/14/2017 05:50 PM, Greg KH wrote: > > On Tue, Feb 14, 2017 at 05:09:30PM +0100, peter.enderb...@sonymobile.com > > wrote: > >> From: Peter Enderborg > >> > >> This collects stats for shrinker calls and how much > >> waste wor

Re: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at the end of line

On Wed, Feb 15, 2017 at 06:53:43AM -0500, Maksymilian Piechota wrote: > On Tue, Feb 14, 2017 at 09:16:31AM -0800, Greg Kroah-Hartman wrote: > > On Mon, Feb 13, 2017 at 09:25:49AM -0500, Maksymilian Piechota wrote: > > > move logical continuations at the end of line > > > > > > Signed-off-by: Maksy

[PATCH] Drivers: hv: util: don't forget to init host_ts.lock

Without the patch, I always get a "BUG: spinlock bad magic" warning. Fixes: 3716a49a81ba ("hv_utils: implement Hyper-V PTP source") Signed-off-by: Dexuan Cui Cc: Vitaly Kuznetsov Cc: "K. Y. Srinivasan" Cc: Haiyang Zhang Cc: Stephen Hemminger --- 3716a49a81ba is the commit id in char-misc.gi

Re: [PATCH v2] Staging: comedi: drivers: comedi_test: Add auto-configuration capability

On Mon, Feb 13, 2017 at 11:14:14AM +, Ian Abbott wrote: > On 11/02/17 10:37, Cheah Kok Cheong wrote: > >+static int __init comedi_test_init(void) > >+{ > >+int ret; > >+ > >+ret = comedi_driver_register(&waveform_driver); > >+if (ret) { > >+pr_err("comedi_test: unable to

Re: [PATCH v2 0/3] x86/vdso: Add Hyper-V TSC page clocksource support

Andy Lutomirski writes: > On Tue, Feb 14, 2017 at 7:50 AM, Vitaly Kuznetsov wrote: >> Thomas Gleixner writes: >> >>> On Tue, 14 Feb 2017, Vitaly Kuznetsov wrote: >>> Hi, while we're still waiting for a definitive ACK from Microsoft that the algorithm is good for SMP case (as

[PATCH] staging: ks7010: fix coding style issues reported by checkpatch.pl

This is patch to ks_wlan.h which fixes various coding style errors and warnings issued by checkpatch.pl Signed-off-by: Chetan Sethi --- drivers/staging/ks7010/ks_wlan.h | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/

[PATCH] staging: octeon: Use net_device_stats from struct net_device

Instead of using a private copy of struct net_device_stats in struct octeon_ethernet, use stats from struct net_device. Also remove the now unnecessary .ndo_get_stats function. Signed-off-by: Tobias Klauser --- drivers/staging/octeon/ethernet-rx.c | 6 +++--- drivers/staging/octeon/ethernet

Re: [patch] staging: bcm2835-camera: free first element in array

Am 15.02.2017 13:25, schrieb Dan Carpenter: > We should free gdev[0] so the > should be >=. > > Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera > driver.") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/staging/media/platform/bcm2835/bcm2835-camera.c > b/dri

[patch] staging: bcm2835-camera: free first element in array

We should free gdev[0] so the > should be >=. Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera driver.") Signed-off-by: Dan Carpenter diff --git a/drivers/staging/media/platform/bcm2835/bcm2835-camera.c b/drivers/staging/media/platform/bcm2835/bcm2835-camera.c index ca1

Re: [PATCH] staging:nvec:nvec_ps2.c: Preferingkzalloc(sizeof(*ser_dev)...) over kzalloc(sizeof(struct serio)...)

Am Dienstag, 14. Februar 2017, 22:31:20 CET schrieb Arushi Singhal: > Prefer kzalloc(sizeof(*ser_dev)...) over kzalloc(sizeof(struct > serio)...) as reported by checkpatch.pl. > > Signed-off-by: Arushi Singhal looks like we are in a (make everyone) happy week. Acked-by: Marc Dietrich > --- >

Re: [PATCH] staging: fsl-mc: Add missing header

On 02/13/2017 06:40 PM, Bogdan Purcareata wrote: > Compiling the fsl-mc bus driver will yield a couple of static analysis > errors: > warning: symbol 'fsl_mc_msi_domain_alloc_irqs' was not declared > warning: symbol 'fsl_mc_msi_domain_free_irqs' was not declared. > warning: symbol 'its_fsl_mc_msi

Re: [PATCH] greybus: fw-management: Replace strncpy with strlcpy

On 15/02/17 00:09, Tobin C. Harding wrote: > Greybus currently uses strncpy() coupled with a check for '\0' on the > last byte of various buffers. strncpy() is passed size parameter equal > to the size of the buffer in all instances. If the source string is > larger than the destination buffer the

Re: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at the end of line

On Tue, Feb 14, 2017 at 09:16:31AM -0800, Greg Kroah-Hartman wrote: > On Mon, Feb 13, 2017 at 09:25:49AM -0500, Maksymilian Piechota wrote: > > move logical continuations at the end of line > > > > Signed-off-by: Maksymilian Piechota > > --- > > drivers/staging/wlan-ng/prism2mgmt.c | 5 ++--- > >

[PATCH] Staging: Speakup: speakup_decpc: fixed a block comment misalignment

Fixed a coding style issue (block comments misasligned and code indents not done with tabs) Signed-off-by: Daniel Perez --- drivers/staging/speakup/speakup_decpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/s

[PATCH] staging: rtl8192u: Fix warnings about endianness

drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:564:37: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:564:37:expected unsigned short [unsigned] [usertype] len drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:564:37:got re

Re: [PATCH] staging: rtl8192u: Fix warnings about endianness

Hi maomao, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.10-rc8 next-20170215] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/maomao-xu/staging-rtl8192u-Fix

Re: [PATCH v3 00/24] i.MX Media Driver

Hi Steve, On Tue, 2017-02-14 at 18:27 -0800, Steve Longerbeam wrote: [...] > > > > # Provide an EDID to the HDMI source > > v4l2-ctl -d /dev/v4l-subdev2 --set-edid=file=edid-1080p.hex > > I can probably generate this Intel hex file myself from sysfs > edid outputs, but for convenience do you mind

Re: [PATCH] staging: fwserial: replace 'a' with '(a)' to avoid precedence issues

On Wed, 2017-02-15 at 09:14 +0100, Geert Uytterhoeven wrote: > On Tue, Feb 14, 2017 at 7:08 PM, Greg KH wrote: > > On Tue, Feb 14, 2017 at 11:26:20PM +0530, Arushi Singhal wrote: > > > Macro argument 'a' may be better as '(a)' to avoid precedence issues as > > > reported by checkpatch.pl > > > >

Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

On Wed, 2017-02-15 at 13:48 +0530, SIMRAN SINGHAL wrote: > Joe, I am new to Linux kernel and just have basic knowledge of > C and C++. > For doing more than checkpatches I need to explore Linux kernel more, > so please suggest me some tasks that help me in exploring > Linux kernel, which helps me

[PATCH] staging: rtl8192u: Fix warnings about endianness

drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:564:37: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:564:37:expected unsigned short [unsigned] [usertype] len drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:564:37:got re

Re: [PATCH] staging: rtl8192u: Fix warnings about endianness

On Wed, Feb 15, 2017 at 8:54 AM, maomao xu wrote: > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:177:16: warning: > cast to restricted __le16 > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:177:16: warning: > cast to restricted __le16 > drivers/staging/rtl8192u/ieee80211

[PATCH] staging: xgifb: function definition argument should also have an identifier name

function definition argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name. Signed-off-by: Arushi Singhal --- drivers/staging/xgifb/vb_init.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/

Re: [PATCH 1/3 staging-next] android: Collect statistics from lowmemorykiller

On 02/14/2017 05:51 PM, Greg KH wrote: > On Tue, Feb 14, 2017 at 05:09:30PM +0100, peter.enderb...@sonymobile.com > wrote: >> From: Peter Enderborg >> >> This collects stats for shrinker calls and how much >> waste work we do within the lowmemorykiller. >> >> Signed-off-by: Peter Enderborg > Wai

Re: [PATCH 1/3 staging-next] android: Collect statistics from lowmemorykiller

On 02/14/2017 05:50 PM, Greg KH wrote: > On Tue, Feb 14, 2017 at 05:09:30PM +0100, peter.enderb...@sonymobile.com > wrote: >> From: Peter Enderborg >> >> This collects stats for shrinker calls and how much >> waste work we do within the lowmemorykiller. >> >> Signed-off-by: Peter Enderborg >> --

Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

On Wed, Feb 15, 2017 at 9:01 AM, Joe Perches wrote: > On Wed, 2017-02-15 at 08:52 +0530, SIMRAN SINGHAL wrote: >> Yes, I totally agree with joe. >> >> But as there is no coding style issue in this patch. > > Style is more than just checkpatch conformity. > >> So, do I have to resend the complete p

Re: [PATCH] staging: fwserial: replace 'a' with '(a)' to avoid precedence issues

On Tue, Feb 14, 2017 at 7:08 PM, Greg KH wrote: > On Tue, Feb 14, 2017 at 11:26:20PM +0530, Arushi Singhal wrote: >> Macro argument 'a' may be better as '(a)' to avoid precedence issues as >> reported by checkpatch.pl >> >> Signed-off-by: Arushi Singhal >> --- >> drivers/staging/fwserial/fwseria