On Tue, 21 Feb 2017, SIMRAN SINGHAL wrote:
>
>
> On Wednesday, February 22, 2017 at 1:28:52 AM UTC+5:30, Julia Lawall wrote:
>
>
> On Wed, 22 Feb 2017, simran singhal wrote:
>
> > The macro DIV_ROUND_UP performs the computation (((n) + (d) -
> 1) /(d)).
> > It clarifies t
On Wed, 22 Feb 2017, Arushi Singhal wrote:
> function definition argument like 'struct vb_device_info *','unsigned
> long' etc. should also have an identifier name.
Actually, this is not really clear. The definition of a function is the
thing that has the actual code, like
int foo(int x) {
re
This patch makes spk_set_key_info return -EINVAL
in case of failure instead of returning 4 different
values for the type of error that occurred.
Print the offending values instead as debug message.
Signed-off-by: Pranay Kr. Srivastava
---
drivers/staging/speakup/main.c | 27 +++-
This patch removes the unnecessary allocation of
current foreground vc during initialization.
This initialization is already handled in the loop
that follows it for all available virtual consoles.
Also change the prototype of speakup_allocate to take
extra argument of gfp_* flags. Thus not requir
Sending both patches as series instead. Made the required changes as
suggessted in earlier versions and fixed the warnings reported from
kbuild test robot.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailm
On Tue, 21 Feb 2017, Tahia Khan wrote:
> Fixes multiple camel case checks on struct tstrRSSI from checkpatch.pl:
>
> Avoid CamelCase:
> Avoid CamelCase:
> Avoid CamelCase:
>
> Signed-off-by: Tahia Khan
> ---
> drivers/staging/wilc1000/coreconfigurator.h | 8
> drivers/stagin
Fixes multiple camel case checks on struct tstrRSSI from checkpatch.pl:
Avoid CamelCase:
Avoid CamelCase:
Avoid CamelCase:
Signed-off-by: Tahia Khan
---
drivers/staging/wilc1000/coreconfigurator.h | 8
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 +-
2 files
On Wed, 2017-02-22 at 09:46 +0530, Arushi Singhal wrote:
> On Wed, Feb 22, 2017 at 12:12 AM, Joe Perches wrote:
>
> > On Tue, 2017-02-21 at 18:40 +0100, Julia Lawall wrote:
> > >
> > > On Tue, 21 Feb 2017, Arushi Singhal wrote:
> > >
> > > > Error was reported by checkpatch.pl as
> > > > WARNIN
function definition argument like 'struct vb_device_info *','unsigned
long' etc. should also have an identifier name.
Signed-off-by: Arushi Singhal
---
Changes in v2:
- By mistake one irrelevant line was added which is removed in this
patch.
- write the changes done in previous version in
Removed initialisation of a varible if it is immediately reassigned.
Changes were made using Coccinelle.
@@
type T;
constant C;
expression e;
identifier i;
@@
T i
- = C
;
i = e;
Signed-off-by: simran singhal
---
drivers/staging/gdm724x/gdm_lte.c | 2 +-
drivers/staging/gdm724x/gdm_mux.c | 4 ++
Juste un coucou pour te signifier que, j aimerais mieux te connaitre, je veux
surtout, échanger, partager, discuter avec toi . en somme, mieux faire ta
connaissance
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproje
On 02/21/2017 02:21 PM, Steve Longerbeam wrote:
On 02/21/2017 04:15 AM, Sakari Ailus wrote:
Hi Steve,
On Mon, Feb 20, 2017 at 02:56:15PM -0800, Steve Longerbeam wrote:
On 02/20/2017 02:04 PM, Sakari Ailus wrote:
Hi Steve,
On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote
On 21/02/17 11:18, Tobin C. Harding wrote:
Checkpatch emits WARNING: struct comedi_lrange should normally be
const.
Add const keyword to definition of struct.
Signed-off-by: Tobin C. Harding
---
drivers/staging/comedi/drivers/addi_apci_3501.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Checkpatch emits WARNING: Block comments use a trailing */ on a
separate line. Offending comments are commenting variables within
the main data structure of s626 driver. We can move these comments
to kernel doc format with the benefit of clearing the warning and
improving the documentation for the
On 02/21/2017 04:15 AM, Sakari Ailus wrote:
Hi Steve,
On Mon, Feb 20, 2017 at 02:56:15PM -0800, Steve Longerbeam wrote:
On 02/20/2017 02:04 PM, Sakari Ailus wrote:
Hi Steve,
On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote:
From: Russell King
Setting and getting frame r
On Wed, Feb 22, 2017 at 08:27:37AM +1100, Tobin C. Harding wrote:
> Comedi drivers make heavy use of standard types i.e unsigned
> short. According to Linux Device Drivers standard C data types are not
> the same size of all architectures.
>
> Should we be converting comedi/drivers to use kernel t
Comedi drivers make heavy use of standard types i.e unsigned
short. According to Linux Device Drivers standard C data types are not
the same size of all architectures.
Should we be converting comedi/drivers to use kernel types u8, u16 etc
Follow up question. Some comedi/drivers also use unsigned
On Tue, 2017-02-21 at 23:16 +0530, simran singhal wrote:
> The macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /(d)).
> It clarifies the divisor calculations. This occurence was detected using
> the coccinelle script:
>
> @@
> expression e1;
> expression e2;
> @@
> (
> - ((e1) + e2 -
Hi Arushi,
[auto build test ERROR on v4.9-rc8]
[cannot apply to staging/staging-testing next-20170220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Arushi-Singhal/staging-xgifb-function-defini
On Tue, Feb 21, 2017 at 04:00:40PM +, Ian Abbott wrote:
> On 21/02/17 11:18, Tobin C. Harding wrote:
> >Checkpatch emits multiple WARNING: Avoid multiple line dereference.
> >Removing these warnings will result in line over 80 warnings being
> >introduced. However,
> >
> >Documentation/process/
Re-send and include cc's
On Tue, Feb 21, 2017 at 03:55:18PM +, Ian Abbott wrote:
> On 21/02/17 11:18, Tobin C. Harding wrote:
>
> For comedi patches affecting a single driver, we prefer the driver name to
> be mentioned in the patch subject, like...
>
> staging: comedi: cb_pcidas64: blah bla
On Tue, 2017-02-21 at 11:48 -0800, Matthew Giassa wrote:
> * Joe Perches [2017-02-21 10:47:31 -0800]:
>
> > On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote:
> > > * Geert Uytterhoeven [2017-02-21 15:22:10 +0100]:
> > >
> > > > The first declaration fit nicely on a single line.
> > > > T
On Wed, 22 Feb 2017, simran singhal wrote:
> The macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /(d)).
> It clarifies the divisor calculations. This occurence was detected using
> the coccinelle script:
>
> @@
> expression e1;
> expression e2;
> @@
> (
> - ((e1) + e2 - 1) / (e2)
>
On Wed, 22 Feb 2017, Arushi Singhal wrote:
> function definition argument like 'struct vb_device_info *','unsigned
> long' etc. should also have an identifier name.
>
> Signed-off-by: Arushi Singhal
> Changes in v2:
> - By mistake one irrelevant line was added which is removed in this
> pat
* Joe Perches [2017-02-21 10:47:31 -0800]:
On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote:
* Geert Uytterhoeven [2017-02-21 15:22:10 +0100]:
> The first declaration fit nicely on a single line.
> The second one indeed has a few spaces instead of TABs in the
> continuation line. But
function definition argument like 'struct vb_device_info *','unsigned
long' etc. should also have an identifier name.
Signed-off-by: Arushi Singhal
Changes in v2:
- By mistake one irrelevant line was added which is removed in this
patch.
---
drivers/staging/xgifb/vb_setmode.h | 18
On 02/20/2017 10:05 PM, Chen Feng wrote:
> Hi Laura,
>
> When we enable kernel v4.4 or newer version on our platform, we meet the issue
> of flushing cache without reference device. It seems that this patch set is
> a solution. I'm curious the progress of the discussion. Do you have any plan
> to
The macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /(d)).
It clarifies the divisor calculations. This occurence was detected using
the coccinelle script:
@@
expression e1;
expression e2;
@@
(
- ((e1) + e2 - 1) / (e2)
+ DIV_ROUND_UP(e1,e2)
|
- ((e1) + (e2 - 1)) / (e2)
+ DIV_ROUND_UP(e
The macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /(d)).
It clarifies the divisor calculations. This occurence was detected using
the coccinelle script:
@@
expression e1;
expression e2;
@@
(
- ((e1) + e2 - 1) / (e2)
+ DIV_ROUND_UP(e1,e2)
|
- ((e1) + (e2 - 1)) / (e2)
+ DIV_ROUND_UP(e
On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote:
> * Geert Uytterhoeven [2017-02-21 15:22:10 +0100]:
>
> > The first declaration fit nicely on a single line.
> > The second one indeed has a few spaces instead of TABs in the
> > continuation line. But that can be fixed easily, without movi
On Tue, 2017-02-21 at 18:40 +0100, Julia Lawall wrote:
>
> On Tue, 21 Feb 2017, Arushi Singhal wrote:
>
> > Error was reported by checkpatch.pl as
> > WARNING: Avoid multiple line dereference...
> > if there is boolean operator then it is fixed by Splitting line at
> > boolean operator.
>
> This
The macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /(d)).
It clarifies the divisor calculations. This occurence was detected using
the coccinelle script:
@@
expression e1;
expression e2;
@@
(
- ((e1) + e2 - 1) / (e2)
+ DIV_ROUND_UP(e1,e2)
|
- ((e1) + (e2 - 1)) / (e2)
+ DIV_ROUND_UP(e
On Tue, 21 Feb 2017, Arushi Singhal wrote:
> function definition argument like 'struct vb_device_info *','unsigned
> long' etc. should have an identifier name.
>
> Signed-off-by: Arushi Singhal
> ---
> drivers/staging/xgifb/vb_setmode.h | 19 ++-
> 1 file changed, 10 insertions
From: Sameer Wadgaonkar
Removed the character device interface from visorchipset and
removed the major and minor numbers.
Reported-by: Greg Kroah-Hartman
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c |
function definition argument like 'struct vb_device_info *','unsigned
long' etc. should have an identifier name.
Signed-off-by: Arushi Singhal
---
drivers/staging/xgifb/vb_setmode.h | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/xgifb/vb_
On Wed, 2017-02-22 at 00:31 +0800, Cheah Kok Cheong wrote:
> > Another option could be using the typedefs from include/linux/types.h,
> > e.g. ushort. However, this might require changing other declarations as
> > well to keep consistency.
>
> Thanks for the idea. I counted seven instances of 'un
> Also, note that the above semantic patch is not completely safe,
> because
> the code could be, eg:
>
> int a = 0;
> a = a + 1;
>
> In that case, the initialization of a would be needed. You
> should check
> each case for this issue.
>
>
> I have c
From: David Binder
Removes kernel-doc formatting for comments that precede static functions.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 36 +-
1 file changed, 18 insertions(+), 18 delet
From: David Binder
Removes kernel-doc formatting for comment that precedes a static function.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/vbuschannel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
From: Sameer Wadgaonkar
Added the structure visorchipset_device and moved the globals to
the struct. The visorchipset_init() function saves acpi_device
within this structure.
Reported-by: Greg Kroah-Hartman
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
From: David Binder
Removes kernel-doc formatting for comments that precede static functions.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorhba/visorhba_main.c | 64 +-
1 file changed, 32 insertions(+), 32 delet
From: David Binder
Removes kernel-doc formatting for comments that precede static functions.
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 24 +--
1 file ch
From: Sameer Wadgaonkar
Removed visorchipset_platform_device and all the unused structures
and functions and using chipset_dev.acpi_device instead.
Reported-by: Greg Kroah-Hartman
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys
From: David Binder
Fixes a minor spelling mistake in a function comment.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/stagi
From: David Binder
Removes kernel-doc formatting for comment that precedes a static function.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchannel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
The visorchipset device is not really a platform device but an acpi device.
This patch series removes the creation of the platform device and uses the
acpi device as needed.
This series also cleans up some misused kernel-doc comments.
David Binder (9):
staging: unisys: visorbus: Move kernel-doc
From: David Binder
Removes kernel-doc formatting for comments that precede static functions.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c | 70 +-
1 file changed, 35 insertions(+), 35 delet
From: David Binder
Fixes miscellaneous comment issues in visorhba_main.c.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorhba/visorhba_main.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/sta
From: David Binder
Moves kernel-doc comment in front of the function it describes.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchannel.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
di
The macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /(d)).
It clarifies the divisor calculations. This occurence was detected using
the coccinelle script:
@@
expression e1;
expression e2;
@@
(
- ((e1) + e2 - 1) / (e2)
+ DIV_ROUND_UP(e1,e2)
|
- ((e1) + (e2 - 1)) / (e2)
+ DIV_ROUND_UP(e
On Tue, 21 Feb 2017, Arushi Singhal wrote:
> Error was reported by checkpatch.pl as
> WARNING: Avoid multiple line dereference...
> if there is boolean operator then it is fixed by Splitting line at
> boolean operator.
This is massively execeeding the 80 character boundary, and not for
somethin
On Tue, 21 Feb 2017, simran singhal wrote:
> Removed initialisation of a varible if it is immediately reassigned.
varible -> variable
>
> Changes were made using Coccinelle.
>
> @@
> type T;
> constant C;
> expression e;
> identifier i;
> @@
>
> T i
> - = C
> ;
> i = e;
This is a big patch, a
* Geert Uytterhoeven [2017-02-21 15:22:10 +0100]:
The first declaration fit nicely on a single line.
The second one indeed has a few spaces instead of TABs in the
continuation line. But that can be fixed easily, without moving the
first parameter to a continuation line.
What would the propose
Fix checkpatch warning "Avoid multiple line dereference"
using a pointer variable to avoid line wrap.
Signed-off-by: Cheah Kok Cheong
---
V2:
-Use pointer instead of normal variable - Ian
-Variable is to be used as "write destination" and
not as "read source" - Ian
drivers/staging/comedi/driv
Error was reported by checkpatch.pl as
WARNING: Avoid multiple line dereference...
if there is boolean operator then it is fixed by Splitting line at
boolean operator.
Signed-off-by: Arushi Singhal
---
drivers/staging/xgifb/XGI_main_26.c | 15 +--
drivers/staging/xgifb/vb_setmode.c
Removed initialisation of a varible if it is immediately reassigned.
Changes were made using Coccinelle.
@@
type T;
constant C;
expression e;
identifier i;
@@
T i
- = C
;
i = e;
Signed-off-by: simran singhal
---
drivers/staging/android/ion/ion_heap.c | 2 +-
drivers/staging/gdm72
On Tue, 21 Feb 2017, Arushi Singhal wrote:
> Unnecessary parentheses are removed as reported by checkpatch.pl
> to make coder nicer and to improve readability.
> Also coding style is improved.For example:-
> It's often nicer to read if &(foo[0]) is converted to foo like:
> memcpy(&(ap->bssi
Unnecessary parentheses are removed as reported by checkpatch.pl
to make coder nicer and to improve readability.
Also coding style is improved.For example:-
It's often nicer to read if &(foo[0]) is converted to foo like:
memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN);
memcpy(ap->
On Tue, Feb 21, 2017 at 11:20:08AM +0100, Valentin Rothberg wrote:
> On Feb 21 '17 10:12, Ian Abbott wrote:
> > On 21/02/2017 09:33, Cheah Kok Cheong wrote:
> > > On Mon, Feb 20, 2017 at 05:36:52PM +, Ian Abbott wrote:
> > > > On 20/02/17 16:02, Cheah Kok Cheong wrote:
> > > > > On Mon, Feb 20,
On 21/02/17 11:18, Tobin C. Harding wrote:
For comedi patches affecting a single driver, we prefer the driver name
to be mentioned in the patch subject, like...
staging: comedi: cb_pcidas64: blah blah
For loop contains only an if conditional (and body of if conditional).
Conditional can be i
Unnecessary parentheses are removed as reported by checkpatch.pl
to make coder nicer and to improve readability.
Also coding style is improved.For example:-
It's often nicer to read if &(foo[0]) is converted to foo like:
memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN);
memcpy(ap->
On Tue, Feb 21, 2017 at 04:03:32PM +, Russell King - ARM Linux wrote:
> On Tue, Feb 21, 2017 at 05:38:34PM +0200, Sakari Ailus wrote:
> > Hi Russell,
> >
> > On Tue, Feb 21, 2017 at 01:21:32PM +, Russell King - ARM Linux wrote:
> > > On Tue, Feb 21, 2017 at 02:37:57PM +0200, Sakari Ailus w
Am 18.02.2017 um 12:22 schrieb Michael Zoran:
The original github source allowed for the cache-line-size property
to be missing. Since recent firmwares also require this property,
it makes sense to always require it in the driver as well.
If the cache-line-size property is missing, then the dri
On 21/02/17 11:18, Tobin C. Harding wrote:
Checkpatch emits multiple WARNING: Avoid multiple line dereference.
Removing these warnings will result in line over 80 warnings being
introduced. However,
Documentation/process/coding-style.rst: "Statements longer than 80
columns will be broken into se
On Tue, Feb 21, 2017 at 05:38:34PM +0200, Sakari Ailus wrote:
> Hi Russell,
>
> On Tue, Feb 21, 2017 at 01:21:32PM +, Russell King - ARM Linux wrote:
> > On Tue, Feb 21, 2017 at 02:37:57PM +0200, Sakari Ailus wrote:
> > > Hi Russell,
> > >
> > > On Tue, Feb 21, 2017 at 12:13:32AM +, Russe
Fixed checkpatch.pl "missing a blank line after declarations" warning
messages in vc04_services module.
Signed-off-by: Yamanappagouda Patil
---
.../interface/vchiq_arm/vchiq_2835_arm.c | 3 ++
.../vc04_services/interface/vchiq_arm/vchiq_arm.c | 39 +++---
.../vc04_ser
Hi Russell,
On Tue, Feb 21, 2017 at 01:21:32PM +, Russell King - ARM Linux wrote:
> On Tue, Feb 21, 2017 at 02:37:57PM +0200, Sakari Ailus wrote:
> > Hi Russell,
> >
> > On Tue, Feb 21, 2017 at 12:13:32AM +, Russell King - ARM Linux wrote:
> > > On Tue, Feb 21, 2017 at 12:04:10AM +0200, S
-error-value-from-spk_set_key_info/20170221-224753
config: i386-randconfig-i1-201708 (attached as .config)
compiler: gcc-4.8 (Debian 4.8.4-1) 4.8.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
drivers/s
On Mon, Feb 20, 2017 at 06:55:06PM +0100, Greg Kroah-Hartman wrote:
> checkpatch is wrong here, you are now adding more lines than you remove:
I see, thank you!
Valentin
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverpro
-error-value-from-spk_set_key_info/20170221-224753
config: i386-randconfig-x018-201708 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
I
Fixed checkpatch.pl "missing a blank line after declarations" waring
messages from rtl8188eu module.
Signed-off-by: Yamanappagouda Patil
---
drivers/staging/rtl8188eu/hal/odm.c | 3 +++
drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 1 +
drivers/staging/rtl8188eu/hal/phy.c
Hi Matthew,
On Tue, Feb 21, 2017 at 3:12 PM, Matthew Giassa wrote:
>>> drivers/staging/ks7010/ks_wlan_ioctl.h | 80
>>> +-
>>> 1 file changed, 41 insertions(+), 39 deletions(-)
>>>
>>> diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h
>>> b/drivers/staging/ks701
* Geert Uytterhoeven [2017-02-21 08:59:18 +0100]:
Hi Geert,
On Tue, Feb 21, 2017 at 5:20 AM, Matthew Giassa wrote:
Please pardon the earlier e-mail which was missing the changelog text.
This line should be between the "---" and the diffstat below.
Thank you.
Some additional style chan
Pranay Kr. Srivastava, on mar. 21 févr. 2017 19:33:32 +0530, wrote:
> This patch removes the unnecessary allocation of
> current foreground vc during initialization.
>
> Also change the prototype of speakup_allocate to take
> extra argument of gfp_* flags. Thus not requiring
> GFP_ATOMIC during in
On Tue, 21 Feb 2017, Arushi Singhal wrote:
> Unnecessary parentheses are removed as reported by checkpatch.pl
> to make coder nicer and to improve readability.
> Also coding style is improved.For example:-
> It's often nicer to read if &(foo[0]) is converted to foo like:
> memcpy(&(ap->bssi
This patch removes the unnecessary allocation of
current foreground vc during initialization.
Also change the prototype of speakup_allocate to take
extra argument of gfp_* flags. Thus not requiring
GFP_ATOMIC during initialization.
Signed-off-by: Pranay Kr. Srivastava
---
drivers/staging/speaku
Unnecessary parentheses are removed as reported by checkpatch.pl
to make coder nicer and to improve readability.
Also coding style is improved.For example:-
It's often nicer to read if &(foo[0]) is converted to foo like:
memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN);
memcpy(ap->
Pranay Kr. Srivastava, on mar. 21 févr. 2017 19:14:38 +0530, wrote:
> + if (key_data_len + SHIFT_TBL_SIZE + 4 >= sizeof(spk_key_buf)) {
> + pr_debug("key_data_len = %d, SHIFT_TBL_SIZE + 4 = %d,\t"
> + "sizeof(spk_key_buf) = %lu\n", key_data_len,
> +
On 02/21/2017 07:44 AM, Johan Hovold wrote:
> On Tue, Feb 21, 2017 at 02:20:50PM +0100, Julia Lawall wrote:
>>
>>
>> On Tue, 21 Feb 2017, simran singhal wrote:
>>
>>> This patch removes braces for single statement blocks. The warning
>>> was detected using checkpatch.pl.
>>> Coccinelle was used to
This patch makes spk_set_key_info return -EINVAL
in case of failure instead of returning 4 different
values for the type of error that occurred.
Print the offending values instead as debug message.
Signed-off-by: Pranay Kr. Srivastava
---
drivers/staging/speakup/main.c | 28
On Tue, Feb 21, 2017 at 02:20:50PM +0100, Julia Lawall wrote:
>
>
> On Tue, 21 Feb 2017, simran singhal wrote:
>
> > This patch removes braces for single statement blocks. The warning
> > was detected using checkpatch.pl.
> > Coccinelle was used to make the change.
> >
> > @@
> > expression e,e1
Running make C=1 M=drivers/staging/fbtft reports warnings about conversion
from __be16 to unsigned short. Change the type of the variables being
assigned into __be16 to remove those warnings.
Signed-off-by: Anthony Brandon
---
drivers/staging/fbtft/fb_ra8875.c| 2 +-
drivers/staging/fbtft/fb
On Tue, Feb 21, 2017 at 02:37:57PM +0200, Sakari Ailus wrote:
> Hi Russell,
>
> On Tue, Feb 21, 2017 at 12:13:32AM +, Russell King - ARM Linux wrote:
> > On Tue, Feb 21, 2017 at 12:04:10AM +0200, Sakari Ailus wrote:
> > > On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote:
> > >
On Tue, 21 Feb 2017, simran singhal wrote:
> This patch removes braces for single statement blocks. The warning
> was detected using checkpatch.pl.
> Coccinelle was used to make the change.
>
> @@
> expression e,e1;
> @@
> - if (e) {
> + if (e)
> e1;
> - }
>
> Signed-off-by: simran singhal
>
On Tue, 21 Feb 2017, simran singhal wrote:
> This patch removes braces for single statement blocks. The warning
> was detected using checkpatch.pl.
> Coccinelle was used to make the change.
>
> @@
> expression e,e1;
> @@
> - if (e) {
> + if (e)
> e1;
> - }
>
> Signed-off-by: simran singhal
A
This patch removes braces for single statement blocks. The warning
was detected using checkpatch.pl.
Coccinelle was used to make the change.
@@
expression e,e1;
@@
- if (e) {
+ if (e)
e1;
- }
Signed-off-by: simran singhal
---
v2:
-I forgot to cc outreachy mailing list
drivers/staging/g
Hi Russell,
On Tue, Feb 21, 2017 at 12:13:32AM +, Russell King - ARM Linux wrote:
> On Tue, Feb 21, 2017 at 12:04:10AM +0200, Sakari Ailus wrote:
> > On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote:
> > > From: Russell King
> > >
> > > Setting and getting frame rates is part
Pranay Kr. Srivastava, on mar. 21 févr. 2017 17:24:42 +0530, wrote:
> Retain the previous error values as debug messages
> instead.
Well, they are not really useful because they are actually undocumented.
> + if (version != KEY_MAP_VER) {
> + pr_debug("Version mismatch %d\n", -1);
This patch removes braces for single statement blocks. The warning
was detected using checkpatch.pl.
Coccinelle was used to make the change.
@@
expression e,e1;
@@
- if (e) {
+ if (e)
e1;
- }
Signed-off-by: simran singhal
---
drivers/staging/greybus/audio_manager_sysfs.c | 3 +--
drivers/stag
Hi Steve,
On Mon, Feb 20, 2017 at 02:56:15PM -0800, Steve Longerbeam wrote:
>
>
> On 02/20/2017 02:04 PM, Sakari Ailus wrote:
> >Hi Steve,
> >
> >On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote:
> >>From: Russell King
> >>
> >>Setting and getting frame rates is part of the nego
This patch makes spk_set_key_info return -EINVAL
in case of failure instead of returning 4 different
values for the type of error that occurred.
Retain the previous error values as debug messages
instead.
Signed-off-by: Pranay Kr. Srivastava
---
drivers/staging/speakup/main.c | 24 +
For loop contains only an if conditional (and body of if conditional).
Conditional can be inverted and the loop continued if the new
conditional is true without modifying the program logic. This allows
one level of indentation to be removed.
Invert conditional and continue loop if new conditional
Checkpatch emits multiple WARNING: Avoid multiple line dereference.
Removing these warnings will result in line over 80 warnings being
introduced. However,
Documentation/process/coding-style.rst: "Statements longer than 80
columns will be broken into sensible chunks, unless exceeding 80
columns si
Checkpatch emits WARNING: struct comedi_lrange should normally be
const.
Add const keyword to definition of struct.
Signed-off-by: Tobin C. Harding
---
drivers/staging/comedi/drivers/addi_apci_3501.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/driv
Checkpatch emits various warnings. We can fix CONST_STRUCT trivially.
MULTILINE_DEREFERENCE warnings can be fixed but in most cases the fix
introduces line over 80 warnings.
Quote Documentation/process/coding-style.rst: "Statements longer than
80 columns will be broken into sensible chunks, unless
On Feb 21 '17 10:12, Ian Abbott wrote:
> On 21/02/2017 09:33, Cheah Kok Cheong wrote:
> > On Mon, Feb 20, 2017 at 05:36:52PM +, Ian Abbott wrote:
> > > On 20/02/17 16:02, Cheah Kok Cheong wrote:
> > > > On Mon, Feb 20, 2017 at 10:03:39AM +, Ian Abbott wrote:
> > > > > On 20/02/17 08:28, Che
On 21/02/2017 09:33, Cheah Kok Cheong wrote:
On Mon, Feb 20, 2017 at 05:36:52PM +, Ian Abbott wrote:
On 20/02/17 16:02, Cheah Kok Cheong wrote:
On Mon, Feb 20, 2017 at 10:03:39AM +, Ian Abbott wrote:
On 20/02/17 08:28, Cheah Kok Cheong wrote:
Fix checkpatch warning "Avoid multiple lin
On Mon, Feb 20, 2017 at 05:36:52PM +, Ian Abbott wrote:
> On 20/02/17 16:02, Cheah Kok Cheong wrote:
> >On Mon, Feb 20, 2017 at 10:03:39AM +, Ian Abbott wrote:
> >>On 20/02/17 08:28, Cheah Kok Cheong wrote:
> >>>Fix checkpatch warning "Avoid multiple line dereference"
> >>>using a local var
On Sun, 2017-02-19 at 23:02 +0100, Pavel Machek wrote:
> Hi!
>
> > From: Philipp Zabel
> >
> > This driver can handle SoC internal and external video bus multiplexers,
> > controlled either by register bit fields or by a GPIO. The subdevice
> > passes through frame interval and mbus configuratio
On Mon, 2017-02-20 at 16:18 -0800, Steve Longerbeam wrote:
>
> On 02/20/2017 04:13 PM, Russell King - ARM Linux wrote:
> > On Tue, Feb 21, 2017 at 12:04:10AM +0200, Sakari Ailus wrote:
> >> On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote:
> >>> From: Russell King
> >>>
> >>> Sett
1 - 100 of 102 matches
Mail list logo
