[PATCH] staging: comedi: db_pcidas64: invert conditional

2017-02-26 Thread Tobin C. Harding
Checkpatch emits WARNING: Avoid multiple line dereference. It is possible to reduce the level of indentation by inverting a conditional and continuing loop if new conditional evaluates to true. Invert conditional. Continue loop if new conditional evaluates to true. Reduce subsequent code indentati

driverdev-devel@linuxdriverproject.org

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Scott Branden wrote: > > > On 17-02-26 01:56 PM, Joe Perches wrote: > > On Sun, 2017-02-26 at 20:40 +0100, Julia Lawall wrote: > > > On Sun, 26 Feb 2017, Joe Perches wrote: > > > > On Sun, 2017-02-26 at 19:59 +0100, Julia Lawall wrote: > > > > > On Sun, 26 Feb 2017, Joe Perc

Re: [PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses.

2017-02-26 Thread Tobin C. Harding
On Sun, Feb 26, 2017 at 06:00:19PM -0800, Matthew Giassa wrote: > --- > drivers/staging/ks7010/ks_wlan_ioctl.h | 64 > +- > 1 file changed, 32 insertions(+), 32 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h > b/drivers/staging/ks7010/ks_wla

[PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-02-26 Thread Michael Zoran
This patch adds compatibility wrappers for the ioctls exposed by vchiq/vc04_services. The compat ioctls are completely implemented on top of the native ioctls. No existing lines are modified. While the ideal approach would be to cleanup the existing code, this path is simplier and easier to revi

[PATCH 5/5] staging: ks7010: refactor function call parameters

2017-02-26 Thread Tobin C. Harding
Function call parameters are split over more lines than necessary. Also assignment statements are split after the '=' sign. This adds extra lines to the function and may also reduces readability. Refactor function call parameters and reduce the number of lines used. Put assignment statements onto

[PATCH 4/5] staging: ks7010: remove switch statement

2017-02-26 Thread Tobin C. Harding
Switch statement uses one [trivial] case and a default case holding bulk of code. We can swap the switch statement with an if/return statement as replacement for the original switch. This can be done without changing the program logic. Remove switch statement. Use original switch parameter as cond

[PATCH 3/5] staging: ks7010: move logic operator to end of line

2017-02-26 Thread Tobin C. Harding
Logic operator (&&) is place at the start of the line. Kernel standards suggest that logical operators should be placed at the end of the line. Move logical operator to the end of the previous line. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks7010_sdio.c | 6 +++--- 1 file chan

[PATCH 0/5] staging: ks7010 refactor _ks_wlan_hw_power_save

2017-02-26 Thread Tobin C. Harding
Function _ks_wlan_hw_power_save has 5 levels of indentation. Reducing the amount of indentation may make code clearer to read. Also a number of other checkpatch warnings may be removed if we first reduce the level of indentation in this function. There are a couple of split line warnings and vario

[PATCH 2/5] staging: ks7010: fix checkpatch MULTILINE_DEREFERENCE

2017-02-26 Thread Tobin C. Harding
Checkpatch emits WARNING: Avoid multiple line dereference. Move dereference onto single line. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks7010_sdio.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/stagin

[PATCH 1/5] staging: ks7010: invert conditional, reduce indent

2017-02-26 Thread Tobin C. Harding
Function _ks_wlan_hw_power_save has 5 levels of indentation. Reducing the amount of indentation may make code clearer to read. Also a number of other checkpatch warnings may be removed if we first reduce the level of indentation in this function. Invert conditional and return from function if new

[PATCHv3] checkpatch fixes for drivers/staging/ks7010/ks_wlan_ioctl.h

2017-02-26 Thread Matthew Giassa
Assembling a set of patches to address all outstanding checkpatch issues in staging/drivers/ks7010/ks_wlan_ioctl.h to replace my earlier v2 work which attempted to do all of this in a single patch. This includes wrapping macros with complex values in parentheses, removing extraneous/mixed whitespac

[PATCHv3 4/4] Changing alignment and indentation in function prototypes so parameters line up to make checkpatch happy (no more warnings/errors).

2017-02-26 Thread Matthew Giassa
--- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 9f71f01..adc935d 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks7010/ks

[PATCHv3 2/4] Removing trailing whitespace in comment block.

2017-02-26 Thread Matthew Giassa
--- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 47c8015..0aa402d 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks7010/ks

[PATCHv3 3/4] Removing mixed spaces/hard-tabs in the alignment indentation to appease checkpatch.

2017-02-26 Thread Matthew Giassa
--- drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 0aa402d..9f71f01 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks701

[PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses.

2017-02-26 Thread Matthew Giassa
--- drivers/staging/ks7010/ks_wlan_ioctl.h | 64 +- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 8e62b10..47c8015 100644 --- a/drivers/staging/ks7010/ks_wlan_io

[PATCH 33/34] staging: lustre: lnet: remove unused lnet_md_iovec_t

2017-02-26 Thread James Simmons
The typedef lnet_md_iovec_t is never used so kill it off. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lust

[PATCH 26/34] staging: lustre: lnet: change lnet_process_id_t to proper structure

2017-02-26 Thread James Simmons
Change lnet_process_id_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lus

[PATCH 25/34] staging: lustre: lnet: change lnet_event_t to proper structure

2017-02-26 Thread James Simmons
Change lnet_event_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/i

[PATCH 23/34] staging: lustre: lnet: change lnet_counter_t to proper structure

2017-02-26 Thread James Simmons
Change lnet_counter_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre

[PATCH 29/34] staging: lustre: lnet: change lnet_ins_pos_t to proper enum

2017-02-26 Thread James Simmons
Change lnet_ins_pos_t from typedef to proper enum. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/incl

[PATCH 34/34] staging: lustre: lnet: use struct bio_vec instead of typedef

2017-02-26 Thread James Simmons
Kill off lnet_kiov_t and use struct bio_vec directly. Signed-off-by: James Simmons --- drivers/staging/lustre/include/linux/lnet/lib-lnet.h| 8 drivers/staging/lustre/include/linux/lnet/lib-types.h | 6 +++--- drivers/staging/lustre/include/linux/lnet/types.h | 7 +++

[PATCH 24/34] staging: lustre: lnet: change lnet_md_t to proper structure

2017-02-26 Thread James Simmons
Change lnet_md_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/incl

[PATCH 31/34] staging: lustre: lnet: change lnet_ack_req_t to proper enum

2017-02-26 Thread James Simmons
Change lnet_ack_req_t from typedef to proper enum. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/incl

[PATCH 21/34] staging: lustre: lnet: change lnet_t to proper structure

2017-02-26 Thread James Simmons
Change lnet_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/include

[PATCH 27/34] staging: lustre: lnet: change lnet_msg_type_t to proper enum

2017-02-26 Thread James Simmons
Change lnet_msg_type_t from typedef to proper enum. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/inc

[PATCH 22/34] staging: lustre: lnet: give LNET_MATCH* enum a name

2017-02-26 Thread James Simmons
The LNET_MATCH* flags are an enum without a name. Lets label that enum. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- driver

[PATCH 32/34] staging: lustre: lnet: remove LNET_SEQ_BASETYPE

2017-02-26 Thread James Simmons
The lnet_seq_t is a simple unsigned long so lets simplify it. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/

[PATCH 13/34] staging: lustre: lnet: change lnet_ni_t to proper structure

2017-02-26 Thread James Simmons
Change lnet_ni_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- .../staging/lustre/include/

[PATCH 17/34] staging: lustre: lnet: change lnet_remotenet_t to proper structure

2017-02-26 Thread James Simmons
Change lnet_remotenet_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- .../staging/lustre/i

[PATCH 30/34] staging: lustre: lnet: change lnet_event_kind_t to proper enum

2017-02-26 Thread James Simmons
Change lnet_event_kind_t from typedef to proper enum. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/i

[PATCH 28/34] staging: lustre: lnet: change lnet_unlink_t to proper enum

2017-02-26 Thread James Simmons
Change lnet_unlink_t from typedef to proper enum. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/inclu

[PATCH 15/34] staging: lustre: lnet: change lnet_peer_t to proper structure

2017-02-26 Thread James Simmons
Change lnet_peer_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- .../staging/lustre/includ

[PATCH 16/34] staging: lustre: lnet: change lnet_route_t to proper structure

2017-02-26 Thread James Simmons
Change lnet_route_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- .../staging/lustre/inclu

[PATCH 19/34] staging: lustre: lnet: change lnet_rtrbuf_t to proper structure

2017-02-26 Thread James Simmons
Change lnet_rtrbuf_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/

[PATCH 18/34] staging: lustre: lnet: change lnet_rtrbufpool_t to proper structure

2017-02-26 Thread James Simmons
Change lnet_rtrbufpool_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lus

[PATCH 20/34] staging: lustre: lnet: change lnet_portal_t to proper structure

2017-02-26 Thread James Simmons
Change lnet_portal_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/

[PATCH 10/34] staging: lustre: lnet: change lnet_libmd_t to proper structure

2017-02-26 Thread James Simmons
Change lnet_libmd_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- .../staging/lustre/inclu

[PATCH 09/34] staging: lustre: lnet: change lnet_me_t to proper structure

2017-02-26 Thread James Simmons
Change lnet_me_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/incl

[PATCH 08/34] staging: lustre: lnet: change lnet_eq_t to proper structure

2017-02-26 Thread James Simmons
Change lnet_eq_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/incl

[PATCH 06/34] staging: lustre: lnet: change lnet_msg_t to proper structure

2017-02-26 Thread James Simmons
Change lnet_msg_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- .../staging/lustre/include

[PATCH 14/34] staging: lustre: lnet: change lnet_rc_data_t to proper structure

2017-02-26 Thread James Simmons
Change lnet_rc_data_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre

[PATCH 04/34] staging: lustre: lnet: change lnet_handle_me_t to proper struct

2017-02-26 Thread James Simmons
Change lnet_handle_me_t from a typedef of another typedef into a proper stand alone structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: Jam

[PATCH 11/34] staging: lustre: lnet: change lnet_test_peer_t to proper structure

2017-02-26 Thread James Simmons
Change lnet_test_peer_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lust

[PATCH 05/34] staging: lustre: lnet: remove generic lnet_handle_any_t

2017-02-26 Thread James Simmons
With the creation of unique handlers we can remove the barely used generic handlers. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons

[PATCH 12/34] staging: lustre: lnet: change lnd_t to proper structure

2017-02-26 Thread James Simmons
Change lnd_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/include/

[PATCH 07/34] staging: lustre: lnet: change lnet_libhandle_t to proper structure

2017-02-26 Thread James Simmons
Change lnet_libhandle_t from typedef to proper structure. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Reviewed-by: Dmitry Eremin Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lust

[PATCH 03/34] staging: lustre: lnet: change lnet_handle_md_t to proper struct

2017-02-26 Thread James Simmons
Change lnet_handle_md_t from a typedef of another typedef into a proper stand alone structure. Create the inline functions LNetInvalidateMDHandle and LNetMDHandleIsInvalid to handle this new piece of data. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: O

[PATCH 00/34] staging: lustre: lnet: remove most of typedefs from LNet headers

2017-02-26 Thread James Simmons
Remove the majority of typedefs from the LNet headers. Change them into structures or enums instead. Currently only lnet_nid_t are lnet_pid_t are left. Removed the rest of the typedefs in socklnd.h as well James Simmons (34): staging: lustre: socklnd: change UAPI typedefs to proper structure s

[PATCH 01/34] staging: lustre: socklnd: change UAPI typedefs to proper structure

2017-02-26 Thread James Simmons
The upstream kernel requires proper structures so convert all the UAPI typedefs in socklnd.h. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6142 Reviewed-on: https://review.whamcloud.com/18506 Reviewed-by: Dmitry Eremin Reviewed-by: Doug Oucharek Reviewed-by:

[PATCH 02/34] staging: lustre: lnet: change lnet_handle_eq_t to proper struct

2017-02-26 Thread James Simmons
Change lnet_handle_eq_t from a typedef of another typedef into a proper stand alone structure. Create the inline functions LNetInvalidateEQHandle and LNetEQHandleIsInvalid to handle this new piece of data. Signed-off-by: James Simmons Reviewed-on: https://review.whamcloud.com/20831 Reviewed-by: O

driverdev-devel@linuxdriverproject.org

2017-02-26 Thread Scott Branden
On 17-02-26 01:56 PM, Joe Perches wrote: On Sun, 2017-02-26 at 20:40 +0100, Julia Lawall wrote: On Sun, 26 Feb 2017, Joe Perches wrote: On Sun, 2017-02-26 at 19:59 +0100, Julia Lawall wrote: On Sun, 26 Feb 2017, Joe Perches wrot Mailing lists _should_ be copied on patch submissions. The id

driverdev-devel@linuxdriverproject.org

2017-02-26 Thread Joe Perches
On Sun, 2017-02-26 at 20:40 +0100, Julia Lawall wrote: > On Sun, 26 Feb 2017, Joe Perches wrote: > > On Sun, 2017-02-26 at 19:59 +0100, Julia Lawall wrote: > > > On Sun, 26 Feb 2017, Joe Perches wrot > > > > Mailing lists _should_ be copied on patch submissions. > > > The idea of outreachy is that

Re: [PATCH V2] staging: vchiq_2835_arm: Make cache-line-size a required DT property

2017-02-26 Thread Michael Zoran
On Sun, 2017-02-26 at 20:36 +0100, Noralf Trønnes wrote: > Den 26.02.2017 19.11, skrev Stefan Wahren: > > > Eric Anholt hat am 26. Februar 2017 um 18:16 > > > geschrieben: > > > > > > ... > > > > > > For staging, Greg has been taking patches without platform > > > maintainer > > > ack.  I think

driverdev-devel@linuxdriverproject.org

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Joe Perches wrote: > On Sun, 2017-02-26 at 19:59 +0100, Julia Lawall wrote: > > On Sun, 26 Feb 2017, Joe Perches wrote: > > > Mailing lists _should_ be copied on patch submissions. > > > > The idea of outreachy is that it should be a place for people to get > > started witho

driverdev-devel@linuxdriverproject.org

2017-02-26 Thread Joe Perches
On Sun, 2017-02-26 at 19:59 +0100, Julia Lawall wrote: > On Sun, 26 Feb 2017, Joe Perches wrote: > > Mailing lists _should_ be copied on patch submissions. > > The idea of outreachy is that it should be a place for people to get > started without too much criticism from the outside. Originally, o

Re: [PATCH V2] staging: vchiq_2835_arm: Make cache-line-size a required DT property

2017-02-26 Thread Noralf Trønnes
Den 26.02.2017 19.11, skrev Stefan Wahren: Eric Anholt hat am 26. Februar 2017 um 18:16 geschrieben: ... For staging, Greg has been taking patches without platform maintainer ack. I think this is great -- the staging code needs *lots* of work, and it generally doesn't need any platform knowl

driverdev-devel@linuxdriverproject.org

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Joe Perches wrote: > On Sun, 2017-02-26 at 19:03 +0100, Julia Lawall wrote: > > > > On Sun, 26 Feb 2017, Narcisa Ana Maria Vasile wrote: > > > > > This was reported by checkpatch.pl > > > > > > Signed-off-by: Narcisa Ana Maria Vasile > > > > Acked-by: Julia Lawall > > > >

driverdev-devel@linuxdriverproject.org

2017-02-26 Thread Joe Perches
On Sun, 2017-02-26 at 19:03 +0100, Julia Lawall wrote: > > On Sun, 26 Feb 2017, Narcisa Ana Maria Vasile wrote: > > > This was reported by checkpatch.pl > > > > Signed-off-by: Narcisa Ana Maria Vasile > > Acked-by: Julia Lawall > > Actually, the outreachy tutorial says not to send patches to

Re: [PATCH V2] staging: vchiq_2835_arm: Make cache-line-size a required DT property

2017-02-26 Thread Stefan Wahren
> Eric Anholt hat am 26. Februar 2017 um 18:16 geschrieben: > > ... > > For staging, Greg has been taking patches without platform maintainer > ack. I think this is great -- the staging code needs *lots* of work, > and it generally doesn't need any platform knowledge. > > As far as this patch

driverdev-devel@linuxdriverproject.org

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Narcisa Ana Maria Vasile wrote: > This was reported by checkpatch.pl > > Signed-off-by: Narcisa Ana Maria Vasile Acked-by: Julia Lawall Actually, the outreachy tutorial says not to send patches to mailing lists, only to people (except in the case of IIO, where the mainta

driverdev-devel@linuxdriverproject.org

2017-02-26 Thread Narcisa Ana Maria Vasile
This was reported by checkpatch.pl Signed-off-by: Narcisa Ana Maria Vasile --- drivers/staging/bcm2835-audio/bcm2835-pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/bcm2835-audio/bcm2835-pcm.c index 9e79236.

Re: [Outreachy kernel] [PATCH v4 2/2] staging: ks7010: Unnecessary parentheses are removed.

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Arushi Singhal wrote: > Unnecessary parentheses are removed as reported by checkpatch.pl > to make coder nicer and to improve readability. > Also coding style is improved.For example:- > It's often nicer to read if &(foo[0]) is converted to foo like: > memcpy(&(ap->bssid[

Re: [Outreachy kernel] [PATCH v4 1/2] staging: ks7010: Unnecessary parentheses are removed.

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Arushi Singhal wrote: > Unnecessary parentheses are removed as reported by checkpatch.pl > to make coder nicer and to improve readability. > Also coding style is improved.For example:- > It's often nicer to read if &(foo[0]) is converted to foo like: > memcpy(&(ap->bssid[

[PATCH v4 2/2] staging: ks7010: Unnecessary parentheses are removed.

2017-02-26 Thread Arushi Singhal
Unnecessary parentheses are removed as reported by checkpatch.pl to make coder nicer and to improve readability. Also coding style is improved.For example:- It's often nicer to read if &(foo[0]) is converted to foo like: memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN); memcpy(ap->

[PATCH v4 1/2] staging: ks7010: Unnecessary parentheses are removed.

2017-02-26 Thread Arushi Singhal
Unnecessary parentheses are removed as reported by checkpatch.pl to make coder nicer and to improve readability. Also coding style is improved.For example:- It's often nicer to read if &(foo[0]) is converted to foo like: memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN); memcpy(ap->

Re: [PATCH V2] staging: vchiq_2835_arm: Make cache-line-size a required DT property

2017-02-26 Thread Eric Anholt
Stefan Wahren writes: > [add Eric] > >> Michael Zoran hat am 18. Februar 2017 um 12:59 >> geschrieben: >> >> >> On Sat, 2017-02-18 at 03:22 -0800, Michael Zoran wrote: >> > The original github source allowed for the cache-line-size property >> > to be missing. Since recent firmwares also req

Re: [PATCH v3] staging: xgifb: correct the multiple line dereference

2017-02-26 Thread Joe Perches
On Sun, 2017-02-26 at 21:23 +0530, Arushi Singhal wrote: > Error was reported by checkpatch.pl as "Avoid multiple line > dereference".And If there is boolean operator then it is > fixed by Splitting line at boolean operator to satisfy coding > style. [] > diff --git a/drivers/staging/xgifb/XGI_ma

Re: [Outreachy kernel] [PATCH v4] staging: xgifb: correct the multiple line dereference

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Arushi Singhal wrote: > Error was reported by checkpatch.pl as "Avoid multiple line > dereference".And If there is boolean operator then it is > fixed by Splitting line at boolean operator to satisfy coding > style. Please improve the commit message. Capital letters should o

[PATCH v4] staging: xgifb: correct the multiple line dereference

2017-02-26 Thread Arushi Singhal
Error was reported by checkpatch.pl as "Avoid multiple line dereference".And If there is boolean operator then it is fixed by Splitting line at boolean operator to satisfy coding style. Signed-off-by: Arushi Singhal --- changes in v4 - changes done such that no other errors can generate. - Im

[PATCH v2] staging: ks7010: remove code in comments.

2017-02-26 Thread Arushi Singhal
Commenting Code Is a Bad Idea. Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them. So in this patch codes in the comments are removed. Signed-off-by: Arushi Singhal -

Re: [PATCH] MAINTAINERS: Remove Noralf Trønnes as fbtft maintainer

2017-02-26 Thread Greg KH
On Sun, Feb 26, 2017 at 03:44:42PM +0100, Noralf Trønnes wrote: > Due to personal reasons I'm unable to continue as fbtft maintainer. > > Signed-off-by: Noralf Trønnes > --- > > For a long time I have wanted to convert the fbtft drivers to drm. > There's now a foundation in place to do so in dri

[PATCH v3] staging: xgifb: correct the multiple line dereference

2017-02-26 Thread Arushi Singhal
Error was reported by checkpatch.pl as "Avoid multiple line dereference".And If there is boolean operator then it is fixed by Splitting line at boolean operator to satisfy coding style. Signed-off-by: Arushi Singhal --- changes in v3 - changes done such that no other errors can generate. -

Re: [PATCH] MAINTAINERS: Remove Noralf Trønnes as fbtft maintainer

2017-02-26 Thread Thomas Petazzoni
Hello, On Sun, 26 Feb 2017 15:44:42 +0100, Noralf Trønnes wrote: > Due to personal reasons I'm unable to continue as fbtft maintainer. > > Signed-off-by: Noralf Trønnes Sad, but I understand. That leaves just me as the "maintainer", but I've never done anything special on fbtft. My aim with a s

[PATCH] MAINTAINERS: Remove Noralf Trønnes as fbtft maintainer

2017-02-26 Thread Noralf Trønnes
Due to personal reasons I'm unable to continue as fbtft maintainer. Signed-off-by: Noralf Trønnes --- For a long time I have wanted to convert the fbtft drivers to drm. There's now a foundation in place to do so in drivers/gpu/drm/tinydrm. Because of a worsening fatigue illness, I'm unable to t

[PATCH 1/2] Staging: xgifb: vb_setmode.c: Fix checkpath warning

2017-02-26 Thread Manoj Sawai
Fix the following checkpatch.pl warning: Avoid multiple line dereference - prefer 'XGI330_RefIndex[RefreshRateTableIndex+(*i)].Ext_InfoFlag' Signed-off-by: Manoj Sawai --- drivers/staging/xgifb/vb_setmode.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/stagin

[PATCH 2/2] Staging: xgifb: vb_setmode.c: Fix checkpath warnings

2017-02-26 Thread Manoj Sawai
Fix the following checkpatch.pl warnings: 1: Avoid multiple line dereference - prefer 'XGI330_RefIndex[RefreshRateTableIndex+i].ModeID' 2: Avoid multiple line dereference - prefer 'XGI330_RefIndex[RefreshRateTableIndex+(*i)].Ext_InfoFlag' Signed-off-by: Manoj Sawai --- drivers/staging/xg