This patch adds support for the SH1106 OLED controller chip.
It's similar to the SSD1306, however it supports only a subset of
commands and the internal video memory has a different width.
Major differences:
- Internal video memory has a width of 132 pixels
- Only a subset of commands is supporte
On Tue, 2017-02-28 at 06:51 +0100, Greg Kroah-Hartman wrote:
> On Tue, Feb 28, 2017 at 10:35:30AM +0530, Arushi Singhal wrote:
> > Error reported by checkpatch.pl as "avoid multiple line dereference".
> > Addition of new variables to make the code more readable and also to
> > correct about mention
On Tue, 2017-02-28 at 07:55 +0530, Arushi Singhal wrote:
> Error reported by checkpatch.pl as "avoid multiple line dereference".
> Addition of new variables to make the code more readable and also to
> correct about mentioned error as by itroducing new variables line is
> not exceeding 80 character
On Tue, Feb 28, 2017 at 10:35:30AM +0530, Arushi Singhal wrote:
> Error reported by checkpatch.pl as "avoid multiple line dereference".
> Addition of new variables to make the code more readable and also to
> correct about mentioned error as by itroducing new variables line is
> not exceeding 80 ch
On Mon, Feb 27, 2017 at 03:35:11PM -0800, Michael Zoran wrote:
> This patch series moves the camera and audio driver for the Raspberry PI
> under the vc04_services
> directory to clarify that these drivers are part of vc04_servies. This also
> simplies the configuration
> system and opens the do
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
Version #1 introduced lines over 80.
This version moves comments to be above the line of code.
drivers/staging/rtl8712/rtl871x_mp_ioctl.h | 173 -
1 file changed, 98 insertions(+),
Error reported by checkpatch.pl as "avoid multiple line dereference".
Addition of new variables to make the code more readable and also to
correct about mentioned error as by itroducing new variables line is
not exceeding 80 characters.
Signed-off-by: Arushi Singhal
---
changes in v6
- changes
From: Stephen Hemminger
Several spelling errors in comments
Signed-off-by: Stephen Hemminger
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/channel.c | 10 +-
drivers/hv/hv_kvp.c | 10 +-
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/hv/channel.
From: Stephen Hemminger
This table is immutable and should be const.
Cleanup indentation and whitespace for this as well.
Signed-off-by: Stephen Hemminger
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/channel_mgmt.c | 48 ++--
drivers/hv/hyperv_vmbus
From: Stephen Hemminger
hv_ringbuffer_read cleanup.
Signed-off-by: Stephen Hemminger
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/ring_buffer.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c
index 52d0556..8a
From: Stephen Hemminger
Compiling with warnings enabled finds missing prototype for
hv_do_hypercall.
Signed-off-by: Stephen Hemminger
Signed-off-by: K. Y. Srinivasan
---
arch/x86/hyperv/hv_init.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/hyperv/hv_init
From: Stephen Hemminger
Allow driver to get debug information about state of the ring.
Signed-off-by: Stephen Hemminger
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/hyperv_vmbus.h | 11 ---
drivers/hv/ring_buffer.c |1 +
include/linux/hyperv.h| 17 +
3 f
From: Stephen Hemminger
The per-cpu channel list is now referred to in the interrupt
routine. This is mostly safe since the host will not normally generate
an interrupt when channel is being deleted but if it did then there
would be a use after free problem.
To solve, this use RCU protection on
From: Stephen Hemminger
The change to reschedule tasklet if more data arrives in ring buffer
can cause performance regression if host timing is such that the
next response happens in small window.
Go back to a modified version of the original looping behavior.
If the race occurs in a small time,
From: Stephen Hemminger
No need for empty return at end of void function
Signed-off-by: Stephen Hemminger
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/hv_balloon.c |2 --
drivers/hv/hv_fcopy.c|2 --
drivers/hv/hv_kvp.c |2 --
drivers/hv/hv_snapshot.c |2 --
drivers
From: Stephen Hemminger
Don't initialize variables that are then set a few lines later.
Signed-off-by: Stephen Hemminger
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/ring_buffer.c | 13 +
1 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/hv/ring_buffer.c b
From: K. Y. Srinivasan
Miscellaneous fixes.
Stephen Hemminger (10):
vmbus: only reschedule tasklet if time limit exceeded
vmbus: use rcu for per-cpu channel list
hyperv: fix warning about missing prototype
vmbus: remove useless return's
vmbus: remove unnecessary initialization
vmbus:
From: Stephen Hemminger
Minor changes to align hyper-v vmbus include files with current
linux kernel style.
Signed-off-by: Stephen Hemminger
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/hyperv_vmbus.h | 16
include/linux/hyperv.h| 12 ++--
2 files changed, 1
This patch fixes coding style issue of using __func__ instead of gcc
specific __FUNCTION__, warning as issued by checkpatch
Signed-off-by: Chetan Sethi
---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
v4:
- modified description to exclude ment
This patch fixes coding style issue of having block comments using a
trailing */ on a separate line, warning as issued by checkpatch
Signed-off-by: Chetan Sethi
---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
v4:
- modified description to exc
Signed-off-by: Chetan Sethi
---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
v4:
- modified description to exclude mention of patch number from changelog
- updated subject to include driver name
v5:
- updated series for removing additional ch
This patch fixes error of enclosing complex macro value in parentheses,
error as issued by checkpatch
Signed-off-by: Chetan Sethi
---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
- incorporated review comment of correct indentation for do stat
This patch fixes warning of line over 80 characters, as issued by
checkpatch.pl
Signed-off-by: Chetan Sethi
---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
v4:
- modified description to exclude mention of patch number from changelog
v5:
- up
> From: Stephen Hemminger
> Sent: Tuesday, February 28, 2017 01:02
>
> The patch looks good. I don't understand the exact semantics here and
> therefore have a couple of naïve questions
>
> Is it possible device could be opened multiple times? Is reference counting
> done above?
The file can on
Error reported by checkpatch.pl as "avoid multiple line dereference".
Addition of new variables to make the code more readable and also to
correct about mentioned error as by itroducing new variables line is
not exceeding 80 characters.
Signed-off-by: Arushi Singhal
---
changes in v5
- changes
A PCI_EJECT message can arrive at the same time we are calling
pci_scan_child_bus in the workqueue for the previous PCI_BUS_RELATIONS
message or in create_root_hv_pci_bus(), in this case we could
potentially modify the bus from multiple places.
Properly lock the bus access.
Thanks Dexuan Cui
hv_pci_devices_present is called in hv_pci_remove when we remove a PCI
device from host (e.g. by disabling SRIOV on a device). In hv_pci_remove,
the bus is already removed before the call, so we don't need to rescan
the bus in the workqueue scheduled from hv_pci_devices_present. By
introducing st
From: Dexuan Cui
Without the patch, I always get a "BUG: spinlock bad magic" warning.
Fixes: 3716a49a81ba ("hv_utils: implement Hyper-V PTP source")
Signed-off-by: Dexuan Cui
Cc: Vitaly Kuznetsov
Cc: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Cc: Stephen Hemminger
Signed-off-by: K. Y. Srinivasan
On Mon, Feb 27, 2017 at 4:21 PM, Greg Kroah-Hartman
wrote:
> On Sat, Feb 18, 2017 at 11:52:37AM +0800, Man Choy wrote:
>> Fix following checks:
>>
>> CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code rather
>> than BUG() or BUG_ON()
>> + BUG_ON((index+2) >= BCM2048_MAX_RD
On Mon, Feb 27, 2017 at 10:42 PM, Greg KH wrote:
> On Sun, Feb 26, 2017 at 01:22:18PM +0800, Man Choy wrote:
>> Fix following checkpatch warning:
>>
>> WARNING: line over 80 characters
>> +&synth->attributes)
>> < 0)
>>
>> total: 0 errors, 1
The bcm2835-camera driver is part of v04_services, so it makes
sense for it to be located under vc04_services to make
configuration clearer.
Signed-off-by: Michael Zoran
---
drivers/staging/media/Kconfig | 2 --
drivers/staging/media/Makefile
This patch series moves the camera and audio driver for the Raspberry PI under
the vc04_services
directory to clarify that these drivers are part of vc04_servies. This also
simplies the configuration
system and opens the door for longer term changes that makes vc04_services a
kernel subsystem.
Update the name of the camera driver as displayed
by the Kconfig to match the audio driver style.
Signed-off-by: Michael Zoran
---
drivers/staging/vc04_services/bcm2835-camera/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/bcm2835-camera
The bcm2835-audio driver is part of v04_services, so it makes
sense for it to be located under vc04_services to make
configuration clearer.
Signed-off-by: Michael Zoran
---
drivers/staging/Kconfig | 2 --
drivers/staging/Makefile
The audio driver description contains a reference to a card.
Since this is for built in audio, drop the card reference
from the description.
Signed-off-by: Michael Zoran
---
drivers/staging/vc04_services/bcm2835-audio/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
From: Dexuan Cui
If the daemon is NOT running at all, when we disable the util device from
Hyper-V Manager (or sometimes the host can rescind a util device and then
re-offer it), we'll hang in util_remove -> hv_kvp_deinit ->
wait_for_completion(&release_event), because this code path doesn't run:
On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote:
> This patch fixes the checkpatch warning that else is not generally
> useful after a break or return.
checkpatch doesn't actually warn for this style
if (foo)
return bar;
else
return baz;
>
Ok, I will resend.
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Saturday, February 25, 2017 12:02 AM
> To: Long Li
> Cc: KY Srinivasan ; Haiyang Zhang
> ; Bjorn Helgaas ;
> de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; linux-
> p...@vger.kernel.org
>
Fix the following formatting issues:
WARNING: Avoid unnecessary line continuations
Signed-off-by: Cezary Gapinski
---
This patch is a part of task 10 of eudyptula challenge
drivers/staging/fbtft/fbtft-sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fb
On Mon, 27 Feb 2017, simran singhal wrote:
> This patch fixes the checkpatch warning that else is not generally
> useful after a break or return.
>
> This was done using Coccinelle:
>
> @@
> expression e2;
> statement s1;
> @@
> if(e2) { ... return ...; }
> -else
> s1
>
> Signed-off-by:
> diff --git a/drivers/staging/iio/accel/adis16201_core.c
> b/drivers/staging/iio/accel/adis16201_core.c
> index 7963d4a..210699e 100644
> --- a/drivers/staging/iio/accel/adis16201_core.c
> +++ b/drivers/staging/iio/accel/adis16201_core.c
> @@ -20,7 +20,150 @@
> #include
> #include
>
> -#inclu
On Mon, 27 Feb 2017, simran singhal wrote:
> This patch fixes the checkpatch warning that else is not generally
> useful after a break or return.
>
> This was done using Coccinelle:
> @@
> expression e2;
> statement s1;
> @@
> if(e2) { ... return ...; }
> -else
> s1
One might be surpri
On Mon, 27 Feb 2017, simran singhal wrote:
> This patch fixes the checkpatch warning that else is not generally
> useful after a break or return.
>
> This was done using Coccinelle:
> @@
> expression e2;
> statement s1;
> @@
> if(e2) { ... return ...; }
> -else
> s1
>
> Signed-off-by: s
Function contains code at differing levels of abstraction. This is
shown by the fact that conditional is loop-invariant. Code may be
refactored out into a separate function.
Refactor out loop body to separate function. Do not alter original
code structure of loop body (to ease review). Add local v
Function contains code at differing levels of abstraction. This is
shown by the fact that conditional is loop-invariant. Code may be
refactored out into a separate function.
Once refactored into separate function a number of minor code style
fixes may be implemented. Remove multi-line dereferece,
Code was moved to a separate function in a previous patch. Code
structure wast maintained to ease review. Code may now be refactored
to ease reading.
Move multi-line dereference onto single line. Give function parameter
more meaningful name. Fix minor alignment issue.
Signed-off-by: Tobin C. Hard
On Mon, 2017-02-27 at 12:35 -0800, Scott Branden wrote:
> >
> Hi Julia,
>
> On 17-02-26 10:25 PM, Julia Lawall wrote:
> >
> > If you consider that you are getting too much outreachy mail at the
> > moment, just let me know what subsystem you want me to add an
> > exception
> > for.
>
> The emai
The fsl-mc-bus driver in staging contains a copy of the standard
'ranges' property parsing algorithm with a hack to treat a missing
property the same way as an empty one. This code produces false-positive
warnings for me in an allmodconfig build:
drivers/staging/fsl-mc/bus/fsl-mc-bus.c: In functio
On Tue, 2017-02-28 at 01:51 +0530, SIMRAN SINGHAL wrote:
> On Tue, Feb 28, 2017 at 12:55 AM, Joe Perches wrote:
> > On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote:
> > > This patch fixes the checkpatch warning that else is not generally
> > > useful after a break or return.
> >
> > check
Hi Julia,
On 17-02-26 10:25 PM, Julia Lawall wrote:
On Sun, 26 Feb 2017, Scott Branden wrote:
On 17-02-26 01:56 PM, Joe Perches wrote:
On Sun, 2017-02-26 at 20:40 +0100, Julia Lawall wrote:
On Sun, 26 Feb 2017, Joe Perches wrote:
On Sun, 2017-02-26 at 19:59 +0100, Julia Lawall wrote:
O
On Mon, Feb 27, 2017 at 04:07:27PM +0100, Julia Lawall wrote:
>
>
> On Mon, 27 Feb 2017, Arushi Singhal wrote:
>
> >
> >
> > On Mon, Feb 27, 2017 at 8:18 PM, Greg KH wrote:
> > On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote:
> > > Commenting Code Is a Bad Idea.
> >
On Tue, Feb 28, 2017 at 1:01 AM, Joe Perches wrote:
> On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote:
>> This patch fixes the checkpatch warning that else is not generally
>> useful after a break or return.
> []
>> diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c
>> b/drivers/staging/
On Tue, Feb 28, 2017 at 12:55 AM, Joe Perches wrote:
> On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote:
>> This patch fixes the checkpatch warning that else is not generally
>> useful after a break or return.
>
> checkpatch doesn't actually warn for this style
>
> if (foo)
>
On Tue, Feb 28, 2017 at 1:11 AM, Joe Perches wrote:
> On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote:
>> This patch fixes the checkpatch warning that else is not generally
>> useful after a break or return.
>
>> This was done using Coccinelle:
>> @@
>> expression e2;
>> statement s1;
>> @
On Mon, Feb 27, 2017 at 10:46:34AM +, Ian Abbott wrote:
> On 27/02/17 06:36, Tobin C. Harding wrote:
> >Checkpatch emits WARNING: Avoid multiple line dereference. It is
> >possible to reduce the level of indentation by inverting a conditional
> >and continuing loop if new conditional evaluates
On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote:
> This patch fixes the checkpatch warning that else is not generally
> useful after a break or return.
> This was done using Coccinelle:
> @@
> expression e2;
> statement s1;
> @@
> if(e2) { ... return ...; }
> -else
> s1
[]
> diff
The contents of the header file are used only by this single
source file. Move content into .c and remove .h.
Signed-off-by: simran singhal
---
drivers/staging/iio/accel/adis16201.h | 144
drivers/staging/iio/accel/adis16201_core.c | 145
On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote:
> This patch fixes the checkpatch warning that else is not generally
> useful after a break or return.
[]
> diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c
> b/drivers/staging/sm750fb/ddk750_swi2c.c
[]
> @@ -295,8 +294,7 @@ static long s
This patch fixes the checkpatch warning that else is not generally
useful after a break or return.
This was done using Coccinelle:
@@
expression e2;
statement s1;
@@
if(e2) { ... return ...; }
-else
s1
Signed-off-by: simran singhal
---
drivers/staging/sm750fb/ddk750_sii164.c | 6 ++
This patch fixes the checkpatch warning that else is not generally
useful after a break or return.
This was done using Coccinelle:
@@
expression e2;
statement s1;
@@
if(e2) { ... return ...; }
-else
s1
Signed-off-by: simran singhal
---
drivers/staging/gdm724x/gdm_endian.c | 12
This patch fixes the checkpatch warning that else is not generally
useful after a break or return.
This was done using Coccinelle:
@@
expression e2;
statement s1;
@@
if(e2) { ... return ...; }
-else
s1
Signed-off-by: simran singhal
---
drivers/staging/rtl8712/os_intfs.c | 3 +--
1 file
This patch fixes the checkpatch warning that else is not generally
useful after a break or return.
This was done using Coccinelle:
@@
expression e2;
statement s1;
@@
if(e2) { ... return ...; }
-else
s1
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_cryp
This patch fixes the checkpatch warning that else is not generally
useful after a break or return.
@@
expression e2;
statement s1;
@@
if(e2) { ... return ...; }
-else
s1
Signed-off-by: simran singhal
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 3 +--
drivers/staging/lustr
On 27/02/17 06:36, Tobin C. Harding wrote:
Checkpatch emits WARNING: Avoid multiple line dereference. It is
possible to reduce the level of indentation by inverting a conditional
and continuing loop if new conditional evaluates to true.
Invert conditional. Continue loop if new conditional evalua
The patch looks good. I don't understand the exact semantics here and
therefore have a couple of naïve questions
Is it possible device could be opened multiple times? Is reference counting
done above?
If device was never opened do you even have to do all the cleanup steps at all?
-Original
On Mon, 27 Feb 2017, Arushi Singhal wrote:
>
>
> On Mon, Feb 27, 2017 at 8:18 PM, Greg KH wrote:
> On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote:
> > Commenting Code Is a Bad Idea.
> > Comments are their to explain the code and how the code
> achieves it
On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote:
> Commenting Code Is a Bad Idea.
> Comments are their to explain the code and how the code achieves its
> goal and as codes in the comments does not explain what the code is
> doing so there is no use of commenting them.
> So in this
On Sun, Feb 26, 2017 at 04:01:22PM +0900, Chetan Sethi wrote:
> This patch fixes error of enclosing complex macro value in parentheses,
> error as issued by checkpatch
>
> Signed-off-by: Chetan Sethi
> ---
> v2:
> - split multiple changes across different patches
> v3:
> - mentioned patch revis
On Mon, Feb 27, 2017 at 07:25:30AM +0100, Julia Lawall wrote:
>
>
> On Sun, 26 Feb 2017, Scott Branden wrote:
>
> >
> >
> > On 17-02-26 01:56 PM, Joe Perches wrote:
> > > On Sun, 2017-02-26 at 20:40 +0100, Julia Lawall wrote:
> > > > On Sun, 26 Feb 2017, Joe Perches wrote:
> > > > > On Sun, 2017
On Wed, Feb 15, 2017 at 06:19:26PM -0800, Steve Longerbeam wrote:
> This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta
> branch, modified heavily to bring forward to latest interfaces and code
> cleanup.
>
> Signed-off-by: Steve Longerbeam
> ---
> .../devicetree/bindings
On Sun, Feb 26, 2017 at 01:22:18PM +0800, Man Choy wrote:
> Fix following checkpatch warning:
>
> WARNING: line over 80 characters
> +&synth->attributes)
> < 0)
>
> total: 0 errors, 1 warnings, 485 lines checked
> Signed-off-by: Man Choy
>
On Wed, Feb 15, 2017 at 06:19:17PM -0800, Steve Longerbeam wrote:
> From: Philipp Zabel
>
> This driver can handle SoC internal and external video bus multiplexers,
> controlled either by register bit fields or by a GPIO. The subdevice
> passes through frame interval and mbus configuration of the
On Wed, Feb 15, 2017 at 06:19:03PM -0800, Steve Longerbeam wrote:
> Add bindings documentation for the i.MX media driver.
>
> Signed-off-by: Steve Longerbeam
> ---
> Documentation/devicetree/bindings/media/imx.txt | 66
> +
> 1 file changed, 66 insertions(+)
> create mo
On Sun, Feb 26, 2017 at 03:32:08PM +1300, Derek Robson wrote:
> Fixed style of block comments
> Found using checkpatch
>
> Signed-off-by: Derek Robson
> ---
> drivers/staging/rtl8712/rtl871x_mp_ioctl.h | 32
> +++---
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
If the daemon is NOT running at all, when we disable the util device from
Hyper-V Manager (or sometimes the host can rescind a util device and then
re-offer it), we'll hang in util_remove -> hv_kvp_deinit ->
wait_for_completion(&release_event), because this code path doesn't run:
hvt_op_release ->
Hello!
Your subject is too long, mught want to move i(part of) it to the patch
description...
And you need to provide your Signed-off-by:, the patch can't be applied
without it.
MBR, Sergei
___
devel mailing list
de...@linuxdriverproject.org
On Sat, Feb 18, 2017 at 11:52:37AM +0800, Man Choy wrote:
> Fix following checks:
>
> CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code rather
> than BUG() or BUG_ON()
> + BUG_ON((index+2) >= BCM2048_MAX_RDS_RT);
>
> CHECK: spaces preferred around that '+' (ctx:VxV)
> +
77 matches
Mail list logo
