-rtl8192e-Fix-coding-style-warnings-and-checks/20170311-16
config: x86_64-rhel (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/s
On Sat, Mar 11, 2017 at 12:12 PM, Julia Lawall wrote:
>
>
> On Sat, 11 Mar 2017, simran singhal wrote:
>
>> This patch-series removes exceptional & on functions name.
>
> The semantic patch shown does nothing to check that the use of & is
> exception in the given file. It just removes all the & o
This is the patch that I previously commented on. Thus the subject line
should contain v2. Please try to remember to do this every time. It is
very confusing to see something one thinks one has already seen with no
version information. There should also be a description of the change
since the
On Sat, 11 Mar 2017, SIMRAN SINGHAL wrote:
> On Sat, Mar 11, 2017 at 12:12 PM, Julia Lawall wrote:
> >
> >
> > On Sat, 11 Mar 2017, simran singhal wrote:
> >
> >> This patch-series removes exceptional & on functions name.
> >
> > The semantic patch shown does nothing to check that the use of &
function prototype arguments like 'struct vb_device_info *','unsigned
long' etc. should have an identifier name.
Signed-off-by: Arushi Singhal
---
changes in v2
-Add the identifier name of one more function prototype
drivers/staging/sm750fb/ddk750_display.h | 2 +-
drivers/staging/sm750fb/ddk
On Sat, Mar 11, 2017 at 10:53 AM, Arushi Singhal
wrote:
> --- a/drivers/staging/sm750fb/sm750.h
> +++ b/drivers/staging/sm750fb/sm750.h
> @@ -184,8 +184,8 @@ static inline unsigned long ps_to_hz(unsigned int psvalue)
> }
>
> int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev);
>
Em Sat, 11 Mar 2017 00:37:14 +0200
Sakari Ailus escreveu:
> Hi Mauro (and others),
>
> On Fri, Mar 10, 2017 at 12:53:42PM -0300, Mauro Carvalho Chehab wrote:
> > Em Fri, 10 Mar 2017 15:20:48 +0100
> > Hans Verkuil escreveu:
> >
> > >
> > > > As I've already mentioned, from talking about t
On Sat, Mar 11, 2017 at 08:07:01AM +0530, SIMRAN SINGHAL wrote:
> On Sat, Mar 11, 2017 at 2:43 AM, Dan Carpenter
> wrote:
> > Don't resend, but next time if you wanted to fold all these patches and
> > send them as one patch that would be fine.
> >
>
> Hi Dan,
>
> Before I sent this patches as
On Sat, Mar 11, 2017 at 2:57 PM, Julia Lawall wrote:
>
>
> On Sat, 11 Mar 2017, SIMRAN SINGHAL wrote:
>
>> On Sat, Mar 11, 2017 at 12:12 PM, Julia Lawall wrote:
>> >
>> >
>> > On Sat, 11 Mar 2017, simran singhal wrote:
>> >
>> >> This patch-series removes exceptional & on functions name.
>> >
>>
On 10/03/17 16:09, Mauro Carvalho Chehab wrote:
> Em Fri, 10 Mar 2017 13:54:28 +0100
> Hans Verkuil escreveu:
>
>>> Devices that have complex pipeline that do essentially require using the
>>> Media controller interface to configure them are out of that scope.
>>>
>>
>> Way too much of how the
On 10/03/17 19:37, Steve Longerbeam wrote:
> Hi Hans,
>
> On 03/10/2017 04:03 AM, Hans Verkuil wrote:
>> On 10/03/17 05:52, Steve Longerbeam wrote:
>>> Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or
>>> output device has measured an interval between the reception or transmi
On Sat, Mar 11, 2017 at 5:01 PM, Dan Carpenter wrote:
> On Sat, Mar 11, 2017 at 08:07:01AM +0530, SIMRAN SINGHAL wrote:
>> On Sat, Mar 11, 2017 at 2:43 AM, Dan Carpenter
>> wrote:
>> > Don't resend, but next time if you wanted to fold all these patches and
>> > send them as one patch that would
On Sat, 11 Mar 2017, SIMRAN SINGHAL wrote:
> On Sat, Mar 11, 2017 at 2:57 PM, Julia Lawall wrote:
> >
> >
> > On Sat, 11 Mar 2017, SIMRAN SINGHAL wrote:
> >
> >> On Sat, Mar 11, 2017 at 12:12 PM, Julia Lawall
> >> wrote:
> >> >
> >> >
> >> > On Sat, 11 Mar 2017, simran singhal wrote:
> >> >
>
Fix checkpatch.pl warning about line over 80 characters by breaking function
parameters into two lines.
Signed-off-by: Thibaut SAUTEREAU
---
drivers/staging/sm750fb/ddk750_chip.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c
b/driver
This patch resolves the "Comparisons should place the constant on
the right side of the test" found with checkpatch tool.
Signed-off-by: Craig Inches
---
drivers/staging/lustre/lustre/include/lu_object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/l
Em Sat, 11 Mar 2017 12:32:43 +0100
Hans Verkuil escreveu:
> On 10/03/17 16:09, Mauro Carvalho Chehab wrote:
> > Em Fri, 10 Mar 2017 13:54:28 +0100
> > Hans Verkuil escreveu:
> >
> >>> Devices that have complex pipeline that do essentially require using the
> >>> Media controller interface to
Hi Steve,
On Thu, Mar 09, 2017 at 08:52:58PM -0800, Steve Longerbeam wrote:
> If the pads on both sides of a link specify a frame interval, then
> those frame intervals should match. Create the exported function
> v4l2_subdev_link_validate_frame_interval() to verify this. This
> function can be ca
Hi Steve,
On Thu, Mar 09, 2017 at 08:53:01PM -0800, Steve Longerbeam wrote:
> Add an empty UAPI Kbuild file for media UAPI headers.
>
> Signed-off-by: Steve Longerbeam
The existing V4L2 UAPI headers are under include/uapi/linux. Could you use
that directory instead?
I actually wouldn't really
This patch-series removes exceptional & on functions name.
v1:
-Change the commit message of all the patches of the patch-series
simran singhal (10):
staging: iio: ad7192: Remove exceptional & on function name
staging: iio: ad7780: Remove exceptional & on function name
staging: iio: cdc:
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: simran singhal
---
drivers/staging/iio/adc/ad7780.c | 2 +-
1 file changed, 1
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: simran singhal
---
drivers/staging/iio/adc/ad7192.c | 12 ++--
1 file
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: simran singhal
---
drivers/staging/iio/accel/adis16240.c | 4 ++--
1 file cha
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: simran singhal
---
drivers/staging/iio/cdc/ad7152.c | 6 +++---
1 file change
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: simran singhal
---
drivers/staging/iio/accel/adis16201.c | 4 ++--
1 file cha
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: simran singhal
---
drivers/staging/iio/accel/adis16209.c | 4 ++--
1 file cha
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: simran singhal
---
drivers/staging/iio/resolver/ad2s1200.c | 2 +-
drivers/st
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: simran singhal
---
drivers/staging/iio/gyro/adis16060_core.c | 2 +-
1 file c
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: simran singhal
---
drivers/staging/iio/cdc/ad7746.c | 4 ++--
1 file changed,
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: simran singhal
---
drivers/staging/iio/accel/adis16203.c | 4 ++--
1 file cha
Hi Mauro and Hans,
On Sat, Mar 11, 2017 at 10:14:08AM -0300, Mauro Carvalho Chehab wrote:
> Em Sat, 11 Mar 2017 12:32:43 +0100
> Hans Verkuil escreveu:
>
> > On 10/03/17 16:09, Mauro Carvalho Chehab wrote:
> > > Em Fri, 10 Mar 2017 13:54:28 +0100
> > > Hans Verkuil escreveu:
> > >
> > >>> De
Remove typdef phy_ofdm_rx_status_rxsc_sgien_exintfflag and replace its uses
in the code.
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/r8192U.h | 4 ++--
drivers/staging/rtl8192u/r8192U_core.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/stag
On Sat, 11 Mar 2017, simran singhal wrote:
> Remove typdef phy_ofdm_rx_status_rxsc_sgien_exintfflag and replace its uses
> in the code.
>
> Signed-off-by: simran singhal
> ---
> drivers/staging/rtl8192u/r8192U.h | 4 ++--
> drivers/staging/rtl8192u/r8192U_core.c | 4 ++--
> 2 files change
On Sat, Mar 11, 2017 at 9:56 PM, Julia Lawall wrote:
>
>
> On Sat, 11 Mar 2017, simran singhal wrote:
>
>> Remove typdef phy_ofdm_rx_status_rxsc_sgien_exintfflag and replace its uses
>> in the code.
>>
>> Signed-off-by: simran singhal
>> ---
>> drivers/staging/rtl8192u/r8192U.h | 4 ++--
>>
On Sat, 11 Mar 2017, SIMRAN SINGHAL wrote:
> On Sat, Mar 11, 2017 at 9:56 PM, Julia Lawall wrote:
> >
> >
> > On Sat, 11 Mar 2017, simran singhal wrote:
> >
> >> Remove typdef phy_ofdm_rx_status_rxsc_sgien_exintfflag and replace its uses
> >> in the code.
> >>
> >> Signed-off-by: simran singhal
Remove typdef phy_ofdm_rx_status_rxsc_sgien_exintfflag and replace its uses
in the code.
Signed-off-by: simran singhal
---
v2:
-Drop the "_" at the beginning of the name of the structure
drivers/staging/rtl8192u/r8192U.h | 4 ++--
drivers/staging/rtl8192u/r8192U_core.c | 4 ++--
2 f
On Sat, 11 Mar 2017, simran singhal wrote:
> Remove typdef phy_ofdm_rx_status_rxsc_sgien_exintfflag and replace its uses
> in the code.
>
> Signed-off-by: simran singhal
Acked-by: Julia Lawall
> ---
>
> v2:
>-Drop the "_" at the beginning of the name of the structure
>
> drivers/stagin
On Sat, Mar 11, 2017 at 05:32:29PM +0200, Sakari Ailus wrote:
> My understanding of the i.MX6 case is the hardware is configurable enough
> to warrant the use of the Media controller API. Some patches indicate
> there are choices to be made in data routing.
The iMX6 does have configurable data rou
On 03/11/2017 07:32 AM, Sakari Ailus wrote:
Hi Mauro and Hans,
On Sat, Mar 11, 2017 at 10:14:08AM -0300, Mauro Carvalho Chehab wrote:
Em Sat, 11 Mar 2017 12:32:43 +0100
Hans Verkuil escreveu:
On 10/03/17 16:09, Mauro Carvalho Chehab wrote:
Em Fri, 10 Mar 2017 13:54:28 +0100
Hans Verkuil
On 03/11/2017 03:39 AM, Hans Verkuil wrote:
On 10/03/17 19:37, Steve Longerbeam wrote:
Hi Hans,
On 03/10/2017 04:03 AM, Hans Verkuil wrote:
On 10/03/17 05:52, Steve Longerbeam wrote:
Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or
output device has measured an interva
On 03/11/2017 05:49 AM, Sakari Ailus wrote:
Hi Steve,
On Thu, Mar 09, 2017 at 08:53:01PM -0800, Steve Longerbeam wrote:
Add an empty UAPI Kbuild file for media UAPI headers.
Signed-off-by: Steve Longerbeam
The existing V4L2 UAPI headers are under include/uapi/linux. Could you use
that dir
On 10/03/17 03:57, Bo Yu wrote:
> The following Coccinelle script was used to detect this:
>
> @@
> local idexpression ret;
> expression e;
> @@
>
> -ret =
> +return
> e;
> -return ret;
A bit of fuzz on this one. Presumably things moving around in other recent
changes.
Anyhow, applied to
Fix bad indentation as reported by checkpatch.pl script.
Signed-off-by: Thibaut SAUTEREAU
---
drivers/staging/rtl8712/rtl8712_led.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl8712_led.c
b/drivers/staging/rtl8712/rtl8712_led.c
index 317aeeed38e
On 11/03/17 14:26, simran singhal wrote:
> This patch-series removes exceptional & on functions name.
>
> v1:
> -Change the commit message of all the patches of the patch-series
Usual convention is to call the first (unlabelled) revision v1
implicitly which would have made this V2. Doesn't real
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On Sat, Mar 11, 2017 at 10:08:23AM -0800, Steve Longerbeam wrote:
> On 03/11/2017 07:32 AM, Sakari Ailus wrote:
> >Hi Mauro and Hans,
> >
> >On Sat, Mar 11, 2017 at 10:14:08AM -0300, Mauro Carvalho Chehab wrote:
> >>Em Sat, 11 Mar 2017 12:32:43 +0100
> >>Hans Verkuil escreveu:
> >>
> >>>On 10/03/1
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On Sat, Mar 11, 2017 at 10:14:49AM -0800, Steve Longerbeam wrote:
> On 03/11/2017 03:39 AM, Hans Verkuil wrote:
> >It's fine to use an internal event as long as the end-user doesn't
> >see it. But if you lose vsyncs, then you never capture another frame,
> >right?
>
> No, that's not correct. By lo
On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote:
On Sat, Mar 11, 2017 at 10:08:23AM -0800, Steve Longerbeam wrote:
On 03/11/2017 07:32 AM, Sakari Ailus wrote:
Hi Mauro and Hans,
On Sat, Mar 11, 2017 at 10:14:08AM -0300, Mauro Carvalho Chehab wrote:
Em Sat, 11 Mar 2017 12:32:43 +0100
On 11/03/17 18:48, Jonathan Cameron wrote:
> On 11/03/17 14:26, simran singhal wrote:
>> Remove & from function pointers to conform to the style found elsewhere
>> in the file. Done using the following semantic patch
>>
>> //
>> @r@
>> identifier f;
>> @@
>>
>> f(...) { ... }
>> @@
>> identifier
On 03/11/2017 10:51 AM, Russell King - ARM Linux wrote:
On Sat, Mar 11, 2017 at 10:14:49AM -0800, Steve Longerbeam wrote:
On 03/11/2017 03:39 AM, Hans Verkuil wrote:
It's fine to use an internal event as long as the end-user doesn't
see it. But if you lose vsyncs, then you never capture anoth
On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote:
>
>
> On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote:
> >I really don't think expecting the user to understand and configure
> >the pipeline is a sane way forward. Think about it - should the
> >user need to know that, bec
On 03/11/2017 10:51 AM, Russell King - ARM Linux wrote:
On Sat, Mar 11, 2017 at 10:14:49AM -0800, Steve Longerbeam wrote:
On 03/11/2017 03:39 AM, Hans Verkuil wrote:
It's fine to use an internal event as long as the end-user doesn't
see it. But if you lose vsyncs, then you never capture anoth
On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote:
On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote:
On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote:
I really don't think expecting the user to understand and configure
the pipeline is a sane way forward. Think ab
From: Colin Ian King
There is no need to check if ret is non-zero, remove this
redundant check and just return the error status from the call
to mt9m114_write_reg_array.
Detected by CoverityScan, CID#1416577 ("Identical code for
different branches")
Signed-off-by: Colin Ian King
---
drivers/s
From: Colin Ian King
The previous statement checks if client is null, so the null check
when assigning dev is redundant and can be removed.
Detected by CoverityScan, CID#1416555 ("Logically Dead Code")
Signed-off-by: Colin Ian King
---
.../staging/media/atomisp/platform/intel-mid/atomisp_gmin
Hi!
> >>I tend to agree with that.
> >
> >I agree as well.
> >
> >This is in line with how existing drivers behave, too.
>
>
> Well, sounds like there is consensus on this topic. I guess I'll
> go ahead and remove the control inheritance support. I suppose
> having a control appear in two places
On 03/11/2017 05:41 AM, Sakari Ailus wrote:
Hi Steve,
On Thu, Mar 09, 2017 at 08:52:58PM -0800, Steve Longerbeam wrote:
If the pads on both sides of a link specify a frame interval, then
those frame intervals should match. Create the exported function
v4l2_subdev_link_validate_frame_interval(
On 03/11/2017 12:26 PM, Pavel Machek wrote:
Hi!
I tend to agree with that.
I agree as well.
This is in line with how existing drivers behave, too.
Well, sounds like there is consensus on this topic. I guess I'll
go ahead and remove the control inheritance support. I suppose
having a con
Replace strcpy with strlcpy as strcpy does not check for buffer
overflow.
This is found using Flawfinder.
Signed-off-by: simran singhal
---
drivers/staging/android/ashmem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/an
On Sat, Mar 11, 2017 at 11:06:55AM -0800, Steve Longerbeam wrote:
> On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote:
> >On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote:
> >>
> >>
> >>On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote:
> >>>I really don't think expecting
On Sun, 12 Mar 2017, simran singhal wrote:
> Replace strcpy with strlcpy as strcpy does not check for buffer
> overflow.
> This is found using Flawfinder.
>
> Signed-off-by: simran singhal
> ---
> drivers/staging/android/ashmem.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> di
Fixed code style warnings reported by checkpatch.pl script.
Signed-off-by: Andrii Vladyka diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 6134eba..d7d2d13 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.
Replace strcpy with strlcpy as strcpy does not check for buffer
overflow.
This is found using Flawfinder.
Signed-off-by: simran singhal
---
v2:
-Correcting the place of the parenthesis
drivers/staging/android/ashmem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/d
On Sun, 12 Mar 2017, simran singhal wrote:
> Replace strcpy with strlcpy as strcpy does not check for buffer
> overflow.
> This is found using Flawfinder.
>
> Signed-off-by: simran singhal
> ---
>
> v2:
>-Correcting the place of the parenthesis
>
> drivers/staging/android/ashmem.c | 3 ++-
Hi!
> > > Ok, perhaps supporting both subdev API and V4L2 API at the same
> > > time doesn't make much sense. We could disable one in favor of the
> > > other, either at compilation time or at runtime.
> >
> > Right. If the subdev API is disabled, then you have to inherit the subdev
> > control
On Sun, Mar 12, 2017 at 2:53 AM, Julia Lawall wrote:
>
>
> On Sun, 12 Mar 2017, simran singhal wrote:
>
>> Replace strcpy with strlcpy as strcpy does not check for buffer
>> overflow.
>> This is found using Flawfinder.
>>
>> Signed-off-by: simran singhal
>> ---
>>
>> v2:
>>-Correcting the pl
On Sun, 12 Mar 2017, SIMRAN SINGHAL wrote:
> On Sun, Mar 12, 2017 at 2:53 AM, Julia Lawall wrote:
> >
> >
> > On Sun, 12 Mar 2017, simran singhal wrote:
> >
> >> Replace strcpy with strlcpy as strcpy does not check for buffer
> >> overflow.
> >> This is found using Flawfinder.
> >>
> >> Signed-
Hi!
> > > The rationale is that we should support the simplest use cases first.
> > >
> > > In the case of the first MC-based driver (and several subsequent
> > > ones), the simplest use case required MC, as it was meant to suport
> > > a custom-made sophisticated application that required fine c
Replace strcpy with strlcpy as strcpy does not check for buffer
overflow.
This is found using Flawfinder.
Signed-off-by: simran singhal
---
v3:
-Correcting the place of the parenthesis and sign
drivers/staging/android/ashmem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
On Sat, Mar 11, 2017 at 08:25:49AM -0300, Mauro Carvalho Chehab wrote:
> This situation is there since 2009. If I remember well, you tried to write
> such generic plugin in the past, but never finished it, apparently because
> it is too complex. Others tried too over the years.
>
> The last trial
On 03/11/2017 03:14 PM, Russell King - ARM Linux wrote:
On Sat, Mar 11, 2017 at 08:25:49AM -0300, Mauro Carvalho Chehab wrote:
This situation is there since 2009. If I remember well, you tried to write
such generic plugin in the past, but never finished it, apparently because
it is too complex
On 03/10/2017 12:13 PM, Russell King - ARM Linux wrote:
Version 5 gives me no v4l2 controls exposed through the video device
interface.
Just like with version 4, version 5 is completely useless with IMX219:
imx6-mipi-csi2: LP-11 timeout, phy_state = 0x0200
ipu1_csi0: pipeline start failed
On Sun, Mar 12, 2017 at 02:10:01AM +0530, simran singhal wrote:
> Replace strcpy with strlcpy as strcpy does not check for buffer
> overflow.
> This is found using Flawfinder.
>
> Signed-off-by: simran singhal
> ---
> drivers/staging/android/ashmem.c | 3 ++-
> 1 file changed, 2 insertions(+), 1
On Sat, Mar 11, 2017 at 09:47:30PM +0100, Julia Lawall wrote:
>
>
> On Sun, 12 Mar 2017, simran singhal wrote:
>
> > Replace strcpy with strlcpy as strcpy does not check for buffer
> > overflow.
> > This is found using Flawfinder.
> >
> > Signed-off-by: simran singhal
> > ---
> > drivers/stagi
Fix prefer kernel type 'u8' over 'uint8_t' checks.
Signed-off-by: Shiva Kerdel
---
drivers/staging/ks7010/ks_hostif.c | 4 +-
drivers/staging/ks7010/ks_hostif.h | 114 +--
drivers/staging/ks7010/ks_wlan_net.c | 2 +-
3 files changed, 60 insertions(+), 60 d
Fix prefer kernel type 'u32' over 'uint32_t' checks.
Signed-off-by: Shiva Kerdel
---
drivers/staging/ks7010/ks_hostif.c | 18 +-
drivers/staging/ks7010/ks_hostif.h | 30 +++---
2 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/stagin
Fix prefer kernel type 'u16' over 'uint16_t' checks.
Signed-off-by: Shiva Kerdel
---
drivers/staging/ks7010/ks_hostif.c | 20 +++---
drivers/staging/ks7010/ks_hostif.h | 134 ++---
2 files changed, 77 insertions(+), 77 deletions(-)
diff --git a/drivers/staging/k
Hello,
This patch series fixes a couple of issues of the previous "support 16bit
unicode screen reading" series:
- fix infinite loop on word spelling
- actually get unicode characters when reviewing console text.
Samuel
--
Samuel
How do I type "for i in *.dvi do xdvi i done" in a GUI?
(Discuss
9831013cbdbd3d06430a1db01d8c32d50c7d1c04 ('speakup: convert screen reading to
16bit characters') paved the way for handling unicode characters in speakup, but
for the review mode, it missed actually getting unicode characters from the VC.
This fixes by just turning the use_unicode parameter to 1.
9831013cbdbd3d06430a1db01d8c32d50c7d1c04 ('speakup: convert screen reading to
16bit characters') made spell_word() ignore non-latin1 characters now read from
the VC, but it missed actually skipping them, leading to an infinite loop. This
fixes it by just advancing the unicode character pointer.
R
New variables are added to make the code more readable.
Also fixed the checkpatch issue: "Alignment should match open
parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/sm750fb/ddk750_mode.c | 112 --
1 file changed, 53 insertions(+), 59 deletions(-)
On Sun, Mar 12, 2017 at 03:29:59AM +0100, Shiva Kerdel wrote:
> Fix prefer kernel type 'u8' over 'uint8_t' checks.
>
> Signed-off-by: Shiva Kerdel
> ---
> drivers/staging/ks7010/ks_hostif.c | 4 +-
> drivers/staging/ks7010/ks_hostif.h | 114
> +--
> drivers
On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote:
On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote:
On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote:
I really don't think expecting the user to understand and configure
the pipeline is a sane way forward. Think ab
On Sun, Mar 12, 2017 at 08:04:02AM +0530, Arushi Singhal wrote:
> New variables are added to make the code more readable.
> Also fixed the checkpatch issue: "Alignment should match open
> parenthesis".
When you have to say "also" in a commit message, that is a huge red-flag
that you need to break
On Sat, Mar 11, 2017 at 07:31:18PM -0800, Steve Longerbeam wrote:
>
>
> On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote:
> >On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote:
> >>
> >>
> >>On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote:
> >>>I really don't think expe
93 matches
Mail list logo
