Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-03 Thread Tobin C. Harding
On Mon, Apr 03, 2017 at 08:19:40AM +0300, Kalle Valo wrote: > + linux-wireless > > "Tobin C. Harding" writes: > > > On Fri, Mar 31, 2017 at 09:58:51AM +0200, Wolfram Sang wrote: > >> > >> > The code is untested, I have hardware in the mail. > >> > >> Cool! > > > > The card I have is a Spectec

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-03 Thread Kalle Valo
"Tobin C. Harding" writes: >> >> But if you want a clean WEXT driver first, this is a step in the right >> >> direction. >> > >> > Let's go for a CFG80211 driver and get out of staging :) So next step >> > is I guess study the ath6kl driver, learn how CFG80211 is done and >> > implement that inte

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-03 Thread Toke Høiland-Jørgensen
"Tobin C. Harding" writes: > Except one: do you know off the top of your head of a canonical > implementation of a softmac wi-fi driver. I'll suggest taking a look at the ath9k driver :) -Toke ___ devel mailing list de...@linuxdriverproject.org http:/

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-03 Thread Arend Van Spriel
seems we are missing out again? On 3-4-2017 11:50, Toke Høiland-Jørgensen wrote: > "Tobin C. Harding" writes: > >> Except one: do you know off the top of your head of a canonical >> implementation of a softmac wi-fi driver. > > I'll suggest taking a look at the ath9k driver :) Looking at ks701

[PATCH v2] scsi: storvsc: Add support for FC rport.

2017-04-03 Thread Cathy Avery
Included in the current storvsc driver for Hyper-V is the ability to access luns on an FC fabric via a virtualized fiber channel adapter exposed by the Hyper-V host. The driver also attaches to the FC transport to allow host and port names to be published under /sys/class/fc_host/hostX. Current cus

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-03 Thread Greg Kroah-Hartman
On Mon, Apr 03, 2017 at 07:03:59PM +1000, Tobin C. Harding wrote: > On Mon, Apr 03, 2017 at 08:19:40AM +0300, Kalle Valo wrote: > > + linux-wireless > > > > "Tobin C. Harding" writes: > > > > > On Fri, Mar 31, 2017 at 09:58:51AM +0200, Wolfram Sang wrote: > > >> > > >> > The code is untested, I

Re: [PATCH v2] scsi: storvsc: Add support for FC rport.

2017-04-03 Thread Christoph Hellwig
> if (host->transportt == fc_transport_template) { > + struct fc_rport_identifiers ids = { > + .roles = FC_PORT_ROLE_FCP_TARGET, > + }; I don't think storvsc ever acts as FCP target. ___ devel mailing lis

Re: [PATCH v2] scsi: storvsc: Add support for FC rport.

2017-04-03 Thread Cathy Avery
On 04/03/2017 08:17 AM, Christoph Hellwig wrote: if (host->transportt == fc_transport_template) { + struct fc_rport_identifiers ids = { + .roles = FC_PORT_ROLE_FCP_TARGET, + }; I don't think storvsc ever acts as FCP target. In order to

Re: [RFC PATCH] binder: Don't require the binder lock when killed in binder_thread_read()

2017-04-03 Thread Greg KH
On Sat, Apr 01, 2017 at 07:34:53PM -0700, Doug Anderson wrote: > Hi, > > On Fri, Mar 31, 2017 at 11:48 PM, Greg KH wrote: > > On Fri, Mar 31, 2017 at 02:00:13PM -0700, Doug Anderson wrote: > >> On Fri, Mar 31, 2017 at 12:29 PM, Greg KH > >> wrote: > >> BTW: I presume that nobody has decided tha

Re: [RFC PATCH] binder: Don't require the binder lock when killed in binder_thread_read()

2017-04-03 Thread peter enderborg
On 03/31/2017 07:53 PM, Douglas Anderson wrote: > Sometimes when we're out of memory the OOM killer decides to kill a > process that's in binder_thread_read(). If we happen to be waiting > for work we'll get the kill signal and wake up. That's good. ...but > then we try to grab the binder lock b

Re: [PATCH v6 02/39] [media] dt-bindings: Add bindings for i.MX media driver

2017-04-03 Thread Rob Herring
On Tue, Mar 28, 2017 at 05:35:52PM -0700, Steve Longerbeam wrote: > > > On 03/28/2017 05:21 PM, Rob Herring wrote: > > On Mon, Mar 27, 2017 at 7:40 PM, Steve Longerbeam > > wrote: > > > Add bindings documentation for the i.MX media driver. > > > > > > > > > + > > > +mipi_csi2 node > > > +

Re: [PATCH v6 02/39] [media] dt-bindings: Add bindings for i.MX media driver

2017-04-03 Thread Rob Herring
On Wed, Mar 29, 2017 at 09:39:05AM +0100, Russell King - ARM Linux wrote: > On Tue, Mar 28, 2017 at 07:21:34PM -0500, Rob Herring wrote: > > On Mon, Mar 27, 2017 at 7:40 PM, Steve Longerbeam > > wrote: > > > Add bindings documentation for the i.MX media driver. > > > > > > Signed-off-by: Steve Lo

Re: [PATCH v6 01/39] [media] dt-bindings: Add bindings for video-multiplexer device

2017-04-03 Thread Rob Herring
On Mon, Mar 27, 2017 at 05:40:18PM -0700, Steve Longerbeam wrote: > From: Philipp Zabel > > Add bindings documentation for the video multiplexer device. > > Signed-off-by: Sascha Hauer > Signed-off-by: Philipp Zabel > Signed-off-by: Steve Longerbeam > --- > .../bindings/media/video-multiplex

Re: [PATCH v6 03/39] [media] dt/bindings: Add bindings for OV5640

2017-04-03 Thread Rob Herring
On Mon, Mar 27, 2017 at 05:40:20PM -0700, Steve Longerbeam wrote: > Add device tree binding documentation for the OV5640 camera sensor. > > Signed-off-by: Steve Longerbeam > --- > .../devicetree/bindings/media/i2c/ov5640.txt | 45 > ++ > 1 file changed, 45 insertions(+

Re: [PATCH v6 02/39] [media] dt-bindings: Add bindings for i.MX media driver

2017-04-03 Thread Russell King - ARM Linux
On Mon, Apr 03, 2017 at 09:11:35AM -0500, Rob Herring wrote: > On Wed, Mar 29, 2017 at 09:39:05AM +0100, Russell King - ARM Linux wrote: > > On Tue, Mar 28, 2017 at 07:21:34PM -0500, Rob Herring wrote: > > > On Mon, Mar 27, 2017 at 7:40 PM, Steve Longerbeam > > > wrote: > > > > Add bindings docum

Re: [PATCH v6 02/39] [media] dt-bindings: Add bindings for i.MX media driver

2017-04-03 Thread Russell King - ARM Linux
On Mon, Apr 03, 2017 at 09:07:43AM -0500, Rob Herring wrote: > On Tue, Mar 28, 2017 at 05:35:52PM -0700, Steve Longerbeam wrote: > > I assume if there's another binding doc in progress, it means > > someone is working on another Synopsys DW CSI-2 subdevice driver. > > Yes. see http://patchwork.ozl

Re: [PATCH 2/2] staging: sm750fb: removed line continuations in quoted strings

2017-04-03 Thread Prasant Jalan
On Sat, Apr 1, 2017 at 12:40 AM, Prasant Jalan wrote: > checkpatch gives WARNING: Avoid line continuations in quoted strings. > > Trivial fix by removing line continuations and adding another quote at > the start of next line. > > Signed-off-by: Prasant Jalan > --- > drivers/staging/sm750fb/sm75

Re: [PATCH 2/2] staging: sm750fb: removed line continuations in quoted strings

2017-04-03 Thread Greg KH
On Mon, Apr 03, 2017 at 10:03:34PM +0530, Prasant Jalan wrote: > On Sat, Apr 1, 2017 at 12:40 AM, Prasant Jalan > wrote: > A gentle reminder for my patches. > Any comments or updates will be helpful! 2 days, over a weekend, for a coding style change is pretty fast, don't you agree? I will ge

RE: [REGRESSION][Stable][v3.12.y][v4.4.y][v4.9.y][v4.10.y][v4.11-rc1] scsi: storvsc: properly set residual data length on errors

2017-04-03 Thread Long Li
I think we need both going forward. They addressed different problems. > -Original Message- > From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > Behalf Of Cathy Avery > Sent: Thursday, March 30, 2017 6:52 AM > To: driverdev-devel@linuxdriverproject.org; Stephen Hemmin

Re: [REGRESSION][Stable][v3.12.y][v4.4.y][v4.9.y][v4.10.y][v4.11-rc1] scsi: storvsc: properly set residual data length on errors

2017-04-03 Thread gre...@linuxfoundation.org
Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Mon, Apr 03, 2017 at 05:57:11PM +, Long Li wrote: > I think we need both going forward. They

Re: [RFC PATCH] binder: Don't require the binder lock when killed in binder_thread_read()

2017-04-03 Thread Doug Anderson
Hi, On Mon, Apr 3, 2017 at 6:25 AM, Greg KH wrote: > On Sat, Apr 01, 2017 at 07:34:53PM -0700, Doug Anderson wrote: >> Hi, >> >> On Fri, Mar 31, 2017 at 11:48 PM, Greg KH wrote: >> > On Fri, Mar 31, 2017 at 02:00:13PM -0700, Doug Anderson wrote: >> >> On Fri, Mar 31, 2017 at 12:29 PM, Greg KH

[PATCH v2] staging: bcm2835-audio: remove unnecessary log messages

2017-04-03 Thread Aishwarya Pant
Remove unnecessary log messages in the driver which are just tracking function entry and exits. Signed-off-by: Aishwarya Pant --- Changes in v2: Patch v1 introduced a compile error; remove it by deleting the log continuation. .../vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 -- .../vc04_

[PATCHv3 00/22] Ion clean up in preparation in moving out of staging

2017-04-03 Thread Laura Abbott
Hi, This is v3 of the series to do some serious Ion cleanup in preparation for moving out of staging. I didn't hear much on v2 so I'm going to assume people are okay with the series as is. I know there were still some open questions about moving away from /dev/ion but in the interest of small step

[PATCHv3 03/22] staging: android: ion: Remove dmap_cnt

2017-04-03 Thread Laura Abbott
The reference counting of dma_map calls was removed. Remove the associated counter field as well. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion_priv.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_priv.h b/drivers/staging/android/ion/ion_

[PATCHv3 05/22] staging: android: ion: Duplicate sg_table

2017-04-03 Thread Laura Abbott
Ion currently returns a single sg_table on each dma_map call. This is incorrect for later usage. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion.c

[PATCHv3 01/22] cma: Store a name in the cma structure

2017-04-03 Thread Laura Abbott
Frameworks that may want to enumerate CMA heaps (e.g. Ion) will find it useful to have an explicit name attached to each region. Store the name in each CMA structure. Signed-off-by: Laura Abbott --- v3: Added default name suggestion per Sumit. Fixup powerpc call site. --- arch/powerpc/kvm/book3s

[PATCHv3 07/22] staging: android: ion: Remove page faulting support

2017-04-03 Thread Laura Abbott
The new method of syncing with dma_map means that the page faulting sync implementation is no longer applicable. Remove it. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.c | 117 -- 1 file changed, 117 deletions(-) diff --git a/drivers/stagi

[PATCHv3 11/22] staging: android: ion: Remove duplicate ION_IOC_MAP

2017-04-03 Thread Laura Abbott
ION_IOC_MAP is the same as ION_IOC_SHARE. We really don't need two identical interfaces. Remove it. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/compat_ion.c | 1 - drivers/staging/android/ion/ion-ioctl.c | 1 - drivers/staging/android/uapi/ion.h | 10 -- 3 files

[PATCHv3 10/22] staging: android: ion: Remove import interface

2017-04-03 Thread Laura Abbott
With the expansion of dma-buf and the move for Ion to be come just an allocator, the import mechanism is mostly useless. There isn't a kernel component to Ion anymore and handles are private to Ion. Remove this interface. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/compat_ion.c |

[PATCHv3 09/22] staging: android: ion: Remove custom ioctl interface

2017-04-03 Thread Laura Abbott
Ion is now moving towards a unified interfact. This makes the custom ioctl interface unneeded. Remove it. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/compat_ion.c | 40 -- drivers/staging/android/ion/ion-ioctl.c| 11 --- drivers/staging/a

[PATCHv3 13/22] staging: android: ion: Use CMA APIs directly

2017-04-03 Thread Laura Abbott
When CMA was first introduced, its primary use was for DMA allocation and the only way to get CMA memory was to call dma_alloc_coherent. This put Ion in an awkward position since there was no device structure readily available and setting one up messed up the coherency model. These days, CMA can be

[PATCHv3 12/22] staging: android: ion: Remove old platform support

2017-04-03 Thread Laura Abbott
Device specific platform support has been haphazard for Ion. There have been several independent attempts and there are still objections to what bindings exist right now. Just remove everything for a fresh start. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/Kconfig

[PATCHv3 06/22] staging: android: ion: Call dma_map_sg for syncing and mapping

2017-04-03 Thread Laura Abbott
Technically, calling dma_buf_map_attachment should return a buffer properly dma_mapped. Add calls to dma_map_sg to begin_cpu_access to ensure this happens. As a side effect, this lets Ion buffers take advantage of the dma_buf sync ioctls. Signed-off-by: Laura Abbott --- drivers/staging/android/i

[PATCHv3 02/22] cma: Introduce cma_for_each_area

2017-04-03 Thread Laura Abbott
Frameworks (e.g. Ion) may want to iterate over each possible CMA area to allow for enumeration. Introduce a function to allow a callback. Signed-off-by: Laura Abbott --- include/linux/cma.h | 2 ++ mm/cma.c| 14 ++ 2 files changed, 16 insertions(+) diff --git a/include/

[PATCHv3 04/22] staging: android: ion: Remove alignment from allocation field

2017-04-03 Thread Laura Abbott
The align field was supposed to be used to specify the alignment of the allocation. Nobody actually does anything with it except to check if the alignment specified is out of bounds. Since this has no effect on the actual allocation, just remove it. Signed-off-by: Laura Abbott --- drivers/stagin

[PATCHv3 08/22] staging: android: ion: Remove crufty cache support

2017-04-03 Thread Laura Abbott
Now that we call dma_map in the dma_buf API callbacks there is no need to use the existing cache APIs. Remove the sync ioctl and the existing bad dma_sync calls. Explicit caching can be handled with the dma_buf sync API. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/compat_ion.c

[PATCHv3 14/22] staging: android: ion: Stop butchering the DMA address

2017-04-03 Thread Laura Abbott
Now that we have proper caching, stop setting the DMA address manually. It should be set after properly calling dma_map. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/staging/android

[PATCHv3 15/22] staging: android: ion: Break the ABI in the name of forward progress

2017-04-03 Thread Laura Abbott
Several of the Ion ioctls were designed in such a way that they necessitate compat ioctls. We're breaking a bunch of other ABIs and cleaning stuff up anyway so let's follow the ioctl guidelines and clean things up while everyone is busy converting things over anyway. As part of this, also remove th

[PATCHv3 16/22] staging: android: ion: Get rid of ion_phys_addr_t

2017-04-03 Thread Laura Abbott
Once upon a time, phys_addr_t was not everywhere in the kernel. These days it is used enough places that having a separate Ion type doesn't make sense. Remove the extra type and just use phys_addr_t directly. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.h | 12 ++

[PATCHv3 18/22] staging: android: ion: Rework heap registration/enumeration

2017-04-03 Thread Laura Abbott
The current model of Ion heap registration is based on the outdated model of board files. The replacement for board files (devicetree) isn't a good replacement for what Ion wants to do. In actuality, Ion wants to show what memory is available in the system for something else to figure out what to

[PATCHv3 20/22] staging: android: ion: Remove ion_handle and ion_client

2017-04-03 Thread Laura Abbott
ion_handle was introduced as an abstraction to represent a reference to a buffer via an ion_client. As frameworks outside of Ion evolved, the dmabuf emerged as the preferred standard for use in the kernel. This has made the ion_handle an unnecessary abstraction and prone to race conditions. ion_cli

[PATCHv3 17/22] staging: android: ion: Collapse internal header files

2017-04-03 Thread Laura Abbott
Ion current has ion_priv.h and ion.h as header files. ion.h was intended to be used for public APIs but Ion never ended up really having anything public. Combine the two headers so there is only one internal header. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion-ioctl.c

[PATCHv3 19/22] staging: android: ion: Drop ion_map_kernel interface

2017-04-03 Thread Laura Abbott
Nobody uses this interface externally. Drop it. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.c | 59 --- 1 file changed, 59 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 7d40233..5a82

[PATCHv3 22/22] staging/android: Update Ion TODO list

2017-04-03 Thread Laura Abbott
Most of the items have been taken care of by a clean up series. Remove the completed items and add a few new ones. Signed-off-by: Laura Abbott --- drivers/staging/android/TODO | 21 - 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/staging/android/TODO

[PATCHv3 21/22] staging: android: ion: Set query return value

2017-04-03 Thread Laura Abbott
This never got set in the ioctl. Properly set a return value of 0 on success. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 9eeb06f..d6fd350 100644

[PATCH] Staging: lustre cleanup macros in libcfs_private.h

2017-04-03 Thread Craig Inches
This resolves a checkpatch warning that "Single statement macros should not use a do {} while (0) loop" by removing the loop and adjusting line length accordingly. Signed-off-by: Craig Inches --- .../lustre/include/linux/libcfs/libcfs_private.h | 51 +++--- 1 file changed, 15 i

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-03 Thread Tobin C. Harding
On Mon, Apr 03, 2017 at 12:15:15PM +0200, Arend Van Spriel wrote: > seems we are missing out again? Sorry, I don't understand what this comment means? > On 3-4-2017 11:50, Toke Høiland-Jørgensen wrote: > > "Tobin C. Harding" writes: > > > >> Except one: do you know off the top of your head of a

[PATCH v2] Remove sparse warnings in mdc_request.c

2017-04-03 Thread skanda . kashyap
From: Skanda Guruanand Signed-off-by: Skanda Guruanand I have modified struct lu_dirpage as suggested in lustre_idl.h file CHECK drivers/staging/lustre/lustre/mdc/mdc_request.c drivers/staging/lustre/lustre/mdc/mdc_request.c:958:42: warning: cast to restricted __le64 drivers/staging/lustre/

Re: [PATCH v2] Remove sparse warnings in mdc_request.c

2017-04-03 Thread Greg KH
On Mon, Apr 03, 2017 at 10:25:37PM -0700, skanda.kash...@gmail.com wrote: > From: Skanda Guruanand > > Signed-off-by: Skanda Guruanand > > I have modified struct lu_dirpage as suggested in lustre_idl.h file > > CHECK drivers/staging/lustre/lustre/mdc/mdc_request.c > drivers/staging/lustre/l

Re: [PATCH v2] scsi: storvsc: Add support for FC rport.

2017-04-03 Thread Christoph Hellwig
On Mon, Apr 03, 2017 at 09:14:02AM -0400, Cathy Avery wrote: > On 04/03/2017 08:17 AM, Christoph Hellwig wrote: > > > if (host->transportt == fc_transport_template) { > > > + struct fc_rport_identifiers ids = { > > > + .roles = FC_PORT_ROLE_FCP_TARGET, > > > +