On Sun, Mar 26, 2017 at 12:24:14AM +0100, Guillaume Brogi wrote:
>
> This patch fixes the following sparse warnings:
> drivers/staging/rtl8192u/r8192U_dm.c:2307:49: warning: cast from restricted
> __le16
> drivers/staging/rtl8192u/r8192U_dm.c:2308:44: warning: cast from restricted
> __le16
> dri
On Mon, Apr 03, 2017 at 11:57:42AM -0700, Laura Abbott wrote:
> Hi,
>
> This is v3 of the series to do some serious Ion cleanup in preparation for
> moving out of staging. I didn't hear much on v2 so I'm going to assume
> people are okay with the series as is. I know there were still some open
> q
On Fri, Mar 31, 2017 at 03:22:26PM +0200, Christian Gromm wrote:
> From: Andrey Shvetsov
>
> This patch replaces the use of a macro MOST_CHNL_ATTR in the macro
> create_channel_attribute with a macro __ATTR_RW.
>
> Additionally, this patch removes not anymore used macro MOST_CHNL_ATTR.
>
> Sign
On Tue, Apr 04, 2017 at 02:59:30PM +0530, Pushkar Jambhlekar wrote:
> Making references in single line
Why? Now the line is too long :(
Will this be a constant stream of patches, one making this change, and
the other the original?
sorry,
greg k-h
___
On Wed, Apr 05, 2017 at 10:42:06AM +1000, Tobin C. Harding wrote:
> Length undergoes type conversion when passed (indirectly) as an
> argument for parameter of type 'unsigned int'. If length is negative
> this is a bug (the value after conversion is large).
>
> Declare 'length' to be of type unsig
On Sat, Mar 25, 2017 at 05:40:48PM +0530, Prasant Jalan wrote:
>
> Replacing spaces with tabs for indetation to fix checkpatch.pl error
> "code indent should use tabs where possible".
>
>
> Signed-off-by: Prasant Jalan
> ---
>
> v2:
> - improved changelog comments
> - fixed only one
On Wed, Mar 29, 2017 at 06:15:35AM +0100, Andrea della Porta wrote:
> Fixed issues:
> CHECK: Alignment should match open parenthesis
> #71: FILE: drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c:71:
> + audio_info("alsa_stream=%p substream=%p\n", alsa_stream,
> + alsa_s
On Fri, Apr 07, 2017 at 05:24:05PM +0530, Aditya Shankar wrote:
> With this update, the host driver is consistent with the
> implementation on the firmware side with respect to obtaining
> the driver handler for all modes.
> With this new format, the calls to set the wilc operation mode
> is simpli
On Fri, Apr 07, 2017 at 02:47:55PM +0200, Maciek Borzecki wrote:
> PDA buffer contains little-endian data, clearly mark it as such.
>
> Fixes sparse warnings:
> drivers/staging/wlan-ng/hfa384x_usb.c:2359:34: warning: cast to restricted
> __le16
> drivers/staging/wlan-ng/hfa384x_usb.c:2360:35:
On Mon, Apr 03, 2017 at 10:25:37PM -0700, skanda.kash...@gmail.com wrote:
> From: Skanda Guruanand
>
> Signed-off-by: Skanda Guruanand
Changelog text goes between those two lines, right?
>
> I have modified struct lu_dirpage as suggested in lustre_idl.h file
Why the extra ' '?
>
> CHECK
On Fri, Apr 07, 2017 at 08:41:11AM -0400, Manny Vindiola wrote:
> Add blank line after variable declarations as part of checkpatch.pl style
> fixup.
>
> Signed-off-by: Manny Vindiola
> ---
> drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c | 1 +
> 1 file changed, 1 insertion(+)
Your s
On Fri, Apr 7, 2017 at 8:57 PM, Deepa Dinamani wrote:
> struct timespec is not y2038 safe.
> Audit timestamps are recorded in string format into
> an audit buffer for a given context.
> These mark the entry timestamps for the syscalls.
> Use y2038 safe struct timespec64 to represent the times.
> T
On Sat, Apr 8, 2017 at 1:01 PM, Greg Kroah-Hartman
wrote:
> On Fri, Apr 07, 2017 at 02:47:55PM +0200, Maciek Borzecki wrote:
>> PDA buffer contains little-endian data, clearly mark it as such.
>>
>> Fixes sparse warnings:
>> drivers/staging/wlan-ng/hfa384x_usb.c:2359:34: warning: cast to restric
On Sat, Apr 8, 2017 at 3:18 PM, Maciek Borzecki
wrote:
> On Sat, Apr 8, 2017 at 1:01 PM, Greg Kroah-Hartman
> wrote:
>> On Fri, Apr 07, 2017 at 02:47:55PM +0200, Maciek Borzecki wrote:
>>> PDA buffer contains little-endian data, clearly mark it as such.
>>>
>>> Fixes sparse warnings:
>>> driver
struct hfa384x_pdrec len and code fields as clearly little endian,
mark both fields as such. pda->buf is also clearly little endian.
Fixes sparse warnings:
drivers/staging/wlan-ng/prism2fw.c:613:16: warning: cast to restricted __le16
drivers/staging/wlan-ng/prism2fw.c:616:21: warning: cast t
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Friday, April 7, 2017 4:27 AM
> To: de...@linuxdriverproject.org; x...@kernel.org
> Cc: linux-ker...@vger.kernel.org; KY Srinivasan ;
> Haiyang Zhang ; Stephen Hemminger
> ; Thomas Gleixner ; Ingo
> Molnar
On Tue, Apr 04, 2017 at 12:03:43AM +0530, Aishwarya Pant wrote:
> Remove unnecessary log messages in the driver which are just tracking
> function entry and exits.
>
> Signed-off-by: Aishwarya Pant
> ---
> Changes in v2:
> Patch v1 introduced a compile error; remove it by deleting the log
> conti
On Thu, Mar 30, 2017 at 12:11:05AM +0300, aviyae wrote:
> Fix style issues by adding parenthesis around macros
> arguments
>
> Signed-off-by: Aviya Erenfeld
> ---
> drivers/staging/goldfish/goldfish_audio.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/
On Thu, Mar 30, 2017 at 12:11:05AM +0300, aviyae wrote:
> Fix style issues by adding parenthesis around macros
> arguments
>
> Signed-off-by: Aviya Erenfeld
Also your From: line does not match this line...
___
devel mailing list
de...@linuxdriverprojec
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Friday, April 7, 2017 4:27 AM
> To: de...@linuxdriverproject.org; x...@kernel.org
> Cc: linux-ker...@vger.kernel.org; KY Srinivasan ;
> Haiyang Zhang ; Stephen Hemminger
> ; Thomas Gleixner ; Ingo
> Molnar
On Wed, Apr 05, 2017 at 06:01:01PM +0100, David Howells wrote:
> When the kernel is running in secure boot mode, we lock down the kernel to
> prevent userspace from modifying the running kernel image. Whilst this
> includes prohibiting access to things like /dev/mem, it must also prevent
> access
On Wed, Apr 05, 2017 at 06:01:10PM +0100, David Howells wrote:
> When the kernel is running in secure boot mode, we lock down the kernel to
> prevent userspace from modifying the running kernel image. Whilst this
> includes prohibiting access to things like /dev/mem, it must also prevent
> access
From: k...@exchange.microsoft.com
Date: Thu, 6 Apr 2017 14:59:21 -0700
> From: K. Y. Srinivasan
>
> Prior to opening the channel we should have all the state setup to handle
> interrupts. The current code does not do that; fix the bug. This bug
> can result in faults in the interrupt path.
>
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Friday, April 7, 2017 4:27 AM
> To: de...@linuxdriverproject.org; x...@kernel.org
> Cc: linux-ker...@vger.kernel.org; KY Srinivasan ;
> Haiyang Zhang ; Stephen Hemminger
> ; Thomas Gleixner ; Ingo
> Molnar
Some of the macros didn't use the parenthesis around the parameters when
used in the body of the macro.
Signed-off-by: Nikola Jelic
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/media/bcm2048/rad
Smatch issues the warning
CHECK drivers/staging/rtl8723bs/os_dep/xmit_linux.c
drivers/staging/rtl8723bs/os_dep/xmit_linux.c:42 _rtw_pktfile_read() warn:
inconsistent indenting
A simple indent changes fixes this.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/os_dep/xmit_linux.c
Smatch lists the following warning:
CHECK drivers/staging/rtl8723bs/os_dep/rtw_proc.c
drivers/staging/rtl8723bs/os_dep/rtw_proc.c:102 rtw_drv_proc_open() warn:
inconsistent indenting
This warning is fixed with a simple change in the white space.
Signed-off-by: Larry Finger
---
drivers/sta
A number of routines have indenting, off by one, and possible usage
while null warnings or errors listed by Smatch. This set of patches
fix all but one of these, and it is in code that will be removed in a
subsequent patch.
Signed-off-by: Larry Finger
Larry Finger (22):
staging: rtl8723bs: Fi
Smatch lists the following warning:
CHECK drivers/staging/rtl8723bs/os_dep/recv_linux.c
drivers/staging/rtl8723bs/os_dep/recv_linux.c:353 rtw_recv_indicatepkt() warn:
variable dereferenced before check 'precv_frame' (see line 312)
This warning is fixed by removing the test at line 353.
Sign
Smatch logs the following warning:
CHECK drivers/staging/rtl8723bs/os_dep/os_intfs.c
drivers/staging/rtl8723bs/os_dep/os_intfs.c:1082 ips_netdrv_open() warn:
inconsistent indenting
A simple change in the white space handles this warning.
Signed-off-by: Larry Finger
---
drivers/staging/rtl
Smatch lists the following:
CHECK drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:470
rtw_cfg80211_ibss_indicate_connect() error: we previously assumed 'scanned'
could be null (see line 466)
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
Smatch logs the following:
CHECK drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:518
rtl8723b_FirmwareDownload() error: we previously assumed 'pFirmware' could be
null (see line 382)
Fixing this error required a rewrite of the error exits
Smatch reports the following warning:
CHECK drivers/staging/rtl8723bs/os_dep/mlme_linux.c
drivers/staging/rtl8723bs/os_dep/mlme_linux.c:149 rtw_os_indicate_disconnect()
warn: inconsistent indenting
Again, a simple change in the white space fixes this problem.
Signed-off-by: Larry Finger
--
Smatch lists the following:
CHECK drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c
drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c:314
ODM_ReadAndConfig_MP_8723B_AGC_TAB() warn: for statement not indented
drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c:583
ODM_ReadAndConfig_MP_8723B_PHY_RE
Smatch logs the following:
CHECK drivers/staging/rtl8723bs/core/rtw_xmit.c
drivers/staging/rtl8723bs/core/rtw_xmit.c:277 _rtw_init_xmit_priv() warn:
inconsistent indenting
drivers/staging/rtl8723bs/core/rtw_xmit.c:294 _rtw_free_xmit_priv() warn:
inconsistent indenting
drivers/staging/rtl8723
Smatch reports the following:
CHECK drivers/staging/rtl8723bs/core/rtw_debug.c
drivers/staging/rtl8723bs/core/rtw_debug.c:454 proc_get_survey_info() error: we
previously assumed 'phead' could be null (see line 453)
drivers/staging/rtl8723bs/core/rtw_debug.c:455 proc_get_survey_info() warn:
v
Smatch reports the following:
CHECK drivers/staging/rtl8723bs/core/rtw_ap.c
drivers/staging/rtl8723bs/core/rtw_ap.c:382 expire_timeout_chk() warn:
inconsistent indenting
Fixing this requires changing the indentatikon of a long for loop.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8
Smatch lists the following:
CHECK drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:2090
Hal_ChannelPlanToRegulation() warn: inconsistent indenting
Fixed by changing the white space.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/hal/
Smatch reports the following:
CHECK drivers/staging/rtl8723bs/core/rtw_ieee80211.c
drivers/staging/rtl8723bs/core/rtw_ieee80211.c:83 rtw_is_cckrates_included()
warn: if statement not indented
drivers/staging/rtl8723bs/core/rtw_ieee80211.c:98
rtw_is_cckratesonly_included() warn: if statement
Smatch reports the following:
CHECK drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:2090
Hal_ChannelPlanToRegulation() warn: inconsistent indenting
This warning is fixed with a white-space change.
Signed-off-by: Larry Finger
---
drivers/stagin
Smatch reports the following:
CHECK drivers/staging/rtl8723bs/core/rtw_security.c
drivers/staging/rtl8723bs/core/rtw_security.c:266 rtw_wep_encrypt() warn:
inconsistent indenting
drivers/staging/rtl8723bs/core/rtw_security.c:433 rtw_seccalctkipmic() warn:
inconsistent indenting
drivers/stagi
Sparse reports the following:
CHECK drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
drivers/staging/rtl8723bs/core/rtw_sta_mgt.c:25 _rtw_init_stainfo() warn:
inconsistent indenting
This problem is fixed with a white-spcae change.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/core
Smatch reports the following:
CHECK drivers/staging/rtl8723bs/core/rtw_wlan_util.c
drivers/staging/rtl8723bs/core/rtw_wlan_util.c:67 cckrates_included() warn: if
statement not indented
drivers/staging/rtl8723bs/core/rtw_wlan_util.c:81 cckratesonly_included() warn:
if statement not indented
d
Smatch lists the following:
CHECK drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:525 _mgt_dispatcher() warn:
inconsistent indenting
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:1595 OnAssocReq() error: buffer
overflow 'pstapriv->sta_aid' 32 <= 32
Smatch reports the following:
CHECK drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:641 LeaveAllPowerSaveModeDirect()
warn: inconsistent indenting
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 2 +-
1 file changed,
Smatch reports the following:
CHECK drivers/staging/rtl8723bs/core/rtw_mlme.c
drivers/staging/rtl8723bs/core/rtw_mlme.c:862 rtw_survey_event_callback() warn:
inconsistent indenting
drivers/staging/rtl8723bs/core/rtw_mlme.c:1102 rtw_free_assoc_resources() warn:
if statement not indented
drive
Smatch reports the following:
CHECK drivers/staging/rtl8723bs/core/rtw_odm.c
drivers/staging/rtl8723bs/core/rtw_odm.c:109 rtw_odm_dbg_comp_msg() warn: if
statement not indented
drivers/staging/rtl8723bs/core/rtw_odm.c:146 rtw_odm_ability_msg() warn: if
statement not indented
Signed-off-by:
Smart reports the following:
CHECK drivers/staging/rtl8723bs/core/rtw_recv.c
drivers/staging/rtl8723bs/core/rtw_recv.c:598 portctrl() warn: inconsistent
indenting
drivers/staging/rtl8723bs/core/rtw_recv.c:838 sta2sta_data_frame() warn:
inconsistent indenting
drivers/staging/rtl8723bs/core/rt
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: 1375baa965590bbd3ce7656a6d643e4b3590fd37
commit: 554c0a3abf216c991c5ebddcdb2c08689ecd290b [751/783] staging: Add
rtl8723bs sdio wifi driver
config: alpha-allyesconfig (attached as .config)
compiler:
Andrea della Porta (3):
staging: vc04_services: bcm2835-audio: bcm2835-pcm.c Fixed checkpatch
warning about unaligned function params
staging: vc04_services: bcm2835-audio: bcm2835-pcm.c Fixed codepatch
coding style issue, line over 80
staging: vc04_services: bcm2835-audio: bcm2835-pc
Fixed unaligned function parameters issues, as per checkpatch warning
Signed-off-by: Andrea della Porta
---
Changes in v2:
- subject line more explicit
- checkpatch output removed as requested, summarized in one line
.../vc04_services/bcm2835-audio/bcm2835-pcm.c | 47 ++
Fixed checkpatch warning about line over 80 chars
Signed-off-by: Andrea della Porta
---
Changes in v2:
- subject line more explicit
- chekpatch output removed as requested, summarized in one line
drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 3 ++-
1 file changed, 2 insertions(+),
Removed an extra spaces at the end of the line
Signed-off-by: Andrea della Porta
---
Changes in v2:
- subject line more explicit
drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/bcm2835-au
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Friday, April 7, 2017 4:27 AM
> To: de...@linuxdriverproject.org; x...@kernel.org
> Cc: linux-ker...@vger.kernel.org; KY Srinivasan ;
> Haiyang Zhang ; Stephen Hemminger
> ; Thomas Gleixner ; Ingo
> Molnar
kfree returns immediately on NULL so the tests are not needed.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
CC: Hans de Goede
Signed-off-by: Julia Lawall
Signed-off-by: Fengguang Wu
---
rtw_cmd.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/drivers/staging/
kfree returns immediately on NULL so the tests are not needed.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
CC: Hans de Goede
Signed-off-by: Julia Lawall
Signed-off-by: Fengguang Wu
---
v2: Extended subject line to avoid conflicting with the next kbuild
report.
rtw_cmd.c |6 ++
kfree returns immediately on NULL so the tests are not needed.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
CC: Hans de Goede
Signed-off-by: Julia Lawall
Signed-off-by: Fengguang Wu
---
rtw_ap.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/staging/rtl87
Hi Julia,
On 08-04-17 19:10, Julia Lawall wrote:
kfree returns immediately on NULL so the tests are not needed.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
CC: Hans de Goede
Signed-off-by: Julia Lawall
Signed-off-by: Fengguang Wu
Thank you for these patches. Larry Finger has ju
On Sat, 8 Apr 2017, Hans de Goede wrote:
> Hi Julia,
>
> On 08-04-17 19:10, Julia Lawall wrote:
> > kfree returns immediately on NULL so the tests are not needed.
> >
> > Generated by: scripts/coccinelle/free/ifnullfree.cocci
> >
> > CC: Hans de Goede
> > Signed-off-by: Julia Lawall
> > Signed
On 04/08/2017 12:32 PM, Julia Lawall wrote:
On Sat, 8 Apr 2017, Hans de Goede wrote:
Hi Julia,
On 08-04-17 19:10, Julia Lawall wrote:
kfree returns immediately on NULL so the tests are not needed.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
CC: Hans de Goede
Signed-off-by: Jul
On Sat, 8 Apr 2017, Larry Finger wrote:
> On 04/08/2017 12:32 PM, Julia Lawall wrote:
> >
> >
> > On Sat, 8 Apr 2017, Hans de Goede wrote:
> >
> > > Hi Julia,
> > >
> > > On 08-04-17 19:10, Julia Lawall wrote:
> > > > kfree returns immediately on NULL so the tests are not needed.
> > > >
> > > >
> I have no problem merging this patch into audit/next for v4.12, would
> you prefer me to do that so at least this patch is merged?
This would be fine.
But, I think whoever takes the last 2 deletion patches should also take them.
I'm not sure how that part works out.
> It would probably make lif
Hi Laura,
Couple of trivial nitpicks below.
On 3 April 2017 at 19:57, Laura Abbott wrote:
> --- a/drivers/staging/android/ion/ion.h
> +++ b/drivers/staging/android/ion/ion.h
> @@ -1,5 +1,5 @@
> /*
> - * drivers/staging/android/ion/ion.h
> + * drivers/staging/android/ion/ion_priv.h
Does not mat
On Sat, Apr 08, 2017 at 12:31:25PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Mar 26, 2017 at 12:24:14AM +0100, Guillaume Brogi wrote:
> >
> > This patch fixes the following sparse warnings:
> > drivers/staging/rtl8192u/r8192U_dm.c:2307:49: warning: cast from restricted
> > __le16
> > drivers/sta
64 matches
Mail list logo