Re: [PATCH] staging: fbtft: fix character limit, trailing ; warning, etc.

2017-04-22 Thread Joe Perches
On Sat, 2017-04-22 at 16:26 +0100, Eric Curtin wrote: > checkpatch spits out a warning about the 80 character line limit. Split > the parameters of these functions onto different lines. Put the ; with > the macro caller instead. Lined up parameters as there was another > CHECK warning about that.

[PATCH] staging: rtl8192u: Improve readability and fix sparse warnings: cast from restricted __le16

2017-04-22 Thread Tuomo Rinne
This patch fixes following sparse warnings: drivers/staging/rtl8192u//r8192U_dm.c:2307:49: warning: cast from restricted __le16 drivers/staging/rtl8192u//r8192U_dm.c:2308:44: warning: cast from restricted __le16 drivers/staging/rtl8192u//r8192U_dm.c:2309:44: warning: cast from restricted

Re: [PATCH] staging: wilc1000: Fixes Alignment should match open parenthesis

2017-04-22 Thread Joe Perches
On Sat, 2017-04-22 at 07:28 +0100, rich...@netpro.work wrote: > This patch fixes the following checkpatch.pl > check: CHECK: Alignment should match open parenthesis Please strive for improved code for human readers and not just shutting up checkpatch. > diff --git

[PATCH] staging: fbtft: fix character limit, trailing ; warning, etc.

2017-04-22 Thread Eric Curtin
checkpatch spits out a warning about the 80 character line limit. Split the parameters of these functions onto different lines. Put the ; with the macro caller instead. Lined up parameters as there was another CHECK warning about that. Signed-off-by: Eric Curtin ---

[PATCH] staging: rtl8188eu: prevent an underflow in rtw_check_beacon_data()

2017-04-22 Thread Dan Carpenter
The "len" could be as low as -14 so we should check for negatives. Fixes: 9a7fe54ddc3a ("staging: r8188eu: Add source files for new driver - part 1") Signed-off-by: Dan Carpenter diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c

[PATCH 2/2] staging: vt6656: use off stack for in buffer USB transfers.

2017-04-22 Thread Malcolm Priestley
Since 4.9 mandated USB buffers to be heap allocated. This causes the driver to fail. Create buffer for USB transfers. Signed-off-by: Malcolm Priestley Cc: # v4.9+ --- drivers/staging/vt6656/usbpipe.c | 17 +++-- 1 file changed, 15

[PATCH 1/2] staging: vt6656: use off stack for out buffer USB transfers.

2017-04-22 Thread Malcolm Priestley
Since 4.9 mandated USB buffers be heap allocated this causes the driver to fail. Since there is a wide range of buffer sizes use kmemdup to create allocated buffer. Signed-off-by: Malcolm Priestley Cc: # v4.9+ --- drivers/staging/vt6656/usbpipe.c |

[patch 1/1] staging: speakup: add send_xchar and tiocmset methods

2017-04-22 Thread Okash Khawaja
This adds two methods to spk_synth struct: send_xchar and tiocmset, and creates serial implementation for each of them. It takes existing code in apollo, audptr and spkout which already fits the behaviour of send_xchar and tiocmset. In follow-up patches there will be TTY-based implementations of

[patch 0/1] staging: speakup: refactor to allow smoother migration to TTY-based comms with external synths

2017-04-22 Thread Okash Khawaja
This is part of move away from raw serial i/o to TTY-based one. Details are in the patch header. Thanks, Okash ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: wilc1000: Fixes Alignment should match open parenthesis

2017-04-22 Thread richard
From: Richard Miller This patch fixes the following checkpatch.pl check: CHECK: Alignment should match open parenthesis Signed-off-by: Richard Miller --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/linux_wlan.c

[PATCH v2] bus: fsl-mc: dpio: fix alter FQ state command

2017-04-22 Thread Horia Geantă
When checking the response verb, the valid bit should be masked out, since its value flips depending on what Response Register (RR0 /RR1) it's been read from. Fixes: 321eecb06bfb ("bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2") Signed-off-by: Horia Geantă --- v2: use