Re: [PATCH 4/7] staging: rtl8723bs: Move braces to same line as conditional

On Thu, 2017-04-27 at 19:22 -0500, Larry Finger wrote: > On 04/27/2017 07:09 PM, Justin Vreeland wrote: > > Signed-off-by: Justin Vreeland > > --- > > drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 15 +-- > > drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c |

Re: [PATCH 4/7] staging: rtl8723bs: Move braces to same line as conditional

On 04/27/2017 07:09 PM, Justin Vreeland wrote: Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 15 +-- drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 9 +++-- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6

Re: [PATCH 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses

On 04/27/2017 07:09 PM, Justin Vreeland wrote: Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/odm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h index

[PATCH 1/7] staging: rtl8723bs: Fix initialization of static variables

Do not initialize static to 0 Do not initialize static to false Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 8 drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 4 ++-- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 +-

[PATCH 6/7] staging: rtl8723bs: Fix spacing around '<'

Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c index

[PATCH 0/7] staging: rtl8732: Various checkpatch fixes

Justin Vreeland (7): staging: rtl8723bs: Fix initialization of static variables staging: rtl8723bs: Wrap multi-line macros in do-while loop staging: rtl8723bs: Macros with complex values should be enclosed in parentheses staging: rtl8723bs: Move braces to same line as conditional

[PATCH 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses

Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/odm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h index 0b3541a91548..13c4aebd178e 100644 ---

[PATCH 4/7] staging: rtl8723bs: Move braces to same line as conditional

Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 15 +-- drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 9 +++-- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6 ++ 3 files changed, 10 insertions(+), 20

[PATCH 7/7] staging: rtl8723bs: Do not use assignment in if condition

Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c index

[PATCH 5/7] staging: rtl8723bs: Fix pointer style

Fix "(foo*)" should be "(foo *)" Fix "foo * bar" should be "foo *bar" Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c

[PATCH 2/7] staging: rtl8723bs: Wrap multi-line macros in do-while loop

Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/odm_debug.h | 80 +-- 1 file changed, 44 insertions(+), 36 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/odm_debug.h b/drivers/staging/rtl8723bs/hal/odm_debug.h index

Re: [PATCH 2/7] staging: rtl8723bs: Wrap multi-line macros in do-while loop

On 04/27/2017 07:09 PM, Justin Vreeland wrote: Signed-off-by: Justin Vreeland --- The patch is OK, but most maintainers require a non-blank commit message. Larry drivers/staging/rtl8723bs/hal/odm_debug.h | 80 +-- 1 file changed, 44

[PATCH] ion: Fixed initialization of static variable to 0

From: Fabrizio Signed-off-by: Fabrizio --- drivers/staging/android/ion/ion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index fb836c6..03d3a4f

Re: [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function

On 27/04/17 05:20 PM, Jason Gunthorpe wrote: > It seems the most robust: test for iomem, and jump to a slow path > copy, otherwise inline the kmap and memcpy > > Every place doing memcpy from sgl will need that pattern to be > correct. Ok, sounds like a good place to start to me. I'll see what

Re: [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function

On Thu, Apr 27, 2017 at 05:03:45PM -0600, Logan Gunthorpe wrote: > > > On 27/04/17 04:11 PM, Jason Gunthorpe wrote: > > On Thu, Apr 27, 2017 at 03:53:37PM -0600, Logan Gunthorpe wrote: > > Well, that is in the current form, with more users it would make sense > > to optimize for the single page

Re: [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function

On 27/04/17 04:11 PM, Jason Gunthorpe wrote: > On Thu, Apr 27, 2017 at 03:53:37PM -0600, Logan Gunthorpe wrote: > Well, that is in the current form, with more users it would make sense > to optimize for the single page case, eg by providing the existing > call, providing a faster

[PATCH] drivers: staging: lustre: lustre: llite: file.c - fixed sparse warning about different fmode_t type

fixed a couple of sparse warning complaining about type mismatch. Signed-off-by: Andrea della Porta --- drivers/staging/lustre/lustre/include/lustre_intent.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function

On Thu, Apr 27, 2017 at 03:53:37PM -0600, Logan Gunthorpe wrote: > On 27/04/17 02:53 PM, Jason Gunthorpe wrote: > > blkfront is one of the drivers I looked at, and it appears to only be > > memcpying with the bvec_data pointer, so I wonder why it does not use > > sg_copy_X_buffer instead.. > >

Re: [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function

On 27/04/17 02:53 PM, Jason Gunthorpe wrote: > blkfront is one of the drivers I looked at, and it appears to only be > memcpying with the bvec_data pointer, so I wonder why it does not use > sg_copy_X_buffer instead.. Yes, sort of... But you'd potentially end up calling sg_copy_to_buffer

[PATCH v7 1/3] staging: typec: USB Type-C Port Manager (tcpm)

From: Guenter Roeck This driver implements the USB Type-C Power Delivery state machine for both source and sink ports. Alternate mode support is not fully implemented. The driver attaches to the USB Type-C class code implemented in the following patches. usb:

[PATCH v7 3/3] staging: typec: Fairchild FUSB302 Type-c chip driver

From: Yueyao Zhu Fairchild FUSB302 Type-C chip driver that works with Type-C Port Controller Manager to provide USB PD and USB Type-C functionalities. Signed-off-by: Yueyao Zhu Signed-off-by: Guenter Roeck --- v7: Added patch to

[PATCH v7 2/3] staging: typec: Type-C Port Controller Interface driver (tcpci)

From: Guenter Roeck The port controller interface driver interconnects the Type-C Port Manager with a Type-C Port Controller Interface (TCPCI) compliant port controller. Signed-off-by: Guenter Roeck Signed-off-by: Guenter Roeck ---

Re: [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function

On Thu, Apr 27, 2017 at 02:19:24PM -0600, Logan Gunthorpe wrote: > > > On 26/04/17 01:37 AM, Roger Pau Monné wrote: > > On Tue, Apr 25, 2017 at 12:21:02PM -0600, Logan Gunthorpe wrote: > >> Straightforward conversion to the new helper, except due to the lack > >> of error path, we have to use

Re: [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function

On 26/04/17 01:37 AM, Roger Pau Monné wrote: > On Tue, Apr 25, 2017 at 12:21:02PM -0600, Logan Gunthorpe wrote: >> Straightforward conversion to the new helper, except due to the lack >> of error path, we have to use SG_MAP_MUST_NOT_FAIL which may BUG_ON in >> certain cases in the future. >> >>

Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

On 26/04/17 01:44 AM, Christoph Hellwig wrote: > I think we'll at least need a draft of those to make sense of these > patches. Otherwise they just look very clumsy. Ok, what follows is a draft patch attempting to show where I'm thinking of going with this. Obviously it will not compile because

Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

On Thu, Apr 27, 2017 at 08:53:38AM +0200, Christoph Hellwig wrote: > > The main difficulty we > > have now is that neither of those functions are expected to fail and we > > need them to be able to in cases where the page doesn't map to system > > RAM. This patch series is trying to address it

Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

On 27/04/17 09:27 AM, Jason Gunthorpe wrote: > On Thu, Apr 27, 2017 at 08:53:38AM +0200, Christoph Hellwig wrote: > How about first switching as many call sites as possible to use > sg_copy_X_buffer instead of kmap? Yeah, I could look at doing that first. One problem is we might get more Naks

Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

On 26/04/17 09:56 PM, Herbert Xu wrote: > On Tue, Apr 25, 2017 at 12:20:54PM -0600, Logan Gunthorpe wrote: >> Very straightforward conversion to the new function in the caam driver >> and shash library. >> >> Signed-off-by: Logan Gunthorpe >> Cc: Herbert Xu

Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

On 27/04/17 12:53 AM, Christoph Hellwig wrote: > I think you'll need to follow the existing kmap semantics and never > fail the iomem version either. Otherwise you'll have a special case > that's almost never used that has a different error path. > > Again, wrong way. Suddenly making things

[PATCH] staging: android: ion: fix QUOTED_WHITESPACE_BEFORE_NEWLINE

Fix checkpatch warning: unnecessary whitespace before a quoted newline. Signed-off-by: Juan Antonio Pedreira Martos --- drivers/staging/android/ion/ion_chunk_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v1 8/8] ACPI: Use recently introduced uuid_le_cmp_p{p}() helpers

On Thu, Apr 27, 2017 at 04:09:56PM +0300, Andy Shevchenko wrote: > Lukas pointed to this: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68725 Yap, the same thing. Thanks. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG

[PATCH] staging: wlan-ng: break long line in p80211req.c

Fix a style warning for a line over 80 characters long. Signed-off-by: Ian Chard --- drivers/staging/wlan-ng/p80211req.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/p80211req.c b/drivers/staging/wlan-ng/p80211req.c index

Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

On Wed, Apr 26, 2017 at 12:11:33PM -0600, Logan Gunthorpe wrote: > Ok, well for starters I think you are mistaken about kmap being able to > fail. I'm having a hard time finding many users of that function that > bother to check for an error when calling it. A quick audit of the arch code shows

Re: [PATCH v6 1/2] usb: typec: USB Type-C Port Manager (tcpm)

On Wed, Apr 26, 2017 at 06:15:08PM -0700, Guenter Roeck wrote: > On Wed, Apr 26, 2017 at 03:26:11PM -0700, Guenter Roeck wrote: > > From: Guenter Roeck > > > > This driver implements the USB Type-C Power Delivery state machine > > for both source and sink ports. Alternate

Re: [PATCH] drivers/staging/emxx_udc: avoid > 80 character lines

On Wed, Apr 26, 2017 at 11:08:46PM -0300, Tiago Shibata wrote: > On Wed, 26 Apr 2017 22:19:59 +0200 > Greg KH wrote: > > > On Wed, Apr 26, 2017 at 01:57:14PM -0300, Tiago Koji Castro Shibata wrote: > > > Fix checkpatch.pl "WARNING: line over 80 characters" > > > > >