Re: [PATCH 3/3][v4] staging: fsl-mc: move bus driver out of staging

2017-05-19 Thread Stuart Yoder
On Fri, May 19, 2017 at 8:41 AM, Matthias Brugger wrote: > > > On 19/05/17 15:13, laurentiu.tu...@nxp.com wrote: >> >> From: Stuart Yoder >> >> Move the source files out of staging into their final locations: >>-include files in

Re: [PATCH] staging: speakup: signedness bug in spk_ttyio_in_nowait()

2017-05-19 Thread Samuel Thibault
Dan Carpenter, on sam. 20 mai 2017 00:27:18 +0300, wrote: > On most of the common arches char is signed so it can't ever == 0xff. > Let's fix this by making it a u8. > > Fixes: 6b9ad1c742bf ("staging: speakup: add send_xchar, tiocmset and input > functionality for tty") > Signed-off-by: Dan

[PATCH] staging: speakup: signedness bug in spk_ttyio_in_nowait()

2017-05-19 Thread Dan Carpenter
On most of the common arches char is signed so it can't ever == 0xff. Let's fix this by making it a u8. Fixes: 6b9ad1c742bf ("staging: speakup: add send_xchar, tiocmset and input functionality for tty") Signed-off-by: Dan Carpenter diff --git

[PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue.

2017-05-19 Thread srishti sharma
fixed a trailing */ issue . Signed-off-by: srishti sharma --- drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/bcm2835-audio/bcm2835-ctl.c

[PATCH 15/25] staging: unisys: visorbus: renamed structures in controlvmchannel.h to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed structures * spar_segment_state to visor_segment_state * efi_spar_indication to efi_visor_indication * spar_controlvm_channel_protocol to visor_controlvm_channel * spar_controlvm_parameters_header to

[PATCH 22/25] staging: unisys: include: renamed #defines in iochannel.h to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed #defines * ULTRA_VHBA_CHANNEL_PROTOCOL_SIGNATURE to VISOR_VHBA_CHANNEL_SIGNATURE * ULTRA_VNIC_CHANNEL_PROTOCOL_SIGNATURE to VISOR_VNIC_CHANNEL_SIGNATURE * ULTRA_VSWITCH_CHANNEL_PROTOCOL_SIGNATURE to

[PATCH 17/25] staging: unisys: visorinput: renamed #defines in visorinput.c to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed #defines * SPAR_KEYBOARD_CHANNEL_PROTOCOL_UUID to VISOR_KEYBOARD_CHANNEL_UUID * SPAR_KEYBOARD_CHANNEL_PROTOCOL_UUID_STR to VISOR_KEYBOARD_CHANNEL_UUID_STR * SPAR_MOUSE_CHANNEL_PROTOCOL_UUID to

[PATCH 18/25] staging: unisys: visorinput: renamed structures in ultrainputreport.h to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed structures * ultra_inputactivity to visor_inputactivity * ultra_inputreport to visor_inputreport Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner ---

[PATCH 19/25] staging: unisys: visorinput: removed enum in ultrainputreport.h to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Removed enum ultra_inputaction in ultrainputreport.h and changed elements to #defnes. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner ---

[PATCH 21/25] staging: unisys: include: renamed #defines in channel.h to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed #defines * ULTRA_CHANNEL_PROTOCOL_SIGNATURE to VISOR_CHANNEL_SIGNATURE * SPAR_CHANNEL_SERVER_READY to VISOR_CHANNEL_SERVER_READY * ULTRA_VALID_CHANNELCLI_TRANSITION

[PATCH 23/25] staging: unisys: include: renamed structure spar_io_channel_protocol in iochannel.h to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed structure spar_io_channel_protocol to visor_io_channel and changed "visor bus" to "visorbus" in a comment in visornic_main.c and visorhba_main.c. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David

[PATCH 24/25] staging: unisys: visorbus: add comment to explain polling logic in controlvm_periodic_work

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Added a comment to explain polling frequency variation logic in controlvm_periodic_logic() in visorchipset.c. Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman

[PATCH 25/25] staging: unisys: visorbus: remove channel_addr check in handle_command

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Removed a check for physaddr=0 in handle_command() function in visorchipset.c. Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner

[PATCH 20/25] staging: unisys: include: renamed function spar_check_channel in channel.h to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed function spar_check_channel() to visor_check_channel(). Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner --- drivers/staging/unisys/include/channel.h

[PATCH 01/25] staging: unisys: visorbus: rename typ to cr_type

2017-05-19 Thread David Kershner
From: Jon Frisch This patch renames enum crash_obj_type typ to cr_type. Signed-off-by: Jon Frisch Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchipset.c | 4 ++-- 1 file changed, 2

[PATCH 06/25] staging: unisys: visorbus: renamed functions like chipset_bus_* to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed functions * chipset_bus_create() to visorchipset_bus_create() * chipset_bus_destroy() to visorchipset_bus_destroy() Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman

[PATCH 07/25] staging: unisys: visorbus: renamed functions like chipset_device_* to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed functions * chipset_device_create() to visorchipset_device_create() * chipset_device_destroy() to visorchipset_device_destroy() * chipset_device_pause() to visorchipset_device_pause() * chipset_device_resume() to

[PATCH 09/25] staging: unisys: visorbus: renamed functions like my_device_* to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed functions * my_device_create() to visorbus_device_create() * my_device_changestate() to visorbus_device_changestate() * my_device_destroy() to visorbus_device_destroy() Signed-off-by: Sameer Wadgaonkar

[PATCH 12/25] staging: unisys: visorbus: renamed #define in visorchannel.c to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed SPAR_CONSOLEVIDEO_CHANNEL_PROTOCOL_GUID to VISOR_CONSOLEVIDEO_CHANNEL_GUID and renamed const spar_video_guid to visor_video_guid Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner

[PATCH 04/25] staging: unisys: visorbus: renamed functions like device_*_response to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed functions * device_create_response() to visorbus_device_create_response() * device_destroy_response() to visorbus_device_destroy_response() * device_pause_response() to visorbus_device_pause_response() * device_resume_response() to

[PATCH 14/25] staging: unisys: visorbus: renamed #defines in controlvmchannel.h to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed #defines * SPAR_CONTROLVM_CHANNEL_PROTOCOL_UUID to VISOR_CONTROLVM_CHANNEL_UUID * ULTRA_CONTROLVM_CHANNEL_PROTOCOL_SIGNATURE to VISOR_CONTROLVM_CHANNEL_SIGNATURE *

[PATCH 08/25] staging: unisys: visorbus: renamed function initiate_chipset_device_pause_resume to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed function initiate_chipset_device_pause_resume() to visorchipset_initiate_device_pause_resume(). Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman

[PATCH 11/25] staging: unisys: visorbus: renamed structures in vbuschannel.h to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed structures * ultra_vbus_deviceinfo to visor_vbus_deviceinfo * spar_vbus_headerinfo to visor_vbus_headerinfo * spar_vbus_channel_protocol to visor_vbus_channel Signed-off-by: Sameer Wadgaonkar

[PATCH 16/25] staging: unisys: visorbus: renamed enum in controlvmchannel.h to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed enum and its members * ultra_chipset_feature to visor_chipset_feature * ULTRA_CHIPSET_FEATURE_REPLY to VISOR_CHIPSET_FEATURE_REPLY * ULTRA_CHIPSET_FEATURE_PARA_HOTPLUG to VISOR_CHIPSET_FEATURE_PARA_HOTPLUG

[PATCH 10/25] staging: unisys: visorbus: renamed #defines in vbuschannel.h to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed #defines: * SPAR_VBUS_CHANNEL_PROTOCOL_UUID to VISOR_VBUS_CHANNEL_UUID * SPAR_VBUS_CHANNEL_PROTOCOL_SIGNATURE to VISOR_VBUS_CHANNEL_SIGNATURE * SPAR_VBUS_CHANNEL_PROTOCOL_VERSIONID to

[PATCH 03/25] staging: unisys: visorbus: renamed functions like bus_*_response to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed functions bus_create_response() to visorbus_create_response() and bus_destroy_response() to visorbus_destroy_response(). Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman

[PATCH 13/25] staging: unisys: visorbus: renamed #defines in visorchipset.c to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed #defines * UNISYS_SPAR_LEAF_ID to UNISYS_VISOR_LEAF_ID * UNISYS_SPAR_ID_EBX to UNISYS_VISOR_ID_EBX * UNISYS_SPAR_ID_ECX to UNISYS_VISOR_ID_ECX * UNISYS_SPAR_ID_EDX to UNISYS_VISOR_ID_EDX Signed-off-by: Sameer Wadgaonkar

[PATCH 05/25] staging: unisys: visorbus: renamed functions like *_bus_instance to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed functions * create_bus_instance() to visorbus_create_instance() * remove_bus_instance() to visorbus_remove_instance() Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman

[PATCH 02/25] staging: unisys: visorbus: renamed functions bus_create, bus_destroy and bus_configure to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed the functions bus_create() to visorbus_create(), bus_destroy() to visorbus_destroy() and bus_configure() to visorbus_configure Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman

[PATCH 00/25] staging: unisys: visorbus: Change function names to be consistent with namespace

2017-05-19 Thread David Kershner
The s-Par visorbus driver had several functions with extremely generic names. This series attempts to clean up the names by making them more unique. This series also addresses other miscellaneous feedback. Jon Frisch (1): staging: unisys: visorbus: rename typ to cr_type Sameer Wadgaonkar

Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue

2017-05-19 Thread srishti sharma
On Sat, May 20, 2017 at 1:03 AM, Dan Carpenter wrote: > On Sat, May 20, 2017 at 01:00:17AM +0530, srishti sharma wrote: >> Was the format of this patch acceptable ,the "from" matches the >> "signed-off-by" right , so this should be correct , were there any >> errors in

Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue

2017-05-19 Thread Dan Carpenter
On Sat, May 20, 2017 at 01:00:17AM +0530, srishti sharma wrote: > Was the format of this patch acceptable ,the "from" matches the > "signed-off-by" right , so this should be correct , were there any > errors in this ? Should I resend it ? > > Regards, > Srishti > You should capitalize your name

Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue

2017-05-19 Thread srishti sharma
Was the format of this patch acceptable ,the "from" matches the "signed-off-by" right , so this should be correct , were there any errors in this ? Should I resend it ? Regards, Srishti On Thu, May 18, 2017 at 7:28 PM, Greg KH wrote: > On Thu, May 18, 2017 at

Re: [PATCH] staging: vme: Use BIT macro for bit definitions

2017-05-19 Thread Martyn Welch
On Mon, May 15, 2017 at 10:18:14AM +0100, Ricardo Silva wrote: > Use the BIT(n) macro instead of '(1 << n)' in definitions where the bit > semantics clearly applies. > > Fixes true positive "Prefer using the BIT macro" checks reported by > checkpatch. > > Some of these checks are still

Re: [PATCH 4/4] Hyper-V vPCI: use vPCI protocol version 1.2

2017-05-19 Thread Stephen Hemminger
On Fri, 19 May 2017 14:27:01 +0300 Dan Carpenter wrote: > > /* > > + * HV_VP_SET available > > + */ > > +#define HV_X64_EX_PROCESSOR_MASKS_RECOMMENDED (1 << 11) > > Use BIT(11). I thought checkpatch.pl complains about this but I guess > that's only with the

[PATCH v3 07/10] hyper-v: globalize vp_index

2017-05-19 Thread Vitaly Kuznetsov
To support implementing remote TLB flushing on Hyper-V with a hypercall we need to make vp_index available outside of vmbus module. Rename and globalize. Signed-off-by: Vitaly Kuznetsov Acked-by: K. Y. Srinivasan Tested-by: Simon Xiao

[PATCH v3 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others()

2017-05-19 Thread Vitaly Kuznetsov
Add Hyper-V tracing subsystem and trace hyperv_mmu_flush_tlb_others(). Tracing is done the same way we do xen_mmu_flush_tlb_others(). Signed-off-by: Vitaly Kuznetsov Acked-by: K. Y. Srinivasan Tested-by: Simon Xiao Tested-by:

[PATCH v3 09/10] x86/hyper-v: support extended CPU ranges for TLB flush hypercalls

2017-05-19 Thread Vitaly Kuznetsov
Hyper-V hosts may support more than 64 vCPUs, we need to use HVCALL_FLUSH_VIRTUAL_ADDRESS_SPACE_EX/LIST_EX hypercalls in this case. Signed-off-by: Vitaly Kuznetsov Acked-by: K. Y. Srinivasan Tested-by: Simon Xiao Tested-by:

[PATCH v3 05/10] hyper-v: use fast hypercall for HVCALL_SIGNAL_EVENT

2017-05-19 Thread Vitaly Kuznetsov
We need to pass only 8 bytes of input for HvSignalEvent which makes it a perfect fit for fast hypercall. hv_input_signal_event_buffer is not needed any more and hv_input_signal_event is converted to union for convenience. Signed-off-by: Vitaly Kuznetsov Acked-by: K. Y.

[PATCH v3 08/10] x86/hyper-v: use hypercall for remote TLB flush

2017-05-19 Thread Vitaly Kuznetsov
Hyper-V host can suggest us to use hypercall for doing remote TLB flush, this is supposed to work faster than IPIs. Implementation details: to do HvFlushVirtualAddress{Space,List} hypercalls we need to put the input somewhere in memory and we don't really want to have memory allocation on each

[PATCH v3 06/10] x86/hyper-v: implement rep hypercalls

2017-05-19 Thread Vitaly Kuznetsov
Rep hypercalls are normal hypercalls which perform multiple actions at once. Hyper-V guarantees to return exectution to the caller in not more than 50us and the caller needs to use hypercall continuation. Touch NMI watchdog between hypercall invocations. This is going to be used for

[PATCH v3 04/10] x86/hyper-v: fast hypercall implementation

2017-05-19 Thread Vitaly Kuznetsov
Hyper-V supports 'fast' hypercalls when all parameters are passed through registers. Implement an inline version of a simpliest of these calls: hypercall with one 8-byte input and no output. Proper hypercall input interface (struct hv_hypercall_input) definition is added as well. Signed-off-by:

[PATCH v3 03/10] x86/hyper-v: make hv_do_hypercall() inline

2017-05-19 Thread Vitaly Kuznetsov
We have only three call sites for hv_do_hypercall() and we're going to change HVCALL_SIGNAL_EVENT to doing fast hypercall so we can inline this function for optimization. Hyper-V top level functional specification states that r9-r11 registers and flags may be clobbered by the hypervisor during

[PATCH v3 01/10] x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set

2017-05-19 Thread Vitaly Kuznetsov
Code is arch/x86/hyperv/ is only needed when CONFIG_HYPERV is set, the 'basic' support and detection lives in arch/x86/kernel/cpu/mshyperv.c which is included when CONFIG_HYPERVISOR_GUEST is set. Signed-off-by: Vitaly Kuznetsov Acked-by: K. Y. Srinivasan

[PATCH v3 00/10] Hyper-V: praravirtualized remote TLB flushing and hypercall improvements

2017-05-19 Thread Vitaly Kuznetsov
Changes since v2: - Rebased to the latest char-misc-next tree. - Added Acked-By and Tested-By tags. Original descriptions: Hyper-V supports hypercalls for doing local and remote TLB flushing and gives its guests hints when using hypercall is preferred. While doing hypercalls for local TLB

[PATCH v3 02/10] x86/hyper-v: stash the max number of virtual/logical processor

2017-05-19 Thread Vitaly Kuznetsov
Max virtual processor will be needed for 'extended' hypercalls supporting more than 64 vCPUs. While on it, unify on 'Hyper-V' in mshyperv.c as we currently have a mix, report acquired misc features as well. Signed-off-by: Vitaly Kuznetsov Acked-by: K. Y. Srinivasan

RE: [PATCH 4/4] Hyper-V vPCI: use vPCI protocol version 1.2

2017-05-19 Thread KY Srinivasan
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Friday, May 19, 2017 3:03 AM > To: Jork Loeser ; KY Srinivasan > > Cc: Stephen Hemminger ; Greg Kroah- > Hartman

Re: [PATCH 3/3][v4] staging: fsl-mc: move bus driver out of staging

2017-05-19 Thread Matthias Brugger
On 19/05/17 15:13, laurentiu.tu...@nxp.com wrote: From: Stuart Yoder Move the source files out of staging into their final locations: -include files in drivers/staging/fsl-mc/include go to include/linux/fsl -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip

[PATCH 0/3][v4] staging: fsl-mc: move bus driver out of staging

2017-05-19 Thread laurentiu.tudor
From: Laurentiu Tudor Now that there is a functional ethernet driver probed on the mc bus this patch series requests that the fsl-mc bus driver be moved out of staging. The proposed destination for the bus driver is drivers/bus. Proposed location for global header files

[PATCH 3/3][v4] staging: fsl-mc: move bus driver out of staging

2017-05-19 Thread laurentiu.tudor
From: Stuart Yoder Move the source files out of staging into their final locations: -include files in drivers/staging/fsl-mc/include go to include/linux/fsl -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip -source in drivers/staging/fsl-mc/bus goes to

[PATCH 2/3] staging: fsl-mc: add binding path to MAINTAINERS

2017-05-19 Thread laurentiu.tudor
From: Laurentiu Tudor Signed-off-by: Laurentiu Tudor --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f7d568b..50b3c36 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10542,6 +10542,7 @@ M:

[PATCH 1/3] staging: fsl-mc: fix several checkpath.pl warnings

2017-05-19 Thread laurentiu.tudor
From: Laurentiu Tudor Remove several unneeded #includes, forward declarations and fix several issues reported by checkpatch.pl --strict, such as: - kfree(NULL) is safe and check is not required - macro argument reuse may cause possible side effects - enclose macro

[PATCH v2 1/6] [media] atomisp: disable several warnings when W=1

2017-05-19 Thread Mauro Carvalho Chehab
The atomisp currently produce hundreds of warnings when W=1. It is a known fact that this driver is currently in bad shape, and there are lot of things to be done here. We don't want to be bothered by those "minor" stuff for now, while the driver doesn't receive a major cleanup. So, disable

Re: [PATCH 4/4] Hyper-V vPCI: use vPCI protocol version 1.2

2017-05-19 Thread Dan Carpenter
Minor nits only. On Thu, May 18, 2017 at 12:14:30PM -0700, Jork Loeser wrote: > From: Jork Loeser > > Update the Hyper-V vPCI driver to use the Server-2016 version > of the vPCI protocol, fixing MSI creation and retargeting issues. > > Signed-off-by: Jork Loeser

Re: [PATCH 3/4] Hyper-V vPCI: Add vPCI version protocol negotiation

2017-05-19 Thread Dan Carpenter
On Thu, May 18, 2017 at 12:14:29PM -0700, Jork Loeser wrote: > static int hv_pci_protocol_negotiation(struct hv_device *hdev) > { > + size_t i; Could you just use "int i". I know some static checkers complain but those tools are dumb. I just fixed a couple bugs two days ago where people

Re: [PATCH 00/13] staging: media: atomisp queued up patches

2017-05-19 Thread Mauro Carvalho Chehab
Em Thu, 18 May 2017 17:40:27 +0100 Alan Cox escreveu: > On Thu, 2017-05-18 at 11:10 -0300, Mauro Carvalho Chehab wrote: > > Em Thu, 18 May 2017 15:50:09 +0200 > > Greg Kroah-Hartman escreveu: > > > > > > > > Hi Mauro, > > > > > > Here's the

[PATCH] [media] atomisp: disable several warnings when W=1

2017-05-19 Thread Mauro Carvalho Chehab
The atomisp currently produce hundreds of warnings when W=1. It is a known fact that this driver is currently in bad shape, and there are lot of things to be done here. We don't want to be bothered by those "minor" stuff for now, while the driver doesn't receive a major cleanup. So, disable

Re: [PATCH 4/4] Hyper-V vPCI: use vPCI protocol version 1.2

2017-05-19 Thread Vitaly Kuznetsov
Jork Loeser writes: >> -Original Message- >> From: Stephen Hemminger [mailto:step...@networkplumber.org] >> Sent: Thursday, May 18, 2017 16:59 >> >> > From: Jork Loeser >> > >> > Update the Hyper-V vPCI driver to use the Server-2016

Re: [PATCH 4/4] Hyper-V vPCI: use vPCI protocol version 1.2

2017-05-19 Thread Vitaly Kuznetsov
Jork Loeser writes: > From: Jork Loeser > > Update the Hyper-V vPCI driver to use the Server-2016 version > of the vPCI protocol, fixing MSI creation and retargeting issues. > > Signed-off-by: Jork Loeser > --- >

[PATCH v3] staging: iio: light: Replace symbolic permissions as per coding style

2017-05-19 Thread surenderpolsani
From: Surender Polsani Fixed the following checkpatch.pl warnings: octal permissions are more preferable than symbolic permissions Replaced DEVICE_ATTR family macros with DEVICE_ATTR_RW family as suggested by Greg K-H. Changed attributes and function names where ever

Re: [PATCH v2] staging: iio: light: Replace symbolic permissions as per coding style

2017-05-19 Thread Greg KH
On Fri, May 19, 2017 at 01:42:55PM +0530, surenderpols...@gmail.com wrote: > -static DEVICE_ATTR(power_state, S_IRUGO | S_IWUSR, > - tsl2x7x_power_state_show, tsl2x7x_power_state_store); > +static DEVICE_ATTR_RW(tsl2x7x_power_state); You do realize you just renamed the sysfs file,

[PATCH v2] staging: iio: light: Replace symbolic permissions as per coding style

2017-05-19 Thread surenderpolsani
From: Surender Polsani Fixed the following checkpatch.pl warnings: octal permissions are more preferable than symbolic permissions Replaced DEVICE_ATTR family macros with DEVICE_ATTR_RW family as suggested by Greg K-H. Changed attributes and function names where ever

[PATCH] staging: ccree: add CRYPTO dependency

2017-05-19 Thread Arnd Bergmann
A rare randconfig build error shows up when we have CONFIG_CRYPTO=m in combination with a built-in CCREE driver: crypto/hmac.o: In function `hmac_update': hmac.c:(.text.hmac_update+0x28): undefined reference to `crypto_shash_update' crypto/hmac.o: In function `hmac_setkey':

Re: [PATCH v2] staging: iio: light: Replace symbolic permissions as per coding style

2017-05-19 Thread suri
On Friday 19 May 2017 12:45 PM, Greg KH wrote: On Fri, May 19, 2017 at 12:33:11PM +0530, surenderpols...@gmail.com wrote: From: Surender Polsani Fixed the following checkpatch.pl warnings: octal permissions are more preferable than symbolic permissions Replaced

Re: [PATCH v2] staging: iio: light: Replace symbolic permissions as per coding style

2017-05-19 Thread Greg KH
On Fri, May 19, 2017 at 12:33:11PM +0530, surenderpols...@gmail.com wrote: > From: Surender Polsani > > Fixed the following checkpatch.pl warnings: > octal permissions are more preferable than symbolic permissions > > Replaced DEVICE_ATTR family macros with

[PATCH v2] staging: iio: light: Replace symbolic permissions as per coding style

2017-05-19 Thread surenderpolsani
From: Surender Polsani Fixed the following checkpatch.pl warnings: octal permissions are more preferable than symbolic permissions Replaced DEVICE_ATTR family macros with DEVICE_ATTR_RW family as suggested by Greg K-H. Changed attributes and function names where ever

Re: [greybus-dev] [PATCH] staging: greybus: mark PM functions as __maybe_unused

2017-05-19 Thread Arnd Bergmann
On Fri, May 19, 2017 at 5:40 AM, Viresh Kumar wrote: > On 18-05-17, 16:51, Arnd Bergmann wrote: >> I find that a lot of users get the #ifdef wrong, either using the wrong >> macro (CONFIG_PM vs CONFIG_PM_SLEEP) or not using the right >> set of functions (e.g. calling a