[PATCH] staging: lustre: Replace printk_ratelimited with pr_warn_ratelimited

2017-05-25 Thread Konrad Malkowski
This patch fixes the checkpoint.pl warning: WARNING: Prefer printk_ratelimited or pr__ratelimited to printk_ratelimit Signed-off-by: Konrad Malkowski --- drivers/staging/lustre/lnet/libcfs/tracefile.c | 12 +--- 1 file changed, 5 insertions(+), 7

Re: [PATCH] staging: iio: light: Replace snprintf calls with scnprintf

2017-05-25 Thread harinath Nampally
Greg, Sure, I will fix it and resend a fresh patch. Thanks, Hari ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 06/16] staging: vchiq_2835_arm: Fix function name cleaup_pagelistinfo

2017-05-25 Thread Stefan Wahren
Assuming the intension of the function is to clean up, so fix the function name accordingly. Signed-off-by: Stefan Wahren --- .../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v2 12/16] staging: vchiq_core: Bail out if service is NULL

2017-05-25 Thread Stefan Wahren
In the unlikely case that service is NULL we should bail out instead of calling BUG_ON(). The other BUG_ON calls will be fixed in separate patches. Signed-off-by: Stefan Wahren --- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 38 ++ 1 file

[PATCH v2 08/16] staging: vchiq_2835_arm: Use PAGE_MASK macro

2017-05-25 Thread Stefan Wahren
Use the PAGE_MASK instead of open code it. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 10/16] staging: vchiq_core: Bailout if VCHIQ state is already initialized

2017-05-25 Thread Stefan Wahren
In case VCHIQ state is already initialized we need to bailout in order to aovid a memory leak. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH v2 05/16] staging: vchiq_arm: Avoid multiline dereference

2017-05-25 Thread Stefan Wahren
Reduce the indentation within vchiq_dump_service_use_state in order to avoid a multiline derefernce. Signed-off-by: Stefan Wahren --- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c| 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

[PATCH v2 01/16] staging: vchiq_core: Use return value of mutex_lock_killable directly

2017-05-25 Thread Stefan Wahren
Instead of saving the return value of mutex_lock_killable in a local variable we could use the value directly. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[PATCH v2 15/16] staging: vchiq_core: Bail out in case of invalid tx_pos

2017-05-25 Thread Stefan Wahren
Properly handle the error case in case of an invalid tx_pos. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH v2 16/16] staging: vchiq_core: Replace remaining BUG_ON with WARN_ON

2017-05-25 Thread Stefan Wahren
This replaces all remaining BUG_ON with WARN_ON. So in case of a VCHIQ bug the system is still usable. Signed-off-by: Stefan Wahren --- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff

[PATCH v2 03/16] staging: vchiq_2835_arm: Remove unnecessary assignment to slot_mem_size

2017-05-25 Thread Stefan Wahren
The variable slot_mem_size is assigned a value which is never used. This issue has been found by CppCheck. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v2 11/16] staging: vchiq_core: Don't BUG if sending RESUME fails

2017-05-25 Thread Stefan Wahren
VCHIQ suspend and resume isn't implemented, but even it was there is no need to call BUG(). Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v2 00/16] staging: vchiq_arm: several cleanups

2017-05-25 Thread Stefan Wahren
This patch series addresses mostly minor issues. It's based on top of the latest vchiq bugfix [1]. [1] - https://lkml.org/lkml/2017/5/4/228 Changes in v2: * fix the signed-off-by in patches 8 and 9 Stefan Wahren (16): staging: vchiq_core: Use return value of mutex_lock_killable directly

[PATCH v2 14/16] staging: vchiq_core: Don't BUG if process is unexpected

2017-05-25 Thread Stefan Wahren
Bail out properly if the process index doesn't match the remote insert. We also drop the BUG in case the process index is at local insert, so we can trigger the WARN_ON again some steps later. Signed-off-by: Stefan Wahren ---

[PATCH v2 09/16] staging: vchiq_core: Simplify VCHIQ init

2017-05-25 Thread Stefan Wahren
Since the ARM side of VCHIQ support only 1 state, we could simplify the init code. This makes it possible to avoid BUG_ON and a theoretical overflow of id. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 5 + 1 file

[PATCH v2 07/16] staging: vchiq_2835_arm: Handle vmalloc_to_page error case

2017-05-25 Thread Stefan Wahren
In case vmalloc_to_page returns NULL create_pagelist must abort imediatly. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH v2 13/16] staging: vchiq_core: Bail out if ref_count is unexpected

2017-05-25 Thread Stefan Wahren
If the ref counter of service has an unexpected value then we better bail out. Signed-off-by: Stefan Wahren --- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git

[PATCH v2 04/16] staging: vchiq_arm: Fix variable names in comment

2017-05-25 Thread Stefan Wahren
This comment was apparently forgotten in the correction of CamelCase. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 02/16] staging: vchiq_2835_arm: Reduce scope of i in free_pagelist

2017-05-25 Thread Stefan Wahren
We can reduce the scope of the counting variable i. This has been found by CppCheck. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 09/16] staging: vchiq_core: Simplify VCHIQ init

2017-05-25 Thread Stefan Wahren
> Greg Kroah-Hartman hat am 25. Mai 2017 um 18:35 > geschrieben: > > > On Sat, May 20, 2017 at 11:30:33PM +0200, Stefan Wahren wrote: > > > > > Stefan Wahren hat am 20. Mai 2017 um 14:22 > > > geschrieben: > > > > > > > > > Since the

Re: [PATCH] staging: fbtft: fix character limit, trailing ; warning, etc.

2017-05-25 Thread Eric Curtin
On 28 April 2017 at 11:07, Greg KH wrote: > On Sun, Apr 23, 2017 at 03:21:31PM +0100, Eric Curtin wrote: >> checkpatch spits out a warning about the 80 character line limit. Split >> the parameters of these functions onto different lines. Put the ; with >> the macro

Re: [PATCH] [media] atomisp: disable several warnings when W=1

2017-05-25 Thread Arnd Bergmann
On Thu, May 25, 2017 at 7:03 PM, kbuild test robot wrote: >>> cc1: warning: unrecognized command line option >>> "-Wno-suggest-attribute=format" >>> cc1: warning: unrecognized command line option >>> "-Wno-unused-but-set-variable" >>> cc1: warning: unrecognized command line

Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue.

2017-05-25 Thread srishti sharma
On Thu, May 25, 2017 at 10:27 PM, Greg KH wrote: > On Sat, May 20, 2017 at 02:00:24AM +0530, srishti sharma wrote: >> fixed a trailing */ issue . >> >> Signed-off-by: srishti sharma >> --- >> drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++--

[PATCH] staging: rtl8192u: swap comparison to constant

2017-05-25 Thread Szilveszter Székely
Comparisons should place the constant on the right side of the test This patch fixes coding style issues as reported by checkpatch. Signed-off-by: Szilveszter Székely --- drivers/staging/rtl8192u/r8192U_core.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH 2/2] staging: wilc1000: add missing blank line after struct declaration

2017-05-25 Thread Marko Stankovic
Fix a missing blank line issue reported by checkpatch.pl Signed-off-by: Marko Stankovic --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c

[PATCH 1/2] staging: wilc1000: remove excessive blank lines

2017-05-25 Thread Marko Stankovic
Fix the multiple blank lines issue reported by checkpatch.pl Signed-off-by: Marko Stankovic --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c

[no subject]

2017-05-25 Thread Marko Stankovic
Subject: [PATCH 2/2] staging: wilc1000: add missing blank line after struct declaration Fix a missing blank line issue reported by checkpatch.pl Signed-off-by: Marko Stankovic --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 + 1 file changed, 1 insertion(+)

[no subject]

2017-05-25 Thread Marko Stankovic
Date: Thu, 25 May 2017 18:44:25 +0200 Subject: [PATCH 1/2] staging: wilc1000: remove excessive blank lines Fix the multiple blank lines issue reported by checkpatch.pl Signed-off-by: Marko Stankovic --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 15

Re: [PATCH] [media] atomisp: disable several warnings when W=1

2017-05-25 Thread kbuild test robot
Hi Mauro, [auto build test WARNING on linuxtv-media/master] [also build test WARNING on next-20170525] [cannot apply to v4.12-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho

Re: [PATCH 2/5][v2] staging: fsl-mc: add binding path to MAINTAINERS

2017-05-25 Thread Greg KH
On Mon, May 22, 2017 at 03:09:32PM +0300, laurentiu.tu...@nxp.com wrote: > From: Laurentiu Tudor > > Signed-off-by: Laurentiu Tudor > --- > > Notes: > -v2 > -no changes then why is it "v2"?

Re: [PATCH 2/5][v2] staging: fsl-mc: add binding path to MAINTAINERS

2017-05-25 Thread Greg KH
On Mon, May 22, 2017 at 03:09:32PM +0300, laurentiu.tu...@nxp.com wrote: > From: Laurentiu Tudor > > Signed-off-by: Laurentiu Tudor I don't take patches without any changelog text :( ___ devel mailing

Re: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings

2017-05-25 Thread Greg KH
On Mon, May 22, 2017 at 03:09:31PM +0300, laurentiu.tu...@nxp.com wrote: > From: Laurentiu Tudor Your subject line is very odd, please use the 'v2' marking properly... > > Remove several unneeded #includes, forward > declarations and fix several issues reported > by

Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue.

2017-05-25 Thread Greg KH
On Sat, May 20, 2017 at 02:00:24AM +0530, srishti sharma wrote: > fixed a trailing */ issue . > > Signed-off-by: srishti sharma > --- > drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This file isn't in my tree,

Re: [PATCH] staging-next: wlan-ng: resolve checkpatch issues

2017-05-25 Thread Greg KH
On Sun, May 21, 2017 at 01:03:55AM +0530, Ranjit W wrote: > fixing following checkpatch warning wherever possible: > WARNING: line over 80 characters > > Signed-off-by: Ranjit W > --- > drivers/staging/wlan-ng/cfg80211.c | 11 --- >

Re: [PATCH 6/6] Staging: rtl8712: ieee80211: fixed camelcase coding style issue

2017-05-25 Thread Greg KH
On Sat, May 20, 2017 at 11:35:04PM +0530, Jaya Durga wrote: > Fixed coding style issue > > Renamed cap_Privacy to cap_privacy > > Signed-off-by: Jaya Durga > --- > drivers/staging/rtl8712/ieee80211.c | 2 +- > drivers/staging/rtl8712/wifi.h | 2 +- > 2 files changed, 2

Re: [PATCH 5/5] Staging: rtl8712: ieee80211: fixed camelcase coding style issue

2017-05-25 Thread Greg KH
On Sat, May 20, 2017 at 11:26:17PM +0530, Jaya Durga wrote: > Fixed coding style issue > > Renamed cap_ShortPremble to cap_short_premble > > Signed-off-by: Jaya Durga Where are patches 1-4 of this patch series? Please fix up and resend. thanks, greg k-h

Re: [PATCH 09/16] staging: vchiq_core: Simplify VCHIQ init

2017-05-25 Thread Greg Kroah-Hartman
On Sat, May 20, 2017 at 11:30:33PM +0200, Stefan Wahren wrote: > > > Stefan Wahren hat am 20. Mai 2017 um 14:22 > > geschrieben: > > > > > > Since the ARM side of VCHIQ support only 1 state, we could simplify > > the init code. This makes it possible to avoid BUG_ON

Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-05-25 Thread Stephen Hemminger
On Thu, 25 May 2017 14:19:55 +0100 Alan Cox wrote: > > > Signed-off-by: Haiyang Zhang > > > --- > > > > According to Stephen Hemminger , there are > > additional programs, like X.org, DPDK, are also using 16-bit

Re: [PATCH] staging: fix macros with multiple statements in rtl8723bs/core/rtw_security.c

2017-05-25 Thread Jamie Huang
On Thu, 25 May 2017 09:15:33 +1000 "Tobin C. Harding" wrote: > On Wed, May 24, 2017 at 10:38:57PM +0800, Jamie Huang wrote: > > Comment on your patch subject line. Patches to staging typically > include the driver in the subject. You can view previous commits to > get an idea

[PATCH v3] dgnc: fix multiple blank lines coding style problem

2017-05-25 Thread Aliza Minkov
According to the coding-style documentation, functions in source files should be separated with one blank line. Redundant blank lines were removed from this source file, in accordance with coding-style documentation. Signed-off-by: Aliza Minkov ---

Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-05-25 Thread Alan Cox
> > Signed-off-by: Haiyang Zhang > > --- > > According to Stephen Hemminger , there are > additional programs, like X.org, DPDK, are also using 16-bit only > PCI domain numbers. So, I'm submitting this patch for re-consideration. The correct way

RE: [PATCH 1/2] staging: fsl-dpaa2/eth: Fix address translations

2017-05-25 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: Laurentiu Tudor > Sent: Wednesday, May 24, 2017 3:34 PM > To: Ruxandra Ioana Radulescu ; > gre...@linuxfoundation.org > Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; > ag...@suse.de; a...@arndb.de;

Re: [PATCH] fix multiple blank lines coding style problem

2017-05-25 Thread Greg KH
On Thu, May 25, 2017 at 02:33:31PM +0300, Aliza Minkov wrote: > According to the coding-style documentation, functions in source files > should be separated with one blank line. Redundant blank lines were > removed from this source file, in accordance with coding-style > documentation. > >

[PATCH] fix multiple blank lines coding style problem

2017-05-25 Thread Aliza Minkov
According to the coding-style documentation, functions in source files should be separated with one blank line. Redundant blank lines were removed from this source file, in accordance with coding-style documentation. Signed-off-by: Aliza Minkov ---

Re: [PATCH] fix multiple blank lines coding style problem

2017-05-25 Thread Tobin C. Harding
On Thu, May 25, 2017 at 12:22:15PM +0300, Aliza Minkov wrote: > Signed-off-by: Aliza Minkov > --- > drivers/staging/dgnc/dgnc_driver.c | 2 -- > 1 file changed, 2 deletions(-) Hi Aliza, Well done getting your patch together. I think you might get an automated message from

[PATCH] fix multiple blank lines coding style problem

2017-05-25 Thread Aliza Minkov
Signed-off-by: Aliza Minkov --- drivers/staging/dgnc/dgnc_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c index 253f38b..c1b6079 100644 --- a/drivers/staging/dgnc/dgnc_driver.c +++

Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-05-25 Thread Christoph Hellwig
On Wed, May 24, 2017 at 01:39:15PM -0700, Haiyang Zhang wrote: > From: Haiyang Zhang > > This patch uses the lower 16 bits of the serial number as PCI > domain, otherwise some drivers may not be able to handle it. > > Besides Nvidia drivers, we also found X.org, and DPDK

[PATCH] platform: video-mux: fix ptr_ret.cocci warnings

2017-05-25 Thread kbuild test robot
drivers/media/platform/video-mux.c:246:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci CC: Philipp Zabel Signed-off-by: Fengguang Wu ---

Re: [PATCH v7 18/34] platform: video-mux: include temporary mmio-mux support

2017-05-25 Thread kbuild test robot
Hi Philipp, [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.12-rc2 next-20170525] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Steve-Longerbeam/i-MX-Media

[PATCH] staging : sm750fb : Replace CamelCase variable names and hungarian prefx

2017-05-25 Thread Richa Jha
Replace CamelCase variable names with underscores and remove hungarian prefixes to comply with the standard kernel coding style Signed-off-by: Richa Jha --- drivers/staging/sm750fb/ddk750_chip.c | 59 ++- drivers/staging/sm750fb/ddk750_chip.h |

Re: drivers/staging/ks7010 hardware test

2017-05-25 Thread Wolfram Sang
Hi Tobin, > I began testing the card you sent today. I'm getting a firmware load > error like you mentioned. Nice. Firstly, that means the card is alive and survived the mailing. > I checked out code from when you originally merged into staging, > however I built the module in a 4.9 kernel. I

Re: [PATCH] Staging: bcm2835-audio: bcm2835-ctl.c: Fixed a comment coding style issue.

2017-05-25 Thread Stefan Wahren
> "Tobin C. Harding" hat am 25. Mai 2017 um 01:28 geschrieben: > > > On Wed, May 24, 2017 at 08:03:14PM +0530, srishti sharma wrote: > > This driver is not in Greg KH's staging tree. The driver has moved to drivers/staging/vc04_services/bcm2835-audio > You may like to work

Re: [PATCH] staging: iio: light: Replace snprintf calls with scnprintf

2017-05-25 Thread Greg KH
On Wed, May 24, 2017 at 07:22:11PM -0400, Harinath Nampally wrote: > This patch fixes the miscoded use of return value of snprintf > by using the scnprintf function which returns the length of actual > string created in the buffer. > > Signed-off-by: Harinath Nampally >