Re: [PATCH 1/1] drivers/staging/pi433: New driver

2017-07-16 Thread kbuild test robot
-staging-pi433-New-driver/20170716-181617 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) include/linux/compiler.h:260:8: sparse: attribute 'no_sanitize_address': u

[PATCH 4/4] staging: lustre: obdclass: constify attribute_group structures.

2017-07-16 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +- 1 file changed

[PATCH 2/4] staging: lustre: ldlm: constify attribute_group structures.

2017-07-16 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 2 +- 1 file changed, 1 inse

[PATCH 3/4] staging: lustre: obdclass: linux: constify attribute_group structures.

2017-07-16 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 2 +- 1 file cha

[PATCH 1/4] staging: lustre: constify attribute_group structures.

2017-07-16 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. File size before: textdata bss dec hex filename 9489 992 40 105212919 lustr

[PATCH 0/4] constify lustre attribute_group structures

2017-07-16 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Arvind Yadav (4): [PATCH 1/4] staging: lustre: constify attribute_group structures. [PATCH 2/4] staging: lus

[PATCH v2] [media] staging/atomisp: fixed trivial coding style issue

2017-07-16 Thread Shy More
Below was the trival error flagged by checkpatch.pl: ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Shy More --- changes in v2: - made the suggested corrections --- .../atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c | 3 +-- 1 file changed, 1 insertio

[PATCH] staging: gs_fpgaboot: add buffer overflow checks

2017-07-16 Thread Jacob von Chorus
Four fields in struct fpgaimage are char arrays of length MAX_STR (256). The amount of data read into these buffers is controlled by a length field in the bitstream file read from userspace. If a corrupt or malicious firmware file was supplied, kernel data beyond these buffers can be overwritten ar

Re: [PATCH 2/2] [media] staging/atomisp: fixed trivial coding style issue

2017-07-16 Thread Joe Perches
On Sun, 2017-07-16 at 16:38 -0700, Shy More wrote: > Below was the trival error flagged by checkpatch.pl: > ERROR: space prohibited after that open parenthesis '(' [] > diff --git > a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c > > b/drivers/staging/media

[PATCH 2/2] [media] staging/atomisp: fixed trivial coding style issue

2017-07-16 Thread Shy More
Below was the trival error flagged by checkpatch.pl: ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Shy More --- .../atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/me

[PATCH 1/2] [media] staging/atomisp: fixed trivial coding style warning

2017-07-16 Thread Shy More
Below was the trivial wanrning flagged by checkpatch.pl WARNING: Block comments use * on subsequent lines Signed-off-by: Shy More --- .../css2400/runtime/isys/src/ibuf_ctrl_rmgr.c | 24 +++--- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/m

[PATCH] Staging:vc04_services:vchiq_util.c: kzalloc call changed to kcalloc

2017-07-16 Thread AndyS
From: Andrey Severin kzalloc call was changed to kcalloc by checkpatch.pl recommendation --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c b/drive

[staging:staging-testing 83/83] drivers/staging//pi433/pi433_if.c:645:1: warning: the frame size of 1036 bytes is larger than 1024 bytes

2017-07-16 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 874bcba65f9a3a2a304b5f520529c046887c3cdc commit: 874bcba65f9a3a2a304b5f520529c046887c3cdc [83/83] staging: pi433: New driver config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc

[patch 2/2] staging: speakup: safely register and unregister ldisc

2017-07-16 Thread Okash Khawaja
This patch makes use of functions added in the previous patch. It registers ldisc during init of main speakup module and unregisters it during exit. It also removes the code to register ldisc every time a synth module is loaded. This way we only register the ldisc once when main speakup module is l

[patch 1/2] staging: speakup: add functions to register and unregister ldisc

2017-07-16 Thread Okash Khawaja
This patch adds the above two functions and makes them available to main.c where they will be called during init and exit functions of main speakup module. Following patch will make use of them. Signed-off-by: Okash Khawaja --- drivers/staging/speakup/spk_priv.h |2 ++ drivers/staging/spea

[patch 0/2] staging: speakup: safely unregister ldisc

2017-07-16 Thread Okash Khawaja
Hi, These patches make sure that N_SPEAKUP is correctly unregistered when all speakup related modules are unloaded, making sure the refcount correctly represents the number of users. Patch 1: simply adds functions to register and unregister ldisc, without changing existing behaviour Patch

Re: [PATCH 1/1] drivers/staging/pi433: New driver

2017-07-16 Thread Greg KH
On Sun, Jul 16, 2017 at 03:53:57PM +0200, Marcus Wolf wrote: > Hi Greg, > > like I wrote before - unfortunally I couldn't find a git command, squashing > all my commits into one single patch. Therfore I copy and pasted the patch > manually. git diff FIRST_PATCH..HEAD > my.patch will do it. > N

Re: [PATCH 1/1] drivers/staging/pi433: New driver

2017-07-16 Thread Marcus Wolf
Hi Greg, like I wrote before - unfortunally I couldn't find a git command, squashing all my commits into one single patch. Therfore I copy and pasted the patch manually. Never the less, the first three rows were copied from a patch, originally generated by git. I used git format-patch master

Re: [PATCH 00/10] Fix alignment issues in staging/ccree

2017-07-16 Thread Greg KH
On Sun, Jul 16, 2017 at 12:33:16PM +0200, Simon Sandström wrote: > Hi > > On Tue, Jul 11, 2017 at 07:00:33PM +0200, Greg KH wrote: > > Not all of these applied, some did, if you could rebase the remaining > > against my staging-testing branch at the moment, and resend, that would > > be great. >

Re: [PATCH 00/10] Fix alignment issues in staging/ccree

2017-07-16 Thread Simon Sandström
Hi On Tue, Jul 11, 2017 at 07:00:33PM +0200, Greg KH wrote: > Not all of these applied, some did, if you could rebase the remaining > against my staging-testing branch at the moment, and resend, that would > be great. I'm not sure about the preferred procedure. Is it OK to send the rebased patche

Re: [PATCH 1/1] drivers/staging/pi433: New driver

2017-07-16 Thread Greg KH
On Sun, Jul 16, 2017 at 11:52:32AM +0200, Wolf Entwicklungen wrote: > From: Marcus Wolf > Date: Tue,16 Jul 2017 11:52:06 +0100 > Subject: [PATCH 1/1] drivers/staging/pi433: New driver Why is this all here in the patch body? Usually git will strip this out, but in the future, please don't put it

[PATCH 1/1] drivers/staging/pi433: New driver

2017-07-16 Thread Wolf Entwicklungen
From: Marcus Wolf Date: Tue,16 Jul 2017 11:52:06 +0100 Subject: [PATCH 1/1] drivers/staging/pi433: New driver Added a driver for the pi433 radio module (see https://www.pi433.de/en.html for details). Signed-off-by: Marcus Wolf --- diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig i

[PATCH] Staging: rtl8192u: Use __func__ instead of function name.

2017-07-16 Thread Shreeya Patel
Current function name is accessed using __func__. Use '%s and __func__' instead of a function name. Problem found by checkpatch. Signed-off-by: Shreeya Patel --- drivers/staging/rtl8192u/r8192U_core.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/

[patch v2 0/1] staging: speakup: safely close tty

2017-07-16 Thread Okash Khawaja
Hi, Let's deal with the ldisc refcount problem separately. Purpose of this patch is to close tty safely, so I have removed the call to unregister the ldisc. I will follow this up with a separate patch which addresses the ldisc issue. Thanks, Okash ___ d

[patch v2 1/1] staging: speakup: safely close tty

2017-07-16 Thread Okash Khawaja
Speakup opens tty using tty_open_by_driver. When closing, it calls tty_ldisc_release but doesn't close and remove the tty itself. As a result, that tty cannot be opened from user space. This patch calls tty_release_struct which ensures that tty is safely removed and freed up. It also calls tty_ldis

Re: [PATCH 1/1] drivers/staging/pi433: New driver (fwd)

2017-07-16 Thread Marcus Wolf
ee, please drop us a note to help > improve the system] > > url: > https://github.com/0day-ci/linux/commits/Wolf-Entwicklungen/drivers-staging-pi433-New-driver/20170716-021625 > :: branch date: 2 hours ago > :: commit date: 2 hours ago > > >> drivers/staging/pi43