[PATCH v2 0/3] Constify lustre attribute_group structures.

ttribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Arvind Yadav (3): [PATCH v2 1/3] staging: lustre: constify attribute_group structures. [PATCH v2 2/3]

[PATCH v2 3/3] staging: lustre: obdclass: linux: constify attribute_group structures.

attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- Changes in v2: patch was sent to

[PATCH v2 2/3] staging: lustre: ldlm: constify attribute_group structures.

attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- Changes in v2: patch was sent to

[PATCH v2 1/3] staging: lustre: constify attribute_group structures.

attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. File size before: textdata bss dec hex filename 9489 992 40 105212919

Re: [PATCH] Make functions rf69_set_bandwidth_intern and rf69_set_dc_cut_off_frequency_intern static

Oops, should have been marked as [V2] in the subject line On 20/07/17 23:33, Colin King wrote: > From: Colin Ian King > > The functions rf69_set_bandwidth_intern and also > rf69_set_dc_cut_off_frequency_intern is local to the source and > do not need to be in global

[PATCH] Make functions rf69_set_bandwidth_intern and rf69_set_dc_cut_off_frequency_intern static

From: Colin Ian King The functions rf69_set_bandwidth_intern and also rf69_set_dc_cut_off_frequency_intern is local to the source and do not need to be in global scope, so make it static. Also break break overly wide line. Finally, remove the function declaration

[patch] staging: speakup: remove support for lp*

Testing has shown that lp* devices don't work correctly with speakup just yet. That will require some additional work. Until then, this patch removes code related to that. Signed-off-by: Okash Khawaja --- drivers/staging/speakup/spk_ttyio.c | 23

Re: [PATCH] staging: pi433: fix bugs in register abstraction of rf69 chip

Am 20.07.2017 18:08, schrieb Marcus Wolf: > Hi Walter, > > since the construction > > WRITE_REG(REG_LNA, ( (READ_REG(REG_LNA) & ~MASK_LNA_GAIN) | > LNA_GAIN_MAX_MINUS_6) ) > aka > WRITE_REG(regname, ( (READ_REG(regname) & ~regmask ) | vale >) ) > > is used nearly

[PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

staging: rts5208: Fix coding style issue caught by checkpatch.pl related to function name in debug print Signed-off-by: Gaurav Pathak --- drivers/staging/rts5208/ms.c| 5 +++-- drivers/staging/rts5208/rtsx.c | 4 ++-- drivers/staging/rts5208/rtsx_chip.c

Re: [PATCH] staging: pi433: fix bugs in register abstraction of rf69 chip

Hi Walter, since the construction WRITE_REG(REG_LNA, ( (READ_REG(REG_LNA) & ~MASK_LNA_GAIN) | LNA_GAIN_MAX_MINUS_6) ) aka WRITE_REG(regname, ( (READ_REG(regname) & ~regmask ) | vale ) ) is used nearly everywhere, I think, about using a more gneric macro like #define

Test of [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation

Hi! Since I don't have an environment for m68k and I would appreciate not having to set it up, I would be very happy, if someone could give the patch, named in the subjext, a try on ARCH=m68k... Thanks, Marcus > Geert Uytterhoeven hat am 20. Juli 2017 um 14:27 >

[PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation

Fixes problem with division in rf69_set_deviation Fixes: 874bcba65f9a ("staging: pi433: New driver") Signed-off-by: Marcus Wolf diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c --- a/drivers/staging/pi433/rf69.c +++

Re: [bug report] vmbus: add prefetch to ring buffer iterator

On Thu, 20 Jul 2017 13:48:45 +0300 Dan Carpenter wrote: > Hello Stephen Hemminger, > > The patch 15e1674de747: "vmbus: add prefetch to ring buffer iterator" > from Jun 25, 2017, leads to the following static checker warning: > > drivers/hv/ring_buffer.c:366

Re: [PATCH]

Em Mon, 10 Jul 2017 01:35:11 +0200 armetallica escreveu: > From 043428d63637a6dd8e52449b73dbb8341885d7e4 Mon Sep 17 00:00:00 2001 > From: Armin Schoenlieb > Date: Mon, 10 Jul 2017 01:12:52 +0200 > Subject: [PATCH] Staging: media: atomisp2: fixed

[PATCH] staging: bcm2835-audio: constify snd_pcm_ops structures

Check for snd_pcm_ops structures that are only stored in the ops field of a snd_soc_platform_driver structure or passed as the third argument to snd_pcm_set_ops. The corresponding field or parameter is declared const, so snd_pcm_ops structures that have this property can be declared as const also.

Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static

Hi Colin, mine is an aditional patch for an other function, that's pretty similar to the one, you improoved. So we need both patches, yours and mine! Cheers, Marcus > Colin Ian King hat am 20. Juli 2017 um 14:58 > geschrieben: > > > On 20/07/17 12:01, Wolf

[PATCH] staging: fsl-mc/dpio: Skip endianness conversion in portal config

Writing to the register using writel does the CPU to LE conversion down the line, so it's not required here. Doing it breaks portal configuration on big endian kernels. Signed-off-by: Bogdan Purcareata --- drivers/staging/fsl-mc/bus/dpio/qbman-portal.c | 24

RE: [bug report] vmbus: add prefetch to ring buffer iterator

> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Thursday, July 20, 2017 3:49 AM > To: step...@networkplumber.org > Cc: de...@linuxdriverproject.org; KY Srinivasan ; > Haiyang Zhang > Subject: [bug report]

Re: [PATCH 7/7] staging: fsl-mc: allow the driver compile multi-arch

Hi, Sparc seems to be broken in multiple places, including generic code. Is this a known issue? Is there something I could/should do? --- Thanks & Best Regards, Laurentiu On 07/19/2017 08:31 PM, kbuild test robot wrote: > Hi Laurentiu, > > [auto build test ERROR on staging/staging-testing] >

[PATCH] staging: ccree: Fix unnecessary NULL check before kfree'ing it

From: Suniel Mahesh kfree(NULL) is safe and their is no need for a NULL check. Pointed out by checkpatch. Signed-off-by: Suniel Mahesh --- Note: - Patch was compile tested and built(ARCH=arm) on next-20170719. No build issues reported. ---

Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static

On 20/07/17 12:01, Wolf Entwicklungen wrote: > Declare rf69_set_dc_cut_off_frequency_intern as static since it > is used internaly only > > Fixes: 874bcba65f9a ("staging: pi433: New driver") > Signed-off-by: Marcus Wolf > > diff --git a/drivers/staging/pi433/rf69.c

Re: [PATCH 1/1] drivers/staging/pi433: New driver

Hi Dan, On Thu, Jul 20, 2017 at 1:37 PM, Dan Carpenter wrote: > On Thu, Jul 20, 2017 at 01:23:05PM +0200, Marcus Wolf wrote: >> below you can see the report with the error on m68k. It was sent to me from a >> test robot of intel. >> >> According to my research, this

Re: [PATCH v1 1/6] efi: Switch to use new generic UUID API

On 19 July 2017 at 19:28, Andy Shevchenko wrote: > There are new types and helpers that are supposed to be used in new code. > > As a preparation to get rid of legacy types and API functions do > the conversion here. > > Cc: Matt Fleming

Re: [PATCH] staging: pi433: fix bugs in register abstraction of rf69 chip

Am 19.07.2017 20:18, schrieb Wolf Entwicklungen: > Bugfixes for rf69_set_modulation, rf69_set_deviation, rf69_set_lna_gain and > rf69_get_lna_gain > The fixes are cross-checked with the datasheet of the rfm69cw > > Fixes: 874bcba65f9a ("staging: pi433: New driver") > Signed-off-by: Marcus Wolf

Re: [PATCH 1/2] staging: fsl-dpaa2/eth: Fix skb use after free

Ah. Good. My mistake. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH 1/2] staging: fsl-dpaa2/eth: Fix skb use after free

> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Thursday, July 20, 2017 2:18 PM > To: Bogdan Purcareata > Cc: Ruxandra Ioana Radulescu ; > gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;

Re: [PATCH 1/1] drivers/staging/pi433: New driver

On Thu, Jul 20, 2017 at 01:23:05PM +0200, Marcus Wolf wrote: > Hi Greg, > > below you can see the report with the error on m68k. It was sent to me from a > test robot of intel. > > According to my research, this problem occured, because there is no hardware > support for floating point on the

Re: [PATCH 1/1] drivers/staging/pi433: New driver

On Thu, Jul 20, 2017 at 01:23:05PM +0200, Marcus Wolf wrote: > Hi Greg, > > below you can see the report with the error on m68k. It was sent to me from a > test robot of intel. > > According to my research, this problem occured, because there is no hardware > support for floating point on the

Re: [PATCH 1/1] drivers/staging/pi433: New driver

Hi Greg, below you can see the report with the error on m68k. It was sent to me from a test robot of intel. According to my research, this problem occured, because there is no hardware support for floating point on the m68k (or it was configured not to use it). Therefore gcc uses an internal

Re: [PATCH 1/2] staging: fsl-dpaa2/eth: Fix skb use after free

On Thu, Jul 20, 2017 at 10:58:37AM +, Bogdan Purcareata wrote: > Once a Tx frame descriptor is enqueued, an interrupt might be triggered > to process the Tx confirmation and free the skb, hitting a memory use > after free when updating the tx_bytes statistic based on skb->len. > > Use the

[PATCH 2/2] staging: fsl-dpaa2/eth: Error report format fixes

Fix mishaps in error format strings. Signed-off-by: Bogdan Purcareata --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c

Re: [PATCH] staging: pi433: Fix a couple of spelling mistakes

Reviewed-by: Marcus Wolf > Colin King hat am 18. Juli 2017 um 07:40 > geschrieben: > > > From: Colin Ian King > > Trivial fix to spelling mistakes in dev_dbg debug messages > > "wiat" -> "wait" > "fonud" ->

Re: [PATCH -next] staging: pi433: depends on SPI

Reviewed-by: Marcus Wolf Am Do, 20.07.2017, 01:58 schrieb Randy Dunlap: > From: Randy Dunlap > > The pi433 driver uses SPI interfaces so it should depend on SPI. > Also, the "default n" can be removed since that is already the > default. > >

Re: [PATCH 2/2] Staging: pi433: check error after kthread_run()

Reviewed-by: Marcus Wolf Tested-by: Marcus Wolf Am So, 16.07.2017, 16:48 schrieb Joseph Wright: > Error should be checked with IS_ERR after calling kthread_run() > instead of comparing the returned pointer to an int. > > Found by sparse

Re: [PATCH 1/2] Staging: pi433: declare functions static

Reviewed-by: Marcus Wolf Am So, 16.07.2017, 16:48 schrieb Joseph Wright: > Declare functions static to fix sparse warnings: > > warning: symbol 'pi433_receive' was not declared. Should it be static? > warning: symbol 'pi433_tx_thread' was not declared. Should it be

Re: [PATCH 2/3][staging-next] staging: pi433: Make functions rf69_set_bandwidth_intern static

Reviewed-by: Marcus Wolf Am Di, 18.07.2017, 15:03 schrieb Colin King: > From: Colin Ian King > > The function rf69_set_bandwidth_intern is local to the source > and do not need to be in global scope, so make it static. Also > break overly

Re: [PATCH 1/3][staging-next] staging: pi433: Make a couple of functions static

Reviewed-by: Marcus Wolf Am Di, 18.07.2017, 15:03 schrieb Colin King: > From: Colin Ian King > > The functions pi433_receive and pi433_tx_thread are local to the source > and do not need to be in global scope, so make them static > > Cleans

Re: [PATCH 3/3][staging-next] staging: pi433: fix thread_run failure check

Reviewed-by: Marcus Wolf Tested-by: Marcus Wolf Am Di, 18.07.2017, 15:04 schrieb Colin King: > From: Colin Ian King > > The check for thread_run failure is incorrect, use IS_ERR instead. > > Cleans up sparse

Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static

Declare rf69_set_dc_cut_off_frequency_intern as static since it is used internaly only Fixes: 874bcba65f9a ("staging: pi433: New driver") Signed-off-by: Marcus Wolf diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c ---

[PATCH 1/2] staging: fsl-dpaa2/eth: Fix skb use after free

Once a Tx frame descriptor is enqueued, an interrupt might be triggered to process the Tx confirmation and free the skb, hitting a memory use after free when updating the tx_bytes statistic based on skb->len. Use the frame descriptor length instead. Signed-off-by: Bogdan Purcareata

[bug report] vmbus: add prefetch to ring buffer iterator

Hello Stephen Hemminger, The patch 15e1674de747: "vmbus: add prefetch to ring buffer iterator" from Jun 25, 2017, leads to the following static checker warning: drivers/hv/ring_buffer.c:366 hv_pkt_iter_first() warn: 'desc' can't be NULL. drivers/hv/ring_buffer.c 357 struct

Re: [PATCH] drivers: staging: comedi: Add ftrace support

;) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[patch v3 0/3] tty contention resulting from tty_open_by_driver export

Hi, I have updated the patches so that the exclusivity flag is in tty_port. When closing the struct - by calling tty_release_struct - we also need to reset the flag. One way to do that is to reset the flag inside tty_release_struct function, regardless of whether the tty was opened through

[patch v3 2/3] staging: speakup: use tty_kopen and tty_kclose

This patch replaces call to tty_open_by_driver with a tty_kopen and uses tty_kclose instead of tty_release_struct to close it. Signed-off-by: Okash Khawaja --- drivers/staging/speakup/spk_ttyio.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---

[patch v3 1/3] tty: resolve tty contention between kernel and user space

The commit 12e84c71b7d4 ("tty: export tty_open_by_driver") exports tty_open_by_device to allow tty to be opened from inside kernel which works fine except that it doesn't handle contention with user space or another kernel-space open of the same tty. For example, opening a tty from user space

[patch v3 3/3] tty: undo export of tty_open_by_driver

Since we have tty_kopen, we no longer need to export tty_open_by_driver. This patch makes this function static. Signed-off-by: Okash Khawaja --- drivers/tty/tty_io.c |3 +-- include/linux/tty.h |5 - 2 files changed, 1 insertion(+), 7 deletions(-) ---