[PATCH] staging: vboxvideo: Kconfig: Fix typos in help text

2017-07-23 Thread Martin Kepplinger
This fixes typos in vboxvideo's help text. Signed-off-by: Martin Kepplinger --- drivers/staging/vboxvideo/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig index a52746f9a670..2b058d573cf1 100644

Re: [PATCH] staging: pi433: fix sparse warning: missing static

2017-07-23 Thread Marcus Wolf
reviewed-by: Marcus Wolf The fixes of this patch are fine, but there are already patches out there, containing these fixes. Thanks, Marcus > David Wittman hat am 24. Juli 2017 um 00:46 geschrieben: > > > A few local functions in the pi433 module were getting flagged by Sparse > for missing dec

RE: [PATCH] Staging : unisys : visorbus : visorbus_main: Fixed a brace cdoing style issue

2017-07-23 Thread Kershner, David A
> -Original Message- > From: Himanshu Jha [mailto:himanshujha199...@gmail.com] > Subject: [PATCH] Staging : unisys : visorbus : visorbus_main: Fixed a brace > cdoing style issue > > Fixed coding style issue for function declaration. > This doesn't apply to Greg's branch, fix was already

[PATCH] staging: pi433: fix sparse warning: missing static

2017-07-23 Thread David Wittman
A few local functions in the pi433 module were getting flagged by Sparse for missing declarations, so I added static qualifiers to clean up the warnings. Signed-off-by: David Wittman --- drivers/staging/pi433/pi433_if.c | 4 ++-- drivers/staging/pi433/rf69.c | 2 +- 2 files changed, 3 insert

[PATCH] Staging : unisys : visorbus : visorbus_main: Fixed a brace cdoing style issue

2017-07-23 Thread Himanshu Jha
Fixed coding style issue for function declaration. Signed-off-by: Himanshu Jha --- drivers/staging/unisys/visorbus/visorbus_main.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/vis

[PATCH] staging: greybus: fix parenthesis alignments

2017-07-23 Thread Diwakar Sharma
Parenthesis alignment issues reported by checkpatch, fixed here. Signed-off-by: Diwakar Sharma --- drivers/staging/greybus/interface.c | 40 ++--- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/staging/greybus/interface.c b/drivers/stagi

[PATCH] staging: imx: fix non-static declarations

2017-07-23 Thread JB Van Puyvelde
Add static keywords to fix this kind of sparse warnings: warning: symbol 'imx_t_vcm_timing' was not declared. Should it be static? Signed-off-by: JB Van Puyvelde --- drivers/staging/media/atomisp/i2c/imx/imx.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

2017-07-23 Thread Johan Hovold
On Sun, Jul 23, 2017 at 03:10:53PM +0300, Dan Carpenter wrote: > On Sun, Jul 23, 2017 at 10:47:43AM +0200, Johan Hovold wrote: > > On Sun, Jul 23, 2017 at 02:09:57PM +0530, Shreeya Patel wrote: > > > Alignment should match with open parenthesis. > > > This fixes the coding style issue. > > > > No,

[PATCH] staging: comedi: ni_mio_common.c: fix coding style issue

2017-07-23 Thread Christopher Mårtensson
>From 3e90ab52ad9b437d7c09cc667161cdb855c0cc7b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christopher=20M=C3=A5rtensson?= Date: Sun, 23 Jul 2017 13:05:09 +0200 Subject: [PATCH] staging: comedi: ni_mio_common.c: fix coding style issue "checkpatch.pl -f ..." gave ERROR: open brace '{' following funct

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

2017-07-23 Thread Dan Carpenter
On Sun, Jul 23, 2017 at 10:47:43AM +0200, Johan Hovold wrote: > On Sun, Jul 23, 2017 at 02:09:57PM +0530, Shreeya Patel wrote: > > Alignment should match with open parenthesis. > > This fixes the coding style issue. > > No, it need not. This is a choice left up to the author, even if > checkpatch

Re: [PATCH] staging: vboxvideo: remove unused variables

2017-07-23 Thread Michael Thayer
Hello, 22.07.2017 20:17, Hans de Goede wrote: > Hi, > > On 22-07-17 12:55, Paolo Cretaro wrote: >> Fix compiler warnings: >> vbox_mode.c:57:15: warning: variable ‘crtc_id’ set but not used >> vbox_mode.c:581:25: warning: variable ‘vbox_connector’ set but not used >> >> Signed-off-by: Paolo Cretar

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

2017-07-23 Thread Johan Hovold
On Sun, Jul 23, 2017 at 02:09:57PM +0530, Shreeya Patel wrote: > Alignment should match with open parenthesis. > This fixes the coding style issue. No, it need not. This is a choice left up to the author, even if checkpatch happens to complain about it with the --strict option. Thanks, Johan

[PATCH] Staging: greybus: Match alignment with open parenthesis.

2017-07-23 Thread Shreeya Patel
Alignment should match with open parenthesis. This fixes the coding style issue. Signed-off-by: Shreeya Patel --- drivers/staging/greybus/tools/loopback_test.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/staging/greybus/tools/loopback

Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver

2017-07-23 Thread kbuild test robot
/linux/commits/Quentin-Schulz/add-ESP8089-WiFi-chip-driver/20170723-143744 config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by

[PATCH] staging: net: wireless: fix badzero.cocci warnings

2017-07-23 Thread kbuild test robot
drivers/staging/esp8089/esp_mac80211.c:596:33-34: WARNING comparing pointer to 0 Compare pointer-typed values to NULL rather than 0 Semantic patch information: This makes an effort to choose between !x and x == NULL. !x is used if it has previously been used with the function used to initiali

Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver

2017-07-23 Thread kbuild test robot
/linux/commits/Quentin-Schulz/add-ESP8089-WiFi-chip-driver/20170723-143744 config: blackfin-allyesconfig (attached as .config) compiler: bfin-uclinux-gcc (GCC) 6.2.0 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x