Re: [PATCH v3/resubmit 1/3] staging: gs_fpgaboot: add buffer overflow checks

On Wed, Jul 26, 2017 at 09:13:57PM -0400, Jacob von Chorus wrote: > Four fields in struct fpgaimage are char arrays of length MAX_STR (256). > The amount of data read into these buffers is controlled by a length > field in the bitstream file read from userspace. If a corrupt or > malicious

Re: [PATCH 1/3] staging: ccree: Replace kzalloc with devm_kzalloc

On Thu, Jul 27, 2017 at 05:27:32PM +0300, Gilad Ben-Yossef wrote: > From: Suniel Mahesh > > It is recommended to use managed function devm_kzalloc, which > simplifies driver cleanup paths and driver code. > This patch does the following: > (a) replace kzalloc with

Re: [PATCH 0/4] staging: ccree: coding style clean ups

On Thu, Jul 27, 2017 at 01:43:14PM +0300, Gilad Ben-Yossef wrote: > Misc. coding style fixes for ccree driver. > > These are the missing patches that failed to apply two weeks ago, > rebased onto latest staging-next. > > By the way, I still do not understand why they failed to apply, > as they

Re: [PATCH] staging: rtl8188eu: Fix coding style issue for braces

On Thu, Jul 27, 2017 at 09:33:45AM -0500, Deb McLemore wrote: > checkpatch.pl open brace following function declaration goes on > next line so fix the brace to go properly on next line > > Signed-off-by: Deb McLemore > --- >

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

On Mon, Jul 24, 2017 at 10:08:37AM +0300, Dan Carpenter wrote: > I don't understand why greybus has to be special instead of the same as > everything else. Who cares about this stuff really? Just do whatever > is easiest and most common. It's not special, and --strict should apply here as long

Re: [PATCH] staging: greybus: Fix coding style issue for column width

On Thu, Jul 27, 2017 at 04:35:32PM +0300, Dan Carpenter wrote: > On Thu, Jul 27, 2017 at 08:23:41AM -0500, Deb McLemore wrote: > > Hi Dan, > > > > Understand the readability issue, but this patch seems readable. > > > > I would have probably merged the patch, but whatever... Ignoring long >

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

On Sun, Jul 23, 2017 at 02:09:57PM +0530, Shreeya Patel wrote: > Alignment should match with open parenthesis. > This fixes the coding style issue. > > Signed-off-by: Shreeya Patel > --- > drivers/staging/greybus/tools/loopback_test.c | 35 >

Re: [PATCH] staging: greybus: Fix coding style issue for column width

On 27-07-17, 08:37, Deb McLemore wrote: > Hi Dan, thanks. > > I'll look for another subsystem to help improve the quality and standards. Please don't do *top-posting*. > On 07/27/2017 08:35 AM, Dan Carpenter wrote: > > On Thu, Jul 27, 2017 at 08:23:41AM -0500, Deb McLemore wrote: > >> Hi Dan, >

Re: [PATCH] staging: unisys: visorchipset: constify attribute_group structure

On Wed, Jul 26, 2017 at 09:51:32PM -0400, Amitoj Kaur Chawla wrote: > Functions working with attribute_groups provided by > work with const attribute_group. These attribute_group structures do not > change at runtime so mark them as const. > > File size before: > text data bss dec

Re: [PATCH] staging: unisys: visorbus_main: constify attribute_group structures

On Tue, Jul 25, 2017 at 06:45:52PM -0400, Amitoj Kaur Chawla wrote: > Functions working with attribute_groups provided by > work with const attribute_group. These attribute_group structures do not > change at runtime so mark them as const. > > File size before: > text data bss dec

Re: [PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap

On Friday 28 July 2017 01:18 AM, Dan Carpenter wrote: > On Thu, Jul 27, 2017 at 05:27:33PM +0300, Gilad Ben-Yossef wrote: >> +new_drvdata->cc_base = devm_ioremap_resource(_dev->dev, >> + req_mem_cc_regs); >> +if (IS_ERR(new_drvdata->cc_base))

Re: [PATCH v9 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others()

On Fri, 14 Jul 2017 14:44:42 +0200 Vitaly Kuznetsov wrote: > Add Hyper-V tracing subsystem and trace hyperv_mmu_flush_tlb_others(). > Tracing is done the same way we do xen_mmu_flush_tlb_others(). > > Signed-off-by: Vitaly Kuznetsov > Reviewed-by: Andy

[PATCH] staging: wilc1000: fix spelling mistake: "Iinitialization" -> "initialization"

From: Colin Ian King Trivial fix to spelling mistake in netdev_err message Signed-off-by: Colin Ian King --- drivers/staging/wilc1000/linux_wlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap

On Thu, Jul 27, 2017 at 05:27:33PM +0300, Gilad Ben-Yossef wrote: > + new_drvdata->cc_base = devm_ioremap_resource(_dev->dev, > + req_mem_cc_regs); > + if (IS_ERR(new_drvdata->cc_base)) { > + rc = PTR_ERR(new_drvdata->cc_base); >

Re: [PATCH 18/20] staging: lustre: llite: Remove filtering of seclabel xattr

> From: Robin Humble > > The security.capability xattr is used to implement File > Capabilities in recent Linux versions. Capabilities are a > fine grained approach to granting executables elevated > privileges. eg. /bin/ping can have capabilities > cap_net_admin,

[PATCH] staging: media: davinci_vpfe: use __func__ for function names

Checkpatch reported warnings for use of embedded function names. Use __func__ instead of embedded function names. Signed-off-by: Diwakar Sharma --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 10 +- drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c

Re: [PATCH] staging: ccree: Fix unnecessary NULL check before kfree'ing it

Hi, On Thu, Jul 20, 2017 at 4:37 PM, wrote: > From: Suniel Mahesh > > kfree(NULL) is safe and their is no need for a NULL check. Pointed out > by checkpatch. > > Signed-off-by: Suniel Mahesh > --- > Note: > - Patch was compile

[PATCH] staging: rtl8188eu: Fix coding style issue for braces

checkpatch.pl open brace following function declaration goes on next line so fix the brace to go properly on next line Signed-off-by: Deb McLemore --- drivers/staging/rtl8188eu/include/rtw_ioctl.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v2 1/3] staging: ccree: Replace kzalloc with devm_kzalloc

On Tue, Jul 18, 2017 at 1:58 PM, wrote: > From: Suniel Mahesh > > It is recommended to use managed function devm_kzalloc, which > simplifies driver cleanup paths and driver code. > This patch does the following: > (a) replace kzalloc with

[PATCH 3/3] staging: ccree: Use platform_get_irq and devm_request_irq

From: Suniel Mahesh It is recommended to use managed function devm_request_irq(), which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace platform_get_resource(), request_irq() and corresponding error handling with

[PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap

From: Suniel Mahesh It is recommended to use managed function devm_ioremap_resource(), which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace request_mem_region(), ioremap() and corresponding error handling with

[PATCH 1/3] staging: ccree: Replace kzalloc with devm_kzalloc

From: Suniel Mahesh It is recommended to use managed function devm_kzalloc, which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace kzalloc with devm_kzalloc. (b) drop kfree(), because memory allocated with devm_kzalloc() is

Re: [PATCH 1/2] staging: greybus: light: Don't leak memory for no gain

Hi, On Wed, Jul 26, 2017 at 08:32:08PM +0200, Pavel Machek wrote: > Hi! > > > On Tue, Jul 25, 2017 at 02:30:31PM +0200, Johan Hovold wrote: > > > [ +CC: Rui and Greg ] > > > > Thanks Johan. I only got this because of you. > > > > > return ret; > > > > } > > > > > > And while it's fine

Re: [PATCH 02/37] binder: use group leader instead of open thread

On 27 July 2017 at 18:53, Greg Kroah-Hartman wrote: > On Thu, Jul 27, 2017 at 02:38:30PM +0530, Amit Pundir wrote: >> Hi, >> >> On 25 July 2017 at 14:43, Martijn Coenen wrote: >> > Hi John, >> > >> > On Mon, Jul 24, 2017 at 11:07 PM, John Stultz

Re: [PATCH] staging: greybus: Fix coding style issue for column width

Hi Dan, thanks. I'll look for another subsystem to help improve the quality and standards. On 07/27/2017 08:35 AM, Dan Carpenter wrote: > On Thu, Jul 27, 2017 at 08:23:41AM -0500, Deb McLemore wrote: >> Hi Dan, >> >> Understand the readability issue, but this patch seems readable. >> > > I

Re: [PATCH] staging: greybus: Fix coding style issue for column width

On Thu, Jul 27, 2017 at 08:23:41AM -0500, Deb McLemore wrote: > Hi Dan, > > Understand the readability issue, but this patch seems readable. > I would have probably merged the patch, but whatever... Ignoring long lines in .h files is within normal bounds of "being special" for maintainers.

Re: [PATCH] staging: greybus: Fix coding style issue for column width

Hi Dan, Understand the readability issue, but this patch seems readable. On 07/27/2017 08:16 AM, Dan Carpenter wrote: > On Thu, Jul 27, 2017 at 08:10:35AM -0500, Deb McLemore wrote: >> Hi Viresh, >> >> So does greybus not follow the coding style from checkpatch.pl ? >> > > Sometimes people go

Re: [PATCH 02/37] binder: use group leader instead of open thread

On Thu, Jul 27, 2017 at 02:38:30PM +0530, Amit Pundir wrote: > Hi, > > On 25 July 2017 at 14:43, Martijn Coenen wrote: > > Hi John, > > > > On Mon, Jul 24, 2017 at 11:07 PM, John Stultz > > wrote: > >> > >> 12-31 16:00:36.632 2518 2584 E

Re: [PATCH] staging: greybus: Fix coding style issue for column width

On Thu, Jul 27, 2017 at 08:10:35AM -0500, Deb McLemore wrote: > Hi Viresh, > > So does greybus not follow the coding style from checkpatch.pl ? > Sometimes people go over the 80 character limit if we think it's more readable. regards, dan carpenter

Re: [PATCH] staging: greybus: Fix coding style issue for column width

Hi Viresh, So does greybus not follow the coding style from checkpatch.pl ? On 07/26/2017 10:32 PM, Viresh Kumar wrote: > On 26-07-17, 17:13, Deb McLemore wrote: >> checkpatch.pl line over 80 characters so fix the formatting >> for coding style compliance. >> >> Signed-off-by: Deb McLemore

[PATCH 3/4] staging: ccree: remove func name from log messages

The SSI_LOG macros already add __func__ to log messages, so remove log message that add them a second time in the log message itself. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c | 4 ++-- drivers/staging/ccree/ssi_cipher.c | 14 +++---

[PATCH 4/4] staging: ccree: kmalloc by sizeof var not type

Change places where we alloc memory by sizeof type to sizeof var. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c| 4 ++-- drivers/staging/ccree/ssi_cipher.c | 4 ++-- drivers/staging/ccree/ssi_driver.c | 2 +-

[PATCH 2/4] staging: ccree: fix split strings

Fix strings in log messages being split across lines and the resulting alignment issues when being fixed. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c| 9 ++-- drivers/staging/ccree/ssi_buffer_mgr.c | 86 ++---

[PATCH 1/4] staging: ccree: fix parenthesis alignment

Fix various remaining parenthesis alignment issues. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c| 46 + drivers/staging/ccree/ssi_buffer_mgr.c | 30 ++- drivers/staging/ccree/ssi_cipher.c | 2 +-

[PATCH 0/4] staging: ccree: coding style clean ups

Misc. coding style fixes for ccree driver. These are the missing patches that failed to apply two weeks ago, rebased onto latest staging-next. By the way, I still do not understand why they failed to apply, as they applied just fine being cherry picked on top of latest staging-next apart for

Re: [PATCH 02/37] binder: use group leader instead of open thread

Hi, On 25 July 2017 at 14:43, Martijn Coenen wrote: > Hi John, > > On Mon, Jul 24, 2017 at 11:07 PM, John Stultz wrote: >> >> 12-31 16:00:36.632 2518 2584 E hw-ProcessState: Using /dev/hwbinder >> failed: unable to mmap transaction memory. > > This

Re: [PATCH v2] staging: lustre: replace simple_strtoul with kstrtoint

I did test it and not everything works as expected. I need to reconsider that change. Please drop this patch. Thanks, Marcin P.S. Sorry for late (sic!) response. On Fri, Apr 14, 2017 at 10:16:31AM +0200, Greg Kroah-Hartman wrote: > On Tue, Mar 21, 2017 at 01:46:09PM +0100, Marcin Ciupak wrote:

Re: [PATCH net-next v2 00/10] netvsc fixes and new features

From: Stephen Hemminger Date: Wed, 26 Jul 2017 16:40:19 -0700 > The next group of patches aims to reduce the driver memory footprint > by reducing the size of the per-device receive and send buffers, and > the per-channel receive completion queue. Sorry Stephen, I