[PATCH] staging/pi433: Solved some coding style issues in pi433_if.c

2017-07-31 Thread Rishabh Hardas
From: Rishabh Hardas Solved a few coding style issues, used BIT macro to set MINORBITS. Signed-off-by: Rishabh Hardas --- drivers/staging/pi433/pi433_if.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/s

Re: [PATCH] staging: ks7010: fix styling WARNINGs

2017-07-31 Thread kbuild test robot
Hi Ashish, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.13-rc3 next-20170731] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ashish-Kalra/staging-ks7010-fix

Re: [PATCH] staging: ks7010: fix styling WARNINGs

2017-07-31 Thread kbuild test robot
Hi Ashish, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.13-rc3 next-20170731] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ashish-Kalra/staging-ks7010-fix

Re: [PATCH] staging: ks7010: fix styling WARNINGs

2017-07-31 Thread Greg KH
On Mon, Jul 31, 2017 at 04:15:21AM +0100, Ashish Kalra wrote: > Signed-off-by: Ashish Kalra > --- I can't accept patches without any changelog comments at all, sorry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject

[PATCH] staging: ks7010: fix styling WARNINGs

2017-07-31 Thread Ashish Kalra
Signed-off-by: Ashish Kalra --- Trivial style changes. There are still "line over 80 characters" checkpatch.pl warnings, but I think they are best left alone as breaking these could hurt readability drivers/staging/ks7010/ks7010_sdio.c | 53 +++- 1 file changed, 4

Re: [PATCH] Removing Check Errors with checkpatch.pl, Converting from macro to function call

2017-07-31 Thread Joe Perches
On Mon, 2017-07-31 at 03:20 +0100, Ashish Kalra wrote: You should not use checkpatch in the commit subject and should use a commit message. You also need a "Signed-off-by:" line with your legal name and email address. > diff --git a/drivers/staging/ks7010/ks7010_sdio.c > b/drivers/staging/ks701

[PATCH] Removing Check Errors with checkpatch.pl, Converting from macro to function call

2017-07-31 Thread Ashish Kalra
--- drivers/staging/ks7010/ks7010_sdio.c | 47 +--- 1 file changed, 33 insertions(+), 14 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index 9b28ee1..274fed8 100644 --- a/drivers/staging/ks7010/ks7010_sdio.c

[PATCH] staging: ks7010: fix styling WARNINGs

2017-07-31 Thread osboxes.org
>From df9062e12930837d5961f2e34ae7eb612820822b Mon Sep 17 00:00:00 2001 From: Ashish Kalra Date: Mon, 31 Jul 2017 02:28:28 +0100 Subject: [PATCH] Removing Check Errors with checkpatch.pl, Converting from macro to function call --- drivers/staging/ks7010/ks7010_sdio.c | 47 +

[PATCH net-next v2 1/3] netvsc: transparent VF management

2017-07-31 Thread Stephen Hemminger
This patch implements transparent fail over from synthetic NIC to SR-IOV virtual function NIC in Hyper-V environment. It is a better alternative to using bonding as is done now. Instead, the receive and transmit fail over is done internally inside the driver. Using bonding driver has lots of issue

[PATCH net-next v2 0/3] netvsc: transparent SR-IOV VF support

2017-07-31 Thread Stephen Hemminger
This patch set changes how SR-IOV Virtual Function devices are managed in the Hyper-V network driver. It was part of earlier bundle, but is now updated. Background In Hyper-V SR-IOV can be enabled (and disabled) by changing guest settings on host. When SR-IOV is enabled a matching PCI device is h

[PATCH net-next v2 2/3] netvsc: add documentation

2017-07-31 Thread Stephen Hemminger
Add some background documentation on netvsc device options and limitations. Signed-off-by: Stephen Hemminger --- Documentation/networking/netvsc.txt | 63 + MAINTAINERS | 1 + 2 files changed, 64 insertions(+) create mode 100644 Docum

[PATCH net-next v2 3/3] netvsc: remove bonding setup script

2017-07-31 Thread Stephen Hemminger
No longer needed, now all managed by transparent VF logic. Signed-off-by: Stephen Hemminger --- tools/hv/bondvf.sh | 255 - 1 file changed, 255 deletions(-) delete mode 100755 tools/hv/bondvf.sh diff --git a/tools/hv/bondvf.sh b/tools/hv/bond

Re: [PATCH net-next 4/4] pci-hyperv: do not sleep in compose_msi_msg

2017-07-31 Thread Stephen Hemminger
On Mon, 31 Jul 2017 16:37:12 -0700 Stephen Hemminger wrote: > The setup of MSI with Hyper-V host was sleeping with locks held. > This error is reported when doing SR-IOV hotplug with kernel built with > lockdep. > > BUG: sleeping function called from invalid context at > kernel/sched/compl

[PATCH net-next 2/4] netvsc: add documentation

2017-07-31 Thread Stephen Hemminger
Add some background documentation on netvsc device options and limitations. Signed-off-by: Stephen Hemminger --- Documentation/networking/netvsc.txt | 63 + MAINTAINERS | 1 + 2 files changed, 64 insertions(+) create mode 100644 Docum

[PATCH net-next 3/4] netvsc: remove bonding setup script

2017-07-31 Thread Stephen Hemminger
No longer needed, now all managed by transparent VF logic. Signed-off-by: Stephen Hemminger --- tools/hv/bondvf.sh | 255 - 1 file changed, 255 deletions(-) delete mode 100755 tools/hv/bondvf.sh diff --git a/tools/hv/bondvf.sh b/tools/hv/bond

[PATCH net-next 4/4] pci-hyperv: do not sleep in compose_msi_msg

2017-07-31 Thread Stephen Hemminger
The setup of MSI with Hyper-V host was sleeping with locks held. This error is reported when doing SR-IOV hotplug with kernel built with lockdep. BUG: sleeping function called from invalid context at kernel/sched/completion.c:93 in_atomic(): 1, irqs_disabled(): 1, pid: 1405, name: ip

[PATCH net-next 1/4] netvsc: transparent VF management

2017-07-31 Thread Stephen Hemminger
This patch implements transparent fail over from synthetic NIC to SR-IOV virtual function NIC in Hyper-V environment. It is a better alternative to using bonding as is done now. Instead, the receive and transmit fail over is done internally inside the driver. Using bonding driver has lots of issue

[PATCH net-next 0/4] netvsc: transparent SR-IOV VF support

2017-07-31 Thread Stephen Hemminger
This patch set changes how SR-IOV Virtual Function devices are managed in the Hyper-V network driver. It was part of earlier bundle, but is now updated. Background In Hyper-V SR-IOV can be enabled (and disabled) by changing guest settings on host. When SR-IOV is enabled a matching PCI device is ho

[PATCH] Staging: rtl8723bs: fix multiple missing spaces coding style problem

2017-07-31 Thread Christoffer Kjoelbaek
According to the coding-style documentation, spaces are required around most binary and ternary operators. Spaces were added to fix mulitple coding-style errors. Signed-off-by: Christoffer Kjoelbaek --- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 10 +- 1 file changed, 5 insertions(+

[PATCH V2] hyperv: netvsc: Neaten netvsc_send_pkt by using a temporary

2017-07-31 Thread Joe Perches
Repeated dereference of nvmsg.msg.v1_msg.send_rndis_pkt can be shortened by using a temporary. Do so. No change in object code. Miscellanea: o Use * const for rpkt and nvchan Signed-off-by: Joe Perches --- v2: Use * const for rpkt and nvchan This is a fairly unusual style, but is techn

Re: [Jfs-discussion] [PATCH] fs: convert a pile of fsync routines to errseq_t based reporting

2017-07-31 Thread Dave Kleikamp
On 07/28/2017 09:23 AM, Jeff Layton wrote: > From: Jeff Layton > > This patch converts most of the in-kernel filesystems that do writeback > out of the pagecache to report errors using the errseq_t-based > infrastructure that was recently added. This allows them to report > errors once for each o

Re: [PATCH] hyperv: netvsc: Neaten netvsc_send_pkt by using a temporary

2017-07-31 Thread Joe Perches
On Mon, 2017-07-31 at 10:05 -0700, Stephen Hemminger wrote: > On Sun, 30 Jul 2017 14:19:30 -0700 Joe Perches wrote: > > Repeated dereference of nvmsg.msg.v1_msg.send_rndis_pkt can be > > shortened by using a temporary. Do so. [] > Looks good, several other places also suffer from to > long.varia

Re: [PATCH v1 3/6] staging: unisys: Switch to use new generic UUID API

2017-07-31 Thread Andy Shevchenko
On Sun, 2017-07-30 at 10:37 -0700, Greg Kroah-Hartman wrote: > On Sun, Jul 30, 2017 at 08:26:48PM +0300, Andy Shevchenko wrote: > > On Sun, Jul 30, 2017 at 6:32 PM, Greg Kroah-Hartman > > wrote: > > > Doesn't apply to the staging tree at all :( > > > > No surprises, it was cooked against uuid tr

[PATCH v2] staging: unisys: Switch to use new generic UUID API

2017-07-31 Thread Andy Shevchenko
There are new types and helpers that are supposed to be used in new code. As a preparation to get rid of legacy types and API functions do the conversion here. While here, re-indent couple of lines to increase readability. Cc: David Kershner Cc: Greg Kroah-Hartman Cc: sparmaintai...@unisys.com

Re: [PATCH] hyperv: netvsc: Neaten netvsc_send_pkt by using a temporary

2017-07-31 Thread Stephen Hemminger
On Sun, 30 Jul 2017 14:19:30 -0700 Joe Perches wrote: > Repeated dereference of nvmsg.msg.v1_msg.send_rndis_pkt can be > shortened by using a temporary. Do so. > > No change in object code. > > Signed-off-by: Joe Perches Looks good, several other places also suffer from to long.variable.nam

Re: [PATCH] staging/pi433: Solved some coding style issues in pi433_if.c

2017-07-31 Thread Greg KH
On Mon, Jul 31, 2017 at 03:51:13PM +0530, RishabhHardas wrote: > From: RishabhHardas > > Solved a few coding style issues, used BIT macro to set MINORBITS. > > Signed-off-by: RishabhHardas For some reason I do not think your legal name has no space in it :( Please fix and resend. thanks, gr

[PATCH] staging: fsl-mc: add explicit dependencies for compile-tested arches

2017-07-31 Thread laurentiu.tudor
From: Laurentiu Tudor The driver makes use of GENERIC_MSI_IRQ_DOMAIN which requires arch support so, on architectures that don't have it, the kernel will fail to build. Add explicit dependency on architectures that were compile-tested, thus fixing compilation for the ones that don't implement GEN

Re: [PATCH] staging/pi433: Solved some coding style issues in pi433_if.c

2017-07-31 Thread Wolf Entwicklungen
Reviewed-by: Marcus Wolf Thank you Rishabh! Marcus Am Mo, 31.07.2017, 12:21 schrieb RishabhHardas: > From: RishabhHardas > > Solved a few coding style issues, used BIT macro to set MINORBITS. > > Signed-off-by: RishabhHardas > --- > drivers/staging/pi433/pi433_if.c | 24 ++---

[PATCH] Staging: media: atomisp: i2c: gc0310: fixed brace coding style issue

2017-07-31 Thread Rene Hickersberger
Fixed a brace coding style issue. Signed-off-by: Rene Hickersberger --- drivers/staging/media/atomisp/i2c/gc0310.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/gc0310.c b/drivers/staging/media/atomisp/i2c/gc0310.c index 1ec616a..bec0c46

Re: [Intel-gfx] [PATCH 0/3] Kconfig dependencies: acpi-video, backlight and thermal

2017-07-31 Thread Jani Nikula
On Wed, 26 Jul 2017, Daniel Vetter wrote: > On Wed, Jul 26, 2017 at 03:53:09PM +0200, Arnd Bergmann wrote: >> Hi everyone, >> >> It took me a while to figure this out properly, as I kept getting >> circular or missing dependencies with video drivers. >> >> This set of three patches should simpli

[PATCH V2] staging: ccree: Fix format/argument mismatches

2017-07-31 Thread Joe Perches
--- On top of next-20170731 drivers/staging/ccree/ssi_aead.c| 8 drivers/staging/ccree/ssi_buffer_mgr.c | 29 +--- drivers/staging/ccree/ssi_cipher.c | 10 +- drivers/staging/ccree/ssi_driver.c | 5 ++--- drivers/staging/ccree

[PATCH] staging/pi433: Solved some coding style issues in pi433_if.c

2017-07-31 Thread RishabhHardas
From: RishabhHardas Solved a few coding style issues, used BIT macro to set MINORBITS. Signed-off-by: RishabhHardas --- drivers/staging/pi433/pi433_if.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/sta

Re: [PATCH] staging: ccree: Fix format/argument mismatches

2017-07-31 Thread Joe Perches
On Mon, 2017-07-31 at 09:39 +0300, Gilad Ben-Yossef wrote: > On Sun, Jul 30, 2017 at 7:45 PM, Joe Perches wrote: > > By default, debug logging is disabled by CC_DEBUG not being defined. > > > > Convert SSI_LOG_DEBUG to use no_printk instead of an empty define > > to validate formats and arguments

[PATCH] staging/ccree: Declare compiled out fuctions static inline

2017-07-31 Thread RishabhHardas
From: RishabhHardas Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and 'fips_handler' that they were not declared and need to be made static. This patch makes both the symbols static inline, to remove the warnings. Signed-off-by: RishabhHardas --- drivers/staging/ccree/

[PATCH] staging: pi433: reduce stack size in tx thread

2017-07-31 Thread Arnd Bergmann
Putting a 900 byte array on the stack is a clearly too much in the kernel, and sometimes results in warnings like: drivers/staging/pi433/pi433_if.c: In function 'pi433_tx_thread': drivers/staging/pi433/pi433_if.c:645:1: error: the frame size of 1028 bytes is larger than 1024 bytes [-Werror=frame-

Re: [PATCH] Staging: vc04_services: Fix WARN_ON instead of BUG_ON

2017-07-31 Thread Dan Carpenter
On Mon, Jul 31, 2017 at 12:44:03PM +0530, janani-sankarababu wrote: > This patch is to replace the use of BUG_ON macro with WARN_ON > inorder to prevent the crashing of the kernel. > > Signed-off-by: Janani Sankara Babu > --- > drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +- >

Re: [PATCH] Staging: vc04_services: Fix WARN_ON instead of BUG_ON

2017-07-31 Thread Stefan Wahren
Am 31.07.2017 um 09:14 schrieb janani-sankarababu: > This patch is to replace the use of BUG_ON macro with WARN_ON > inorder to prevent the crashing of the kernel. Unfortunately it isn't always that simple. checkpatch isn't smart. It's preferred to handle error cases instead of flooding the kernel

[PATCH v2] staging: pi433: Use matching enum types calling rf69_set_packet_format

2017-07-31 Thread Elia Geretto
This patch fixes the following four warnings found using sparse: drivers/staging/pi433/pi433_if.c:211:9: warning: mixing different enum types drivers/staging/pi433/pi433_if.c:211:9: int enum optionOnOff versus drivers/staging/pi433/pi433_if.c:211:9: int enum packetFormat drivers/staging/p

Re: [PATCH] fs: convert a pile of fsync routines to errseq_t based reporting

2017-07-31 Thread Jan Kara
On Fri 28-07-17 10:23:21, Jeff Layton wrote: > From: Jeff Layton > > This patch converts most of the in-kernel filesystems that do writeback > out of the pagecache to report errors using the errseq_t-based > infrastructure that was recently added. This allows them to report > errors once for each

[PATCH] Staging: vc04_services: Fix WARN_ON instead of BUG_ON

2017-07-31 Thread janani-sankarababu
This patch is to replace the use of BUG_ON macro with WARN_ON inorder to prevent the crashing of the kernel. Signed-off-by: Janani Sankara Babu --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_s

Re: [PATCH 10/11] greybus: usb: constify hc_driver structures

2017-07-31 Thread Johan Hovold
On Fri, Jul 28, 2017 at 10:41:57PM +0200, Julia Lawall wrote: > The hc_driver structure is only passed as the first argument to > usb_create_hcd, which is declared as const. Thus the hc_driver structure > itself can be const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall

Re: [PATCH 0/3] ANDROID: binder: reconcile with android common tree

2017-07-31 Thread Martijn Coenen
On Sat, Jul 29, 2017 at 1:22 AM, Greg KH wrote: > Ok, do some of these need to go to Linus now for 4.13-final and to the > stable trees to match up with the 3 that are already proposed for the > stable trees? If so, which ones? "fix proc->tsk check" is a fix for "c4ea41ba195d ("binder: use group