Re: [PATCH v2 1/4] staging: pi433: Style fix - Correct long lines

2017-08-16 Thread Dan Carpenter
On Wed, Aug 16, 2017 at 10:53:18AM +0530, Rishabh Hardas wrote: > @@ -143,10 +142,13 @@ struct pi433_rx_cfg { > > #define PI433_IOC_MAGIC 'r' > > -#define PI433_IOC_RD_TX_CFG _IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, > char[sizeof(struct pi433_tx_cfg)]) > -#define PI433

Re: [PATCH v2 3/4] staging: pi433: Renaming Enums

2017-08-16 Thread Dan Carpenter
On Wed, Aug 16, 2017 at 10:53:20AM +0530, Rishabh Hardas wrote: > Remove camel casing by renaming enums. > > Signed-off-by: Rishabh Hardas > --- > drivers/staging/pi433/pi433_if.h | 36 > drivers/staging/pi433/rf69.c | 26 +- > d

Re: [PATCH v2 2/4] staging: pi433: Change Comments

2017-08-16 Thread Dan Carpenter
On Wed, Aug 16, 2017 at 10:53:19AM +0530, Rishabh Hardas wrote: > + enum optionOnOffenable_crc; /* only operational, > +*if sync on and fixed > +* length or leng

[PATCH] staging: wlan-ng: hfa384x.h: Use endian type in 'hfa384x_link_status' struct

2017-08-16 Thread Ricardo Silva
The 'linkstatus' field from struct 'hfa384x_link_status' represents a 16-bit little-endian integer, so declare it as such to avoid the following sparse warning when accessing it through the 'le16_to_cpu()' function: prism2sta.c:1450:31: warning: cast to restricted __le16 Signed-off-by: Ricardo S

[PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

2017-08-16 Thread Colin King
From: Colin Ian King The previous fix removed the equal to zero comparisons by the strcmps and now the function always returns true. Fix this by adding in the missing logical negation operators. Detected by CoverityScan, CID#1452267 ("Constant expression result") Fixes: b93ad9a067e1 ("staging:

Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

2017-08-16 Thread Dan Carpenter
On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote: > From: Colin Ian King > > The previous fix removed the equal to zero comparisons by the strcmps and > now the function always returns true. Fix this by adding in the missing > logical negation operators. > > Detected by CoverityScan, C

Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

2017-08-16 Thread Dan Carpenter
On Wed, Aug 16, 2017 at 03:06:54PM +0300, Dan Carpenter wrote: > On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote: > > From: Colin Ian King > > > > The previous fix removed the equal to zero comparisons by the strcmps and > > now the function always returns true. Fix this by adding in t

Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

2017-08-16 Thread Laurentiu Tudor
On 08/16/2017 03:06 PM, Dan Carpenter wrote: > On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote: >> From: Colin Ian King >> >> The previous fix removed the equal to zero comparisons by the strcmps and >> now the function always returns true. Fix this by adding in the missing >> logical n

Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

2017-08-16 Thread Colin Ian King
On 16/08/17 14:37, Laurentiu Tudor wrote: > On 08/16/2017 03:06 PM, Dan Carpenter wrote: >> On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote: >>> From: Colin Ian King >>> >>> The previous fix removed the equal to zero comparisons by the strcmps and >>> now the function always returns tru

[PATCH] staging: lustre: fix structure size for ARM OABI

2017-08-16 Thread Cihangir Akturk
When building the kernel for the ARM architecture without setting CONFIG_AEABI, size of struct lov_user_md_v3 and struct lov_mds_md_v3 differs, due to different alignment requirements of OABI and EABI. Marking the anonymous union within struct lov_user_md_v3 as '_packed' solves this issue. Otherwi

Re: [PATCH v2 02/14] staging: typec: tcpm: Add get_current_limit tcpc_dev callback

2017-08-16 Thread Guenter Roeck
On 08/15/2017 01:04 PM, Hans de Goede wrote: A Rp signalling the default current limit indicates that we're possibly connected to an USB2 power-source. In some cases the type-c port-controller may provide the capability to detect the current-limit in this case, through e.g. BC1.2 detection. This

[PATCH] vmbus: fix missing signaling in hv_signal_on_read()

2017-08-16 Thread Stephen Hemminger
When the space available before start of reading (cached_write_sz) is the same as the host required space (pending_sz), we need to still signal host. Fixes: 433e19cf33d3 ("Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()") Signed-off-by: John Starks Signed-off-by: Dexuan Cui Signed-

Re: [PATCH v2 08/14] power: supply: Add power_supply_set_input_current_limit_from_supplier helper

2017-08-16 Thread Tony Lindgren
* Hans de Goede [170815 13:06]: > On some devices the USB Type-C port power (USB PD 2.0) negotiation is > done by a separate port-controller IC, while the current limit is > controlled through another (charger) IC. > > It has been decided to model this by modelling the external Type-C > power bri

[PATCH net-next 0/3] vmbus sendpacket cleanups

2017-08-16 Thread Stephen Hemminger
These patches remove and consolidate vmbus_sendpacket functions. They should go through the net-next tree since these API's were only used by the netvsc driver. Stephen Hemminger (3): vmbus: remove unused vmbus_sendpacket_multipagebuffer vmbus: remove unused vmubs_sendpacket_pagebuffer_ctl

[PATCH net-next 3/3] vmbus: remove unused vmbus_sendpacket_ctl

2017-08-16 Thread Stephen Hemminger
The only usage of vmbus_sendpacket_ctl was by vmbus_sendpacket. Signed-off-by: Stephen Hemminger --- drivers/hv/channel.c| 43 +-- drivers/net/hyperv/netvsc.c | 9 - include/linux/hyperv.h | 7 --- 3 files changed, 21 insertions(

[PATCH net-next 2/3] vmbus: remove unused vmubs_sendpacket_pagebuffer_ctl

2017-08-16 Thread Stephen Hemminger
The function vmbus_sendpacket_pagebuffer_ctl was never used directly. Just have vmbus_send_pagebuffer Signed-off-by: Stephen Hemminger --- drivers/hv/channel.c| 30 ++ drivers/net/hyperv/netvsc.c | 10 -- include/linux/hyperv.h | 8 3 fi

[PATCH net-next 1/3] vmbus: remove unused vmbus_sendpacket_multipagebuffer

2017-08-16 Thread Stephen Hemminger
This function is not used anywhere in current code. Signed-off-by: Stephen Hemminger --- drivers/hv/channel.c | 56 -- include/linux/hyperv.h | 6 -- 2 files changed, 62 deletions(-) diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c

Re: [PATCH] vmbus: fix missing signaling in hv_signal_on_read()

2017-08-16 Thread Greg KH
On Wed, Aug 16, 2017 at 08:49:46AM -0700, Stephen Hemminger wrote: > When the space available before start of reading (cached_write_sz) > is the same as the host required space (pending_sz), we need to > still signal host. > > Fixes: 433e19cf33d3 ("Drivers: hv: vmbus: finally fix > hv_need_to_sig

Re: [PATCH] vmbus: fix missing signaling in hv_signal_on_read()

2017-08-16 Thread Stephen Hemminger
On Wed, 16 Aug 2017 09:10:40 -0700 Greg KH wrote: > On Wed, Aug 16, 2017 at 08:49:46AM -0700, Stephen Hemminger wrote: > > When the space available before start of reading (cached_write_sz) > > is the same as the host required space (pending_sz), we need to > > still signal host. > > > > Fixes:

[PATCH] Revert "staging: fsl-mc: be consistent when checking strcmp() return"

2017-08-16 Thread Colin King
From: Colin Ian King The previous fix removed the equal to zero comparisons by the strcmps and now the function always returns true. Revert this change to restore the original correctly functioning code. Detected by CoverityScan, CID#1452267 ("Constant expression result") This reverts commit b9

Re: [PATCH] Revert "staging: fsl-mc: be consistent when checking strcmp() return"

2017-08-16 Thread Greg Kroah-Hartman
On Wed, Aug 16, 2017 at 06:12:00PM +0100, Colin King wrote: > From: Colin Ian King > > The previous fix removed the equal to zero comparisons by the strcmps and > now the function always returns true. Revert this change to restore the > original correctly functioning code. > > Detected by Coveri

[PATCH][V2] Revert "staging: fsl-mc: be consistent when checking strcmp() return"

2017-08-16 Thread Colin King
From: Colin Ian King The previous fix removed the equal to zero comparisons by the strcmps and now the function always returns true. Revert this change to restore the original correctly functioning code. Detected by CoverityScan, CID#1452267 ("Constant expression result") This reverts commit b9

Re: [PATCH v2 08/14] power: supply: Add power_supply_set_input_current_limit_from_supplier helper

2017-08-16 Thread Hans de Goede
Hi, On 16-08-17 17:54, Tony Lindgren wrote: * Hans de Goede [170815 13:06]: On some devices the USB Type-C port power (USB PD 2.0) negotiation is done by a separate port-controller IC, while the current limit is controlled through another (charger) IC. It has been decided to model this by mod

Re: [PATCH net-next 1/3] VMCI: only load on VMware hypervisor

2017-08-16 Thread David Miller
From: Dexuan Cui Date: Tue, 15 Aug 2017 22:13:29 + > + /* > + * Check if we are running on VMware's hypervisor and bail out > + * if we are not. > + */ > + if (x86_hyper != &x86_hyper_vmware) > + return -ENODEV; This symbol is only available when CONFIG_HYP

Re: [PATCH net-next 1/3] VMCI: only load on VMware hypervisor

2017-08-16 Thread David Miller
From: Dexuan Cui Date: Wed, 16 Aug 2017 18:51:36 + > It looks typically modern Linux distros have CONFIG_HYPERVISOR_GUEST=y > by default It doesn't matter what any distribution does or does not do. People are going to do 'randconfig' builds over thousands and thousands of configuration comb

RE: [PATCH net-next 1/3] VMCI: only load on VMware hypervisor

2017-08-16 Thread Dexuan Cui
> From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, August 16, 2017 11:07 > > From: Dexuan Cui > Date: Tue, 15 Aug 2017 22:13:29 + > > > + /* > > +* Check if we are running on VMware's hypervisor and bail out > > +* if we are not. > > +*/ > > + if (x86_hyper

Re: [PATCH v2 08/14] power: supply: Add power_supply_set_input_current_limit_from_supplier helper

2017-08-16 Thread Tony Lindgren
* Hans de Goede [170816 10:38]: > Hi, > > On 16-08-17 17:54, Tony Lindgren wrote: > > * Hans de Goede [170815 13:06]: > > > On some devices the USB Type-C port power (USB PD 2.0) negotiation is > > > done by a separate port-controller IC, while the current limit is > > > controlled through anoth

Re: [PATCH v2 11/14] power: supply: bq24190_charger: Get input_current_limit from our supplier

2017-08-16 Thread Liam Breck
Hi Hans, On Tue, Aug 15, 2017 at 1:04 PM, Hans de Goede wrote: > On some devices the USB Type-C port power (USB PD 2.0) negotiation is > done by a separate port-controller IC, while the current limit is > controlled through another (charger) IC. > > It has been decided to model this by modelling

Re: [PATCH net-next 1/3] VMCI: only load on VMware hypervisor

2017-08-16 Thread Jorgen S. Hansen
> On Aug 16, 2017, at 12:13 AM, Dexuan Cui wrote: > > > Without the patch, vmw_vsock_vmci_transport.ko and vmw_vmci.ko can > automatically load when an application creates an AF_VSOCK socket. > > This is the expected good behavior on VMware hypervisor, but as we > are going to add hv_sock.ko (

Re: [PATCH v3 11/22] staging: ccree: fix line indentation and breaks

2017-08-16 Thread Greg Kroah-Hartman
On Tue, Aug 15, 2017 at 09:26:39AM +0300, Gilad Ben-Yossef wrote: > Fix wrong indentation and line breaks, including missing tabs, > breaking lines longer then 80 char or wrongly broken. > > Signed-off-by: Gilad Ben-Yossef > --- > drivers/staging/ccree/ssi_driver.c | 107 > +

Re: [PATCH] staging/ccree: Declare compiled out fuctions static inline

2017-08-16 Thread Greg KH
On Mon, Jul 31, 2017 at 02:47:23PM +0530, RishabhHardas wrote: > From: RishabhHardas > > Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and > 'fips_handler' > that they were not declared and need to be made static. This patch makes both > the symbols > static inline, to re

Re: [PATCH v3 00/22] staging: ccree: fixes and simplifications

2017-08-16 Thread Greg Kroah-Hartman
On Tue, Aug 15, 2017 at 09:26:28AM +0300, Gilad Ben-Yossef wrote: > The series includes various bug fixes, code simplification and style > cleanups. > > Changer from v2: > - Drop M32R as supported architecture, which resolve the kbuild bot > warnings on Joe Perches patch. > - Bug fix that prope

RE: [PATCH net-next 1/3] VMCI: only load on VMware hypervisor

2017-08-16 Thread Dexuan Cui
> From: Jorgen S. Hansen [mailto:jhan...@vmware.com] > > Without the patch, vmw_vsock_vmci_transport.ko and vmw_vmci.ko can > > automatically load when an application creates an AF_VSOCK socket. > > > > This is the expected good behavior on VMware hypervisor, but as we > > are going to add hv_sock.

Re: [PATCH net-next 0/3] vmbus sendpacket cleanups

2017-08-16 Thread David Miller
From: Stephen Hemminger Date: Wed, 16 Aug 2017 08:56:23 -0700 > These patches remove and consolidate vmbus_sendpacket functions. > > They should go through the net-next tree since these API's > were only used by the netvsc driver. Series applied, thanks.