space required before the open parenthesis, open brace should be
on previous line.
Signed-off-by: Xiangyang Zhang
---
drivers/staging/pi433/pi433_if.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi43
> From: Jorgen S. Hansen [mailto:jhan...@vmware.com]
> Sent: Thursday, August 17, 2017 08:17
> >
> > Putting aside nested virtualization, I want to load the transport (vmci,
> > Hyper-V, vsock) for which there is paravirtualized hardware present
> > inside the guest.
>
> Good points. Completely ag
On 08/17/2017 04:07 PM, tedheadster wrote:
Larry, you've migrated a bunch of staging code, and tried various
approaches. Do you have any lessons on what has worked and what hasn't
and if there is anything we can do to make the process better?
I am also quite interested in such work. We asked
checkpatch.pl gave
ERROR: open brace '{' following function definitions go on the next line.
Signed-off-by: Jamie Huang
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
b/drivers
> > On Aug 16, 2017, at 12:15 AM, Dexuan Cui wrote:
> > With the current code, when vsock_dequeue_accept() is removing a sock
> > from the list, nothing prevents vsock_enqueue_accept() from adding a new
> > sock into the list concurrently. We should add a lock to protect the list.
>
> For the VMC
On Tue, Aug 15, 2017 at 10:04:52PM +0200, Hans de Goede wrote:
> This is board specific info so it should come from board config, such
> as devicetree.
>
> I've chosen to prefix these with "fcs," treating them as fusb302 driver
> specific for now. We may want to revisit this and replace these with
>
> Larry, you've migrated a bunch of staging code, and tried various
> approaches. Do you have any lessons on what has worked and what hasn't
> and if there is anything we can do to make the process better?
I am also quite interested in such work. We asked for a Birds of
Feather discussion at th
I'm excited to see all the @realtek.com addresses. :)
Larry, you've migrated a bunch of staging code, and tried various
approaches. Do you have any lessons on what has worked and what hasn't
and if there is anything we can do to make the process better?
regards,
dan carpenter
_
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: 8d2fa5c352a9e0f877281c2b4486347305a380db
commit: ce6e67f2ed110fdbb89bb76bca8c2b9d2ad6c736 [276/342] staging: lustre:
fid: add include path to Makefile
config: ia64-allyesconfig (attached as .config)
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Thursday, August 17, 2017 10:04
> I would avoid module parameters at all costs.
>
> It is the worst possible interface for users of your software.
>
> You really need to fundamentally solve the problems related to making
> sure the proper
On Thu, Aug 10, 2017 at 06:49:45PM +0300, Sakari Ailus wrote:
> From: Rui Miguel Silva
>
> We are allocating memory for the v4l2 flash configuration structure and
> leak it in the normal path. Just use the stack for this as we do not
> use it outside of this function.
>
> Also use IS_ERR() inste
On Tue, Aug 15, 2017 at 02:28:11PM +0300, Sakari Ailus wrote:
> The V4L2 flash interface allows controlling multiple LEDs through a single
> sub-devices if, and only if, these LEDs are of different types. This
> approach scales badly for flash controllers that drive multiple flash LEDs
> or for LED
On Wed, Aug 02, 2017 at 05:54:49PM +0530, janani-sankarababu wrote:
> This patch fixes multiple line dereference Warning
> reported by checkpatch script. This is done to
> simplify the code and make it more readable.
>
> Signed-off-by: Janani Sankara Babu
Same "From:" line problem again :(
_
On Tue, Aug 01, 2017 at 12:30:25PM +0530, janani-sankarababu wrote:
> This patch is created to solve the coding style issues reported
> by the checkpatch script.
>
> Signed-off-by: Janani Sankara Babu
Your "From:" line name does not match this name :(
Please fix and resend.
thanks,
greg k-h
_
On Tue, Aug 01, 2017 at 04:21:06PM +0530, janani-sankarababu wrote:
> This patch is created to solve CamelCase issue. The
> variables 'IEs' and 'IELength' of struct wlan_bssid_ex
> are replaced with 'ies' and 'ie_length' to solve the
> CamelCase issue and these changes are applied to all the
> pl
On Mon, Aug 14, 2017 at 01:11:29PM +0530, janani-sankarababu wrote:
> This patch solves the following warnings
> thrown by checkpatch script
> WARNING: Comparisons should place the constant
> on the right side of the test
>
> Signed-off-by: Janani Sankara Babu
> ---
> drivers/staging/rtl8188eu/c
On Sun, Aug 06, 2017 at 12:12:47AM +0800, 张树荣 wrote:
> Replace hard-coded function names in strings with "%s", __func__
> in the olpc_dcon.c file. Issue found by checkpatch.pl.
Your subject line is too long :(
>
> Signed-off-by: Marvin Zhang
> ---
> drivers/staging/olpc_dcon/olpc_dcon.c |
On Thu, Aug 03, 2017 at 09:46:26AM +0800, vergilzhang wrote:
> Replace hard-coded function names in strings with "%s", __func__
> in the dot11d.c file. Issue found by checkpatch.pl.
>
> Signed-off-by: vergilzhang
Please use your "legal" name here, and in the From line. Please fix up
and res
On Wed, Aug 02, 2017 at 01:37:37AM +0100, Ashish Kalra wrote:
> This Patch is to solve coding style issues, Major changes to
> add Space around &,+,-. Major pending is to fix CamelCase
Please only do one type of thing per patch. And "fix all issues" is not
one thing.
thanks,
greg k-h
_
On Tue, Aug 01, 2017 at 06:25:36PM +0100, Ashish Kalra wrote:
> Signed-off-by: Ashish Kalra
>
> Trivial style changes. There are still "line over 80 characters"
> checkpatch.pl warnings, but I think they are best left alone as
> breaking these could hurt readability
> v2: Updated Patch as per rev
On Tue, Aug 15, 2017 at 04:23:39PM -0700, Badhri Jagan Sridharan wrote:
> While in SNK_READY state, the explicit_contract seems to be
> set to true irrespective of whether an explicit contract
> was established for the current connection. TCPM also seems
> to report the pwr_opmode as TYPEC_PWR_MODE
The RTL8822BE, an 802.11ac wireless network card, is now appearing in
new computers. Its driver is being placed in staging to reduce the time
that users of this new card will have access to in-kernel drivers.
This commit enables building of the new driver. For this version, all
routines are built
This commit adds the TODO file and implements some reviewers comments
made against some patches to the wireless tree.
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc: Shaofu
Cc: Steven Ting
---
drivers/staging/rtlwifi/TODO | 8 -
The RTL8822BE, an 802.11ac wireless network card, is now appearing in
new computers. Its driver is being placed in staging to reduce the time
that users of this new card will have access to in-kernel drivers.
This commit copies the existing routines from .../rtlwifi/btcoexist/
into staging. There
The RTL8822BE, an 802.11ac wireless network card, is now appearing in
new computers. Its driver is being placed in staging to reduce the time
that users of this new card will have access to in-kernel drivers.
Residence in staging should be relatively short as we soon plan to start
introducing the
On Thu, Jul 20, 2017 at 11:33:24PM +0100, Colin King wrote:
> From: Colin Ian King
Your subject needs work :(
Also does not apply to my tree at all :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/l
On Wed, Aug 09, 2017 at 05:14:16PM -0700, Seth Kushniryk wrote:
> My first try at this. I hope it's alright.
That's a very odd changelog text :(
Also please make your subject match other patches for this subsystem and
try again.
thanks,
greg k-h
___
d
On Thu, Aug 17, 2017 at 10:33 PM, Greg KH wrote:
> On Tue, Aug 08, 2017 at 09:15:42PM +0530, Bhumika Goyal wrote:
>> Make the structure const as it is only passed to the function
>> drm_fb_helper_prepare and the corresponding argument is of type
>> const.
>> Done using Coccinelle.
>>
>> Signed-off
From: Dexuan Cui
Date: Thu, 17 Aug 2017 08:00:29 +
> @@ -73,6 +74,10 @@ struct vmci_transport_recv_pkt_info {
> struct vmci_transport_packet pkt;
> };
>
> +static bool skip_hypervisor_check;
> +module_param(skip_hypervisor_check, bool, 0444);
> +MODULE_PARM_DESC(hot_add, "If set, att
On Tue, Aug 08, 2017 at 09:15:42PM +0530, Bhumika Goyal wrote:
> Make the structure const as it is only passed to the function
> drm_fb_helper_prepare and the corresponding argument is of type
> const.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal
> ---
> drivers/staging/vboxvideo/vb
On Mon, Aug 07, 2017 at 03:30:10PM -0700, Luis R. Rodriguez wrote:
> prism54 is deprecated in favor of the p54pci device driver. Although
> only *one soul* had reported issues with it long ago Linux most Linux
> distributions these days just disable the device driver given the
> conflicts with the
On Wed, Aug 16, 2017 at 05:44:15PM +0300, Cihangir Akturk wrote:
> When building the kernel for the ARM architecture without setting
> CONFIG_AEABI, size of struct lov_user_md_v3 and struct lov_mds_md_v3
> differs, due to different alignment requirements of OABI and EABI.
>
> Marking the anonymous
On Mon, Aug 14, 2017 at 12:20:51PM -0400, James Simmons wrote:
> From: Robin Humble
>
> The security.capability xattr is used to implement File
> Capabilities in recent Linux versions. Capabilities are a
> fine grained approach to granting executables elevated
> privileges. eg. /bin/ping can have
On Mon, Aug 14, 2017 at 11:46:28AM -0400, James Simmons wrote:
> The headers for lustre/LNet for a long time lacked a clean separation in
> its internal headers which resulted in kernel specific data structures
> being exposed in user land code. This work unravels this mess and creates
> a clear se
> On Aug 17, 2017, at 3:55 PM, Stefan Hajnoczi wrote:
>
> On Thu, Aug 17, 2017 at 08:00:29AM +, Dexuan Cui wrote:
>>
>> Without the patch, vmw_vsock_vmci_transport.ko can automatically load
>> when an application creates an AF_VSOCK socket.
>>
>> This is the expected good behavior on VMwar
On Mon, Aug 14, 2017 at 04:01:17PM +0100, James Simmons wrote:
>
> > We want to concatonate join string one, a '/' character, string two and
> > then a NUL terminator. The destination buffer holds ori_gf->gf_pathlen
> > characters. The strlen() function returns the number of characters not
> > c
On Thu, Aug 17, 2017 at 08:00:29AM +, Dexuan Cui wrote:
>
> Without the patch, vmw_vsock_vmci_transport.ko can automatically load
> when an application creates an AF_VSOCK socket.
>
> This is the expected good behavior on VMware hypervisor, but as we
> are going to add hv_sock.ko (i.e. Hyper-
The following macro:
\#define INVALID_PARAM
{ \
dev_dbg(&spi->dev, "set: illegal input param"); \
return -EINVAL; \
}
affects control flow by having return statement. This is against
Linux Kernel Coding Style and should be avoided and therefore
this m
There is a typo in patch subject. Please drop this patch. I will send v2
with corrected subject.
Thanks,
Marcin
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> On Aug 16, 2017, at 12:15 AM, Dexuan Cui wrote:
>
>
> With the current code, when vsock_dequeue_accept() is removing a sock
> from the list, nothing prevents vsock_enqueue_accept() from adding a new
> sock into the list concurrently. We should add a lock to protect the list.
>
For the VMCI
The following macro:
\#define INVALID_PARAM
{ \
dev_dbg(&spi->dev, "set: illegal input param"); \
return -EINVAL; \
}
affects control flow by having return statement. This is against
Linux Kernel Coding Style and should be avoided and therefore
this m
From: Laurentiu Tudor
Throughout the driver we use == 0 / != 0 to check strcmp() returns except
this place, so fix it.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-mc/bus/dprc
On Thu, Aug 10, 2017 at 08:42:43PM +0300, Horia Geantă wrote:
>
> Patches 5-9 are the core of the patch set, adding the driver.
> For symmetric encryption the legacy ablkcipher interface is used; the
> plan is to convert to skcipher all CAAM frontends at once at a certain
> point in time.
I'm fine
> From: Dexuan Cui
> Sent: Wednesday, August 16, 2017 15:34
> > From: Jorgen S. Hansen [mailto:jhan...@vmware.com]
> > > Without the patch, vmw_vsock_vmci_transport.ko and vmw_vmci.ko can
> > > automatically load when an application creates an AF_VSOCK socket.
> > >
> > > This is the expected good
Without the patch, vmw_vsock_vmci_transport.ko can automatically load
when an application creates an AF_VSOCK socket.
This is the expected good behavior on VMware hypervisor, but as we
are going to add hv_sock.ko (i.e. Hyper-V transport for AF_VSOCK), we
should make sure vmw_vsock_vmci_transport.
45 matches
Mail list logo
