Re: [PATCH] staging: lustre: uapi: properly include lustre_errno.h

2017-08-18 Thread Greg Kroah-Hartman
On Fri, Aug 18, 2017 at 11:04:14PM -0400, James Simmons wrote: > The path for lustre_errno.h was not updated to the new path > for errno.c. Also the header lustre_net.h uses code found in > lustre_errno.h but doesn't include the header directly. It > is easy to forget to add the header

Re: [staging:staging-testing 306/323] drivers/staging/lustre/lustre/ptlrpc/errno.c:29:44: fatal error: ../include/lustre/lustre_errno.h: No such file or directory

2017-08-18 Thread Greg Kroah-Hartman
On Sat, Aug 19, 2017 at 02:50:48AM +0100, James Simmons wrote: > > > On Fri, Aug 18, 2017 at 03:53:56PM -0700, Greg Kroah-Hartman wrote: > > > On Sat, Aug 19, 2017 at 02:49:02AM +0800, kbuild test robot wrote: > > > > tree: > > > >

[PATCH] staging: lustre: uapi: properly include lustre_errno.h

2017-08-18 Thread James Simmons
The path for lustre_errno.h was not updated to the new path for errno.c. Also the header lustre_net.h uses code found in lustre_errno.h but doesn't include the header directly. It is easy to forget to add the header lustre_errno.h before including lustre_net.h so it is just easier to include

Re: [staging:staging-testing 306/323] drivers/staging/lustre/lustre/ptlrpc/errno.c:29:44: fatal error: ../include/lustre/lustre_errno.h: No such file or directory

2017-08-18 Thread James Simmons
> On Fri, Aug 18, 2017 at 03:53:56PM -0700, Greg Kroah-Hartman wrote: > > On Sat, Aug 19, 2017 at 02:49:02AM +0800, kbuild test robot wrote: > > > tree: > > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > > staging-testing > > > head:

Re: [staging:staging-testing 306/323] drivers/staging/lustre/lustre/ptlrpc/errno.c:29:44: fatal error: ../include/lustre/lustre_errno.h: No such file or directory

2017-08-18 Thread Greg Kroah-Hartman
On Fri, Aug 18, 2017 at 03:54:58PM -0700, Greg Kroah-Hartman wrote: > On Fri, Aug 18, 2017 at 03:53:56PM -0700, Greg Kroah-Hartman wrote: > > On Sat, Aug 19, 2017 at 02:49:02AM +0800, kbuild test robot wrote: > > > tree: > > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git

Re: [PATCH] staging: lustre: lustre: Off by two in lmv_fid2path()

2017-08-18 Thread Dilger, Andreas
> On Aug 17, 2017, at 09:47, Greg Kroah-Hartman > wrote: > > On Mon, Aug 14, 2017 at 04:01:17PM +0100, James Simmons wrote: >> >>> We want to concatonate join string one, a '/' character, string two and >>> then a NUL terminator. The destination buffer holds

Re: [PATCH] vmbus: add per-channel sysfs info

2017-08-18 Thread Stephen Hemminger
On Fri, 18 Aug 2017 15:59:49 -0700 Greg KH wrote: > On Fri, Aug 18, 2017 at 02:42:14PM -0700, Stephen Hemminger wrote: > > This extends existing vmbus related sysfs structure to provide per-channel > > state information. This is useful when diagnosing issues with multiple > >

Re: [PATCH] staging: lustre: fix structure size for ARM OABI

2017-08-18 Thread Dilger, Andreas
On Aug 17, 2017, at 10:26, Greg KH wrote: > > On Wed, Aug 16, 2017 at 05:44:15PM +0300, Cihangir Akturk wrote: >> When building the kernel for the ARM architecture without setting >> CONFIG_AEABI, size of struct lov_user_md_v3 and struct lov_mds_md_v3 >> differs, due

RE: [PATCH] vsock: only load vmci transport on VMware hypervisor by default

2017-08-18 Thread Dexuan Cui
> From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > > CID is not really used by us, because we only support guest<->host > communication, > > and don't support guest<->guest communication. The Hyper-V host > references > > every VM by VmID (which is invisible to the VM), and a VM can only talk

Re: [PATCH] vmbus: add per-channel sysfs info

2017-08-18 Thread Greg KH
On Fri, Aug 18, 2017 at 02:42:14PM -0700, Stephen Hemminger wrote: > This extends existing vmbus related sysfs structure to provide per-channel > state information. This is useful when diagnosing issues with multiple > queues in networking and storage. > > The existing sysfs only displayed

Re: [staging:staging-testing 306/323] drivers/staging/lustre/lustre/ptlrpc/errno.c:29:44: fatal error: ../include/lustre/lustre_errno.h: No such file or directory

2017-08-18 Thread Greg Kroah-Hartman
On Fri, Aug 18, 2017 at 03:53:56PM -0700, Greg Kroah-Hartman wrote: > On Sat, Aug 19, 2017 at 02:49:02AM +0800, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > staging-testing > > head: 4d64b24f1fd892842e4502c0ff9c0e6b8144efa0 > >

Re: [staging:staging-testing 306/323] drivers/staging/lustre/lustre/ptlrpc/errno.c:29:44: fatal error: ../include/lustre/lustre_errno.h: No such file or directory

2017-08-18 Thread Greg Kroah-Hartman
On Sat, Aug 19, 2017 at 02:49:02AM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: 4d64b24f1fd892842e4502c0ff9c0e6b8144efa0 > commit: 1c4e5aa23a78c16ac15966a7704fa8a6201be095 [306/323] staging: lustre: >

RE: [PATCH net-next 3/3] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)

2017-08-18 Thread Dexuan Cui
> From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Thursday, August 17, 2017 07:56 > To: Dexuan Cui > On Tue, Aug 15, 2017 at 10:18:41PM +, Dexuan Cui wrote: > > +static u32 hvs_get_local_cid(void) > > +{ > > + return VMADDR_CID_ANY; > > +} > > Interesting

[PATCH] vmbus: add per-channel sysfs info

2017-08-18 Thread Stephen Hemminger
This extends existing vmbus related sysfs structure to provide per-channel state information. This is useful when diagnosing issues with multiple queues in networking and storage. The existing sysfs only displayed information about the primary channel. The one place it reported multiple channels

RE: [PATCH net-next 2/3] vsock: fix vsock_dequeue/enqueue_accept race

2017-08-18 Thread Dexuan Cui
> From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Thursday, August 17, 2017 07:06 > > On Tue, Aug 15, 2017 at 10:15:39PM +, Dexuan Cui wrote: > > With the current code, when vsock_dequeue_accept() is removing a sock > > from the list, nothing prevents vsock_enqueue_accept() from

[PATCH] staging: rtl8188eu: add RNX-N150NUB support

2017-08-18 Thread Charles Milette
Add support for USB Device Rosewill RNX-N150NUB. VendorID: 0x0bda, ProductID: 0xffef Signed-off-by: Charles Milette --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c

Re: [PATCH] staging: wlan-ng: Fix sparse warning: cast to restricted __le16.

2017-08-18 Thread Ricardo Silva
Hi, On 08/09/2017 11:35 PM, AbdAllah-MEZITI wrote: > The same structure is used in both side, so we dont need to cast. I believe there were no casts there, but calls to le16_to_cpu(), meaning there was previously a bug or the data being accessed was really stored in little-endian format, so we

[staging:staging-testing 306/323] drivers/staging/lustre/lustre/ptlrpc/errno.c:29:44: fatal error: ../include/lustre/lustre_errno.h: No such file or directory

2017-08-18 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 4d64b24f1fd892842e4502c0ff9c0e6b8144efa0 commit: 1c4e5aa23a78c16ac15966a7704fa8a6201be095 [306/323] staging: lustre: uapi: migrate remaining uapi headers to uapi directory config:

Re: [staging:staging-testing 276/342] drivers/staging/lustre/lustre/include/lustre_net.h:2110:11: error: implicit declaration of function 'lustre_errno_hton'

2017-08-18 Thread Greg Kroah-Hartman
On Fri, Aug 18, 2017 at 03:05:22AM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: 8d2fa5c352a9e0f877281c2b4486347305a380db > commit: ce6e67f2ed110fdbb89bb76bca8c2b9d2ad6c736 [276/342] staging: lustre: >

[PATCH] staging: rtl8192e: Change fixed function names with "%s: ", __func__

2017-08-18 Thread ??????
From: Shurong Zhang Replace hard-coded function names in strings with "%s", __func__ in the dot11d.c file. Issue found by checkpatch.pl. Signed-off-by: Shurong Zhang --- drivers/staging/rtl8192e/dot11d.c | 4 ++-- 1 file changed, 2

Re: [PATCH net-next 3/3] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)

2017-08-18 Thread Stefan Hajnoczi
On Tue, Aug 15, 2017 at 10:18:41PM +, Dexuan Cui wrote: > +static u32 hvs_get_local_cid(void) > +{ > + return VMADDR_CID_ANY; > +} Interesting concept: the guest never knows its CID. This is nice from a live migration perspective. Currently VMCI and virtio adjust listen socket local

Re: [PATCH net-next 2/3] vsock: fix vsock_dequeue/enqueue_accept race

2017-08-18 Thread Stefan Hajnoczi
On Tue, Aug 15, 2017 at 10:15:39PM +, Dexuan Cui wrote: > With the current code, when vsock_dequeue_accept() is removing a sock > from the list, nothing prevents vsock_enqueue_accept() from adding a new > sock into the list concurrently. We should add a lock to protect the list. The listener

Re: [PATCH] vsock: only load vmci transport on VMware hypervisor by default

2017-08-18 Thread Stefan Hajnoczi
On Fri, Aug 18, 2017 at 03:07:30AM +, Dexuan Cui wrote: > > From: Jorgen S. Hansen [mailto:jhan...@vmware.com] > > Sent: Thursday, August 17, 2017 08:17 > > > > > > Putting aside nested virtualization, I want to load the transport (vmci, > > > Hyper-V, vsock) for which there is paravirtualized

[PATCH] staging/rts5208: fix incorrect shift to extract upper nybble

2017-08-18 Thread Colin King
From: Colin Ian King The mask of sns_key_info1 suggests the upper nybble is being extracted however the following shift of 8 bits is too large and always results in 0. Fix this by shifting only by 4 bits to correctly get the upper nybble. Detected by CoverityScan,

[PATCH] staging:wlan-ng Fix Multiple line dereference

2017-08-18 Thread Janani S
This patch fixes multiple line dereference warning reported by checkpatch script. Signed-off-by: Janani S --- drivers/staging/wlan-ng/hfa384x_usb.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c

[PATCH] [PATCH] staging:wlan-ng Fix Multiple line dereference

2017-08-18 Thread Janani S
This patch fixes multiple line dereference warning reported by checkpatch script. Signed-off-by: Janani S --- drivers/staging/wlan-ng/hfa384x_usb.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c