[PATCH] [media] staging: omap4iss: make v4l2_file_operations const

Make this const as it is only stored in a const field of a video_device structure. Signed-off-by: Bhumika Goyal --- drivers/staging/media/omap4iss/iss_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/o

[PATCH 3/3] staging: lustre: obdclass: fix checking for obd_init_checks()

The obd_init_checks() function can either return -EOVERFLOW or -EINVAL but we accidentally ignore -EINVAL returns. Signed-off-by: Dan Carpenter --- This patch is the right thing, but it's always a bit risky turning on new checks and I haven't tested this. diff --git a/drivers/staging/lustre/lust

[PATCH 2/3] staging: lustre: obdclass: return -EFAULT if copy_from_user() fails

The copy_from_user() function returns the number of bytes which we weren't able to copy. We don't want to return that to the user but instead we want to return -EFAULT. Fixes: d7e09d0397e8 ("staging: add Lustre file system client support") Signed-off-by: Dan Carpenter diff --git a/drivers/stagi

[PATCH 1/3] staging: lustre: obdclass: return -EFAULT if copy_to_user() fails

We recently changed from using obd_ioctl_popdata() to calling copy_to_user() directly. This if statement was supposed to be deleted but it was over looked. "err" is zero at this point so it means we return success. Fixes: b03679f6a41a ("staging: lustre: uapi: remove obd_ioctl_popdata() wrapper"

Re: [PATCH] staging:rtl8712:xmit_linux.c: Avoid CamelCase

On Sat, 2017-08-26 at 01:21 +0530, Harsha Sharma wrote: > Hello, > > Sorry, this was my first contribution in linux-kernel. I will take care > about this from next time. > Do I need to send these patches once again one by one? No, just pick the "best" one of what you sent without any of the "styl

[PATCH v3 net-next 1/1] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)

Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It uses VMBus ringbuffer as the transportation layer. With hv_sock, applications between the host (Windows 10, Windows Server 2016 or newer) and the guest can talk with each other using

Re: [PATCH] staging: rtlwifi: Improve debugging by using debugfs

Fri, Aug 25, 2017 at 7:16 AM, Andrew Lunn wrote: > On Fri, Aug 25, 2017 at 08:47:00AM -0500, Larry Finger wrote: >> On 08/24/2017 08:54 PM, Andrew Lunn wrote: >> >netdev frowns upon debugfs. You should try to keep this altogether, >> >making it easy to throw away before the driver is moved out of

Re: [PATCH 00/14] VME: Adjustments for several function implementations

On Fri, Aug 25, 2017 at 05:41:13PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 25 Aug 2017 13:15:43 +0200 > > Several update suggestions were taken into account > from static source code analysis. > > Markus Elfring (14): > Delete 11 error messages for a failed memory a

Re: [PATCH 13/15] scsi: make device_type const

Bhumika, > Make these const as they are only stored in the type field of a device > structure, which is const. Applied to 4.14/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations

On Fri, Aug 25, 2017 at 06:15:08PM +0200, SF Markus Elfring wrote: > @@ -2363,5 +2364,5 @@ static int tsi148_probe(struct pci_dev *pdev, const > struct pci_device_id *id) > master_num--; > > tsi148_device->flush_image = > - kmalloc(sizeof(struct

Re: [PATCH] staging: most: hdm_usb: Driver registration with module_driver macro

On Fri, Aug 25, 2017 at 06:36:18PM +0300, Alex Briskin wrote: > 1. Remove redundant functions. > 2. Remove potentially missleading return code (-EIO). > 3. Add module_driver driver registration macro. > * Will also remove pr_info messages. If you have a list of things your patch does, that's a hug

Re: [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG() Signed-off-by: harsha

On Fri, Aug 25, 2017 at 11:04:27PM +0530, harsha wrote: > --- > drivers/staging/android/ion/ion.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ion/ion.c > b/drivers/staging/android/ion/ion.c > index 93e2c90..a2d36b3 100644 > --- a/drivers/stagi

[PATCH] staging: typec: Add __printf verification

Adding __printf verification can help avoid format/argument mismatches. Signed-off-by: Joe Perches --- drivers/staging/typec/tcpm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c index a911cad41a59..d4decb048efa 100644 --- a/d

Re: [PATCH] staging:rtl8712:xmit_linux.c: Avoid CamelCase

On Fri, 2017-08-25 at 23:21 +0530, harsha wrote: > Signed-off-by: harsha Hello Harsha. It seems you are pretty new at this. Please try to send one patch and have that accepted before sending more. There are many details that need to be known by you before you get the process down and it takes

Re: [PATCH 03/13] ANDROID: binder: add support for RT prio inheritance.

Hi Thomas, On Fri, Aug 25, 2017 at 5:08 PM, Thomas Gleixner wrote: > Sorry, but this has not much to do with real priority inheritance. Can you clarify what "real priority inheritance" is, or are you more concerned about this particular implementation of it? > > It's a poor mans pseudo PI imple

[PATCH] staging:rtl8712:rtl871x_xmit.c : Removed unnecessary blank line

Signed-off-by: harsha --- drivers/staging/rtl8712/rtl871x_xmit.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c index 4e28209..6ecfe0f 100644 --- a/drivers/staging/rtl8712/rtl871x_xmit.c +++ b/drivers/staging/rtl

[PATCH] staging:unisys:visornic:visornic_main.c: Avoid multiple line derefernece

Signed-off-by: harsha --- drivers/staging/unisys/visornic/visornic_main.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c index 0b39676..57fc65f 100644 --- a/drivers/stagi

[PATCH] staging:unisys:visorbus:visorchipset.c: Declared char * array as static const

Signed-off-by: harsha --- drivers/staging/unisys/visorbus/visorchipset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c index 6d4498f..6f2a010 100644 --- a/drivers/staging/uni

[PATCH] staging:unisys:visorbus:visorchipset.c: Added a blank line after function declaration

Signed-off-by: harsha --- drivers/staging/unisys/visorbus/visorchipset.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c index 6f2a010..6789c04 100644 --- a/drivers/staging/unisys/visorbus/visorch

[PATCH] staging:typec:tcpm.c : Fixed warning line over 80 characters Signed-off-by: harsha

--- drivers/staging/typec/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c index a30c01b..630fe75 100644 --- a/drivers/staging/typec/tcpm.c +++ b/drivers/staging/typec/tcpm.c @@ -991,7 +991,7 @@ static void svdm_

[PATCH] Staging:typec:tcpm.c : Fixed error Macros with complex values should be enclosed in parentheses Added comment after spinlock_t_definition Signed-off-by: harsha

--- drivers/staging/typec/tcpm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c index b800313..a30c01b 100644 --- a/drivers/staging/typec/tcpm.c +++ b/drivers/staging/typec/tcpm.c @@ -217,7 +217,9 @@ struct tcpm_po

[PATCH] staging:typec:tcpm.c: Fixed check by adding comment after spinlock_t definition

Signed-off-by: harsha --- drivers/staging/typec/tcpm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c index 9f4a5a5..9ab8d82 100644 --- a/drivers/staging/typec/tcpm.c +++ b/drivers/staging/typec/tcpm.c @@ -217,9 +

[PATCH] staging:typec:tcpm.c : Comparison to null changed as "!port->partner_altmode[pmdata->altmodes]"

--- drivers/staging/typec/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c index 630fe75..9f4a5a5 100644 --- a/drivers/staging/typec/tcpm.c +++ b/drivers/staging/typec/tcpm.c @@ -982,7 +982,7 @@ static void svdm_

[PATCH] staging:rtl8712:xmit_linux.c: Removed unnecessary blank line

Signed-off-by: harsha --- drivers/staging/rtl8712/xmit_linux.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c index 03c6b0c..5d915c9 100644 --- a/drivers/staging/rtl8712/xmit_linux.c +++ b/drivers/staging/rtl8712/xmi

[PATCH] staging:rtl8712:xmit_linux.c: Avoid CamelCase

Signed-off-by: harsha --- drivers/staging/rtl8712/xmit_linux.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c index 5d915c9..fd3380d 100644 --- a/drivers/staging/rtl8712/xmit_linux.c +

[PATCH] staging:rtl8712:usb_ops_linux.c: Removed unnecessary parentheses around pio_q->intf

Signed-off-by: harsha --- drivers/staging/rtl8712/usb_ops_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/usb_ops_linux.c b/drivers/staging/rtl8712/usb_ops_linux.c index 32bac18..31f204a 100644 --- a/drivers/staging/rtl8712/usb_ops_linux.c +++

[PATCH] staging:rtl8712:usb_ops_linux.c: Removed paragraoh about writing to Free Software Foundation's mailing address

Signed-off-by: harsha --- drivers/staging/rtl8712/usb_ops_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/usb_ops_linux.c b/drivers/staging/rtl8712/usb_ops_linux.c index 441e76b..32bac18 100644 --- a/drivers/staging/rtl8712/usb_ops_linux.c ++

[PATCH] staging:rtl8712:usb_ops_linux.c: Avoid CamelCase

Signed-off-by: harsha --- drivers/staging/rtl8712/usb_ops_linux.c | 35 + 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/drivers/staging/rtl8712/usb_ops_linux.c b/drivers/staging/rtl8712/usb_ops_linux.c index 31f204a..7939902 100644 --- a/drivers/

[PATCH] staging:rtl8712:usb_ops.c: Removed paragraph about writing to Free Software Foundation's mailing address

Signed-off-by: harsha --- drivers/staging/rtl8712/usb_ops.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/usb_ops.c b/drivers/staging/rtl8712/usb_ops.c index 332e2e5..e5d28b4 100644 --- a/drivers/staging/rtl8712/usb_ops.c +++ b/drivers/staging/rtl8

[PATCH] staging:rtl8712:rtl871x_xmit.c: Removed unnecessary spaces after cast

Signed-off-by: harsha --- drivers/staging/rtl8712/rtl871x_xmit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c index e9af897..13c81680 100644 --- a/drivers/staging/rtl8712/rtl871x_xmit.c +++

[PATCH] staging:rtl8712:rtl871x_xmit.c: break line over 80 characters

Signed-off-by: harsha --- drivers/staging/rtl8712/rtl871x_xmit.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c index 6ecfe0f..e9af897 100644 --- a/drivers/staging/rtl8712/rtl871x_xmit.c ++

[PATCH] staging:rtl8712:rt871x_xmit.c: Removed the paragraph about writing to the Free Software Foundation's mailing address

Signed-off-by: harsha --- drivers/staging/rtl8712/rtl871x_xmit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c index eda2aee..4e28209 100644 --- a/drivers/staging/rtl8712/rtl871x_xmit.c +++ b/

[PATCH] staging:rt8712:xmit_linux.c: removed paragraph about writing to the Free software Foundation's mailing list

Signed-off-by: harsha --- drivers/staging/rtl8712/xmit_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c index 4ee4136..d13fd15 100644 --- a/drivers/staging/rtl8712/xmit_linux.c +++ b/drivers/

[PATCH] staging:rt8712:xmit_linux.c: Avoid multiple assignments in a single line

Signed-off-by: harsha --- drivers/staging/rtl8712/xmit_linux.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c index d13fd15..03c6b0c 100644 --- a/drivers/staging/rtl8712/xmit_linux.c +++ b/driv

[PATCH] Staging:android:ion:ion_system_heap.c : Using WARN_ON() rather than BUG_ON() Signed-off-by: harsha

--- drivers/staging/android/ion/ion_system_heap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c index 4dc5d7a..46125bc 100644 --- a/drivers/staging/android/ion/ion_system_heap.c +

[PATCH] Staging:android:ion:ion_heap.c : Using WARN_ON() rather than BUG_ON()

--- drivers/staging/android/ion/ion_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_heap.c b/drivers/staging/android/ion/ion_heap.c index 91faa7f..476e741 100644 --- a/drivers/staging/android/ion/ion_heap.c +++ b/drivers/staging/android/i

[PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG() Signed-off-by: harsha

--- drivers/staging/android/ion/ion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 93e2c90..a2d36b3 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/android/ion/ion.c @@ -66,7 +6

[PATCH v2 0/2] vmbus: sysfs extensions

This adds additional sysfs information about vmbus multi-channel devices that helps with diagnosing performance and other issues. Stephen Hemminger (2): vmbus: add per-channel sysfs info vmbus: expose per-channel interrupts and events counters v2 - adds interrupt information drivers/hv/chan

[PATCH v2 2/2] vmbus: expose per-channel interrupts and events counters

When investigating performance, it is useful to be able to look at the number of host and guest events per-channel. This is equivalent to per-device interrupt statistics. Signed-off-by: Stephen Hemminger --- drivers/hv/connection.c | 2 ++ drivers/hv/vmbus_drv.c | 16 include/

[PATCH v2 1/2] vmbus: add per-channel sysfs info

This extends existing vmbus related sysfs structure to provide per-channel state information. This is useful when diagnosing issues with multiple queues in networking and storage. The existing sysfs only displayed information about the primary channel. The one place it reported multiple channels w

RE: [PATCH v1] staging: unisys: visorinput: Add module_driver driver registration

> -Original Message- > From: Alex Briskin [mailto:br.shu...@gmail.com] > Sent: Friday, August 25, 2017 12:25 PM > To: *S-Par-Maintainer > Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org > Subject: [PATCH v1] staging: unisys: visorinput: Add module_driver driver > registration >

Re: [PATCH v2] staging: most: hdm_usb: Driver registration with module_driver macro

On Fri, Aug 25, 2017 at 06:40:18PM +0300, Alex Briskin wrote: > 1. Remove redundant functions. > 2. Remove potentially missleading return code (-EIO). > 3. Add module_driver driver registration macro. s/module_driver/module_usb_driver/ /andy > * Will also remove pr_info messages. > > Signed-off-

Re: [PATCH v2] staging: most: hdm_usb: Driver registration with module_driver macro

OK got it On 08/25/2017 07:19 PM, Andrey Shvetsov wrote: On Fri, Aug 25, 2017 at 06:40:18PM +0300, Alex Briskin wrote: 1. Remove redundant functions. 2. Remove potentially missleading return code (-EIO). 3. Add module_driver driver registration macro. s/module_driver/module_usb_driver/ /andy

[PATCH v1] staging: unisys: visorinput: Add module_driver driver registration

1. Remove module_init()/module_exit() macroes and visorbus_register_visor_driver/visorbus_unregister_visor_driver functions. 2. Replace with a short module_driver macro Signed-off-by: Alex Briskin --- drivers/staging/unisys/visorinput/visorinput.c | 14 ++ 1 file changed, 2 insertion

Re: [PATCH] staging: most: hdm_usb: Driver registration with module_driver macro

Alex, On Fri, Aug 25, 2017 at 06:26:03PM +0300, Alex Briskin wrote: > Hi Andy, > I'm not sure what to make from your comment. I meant instead of module_driver(hdm_usb, usb_register, usb_deregister); use module_usb_driver(hdm_usb); since $ grep def.*module_usb_driver include

[PATCH 14/14] vme: tsi148: Adjust 14 checks for null pointers

From: Markus Elfring Date: Fri, 25 Aug 2017 12:00:17 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code pla

[PATCH 13/14] vme: tsi148: Improve 17 size determinations

From: Markus Elfring Date: Fri, 25 Aug 2017 11:55:03 +0200 Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus

[PATCH 12/14] vme: tsi148: Delete nine error messages for a failed memory allocation

From: Markus Elfring Date: Fri, 25 Aug 2017 11:10:07 +0200 Omit extra messages for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/vme/bridges/vme_tsi148.c | 18 -- 1 file chang

[PATCH 11/14] vme: ca91cx42: Adjust 14 checks for null pointers

From: Markus Elfring Date: Fri, 25 Aug 2017 11:01:29 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code pla

[PATCH 10/14] vme: ca91cx42: Improve 12 size determinations

From: Markus Elfring Date: Fri, 25 Aug 2017 10:56:41 +0200 Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus

[PATCH 09/14] vme: ca91cx42: Delete eight error messages for a failed memory allocation

From: Markus Elfring Date: Fri, 25 Aug 2017 10:20:03 +0200 Omit extra messages for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/vme/bridges/vme_ca91cx42.c | 16 1 file chang

[PATCH 08/14] vme: fake: Adjust 11 checks for null pointers

From: Markus Elfring Date: Fri, 25 Aug 2017 10:01:16 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code pla

[PATCH 07/14] vme: fake: Improve five size determinations in fake_init()

From: Markus Elfring Date: Fri, 25 Aug 2017 09:46:13 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detec

[PATCH 06/14] vme: fake: Delete an error message for a failed memory allocation in fake_init()

From: Markus Elfring Date: Fri, 25 Aug 2017 09:31:46 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/vme/bridges/vme_fake.c | 1 - 1 file changed, 1 deletion(-) d

[PATCH 05/14] vme: Return directly in two functions

From: Markus Elfring Date: Thu, 24 Aug 2017 22:32:14 +0200 Return directly without using an intermediate local variable in these functions. Signed-off-by: Markus Elfring --- drivers/vme/vme.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/vme/vme.c b/dri

[PATCH 02/14] vme: Improve 11 size determinations

From: Markus Elfring Date: Thu, 24 Aug 2017 21:52:00 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detec

[PATCH 04/14] vme: Adjust 48 checks for null pointers

From: Markus Elfring Date: Thu, 24 Aug 2017 22:24:38 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code pla

[PATCH 03/14] vme: Move an assignment in vme_new_dma_list()

From: Markus Elfring Date: Thu, 24 Aug 2017 22:04:45 +0200 Assign a pointer to a data structure member without using an intermediate local variable. Signed-off-by: Markus Elfring --- drivers/vme/vme.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/vme/vme.c

[PATCH 01/14] vme: Delete 11 error messages for a failed memory allocation

From: Markus Elfring Date: Thu, 24 Aug 2017 21:38:20 +0200 Omit extra messages for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/vme/vme.c | 51 ---

[PATCH 00/14] VME: Adjustments for several function implementations

From: Markus Elfring Date: Fri, 25 Aug 2017 13:15:43 +0200 Several update suggestions were taken into account from static source code analysis. Markus Elfring (14): Delete 11 error messages for a failed memory allocation Improve 11 size determinations Move an assignment in vme_new_dma_list

[PATCH v2] staging: most: hdm_usb: Driver registration with module_driver macro

1. Remove redundant functions. 2. Remove potentially missleading return code (-EIO). 3. Add module_driver driver registration macro. * Will also remove pr_info messages. Signed-off-by: Alex Briskin --- drivers/staging/most/hdm-usb/hdm_usb.c | 20 +--- 1 file changed, 1 insertion(

[PATCH] staging: most: hdm_usb: Driver registration with module_driver macro

1. Remove redundant functions. 2. Remove potentially missleading return code (-EIO). 3. Add module_driver driver registration macro. * Will also remove pr_info messages. Signed-off-by: Alex Briskin --- drivers/staging/most/hdm-usb/hdm_usb.c | 20 +--- 1 file changed, 1 insertion(

Re: [PATCH 03/13] ANDROID: binder: add support for RT prio inheritance.

On Fri, 25 Aug 2017, Martijn Coenen wrote: > Adds support for SCHED_BATCH/SCHED_FIFO/SCHED_RR > priority inheritance. Sorry, but this has not much to do with real priority inheritance. It's a poor mans pseudo PI implementation. What I can't see from the sparse changelog is how all of this is sup

Re: [PATCH] staging: most: hdm_usb: Driver registration with module_driver macro

Hi Andy, I'm not sure what to make from your comment. I stand by my patch. According to device.h module_driver is a variadic macro requiring at least 3 parameters. Please see below quote: /** * module_driver() - Helper macro for drivers that don't do anything * special in module init/exit. Thi

Re: [PATCH] staging: rtlwifi: Improve debugging by using debugfs

On Fri, Aug 25, 2017 at 08:47:00AM -0500, Larry Finger wrote: > On 08/24/2017 08:54 PM, Andrew Lunn wrote: > >netdev frowns upon debugfs. You should try to keep this altogether, > >making it easy to throw away before the driver is moved out of > >staging. > > > >You might want to look at ethtool -d

[PATCH] staging: vboxvideo: Use fbdev helpers where possible

This results in a nice cleanup, and fixes link errors when fbdev support is disabled. Signed-off-by: Hans de Goede --- drivers/staging/vboxvideo/vbox_fb.c | 150 +++- 1 file changed, 9 insertions(+), 141 deletions(-) diff --git a/drivers/staging/vboxvideo/vbox_fb

Re: [PATCH] staging: r8822be: remove some dead code

On 08/25/2017 03:42 AM, Dan Carpenter wrote: "hdr" can't be NULL. We take skb->data which is non-NULL and add an offset to get "hdr". Signed-off-by: Dan Carpenter Thanks. Looks good. Acked-by: Larry Finger Larry ___ devel mailing list de...@linu

Re: [PATCH] staging: rtlwifi: Improve debugging by using debugfs

On 08/24/2017 08:54 PM, Andrew Lunn wrote: netdev frowns upon debugfs. You should try to keep this altogether, making it easy to throw away before the driver is moved out of staging. You might want to look at ethtool -d. That will be accepted. Andrew, What is the problem with debugfs? Please

Re: [PATCH] staging: most: hdm_usb: Driver registration with module_driver macro

On Fri, Aug 25, 2017 at 12:47:33PM +0300, Alex Briskin wrote: > 1. Remove redundant functions. > 2. Remove potentially misleading return code (-EIO). > 3. Add module_driver driver registration macro. > * Will also remove pr_info messages. > > Signed-off-by: Alex Briskin > --- > drivers/staging/m

Re: [PATCH 02/15] drm: make device_type const

On Sat, Aug 19, 2017 at 01:52:13PM +0530, Bhumika Goyal wrote: > Make these const as they are only stored in the type field of a device > structure, which is const. > Done using Coccinelle. I can't apply this, it's missing your s-o-b line. You can just replay with that. Thanks, Daniel > --- > d

Re: [PATCH] tools: hv: handle EINTR in hv_fcopy_daemon

On Fri, Aug 25, Vitaly Kuznetsov wrote: > Shall we request SA_RESTART with sigaction() in all three daemons instead? If that works better, probably yes. Olaf signature.asc Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org

[PATCH] Drivers: hv: fcopy: restore correct transfer length

Prior commit c7e490fc23eb the expected length of bytes read by the daemon did depend on the context. It was either hv_start_fcopy or hv_do_fcopy. The daemon had a buffer size of two pages, which was much larger than needed. Since commit c7e490fc23eb the expected length of bytes read by the daemon

Re: [PATCH] tools: hv: handle EINTR in hv_fcopy_daemon

Olaf Hering writes: > If strace attaches to the daemon pread returns with EINTR, and the > process exits. Catch this case and continue with the next iteration. > > Signed-off-by: Olaf Hering > --- > tools/hv/hv_fcopy_daemon.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/hv/h

[PATCH] tools: hv: handle EINTR in hv_fcopy_daemon

If strace attaches to the daemon pread returns with EINTR, and the process exits. Catch this case and continue with the next iteration. Signed-off-by: Olaf Hering --- tools/hv/hv_fcopy_daemon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv/hv_fcopy_d

[PATCH] staging: most: hdm_usb: Driver registration with module_driver macro

1. Remove redundant functions. 2. Remove potentially misleading return code (-EIO). 3. Add module_driver driver registration macro. * Will also remove pr_info messages. Signed-off-by: Alex Briskin --- drivers/staging/most/hdm-usb/hdm_usb.c | 20 +--- 1 file changed, 1 insertion(+

[PATCH] staging: most: hdm_usb: Driver registration with module_driver macro

1. Remove redundant functions. 2. Remove potentially missleading return code (-EIO). 3. Add module_driver driver registration macro. * Will also remove pr_info messages. Signed-off-by: Alex Briskin --- drivers/staging/most/hdm-usb/hdm_usb.c | 20 +--- 1 file changed, 1 insertion(

[PATCH 12/13] ANDROID: binder: don't queue async transactions to thread.

This can cause issues with processes using the poll() interface: 1) client sends two oneway transactions 2) the second one gets queued on async_todo (because the server didn't handle the first one yet) 3) server returns from poll(), picks up the first transaction and does transaction wor

[PATCH 03/13] ANDROID: binder: add support for RT prio inheritance.

Adds support for SCHED_BATCH/SCHED_FIFO/SCHED_RR priority inheritance. Signed-off-by: Martijn Coenen --- drivers/android/binder.c | 164 ++- 1 file changed, 135 insertions(+), 29 deletions(-) diff --git a/drivers/android/binder.c b/drivers/android/bin

[PATCH 13/13] ANDROID: binder: Add tracing for binder priority inheritance.

This allows to easily trace and visualize priority inheritance in the binder driver. Change-Id: I8449ae4b002e55c5e9517a47f3581e05eef051d8 Signed-off-by: Martijn Coenen --- drivers/android/binder.c | 4 drivers/android/binder_trace.h | 24 2 files changed, 28

[PATCH 05/13] ANDROID: binder: improve priority inheritance.

By raising the priority of a thread selected for a transaction *before* we wake it up. Delay restoring the priority when doing a reply until after we wake-up the process receiving the reply. Signed-off-by: Martijn Coenen --- drivers/android/binder.c | 74 ++--

[PATCH 04/13] ANDROID: binder: add min sched_policy to node.

This change adds flags to flat_binder_object.flags to allow indicating a minimum scheduling policy for the node. It also clarifies the valid value range for the priority bits in the flags. Internally, we use the priority map that the kernel uses, e.g. [0..99] for real-time policies and [100..139]

[PATCH 09/13] ANDROID: binder: Don't BUG_ON(!spin_is_locked()).

Because is_spin_locked() always returns false on UP systems. Use assert_spin_locked() instead, and remove the WARN_ON() instances, since those were easy to verify. Signed-off-by: Martijn Coenen --- drivers/android/binder.c | 26 ++ 1 file changed, 10 insertions(+), 16 de

[PATCH 02/13] ANDROID: binder: push new transactions to waiting threads.

Instead of pushing new transactions to the process waitqueue, select a thread that is waiting on proc work to handle the transaction. This will make it easier to improve priority inheritance in future patches, by setting the priority before we wake up a thread. If we can't find a waiting thread, s

[PATCH 11/13] ANDROID: binder: don't enqueue death notifications to thread todo.

This allows userspace to request death notifications without having to worry about getting an immediate callback on the same thread; one scenario where this would be problematic is if the death recipient handler grabs a lock that was already taken earlier (eg as part of a nested transaction). Sign

[PATCH 10/13] ANDROID: binder: call poll_wait() unconditionally.

Because we're not guaranteed that subsequent calls to poll() will have a poll_table_struct parameter with _qproc set. When _qproc is not set, poll_wait() is a noop, and we won't be woken up correctly. Signed-off-by: Martijn Coenen --- drivers/android/binder.c | 11 +-- 1 file changed, 1

[PATCH 08/13] ANDROID: binder: don't check prio permissions on restore.

Because we have disabled RT priority inheritance for the regular binder domain, the following can happen: 1) thread A (prio 98) calls into thread B 2) because RT prio inheritance is disabled, thread B runs at the lowest nice (prio 100) instead 3) thread B calls back into A; A will run at prio 1

[PATCH 07/13] Add BINDER_GET_NODE_DEBUG_INFO ioctl

From: Colin Cross The BINDER_GET_NODE_DEBUG_INFO ioctl will return debug info on a node. Each successive call reusing the previous return value will return the next node. The data will be used by libmemunreachable to mark the pointers with kernel references as reachable. Signed-off-by: Colin C

[PATCH 06/13] ANDROID: binder: add RT inheritance flag to node.

Allows a binder node to specify whether it wants to inherit real-time scheduling policy from a caller. Signed-off-by: Martijn Coenen --- drivers/android/binder.c| 22 +- include/uapi/linux/android/binder.h | 8 2 files changed, 25 insertions(+), 5 deleti

[PATCH 01/13] ANDROID: binder: remove proc waitqueue

Removes the process waitqueue, so that threads can only wait on the thread waitqueue. Whenever there is process work to do, pick a thread and wake it up. This also fixes an issue with using epoll(), since we no longer have to block on different waitqueues. Signed-off-by: Martijn Coenen --- driv

[PATCH 00/13] ANDROID: binder: RT priority inheritance and small fixes.

The first six patches in this set introduce support for priority inheritance of real-time scheduling policies in binder. With the introduction of Android Treble, functionality that used to be in a single process is now split over two or more processes, which communicate using binder IPC. For latenc

[PATCH] staging: r8822be: remove some dead code

"hdr" can't be NULL. We take skb->data which is non-NULL and add an offset to get "hdr". Signed-off-by: Dan Carpenter diff --git a/drivers/staging/rtlwifi/rtl8822be/trx.c b/drivers/staging/rtlwifi/rtl8822be/trx.c index 123e83bd6e82..38f80e48a399 100644 --- a/drivers/staging/rtlwifi/rtl8822be/t

[PATCH] staging: pi433: fix interrupt handler signatures

Remove "struct pt_regs *" parameter from interrupt handlers, since it is no longer passed to interrupt handlers. Also, convert return types to irqreturn_t. Additionally, move DIO_irq_handler variable into the setup_GPIO function, as it's not used outside of this function. Signed-off-by: Cihangir