Re: [PATCH 13/31] timer: Remove meaningless .data/.function assignments

On Thu, Aug 31, 2017 at 04:29:25PM -0700, Kees Cook wrote: > Several timer users needlessly reset their .function/.data fields during > their timer callback, but nothing else changes them. Some users do not > use their .data field at all. Each instance is removed here. > > Cc: Krzysztof Halasa

Re: [PATCH 26/31] staging/comedi/das16: Make timer initialization unconditional

On Thu, Aug 31, 2017 at 04:29:38PM -0700, Kees Cook wrote: > With timer initialization made unconditional, there is no reason to > make del_timer_sync() calls conditionally, there by removing the test > of the .data field. > > Cc: Ian Abbott > Cc: H Hartley Sweeten

[PATCH 26/31] staging/comedi/das16: Make timer initialization unconditional

With timer initialization made unconditional, there is no reason to make del_timer_sync() calls conditionally, there by removing the test of the .data field. Cc: Ian Abbott Cc: H Hartley Sweeten Cc: Greg Kroah-Hartman

[PATCH 13/31] timer: Remove meaningless .data/.function assignments

Several timer users needlessly reset their .function/.data fields during their timer callback, but nothing else changes them. Some users do not use their .data field at all. Each instance is removed here. Cc: Krzysztof Halasa Cc: Aditya Shankar Cc:

[PATCH net-next 0/2] netvsc: transparent VF related cleanups

The first gets rid of unnecessary ref counting, and second allows removing hv_netvsc driver even if VF present. Stephen Hemminger (2): netvsc: cleanup datapath switch netvsc: allow driver to be removed even if VF is present drivers/net/hyperv/netvsc_drv.c | 55

[PATCH net-next 1/2] netvsc: cleanup datapath switch

Use one routine for datapath up/down. Don't need to reopen the rndis layer. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 38 +++--- 1 file changed, 7 insertions(+), 31 deletions(-) diff --git

[PATCH net-next 2/2] netvsc: allow driver to be removed even if VF is present

If VF is attached then can still allow netvsc driver module to be removed. Just have to make sure and do the cleanup. Also, avoid extra rtnl round trip when calling unregister. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 17 +

RE: [PATCHv2] hv_set_ifconfig.sh double check before setting ip

> -Original Message- > From: Eduardo Otubo [mailto:ot...@redhat.com] > Sent: Thursday, August 31, 2017 1:17 AM > To: KY Srinivasan > Cc: Haiyang Zhang ; Stephen Hemminger > ; linux-ker...@vger.kernel.org; >

Re: [PATCH v10 0/9] Hyper-V: paravirtualized remote TLB flushing and hypercall improvements

* Vitaly Kuznetsov wrote: > Ingo Molnar writes: > > > * Vitaly Kuznetsov wrote: > > > >> > Changes since v9: > >> > - Rebase to 4.13-rc3. > >> > - Drop PATCH1 as it was already taken by Greg to char-misc tree. > >> > There're no >

[PATCH] android: binder: Add page usage in binder stats

Add the number of active, lru, and free pages for each binder process in binder stats Signed-off-by: Sherry Yang --- drivers/android/binder.c | 2 ++ drivers/android/binder_alloc.c | 28 drivers/android/binder_alloc.h | 2 ++ 3 files

Re: [PATCH v3 1/6] android: binder: Refactor prev and next buffer into a helper function

On Thu, Aug 31, 2017 at 10:30:27AM -0700, Sherry Yang wrote: > On Wed, Aug 30, 2017 at 9:28 PM, Greg Kroah-Hartman > wrote: > > Ok, exactly what git commit ids should I revert from the tree? But > > really, a fix would be easier at this point :) > > I sent a fixup

Re: [PATCH v3 1/6] android: binder: Refactor prev and next buffer into a helper function

On Wed, Aug 30, 2017 at 9:28 PM, Greg Kroah-Hartman wrote: > Ok, exactly what git commit ids should I revert from the tree? But > really, a fix would be easier at this point :) I sent a fixup patch as a separate reply to this email. Please also apply [patch v3 6/6]

[PATCH] android: binder: fixup crash introduced by moving buffer hdr

Fix crash introduced by 74310e06be4d74dcf67cd108366710dee5c576d5 (android: binder: Move buffer out of area shared with user space) when close is called after open without mmap in between. Signed-off-by: Sherry Yang --- drivers/android/binder_alloc.c | 2 +- 1 file changed,

[PATCH] drivers: staging: Add driver for Amplicon PCIe215

This is a small and simple driver for handling of external interrupt signal asserted on pins of Amplicon's PCIe215 board. There is already a Comedi driver subsystem in kernel which handles that (and more) board, but that framework while offering more flexibility brings also additional complexity

Re: [PATCH] staging: gdm724x: Rename variable for consistency

jonathan...@gctsemi.com, linux-ker...@vger.kernel.org Bcc: Subject: Re: [PATCH v2] staging : gdm724x: Rename variable for consistency Reply-To: In-Reply-To: <20170831162747.ga31...@kroah.com> Sorry for the confusion. This patch is a revision to an earlier patch I submitted that did not compile.

Re: [PATCH v2] staging : gdm724x: Rename variable for consistency

On Tue, Aug 29, 2017 at 11:11:29PM -0400, Nick Fox wrote: > v2: Undo the renaming of the dft_eps_id variable in hci_pdn_table_ind > to resolve a compiler error. What compiler error? Who reported it? And why put v2 here in the changelog area? totally confused, greg k-h

Re: [PATCH v3 00/11] Hookup typec power-negotation to the PMIC and charger

On Wed, Aug 30, 2017 at 11:48:03AM +0200, Hans de Goede wrote: > Hi All, > > Here is v3 of my typec power-negotation hookup series. New this version: > - Drop a few patches merged into linux-power-supply.git/for-next > - Drop the "power: supply: bq24190_charger: Remove extcon handling" > patch

Re: [PATCH v3] staging: most: hdm_usb: Register the driver with module_usb_driver macro

On Tue, Aug 29, 2017 at 08:27:44PM +0300, Alex Briskin wrote: > 1. Register the driver with module_usb_driver macro instead of module_init >and module_exit. > 2. Remove redundant code. > > Signed-off-by: Alex Briskin > --- > drivers/staging/most/hdm-usb/hdm_usb.c | 20

Re: [PATCH 0/4] staging: fsl-mc: dpio: add dpseci dependencies

On Wed, Aug 30, 2017 at 01:41:58PM +0300, Horia Geantă wrote: > This patch set adds support for functionalities needed by the upcoming > dpseci (Data Path SEC Interface) object device driver: > -Frame List Entries (FLEs) > -Congestion State Change Notifications (CSCNs) > -Order Preservation > >

Re: [PATCH 4/4] staging: fsl-dpaa2/eth: move generic FD defines to DPIO

On Wed, Aug 30, 2017 at 01:42:02PM +0300, Horia Geantă wrote: > Previous commits: > 6e2387e8f19e ("staging: fsl-dpaa2/eth: Add Freescale DPAA2 Ethernet driver") > 39163c0ce0f4 ("staging: fsl-dpaa2/eth: Errors checking update") > have added bits that are not specific to the WRIOP accelerator. > >

Re: [PATCH V3] staging:rtl8188eu:core Rename CamelCase variables

On Tue, Aug 29, 2017 at 05:01:20PM +0530, Janani Sankara Babu wrote: > This patch is created to solve the CamelCase issue. The members 'IEs' and > 'IELength' of struct wlan_bssid_ex are being modified to 'ie' and > 'ie_length' to solve the issue. And all the places where these variables > are

Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

On Mon, Aug 28, 2017 at 01:54:05PM +0300, laurentiu.tu...@nxp.com wrote: > From: Stuart Yoder > > Move the source files out of staging into their final locations: > -include files in drivers/staging/fsl-mc/include go to include/linux/fsl > -irq-gic-v3-its-fsl-mc-msi.c

[PATCH] staging: vboxvideo: Use CONFIG_DRM_KMS_FB_HELPER to check for fbdefio availability

Checking for CONFIG_FB_DEFERRED_IO is not the right thing to do since the fbdev code may be built as a module while vboxvideo is builtin. This can only happen when DRM_KMS_FB_HELPER is not set: a) DRM_VBOXVIDEO selects DRM_KMS_HELPER b) DRM_KMS_FB_HELPER depends on DRM_KMS_HELPER c)

Re: [PATCH v10 0/9] Hyper-V: paravirtualized remote TLB flushing and hypercall improvements

Ingo Molnar writes: > * Vitaly Kuznetsov wrote: > >> > Changes since v9: >> > - Rebase to 4.13-rc3. >> > - Drop PATCH1 as it was already taken by Greg to char-misc tree. There're >> > no >> > functional dependencies on this patch so the series can go

Re: [PATCH v3] staging: ks7010: Fix coding style and remove checkpatch.pl warnings.

Thank you for all of the feedback! On Thu, Aug 31, 2017 at 2:07 AM, Dan Carpenter wrote: > Thanks! > > regards, > dan carpenter > ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH v10 0/9] Hyper-V: paravirtualized remote TLB flushing and hypercall improvements

* Vitaly Kuznetsov wrote: > > Changes since v9: > > - Rebase to 4.13-rc3. > > - Drop PATCH1 as it was already taken by Greg to char-misc tree. There're no > > functional dependencies on this patch so the series can go through a > > different tree > > (and it actually

Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance.

On Thu, Aug 31, 2017 at 02:00:54PM +0200, Martijn Coenen wrote: > Appreciate if you could take a look! In particular I'm curious why > this approach is considered "dodgy", or "engineered sideways" as > Thomas pointed out earlier. The fact that you could not reuse rt_mutex makes me very nervous.

Re: [PATCH] staging:rtl8188eu:core Remove unneccessary else block

On Thu, Aug 31, 2017 at 05:03:30PM +0530, Janani Sankara Babu wrote: > This patch is created to remove the unneccessary else statement inside the > function 'SecIsInPMKIDList'. > > Signed-off-by: Janani Sankara Babu > --- > drivers/staging/rtl8188eu/core/rtw_mlme.c | 9

Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance.

On Thu, Aug 31, 2017 at 1:32 PM, Peter Zijlstra wrote: > AFAIK people are actively working on fixing that. SCHED_DEADLINE was definitely looked at in the past. We certainly don't use it on our own devices in Android Oreo, and I am not aware of any current plans to use it.

Re: [PATCH] vsock: only load vmci transport on VMware hypervisor by default

On Tue, Aug 29, 2017 at 03:37:07PM +, Jorgen S. Hansen wrote: > > On Aug 29, 2017, at 4:36 AM, Dexuan Cui wrote: > If we allow multiple host side transports, virtio host side support and > vmci should be able to coexist regardless of the order of initialization. That

[PATCH] staging:rtl8188eu Fix comparison to NULL

This patch replaces the comparison of variable say x to NULL with '!x' signed-off-by: Janani Sankara Babu --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c

Re: [PATCH v10 0/9] Hyper-V: paravirtualized remote TLB flushing and hypercall improvements

Vitaly Kuznetsov writes: > Changes since v9: > - Rebase to 4.13-rc3. > - Drop PATCH1 as it was already taken by Greg to char-misc tree. There're no > functional dependencies on this patch so the series can go through a > different tree > (and it actually belongs to x86

[PATCH] staging: rts5208: rename mmc_ddr_tunning_rx_cmd to mmc_ddr_tuning_rx_cmd

From: Colin Ian King Trival fix to spelling mistake in function name Signed-off-by: Colin Ian King --- drivers/staging/rts5208/sd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rts5208/sd.c

[PATCH] staging:rtl8188eu:core Remove unneccessary else block

This patch is created to remove the unneccessary else statement inside the function 'SecIsInPMKIDList'. Signed-off-by: Janani Sankara Babu --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git

Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance.

On Thu, Aug 31, 2017 at 10:27:58AM +0200, Martijn Coenen wrote: > On Thu, Aug 31, 2017 at 10:18 AM, Peter Zijlstra wrote: > > You fail to support SCHED_DEADLINE, that's not optional. > > The reason I didn't include it is that we don't use SCHED_DEADLINE in > Android

[staging:staging-testing 231/445] vbox_fb.c:undefined reference to `fb_deferred_io_cleanup'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 59b5306d1db0b53e39a676643b9781ba35813bb4 commit: 01d79e9b6afd15c3d2f34b39a9a6a08b45440d01 [231/445] staging: vboxvideo: Call fb_deferred_io_cleanup() on cleanup config:

Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance.

On Thu, Aug 31, 2017 at 10:04:20AM +0200, Martijn Coenen wrote: > Adds support for SCHED_BATCH/SCHED_FIFO/SCHED_RR priority inheritance > to the binder driver. The desired behavior is as follows: You fail to support SCHED_DEADLINE, that's not optional.

Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance.

On Thu, Aug 31, 2017 at 10:18 AM, Peter Zijlstra wrote: > You fail to support SCHED_DEADLINE, that's not optional. The reason I didn't include it is that we don't use SCHED_DEADLINE in Android userspace. Can we add support for this in a follow-up patch, or do you consider

Re: [PATCHv2] hv_set_ifconfig.sh double check before setting ip

On Mon, Aug 28, 2017 at 04:48:32PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Haiyang Zhang > > Sent: Monday, August 28, 2017 8:57 AM > > To: Stephen Hemminger ; Eduardo Otubo > > ; KY Srinivasan > >

Re: [PATCH v3] staging: ks7010: Fix coding style and remove checkpatch.pl warnings.

Thanks! regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 11/13] ANDROID: binder: don't enqueue death notifications to thread todo.

This allows userspace to request death notifications without having to worry about getting an immediate callback on the same thread; one scenario where this would be problematic is if the death recipient handler grabs a lock that was already taken earlier (eg as part of a nested transaction).

[PATCH v2 13/13] ANDROID: binder: Add tracing for binder priority inheritance.

This allows to easily trace and visualize priority inheritance in the binder driver. Signed-off-by: Martijn Coenen --- drivers/android/binder.c | 4 drivers/android/binder_trace.h | 24 2 files changed, 28 insertions(+) diff --git

[PATCH v2 10/13] ANDROID: binder: call poll_wait() unconditionally.

Because we're not guaranteed that subsequent calls to poll() will have a poll_table_struct parameter with _qproc set. When _qproc is not set, poll_wait() is a noop, and we won't be woken up correctly. Signed-off-by: Martijn Coenen --- drivers/android/binder.c | 11 +--

[PATCH v2 12/13] ANDROID: binder: don't queue async transactions to thread.

This can cause issues with processes using the poll() interface: 1) client sends two oneway transactions 2) the second one gets queued on async_todo (because the server didn't handle the first one yet) 3) server returns from poll(), picks up the first transaction and does transaction

[PATCH v2 05/13] ANDROID: binder: improve priority inheritance.

By raising the priority of a thread selected for a transaction *before* we wake it up. Delay restoring the priority when doing a reply until after we wake-up the process receiving the reply. Signed-off-by: Martijn Coenen --- drivers/android/binder.c | 74

[PATCH v2 02/13] ANDROID: binder: push new transactions to waiting threads.

Instead of pushing new transactions to the process waitqueue, select a thread that is waiting on proc work to handle the transaction. This will make it easier to improve priority inheritance in future patches, by setting the priority before we wake up a thread. If we can't find a waiting thread,

[PATCH v2 04/13] ANDROID: binder: add min sched_policy to node.

This change adds flags to flat_binder_object.flags to allow indicating a minimum scheduling policy for the node. It also clarifies the valid value range for the priority bits in the flags. Internally, we use the priority map that the kernel uses, e.g. [0..99] for real-time policies and [100..139]

[PATCH v2 07/13] ANDROID: binder: Add BINDER_GET_NODE_DEBUG_INFO ioctl

From: Colin Cross The BINDER_GET_NODE_DEBUG_INFO ioctl will return debug info on a node. Each successive call reusing the previous return value will return the next node. The data will be used by libmemunreachable to mark the pointers with kernel references as reachable.

[PATCH v2 08/13] ANDROID: binder: don't check prio permissions on restore.

Because we have disabled RT priority inheritance for the regular binder domain, the following can happen: 1) thread A (prio 98) calls into thread B 2) because RT prio inheritance is disabled, thread B runs at the lowest nice (prio 100) instead 3) thread B calls back into A; A will run at prio

[PATCH v2 09/13] ANDROID: binder: Don't BUG_ON(!spin_is_locked()).

Because is_spin_locked() always returns false on UP systems. Use assert_spin_locked() instead, and remove the WARN_ON() instances, since those were easy to verify. Signed-off-by: Martijn Coenen --- drivers/android/binder.c | 26 ++ 1 file changed, 10

[PATCH v2 06/13] ANDROID: binder: add RT inheritance flag to node.

Allows a binder node to specify whether it wants to inherit real-time scheduling policy from a caller. This inheritance may not always be desirable, for example in cases where the binder call runs untrusted and therefore potentially unbounded code. Signed-off-by: Martijn Coenen

[PATCH v2 01/13] ANDROID: binder: remove proc waitqueue

Removes the process waitqueue, so that threads can only wait on the thread waitqueue. Whenever there is process work to do, pick a thread and wake it up. Having the caller pick a thread is helpful for things like priority inheritance. This also fixes an issue with using epoll(), since we no

[PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance.

Adds support for SCHED_BATCH/SCHED_FIFO/SCHED_RR priority inheritance to the binder driver. The desired behavior is as follows: Each thread in the binder threadpool runs at a default priority, which is typically nice 0. Binder nodes (endpoints that can receive binder transactions) can have a

[PATCH v2 00/13] ANDROID: binder: RT priority inheritance and small fixes.

Changes since v1 [1]: - added more detailed commit messages and comments to the priority inheritance patches, including rationale for not using schet_setscheduler() directly, or rt_mutex prio inheritance. No functional changes. [1]:

[PATCH] Staging: atomisp: constify driver_attribute

driver_attribute are not supposed to change at runtime. Functions driver_create_file/driver_remove_file are working with const driver_attribute. So mark the non-const structs as const. Signed-off-by: Arvind Yadav ---

Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it

On Thursday 31 August 2017, Greg KH wrote: > On Tue, Aug 29, 2017 at 11:32:58PM +0200, Ondrej Zary wrote: > > On Tuesday 29 August 2017 01:42:08 David Miller wrote: > > > From: Greg Kroah-Hartman > > > Date: Sun, 27 Aug 2017 17:03:30 +0200 > > > > > > > The IRDA code

[PATCH] staging:rt8712:xmit_linux.c: Avoid multiple assignments in a single line

Fixed coding style issue Signed-off-by: Harsha Sharma --- drivers/staging/rtl8712/xmit_linux.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c index

[PATCH] Staging: Pi433: style fix - tabs and spaces

Fixed checkpatch errors, spaces before tabs. Found using checkpatch. Signed-off-by: Derek Robson --- drivers/staging/pi433/rf69.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h index